[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

I think you can still lose the explicit removeHandler. http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

Love it. Sold. On Sep 10, 2010 5:27 AM, b...@google.com wrote: I think you can still lose the explicit removeHandler. http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right):

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34 user/src/com/google/gwt/event/shared/EventBus.java:34: public H extends EventHandler void

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34 user/src/com/google/gwt/event/shared/EventBus.java:34: public H extends EventHandler void

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

Oh, damn. Forgot to put John's null check back. One more moment. http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

Null checks are in place, and tested. Found some stray garbage and bugs along the way, including a redundant fire method (oops). I think it's done, but I'm getting sloppy. http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

LGTM Just take a look at the assertsOn thing in the tests. http://gwt-code-reviews.appspot.com/841804/diff/58001/45043 File user/test/com/google/gwt/event/shared/HandlerManagerTest.java (right): http://gwt-code-reviews.appspot.com/841804/diff/58001/45043#newcode197

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

LGTM, just some minor suggestions. http://gwt-code-reviews.appspot.com/841804/diff/31001/3028 File user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java (right): http://gwt-code-reviews.appspot.com/841804/diff/31001/3028#newcode81

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

Last changes made, submitting. On 2010/09/10 23:21:27, rjrjr wrote: http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/diff/58001/45022 File user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java (right): http://gwt-code-reviews.appspot.com/841804/diff/58001/45022#newcode22 user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java:22: *

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

Comments for SimpleEventBus. http://gwt-code-reviews.appspot.com/841804/diff/1/24 File user/src/com/google/gwt/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode36 user/src/com/google/gwt/event/shared/SimpleEventBus.java:36: // Add and remove

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

I believe I've addressed what should be addressed. What say you? http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

LGTM http://gwt-code-reviews.appspot.com/841804/diff/1/19 File user/src/com/google/gwt/event/shared/AbstractEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/19#newcode8 user/src/com/google/gwt/event/shared/AbstractEventBus.java:8: public abstract class AbstractEventBus