[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-14 Thread t . broyer
On 2012/06/14 01:20:58, skybrian wrote: To fix the compiler and close issue 7397, we only need to add json (of any version) to gwt-dev.jar. So I think I'm going to commit a tiny change that just does that. We can defer the other stuff until we have a better plan. OK let's do that. Baby

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-14 Thread Thomas Broyer
On Wed, Jun 13, 2012 at 11:23 PM, Rajeev Dayal rda...@google.com wrote: On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.com wrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread t . broyer
I've removed the changes concerning javax.validation, so it's still distributed as a separate JAR. org.json is now bundled in gwt-dev, no longer bundled into requestfactory-* JARs, and distributed as a separate JAR in the SDK (so that requestfactory users have the choice to user

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread Brian Slesinsky
I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with dropping support for 1.5 altogether. - Brian On Wed, Jun 13, 2012 at 9:47 AM,

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread Rajeev Dayal
On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.comwrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread skybrian
Okay, seems fine for now. I'm going to commit this. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread t . broyer
On 2012/06/13 21:45:00, skybrian wrote: Okay, seems fine for now. I'm going to commit this. FYI, I just removed all occurrences of json-1.5.jar, so we consistently use json.jar everywhere. https://gwt-code-reviews.appspot.com/1731804/ --

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread skybrian
I'm getting failing tests because JSON is gone from gwt-user.jar and the requestfactory jars. I could add the dependency internal to google, but I think we might still be trying to do too much at once - this is looking more like churn than an actual improvement. To fix the compiler and close

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread skybrian
Moving org.json into gwt-dev makes sense because the compiler actually uses it. I'd like to see it repackaged, but perhaps we can wait until someone complains? I'm not sure about validation. Many people don't use it and I sorta think GWT's validation support ought to be split out of gwt-user

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Chris Ruffalo
I'm not sure about validation. Many people don't use it and I sorta think GWT's validation support ought to be split out of gwt-user into a separate jar. If there's no actual bug than I'm inclined to leave it alone for now. This would absolutely kill compatibility with gwt-validation.

Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Stephen Haberman
think GWT's validation support ought to be split out of gwt-user into a separate jar. This would absolutely kill compatibility with gwt-validation I know very little about gwt-validation and GWT's javax validation, but wouldn't having GWT's validation in a separate jar make it easier for

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread t . broyer
On 2012/06/08 18:02:44, skybrian wrote: Moving org.json into gwt-dev makes sense because the compiler actually uses it. I'd like to see it repackaged, but perhaps we can wait until someone complains? I'm not sure about validation. Many people don't use it and I sorta think GWT's

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Brian Slesinsky
Chris, I'm not sure what you mean by This. Do you mean the patch as it stands or something I've been speculating about? On Fri, Jun 8, 2012 at 11:43 AM, Chris Ruffalo chris.ruff...@gmail.com wrote: This would absolutely kill compatibility with gwt-validation.  

Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Chris Ruffalo
I guess I didn't make myself clear, I was agreeing. GWT's validation should *always* be in a separate module from gwt-user. What I should have said Otherwise, this would completely kill... I don't think that moving javax.validation into gwt-user would be a good idea. Especially if it comes

Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Brian Slesinsky
Okay, I think we should just fix JSON in this patch and figure out validation as a separate patch. - Brian On Fri, Jun 8, 2012 at 12:04 PM, Chris Ruffalo chris.ruff...@gmail.com wrote: I guess I didn't make myself clear,  I was agreeing.  GWT's validation should *always* be in a separate 

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-08 Thread Thomas Broyer
On Fri, Jun 8, 2012 at 8:43 PM, Chris Ruffalo chris.ruff...@gmail.com wrote: I'm not sure about validation. Many people don't use it and I sorta think GWT's validation support ought to be split out of gwt-user into a separate jar. If there's no actual bug than I'm inclined to leave it alone