Re: [gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-25 Thread Ray Ryan
I've shared a publicly visible copy here: https://docs.google.com/document/d/1Oo_imxskoGX5O9l9LhHDtJ0yJkHvNTNQqU3dkkekZYI/edit?hl=en_US Does that work for you? On Fri, Jul 8, 2011 at 3:22 PM, stephen.haber...@gmail.com wrote: Is it okay to make that public? I think it is OK. We usually

Re: [gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-25 Thread Stephen Haberman
https://docs.google.com/document/d/1Oo_imxskoGX5O9l9LhHDtJ0yJkHvNTNQqU3dkkekZYI/edit?hl=en_US Does that work for you? Awesome! Yep, it works. Thanks. - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-08 Thread jlabanca
http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java File user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java (right):

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-08 Thread rchandia
http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-08 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-08 Thread rchandia
http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-08 Thread stephen . haberman
Is it okay to make that public? I think it is OK. We usually publish them in the Wiki, but Docs is getting so good that I wanted to try it this way. Using docs makes sense. Will it eventually be made public? Perhaps copy/pasted over into the wiki for posterity?

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf File tools/api-checker/config/gwt23_24userApi.conf (right): http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf#newcode58

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-04 Thread rdcastro
Ok, I think I have some more useful feedback now. Nice document, I think we must add support in RenderablePanel to have UiRenderer objects added to them, that'd be awesome. Components that don't have to be widgets :-)

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread t . broyer
Was curious to see what it'd look like; finally have a few comments. http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java File user/src/com/google/gwt/uibinder/client/UiRenderer.java (right):

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread t . broyer
Was curious to see what it'd look like; finally have a few comments. http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread rchandia
http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread rchandia
Thanks Thomas!. http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java File user/src/com/google/gwt/uibinder/client/UiRenderer.java (right):

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread jlabanca
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf File tools/api-checker/config/gwt23_24userApi.conf (right): http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf#newcode58

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread rdcastro
I had a few nits below but I felt a bit out of context. Is there an overview somewhere of what you guys are trying to accomplish? What should rendering for Cells look like? http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java File

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread rchandia
On 2011/07/01 20:59:37, rdcastro wrote: I had a few nits below but I felt a bit out of context. Is there an overview somewhere of what you guys are trying to accomplish? What should rendering for Cells look like? Yes, we have a design doc... which I forgot to share. Here is the link,

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread stephen . haberman
https://docs.google.com/a/google.com/document/pub?id=1a-_8IdBrBmWCnhV6rnQVmzXB_bXQ9JQ4ya-k1_s1_sA Is it okay to make that public? http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread Rafael Castro
Thanks for sharing, I'll read it tomorrow and try and come up with more interesting suggestions :-) On Fri, Jul 1, 2011 at 6:14 PM, rchan...@google.com wrote: On 2011/07/01 20:59:37, rdcastro wrote: I had a few nits below but I felt a bit out of context. Is there an overview somewhere of

[gwt-contrib] Re: Implements UiBinder rendering for Cells. (issue1466809)

2011-07-01 Thread rchandia
On 2011/07/01 21:19:25, stephenh wrote: https://docs.google.com/a/google.com/document/pub?id=1a-_8IdBrBmWCnhV6rnQVmzXB_bXQ9JQ4ya-k1_s1_sA Is it okay to make that public? I think it is OK. We usually publish them in the Wiki, but Docs is getting so good that I wanted to try it this way.