[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-12-01 Thread sbrubaker
LGTM http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-12-01 Thread jlabanca
committed as r9328 http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-30 Thread pdr
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024 File user/src/com/google/gwt/cell/client/Cell.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024#newcode65 user/src/com/google/gwt/cell/client/Cell.java:65: context.key = key; On 2010/11/29 23:24:01, jlabanca

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-30 Thread pdr
On 2010/11/30 20:57:40, jlabanca wrote: LGTM, thanks for splitting those out. http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-29 Thread jlabanca
I agree with most of the comments except passing values as separate arguments from the Context because it doesn't seem to make any difference. Do you have a convincing argument why it should be separated? http://gwt-code-reviews.appspot.com/1129801/diff/4001/5008 File

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-24 Thread jlabanca
http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-24 Thread pdr
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5008 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ContactTreeViewModel.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5008#newcode199

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-24 Thread sbrubaker
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038 File user/src/com/google/gwt/cell/client/TextCell.java (right): http://gwt-code-reviews.appspot.com/1129801/diff/4001/5038#newcode47 user/src/com/google/gwt/cell/client/TextCell.java:47: public void render(ContextString context,

[gwt-contrib] Re: Passing the row index along with the row value to Cell methods. Currently, the row index is not ... (issue1129801)

2010-11-20 Thread jlabanca
Please hold off on this review. Instead of just adding the row index, we should really pass a concrete Context object that has the row index, value, etc... so we can add more fields in the future. I can already predict that people are going to want to know the column index. I'll update the