Re: [PATCH v4 11/19] xen: get memory map from hypervisor for PVH

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:30PM +0100, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross One nit pick below. Otherwise Reviewed-by: Daniel Kiper

Re: [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:31PM +0100, Juergen Gross wrote: > Add possible PCI space MMIO areas as "Reserved" to the memory map in > order to avoid using those areas for special Xen pages later. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper but I would

Re: [PATCH v4 13/19] xen: setup Xen specific data for PVH

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:32PM +0100, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Write back the possibly modifie

Re: [PATCH v4 14/19] xen: init memory regions for PVH

2018-11-09 Thread Daniel Kiper
-bit mode don't add memory above 4GB. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4 17/19] xen_pvh: support building a standalone image

2018-11-09 Thread Daniel Kiper
off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V2: some style adjustments (Daniel Kiper) > use defines for elf-notes (Daniel Kiper) Thanks a lot! However, I would like to ask you to move the latter to separate patch. You can retain my RB though. Daniel ___

Re: [PATCH v5 1/2] Import upstream zstd-1.3.6

2018-11-13 Thread Daniel Kiper
_LIB="grub-core/lib/zstd" > rm -rf $DST_LIB > mkdir -p $DST_LIB > cp $SRC_LIB/zstd.h $DST_LIB/ > cp $SRC_LIB/common/*.[hc] $DST_LIB/ > cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ > rm $DST_LIB/{pool.[hc],threading.[hc]} > rm -rf zstd-1.3.6* > echo SUCCESS! > ``` >

Re: [PATCH v5 2/2] btrfs: Add zstd support to grub btrfs

2018-11-13 Thread Daniel Kiper
On Mon, Nov 12, 2018 at 02:14:46PM -0800, Nick Terrell wrote: > - Adds zstd support to the btrfs module. > - Adds a test case for btrfs zstd support. > - Changes top_srcdir to srcdir in the btrfs module's lzo include > following comments from Daniel Kiper about the zstd inclu

Re: [Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

2018-11-14 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 01:49:16PM +0100, Roger Pau Monné wrote: > On Fri, Nov 09, 2018 at 08:14:57PM +0100, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:31PM +0100, Juergen Gross wrote: > > > Add possible PCI space MMIO areas as "Reserved" to the memory map i

Re: [PATCH] verifiers: fix double close on pgp's sig file descriptor

2018-11-14 Thread Daniel Kiper
On Tue, Nov 13, 2018 at 02:31:18PM +0800, Michael Chang wrote: > An error emerged as when I was tesing the verifiers branch, so instead > of putting it in pgp prefix, the verifiers is used to reflect what the > patch is based on. > > While running verify_detached, grub aborts with error. > > verify

Re: Network boot

2018-11-14 Thread Daniel Kiper
Hi Christopher, Sorry for late reply but I am busy. On Fri, Nov 02, 2018 at 12:32:09PM +0100, Christopher Lucas wrote: > Hello, > > I've recently bought a 32-bit EFI Windows Tablet with 64-bit CPU. It doesn't > have any Ethernet port so I'm using a USB-Ethernet adapter (rtl8153 chipset > works wi

Re: [PATCH] mkimage: pad DTBs to target-specific pointer size

2018-11-14 Thread Daniel Kiper
ion on arm64. > > Fix by using ALIGN_ADDR, not ALIGN_UP. > > Signed-by-off: Matthew Daley Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/3] verifiers: Verify commands executed by grub

2018-11-14 Thread Daniel Kiper
ted in order to ensure that > the boot state is as expected. Except lack of SOB patch LGTM. May I add your SOB before pushing this patch. Or you can repost it with Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org htt

Re: [PATCH 2/3] verifiers: Core TPM support

2018-11-14 Thread Daniel Kiper
On Fri, Nov 09, 2018 at 03:41:02PM -0800, Matthew Garrett wrote: Hmmm... Here it is a bit better... > From: Matthew Garrett > > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. In future we might > want to have some sor

Re: [PATCH 3/3] verifiers: Add TPM documentation

2018-11-14 Thread Daniel Kiper
On Fri, Nov 09, 2018 at 03:41:03PM -0800, Matthew Garrett wrote: > Describe the behaviour of grub when the TPM module is in use. Lack of SOB. Otherwise Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org ht

Re: [PATCH v2] verifiers: fix double close on pgp's sig file descriptor

2018-11-16 Thread Daniel Kiper
On Thu, Nov 15, 2018 at 06:13:11PM +0800, Michael Chang wrote: > An error emerged as when I was tesing the verifiers branch, so instead > of putting it in pgp prefix, the verifiers is used to reflect what the > patch is based on. > > While running verify_detached, grub aborts with error. > > verify

Re: [PATCH 0/5] Fix non-x86 builds after verifiers framework merged

2018-11-16 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 07:29:14PM +, Leif Lindholm wrote: > The verifiers framework caused some breakage for non-x86 > platforms that need fixing. > > Basically, this boils down to: > - Add an include guard for verify.h. > - Add a new file type for device tree blobs. > - Fix an error added to

Re: [PATCH 0/5] Fix non-x86 builds after verifiers framework merged

2018-11-16 Thread Daniel Kiper
On Fri, Nov 16, 2018 at 10:31:08AM +0800, Fu Wei Fu wrote: > Hi Leif, > > Great thanks for your information, will do ASAP when I am back home. I have pushed fixes into the master, so, please take a look at it. Daniel ___ Grub-devel mailing list Grub-de

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: > - Adds zstd support to the btrfs module. > - Adds a test case for btrfs zstd support. > - Changes top_srcdir to srcdir in the btrfs module's lzo include > following comments from Daniel Kiper about the zstd inclu

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote: > On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: > > - Adds zstd support to the btrfs module. > > - Adds a test case for btrfs zstd support. > > - Changes top_srcdir to srcdir in the btrfs

Re: [PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Mon, Nov 19, 2018 at 11:20:06AM -0800, Nick Terrell wrote: > Hi all, > > This patch set imports the upstream zstd library, adds zstd support to the > btrfs module, and adds a test case. I've also tested the patch set by storing > my boot partition in btrfs with and without zstd compression and r

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-19 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 03:24:53PM -0800, Matthew Garrett wrote: > From: Matthew Garrett > > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. In future we might > want to have some sort of mechanism for choosing which eve

Re: [PATCH v3] verifiers: fix double close on pgp's sig file descriptor

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 07:15:37PM +0800, Michael Chang wrote: > An error emerged as when I was tesing the verifiers branch, so instead > of putting it in pgp prefix, the verifiers is used to reflect what the > patch is based on. > > While running verify_detached, grub aborts with error. > > verify

Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression'

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 12:37:01PM +, Lee Jones wrote: > From: Lee Jones > > generic/blocklist: Fix implicit declaration of function > ‘grub_file_filter_disable_compression' > > grub_file_filter_disable_compression() no longer exists. > > Signed-off-by: Lee Jones Pushed with two minor chang

Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 10:45:04AM +, Lee Jones wrote: > From: Lee Jones > > arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’ > > Without this fix, building xen_boot.c omits: > > loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’: > loader/arm64/xen_boot.c:370

Re: [PATCH v2] arm64/xen: Fix too few arguments to function ‘grub_file_open’

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 11:39:42AM +, Lee Jones wrote: > From: Lee Jones > > arm64/xen: Fix too few arguments to function ‘grub_file_open’ > > Without this fix xen_boot.c omits: > > loader/arm64/xen_boot.c: In function ‘grub_cmd_xen_module’: > loader/arm64/xen_boot.c:424:10: error: too few arg

Re: [PATCH v3 (part 1)] arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression'

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 12:35:39PM +, Lee Jones wrote: > From: Lee Jones > > arm64/xen: Fix implicit declaration of function > ‘grub_file_filter_disable_compression' > > Without this fix, building xen_boot.c emits: > > loader/arm64/xen_boot.c:433:5: error: implicit declaration of function >

Re: [PATCH] .gitignore: Add po/*.insert-header and factor out po/.gitignore

2018-11-21 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 01:50:59AM +, Tim Landscheidt wrote: > Signed-off-by: Tim Landscheidt Why this patch is needed? Please add a few words about that to the commit message. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gn

Re: [PATCH v3 04/10] RISC-V: Add setjmp implementation

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:33PM +0100, Alexander Graf wrote: > This patch adds a 32/64 capable setjmp implementation for RISC-V. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > --- > grub-core/lib/riscv/setjmp.S | 82 > +++ > inclu

Re: [PATCH v3 06/10] RISC-V: Add Linux load logic

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:35PM +0100, Alexander Graf wrote: > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > we also only want to support running Linux underneath as UEFI payload. > > Prepare that with a Linux boot case that is not enabled in Linux yet. At > least i

Re: [PATCH v3 07/10] RISC-V: Add awareness for RISC-V reloations

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:36PM +0100, Alexander Graf wrote: > This patch adds awareness of RISC-V relocations throughout the grub tools > as well as dynamic linkage and elf->PE relocation conversion support. > > Signed-off-by: Alexander Graf > > --- > > v2 -> v3: > > - Fix riscv32 target > -

Re: [PATCH v3 08/10] RISC-V: Add auxiliary files

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:37PM +0100, Alexander Graf wrote: > To support a new architecture we need to provide a few helper functions > for memory, cache, timer, etc support. > > This patch adds the remainders of those. Some bits are still disabled, > as I couldn't guarantee that we're always r

Re: [PATCH v3 09/10] RISC-V: Add to build system

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:38PM +0100, Alexander Graf wrote: > This patch adds support for RISC-V to the grub build system. With this > patch, I can successfully build grub on RISC-V as a UEFI application. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis [...] > diff --git a

Re: [PATCH v3 07/10] RISC-V: Add awareness for RISC-V reloations

2018-11-21 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 05:08:09PM +0100, Andreas Schwab wrote: > On Nov 21 2018, Daniel Kiper wrote: > > >> + case R_RISCV_BRANCH: > >> +{ > >> + grub_uint32_t *abs_place = place; > >> + grub_ssize_t off = sym_addr - (grub_addr_t) pla

Re: [PATCH v3 10/10] fdt: Add device tree file type

2018-11-21 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 06:27:39PM +0100, Alexander Graf wrote: > We now have signature check logic in grub which allows us to treat > files differently depending on their file type. > > Mark a loaded device tree as such and treat it like an overlayed ACPI > table. Both describe hardware, so I supp

Re: [PATCH v3 09/10] RISC-V: Add to build system

2018-11-21 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 05:26:25PM +0100, Andreas Schwab wrote: > On Nov 21 2018, Daniel Kiper wrote: > > > s/__riscv/__riscv__/? and s/__riscv_xlen/__riscv_xlen__/? > > The latter aren't defined. Both __riscv__ and __riscv_xlen__ a

Re: [PATCH v3 10/10] fdt: Add device tree file type

2018-11-21 Thread Daniel Kiper
On Mon, Nov 19, 2018 at 05:56:36PM +, Leif Lindholm wrote: > On Mon, Nov 19, 2018 at 11:11:09AM +0100, Andreas Schwab wrote: > > On Nov 14 2018, Alexander Graf wrote: > > > > > diff --git a/grub-core/loader/efi/fdt.c b/grub-core/loader/efi/fdt.c > > > index a4c6e8036..d8ebe648e 100644 > > > -

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-21 Thread Daniel Kiper
On Tue, Nov 20, 2018 at 10:59:18AM +1100, Matthew Garrett wrote: > On Mon, Nov 19, 2018 at 1:13 AM Daniel P. Smith wrote: > > > > It would be great if the TPM commands that are using EFI protocol and > > exposed to TPM command module be name spaced under efi, e.g. > > grub_efi_tpm_log_event. As I

Re: [PATCH v3 09/10] RISC-V: Add to build system

2018-11-21 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 05:54:41PM +0100, Andreas Schwab wrote: > On Nov 21 2018, Daniel Kiper wrote: > > > On Wed, Nov 21, 2018 at 05:26:25PM +0100, Andreas Schwab wrote: > >> On Nov 21 2018, Daniel Kiper wrote: > >> > >> > s/__riscv/__riscv__/? and s/_

Re: [PATCH 2/3] verifiers: Core TPM support

2018-11-23 Thread Daniel Kiper
On Thu, Nov 15, 2018 at 12:23:32PM +1300, Matthew Garrett wrote: > On Thu, Nov 15, 2018 at 6:39 AM Daniel Kiper wrote: > > > Could you be more C-ish? E.g. s/Major/major/, s/Minor/minor/, etc. > > These are the spec-defined member names, so I've a mild preference for >

Re: [PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-27 Thread Daniel Kiper
On Tue, Nov 27, 2018 at 02:55:33AM +, Nick Terrell wrote: > > On Nov 19, 2018, at 12:34 PM, Daniel Kiper wrote: > > On Mon, Nov 19, 2018 at 11:20:06AM -0800, Nick Terrell wrote: > >> Hi all, > >> > >> This patch set imports the upstream zstd library, add

Re: Network boot

2018-11-27 Thread Daniel Kiper
Hi Christopher, Re-adding grub-devel. Next time please do not drop it if it is not required. Other people may learn something from your experience too. On Fri, Nov 16, 2018 at 01:34:51PM +0100, Christopher Lucas wrote: > Hello, > > No problem for the delay. That's good to clarify because I couldn

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-27 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 05:00:03PM +1100, Matthew Garrett wrote: > On Mon, Nov 26, 2018 at 4:47 PM Daniel Kiper wrote: > > > I have a feeling that both UEFI and TIS TPM implementations can coexists > > together even on UEFI platform. Of course, AIUI, UEFI TPM should be default &

Re: [PATCH v5 02/20] loader/linux: support passing rsdp address via boot params

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:37PM +0100, Juergen Gross wrote: > Xen PVH guests will have the RSDP at an arbitrary address. Support that > by passing the RSDP address via the boot parameters to Linux. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Ki

Re: [PATCH v5 05/20] xen: add some dummy headers for PVH mode

2018-11-27 Thread Daniel Kiper
> Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 07/20] xen: modify grub_xen_ptr2mfn() for xen-pvh

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:42PM +0100, Juergen Gross wrote: > grub_xen_ptr2mfn() returns the machine frame number for a given pointer > value. For Xen-PVH guests this is just the PFN. Add the PVH specific > variant. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel

Re: [PATCH v5 09/20] xen: add basic hooks for PVH in current code

2018-11-27 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 11/20] xen: setup hypercall page for PVH

2018-11-27 Thread Daniel Kiper
gen Gross > --- > V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) > issue panic message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > V5: Use XEN_HVM_DEBUGCONS_IOPORT from Xen unstable (Roger Pau Monné) > Iss

Re: [PATCH v5 13/20] xen: setup Xen specific data for PVH

2018-11-27 Thread Daniel Kiper
Write back the possibly modified memory map to the hypervisor in case > the guest is reading it from there again. > > Set the RSDP address for the guest from the start_info page passed > as boot parameter. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper One nitpick b

Re: [PATCH v5 15/20] xen_pvh: add build runes for grub-core

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:50PM +0100, Juergen Gross wrote: > Add the modifications to the build system needed to build a xen_pvh > grub. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: sorted some filenames (Daniel Kiper) > V4: add bus/pci.c

Re: [PATCH v5 11/20] xen: setup hypercall page for PVH

2018-11-28 Thread Daniel Kiper
On Tue, Nov 27, 2018 at 09:31:10PM +0100, Daniel Kiper wrote: > On Wed, Nov 21, 2018 at 03:28:46PM +0100, Juergen Gross wrote: > > Add the needed code to setup the hypercall page for calling into the > > Xen hypervisor. > > > > Import the XEN_HVM_DEBUGCONS_IOPORT de

Re: [PATCH v5 01/20] xen: add some xen headers

2018-11-28 Thread Daniel Kiper
Xen 4.10 being the first Xen version with > full (not only experimental) PVH guest support. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper When I apply this patch I get this: Applying: xen: add some xen headers .git/rebase-apply/patch:723: trailing whitespace.

Re: [PATCH] ofnet: fix build regression in grub_ieee1275_parse_bootpath

2018-11-28 Thread Daniel Kiper
On Tue, Nov 27, 2018 at 03:17:26PM -0800, Eric Snowberg wrote: > The grub_ieee1275_parse_bootpath function (commit a661a32, ofnet: Initialize > structs in bootpath parser.) introduces a build regression on SPARC: > > cc1: warnings being treated as errors > net/drivers/ieee1275/ofnet.c: In function

Re: [PATCH v6 11/20] xen: setup hypercall page for PVH

2018-11-29 Thread Daniel Kiper
Gross > Reviewed-by: Roger Pau Monné > --- > V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) > issue panic message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > V5: Use XEN_HVM_DEBUGCONS_IOPORT from Xen unst

Re: [PATCH v6 16/20] grub-module-verifier: Ignore all_video for xenpvh

2018-11-29 Thread Daniel Kiper
oddeps section" > > > > Also see: > > - 6371e9c10433578bb236a8284ddb9ce9e201eb59 > > - https://savannah.gnu.org/bugs/?49012 > > > > Signed-off-by: Hans van Kranenburg > > Reviewed-by: Daniel Kiper > > Just a small detail... The xenpvh in the subject was not renamed to > xen

Re: [PATCH v6 00/20] xen: add pvh guest support

2018-11-29 Thread Daniel Kiper
On Wed, Nov 28, 2018 at 02:55:10PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is us

Re: [Xen-devel] [PATCH v6 00/20] xen: add pvh guest support

2018-11-29 Thread Daniel Kiper
On Thu, Nov 29, 2018 at 01:40:35PM +0100, Hans van Kranenburg wrote: > Hi Daniel, > > On 11/29/18 1:22 PM, Daniel Kiper wrote: > > On Wed, Nov 28, 2018 at 02:55:10PM +0100, Juergen Gross wrote: > >> This patch series adds support for booting Linux as PVH guest. > >

Re: [PATCH V3 1/3] verifiers: Verify commands executed by grub

2018-12-03 Thread Daniel Kiper
ted in order to ensure that > the boot state is as expected. > > Signed-off-by: Matthew Garrett Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH V3 2/3] verifiers: Core TPM support

2018-12-03 Thread Daniel Kiper
choosing which events get logged > to which PCRs, but this seems like a good default policy and we can wait > to see whether anyone has a use case before adding more complexity. > > Signed-off-by: Matthew Garrett Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH V3 3/3] verifiers: Add TPM documentation

2018-12-03 Thread Daniel Kiper
On Thu, Nov 29, 2018 at 11:28:10AM -0800, Matthew Garrett wrote: > Describe the behaviour of grub when the TPM module is in use. > > Signed-off-by: Matthew Garrett Reviewed-by: Daniel Kiper If there are no objections I will apply the patch series in a week or so. Thank you for doing

Re: Proposed patch for SESAME support

2018-12-05 Thread Daniel Kiper
On Thu, Nov 29, 2018 at 12:40:30AM +0100, Stephen R. van den Berg wrote: > commit 4d9673b72e1dd05489176073ea630ec4cf5b2760 > Author: Stephen R. van den Berg > Date: Wed Sep 6 01:42:29 2017 +0200 > > GRUB_SESAME support. OK, nice but I do not really know what problem this patch solves. So, p

[GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for fine-grained signature-verification controlling). Signed-off-by: Daniel Kiper --- grub-core/loader/i386/xen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/grub-core/loader/i386/xen.c b

[GRUB PATCH 2/2] verifiers: ARM Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
ARM Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for fine-grained signature-verification controlling). Signed-off-by: Daniel Kiper --- grub-core/loader/arm64/xen_boot.c | 8 include/grub/file.h | 5 + 2 files changed, 9 insertions(+), 4 deletions

[GRUB PATCH 0/2] verifiers: Fallout cleanup

2018-12-06 Thread Daniel Kiper
/xen.c | 14 +++--- include/grub/file.h | 5 + 3 files changed, 16 insertions(+), 11 deletions(-) Daniel Kiper (2): verifiers: Xen fallout cleanup verifiers: ARM Xen fallout cleanup ___ Grub-devel mailing list

Re: [PATCH v6 09/20] xen: add basic hooks for PVH in current code

2018-12-06 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: xenpvh->xen_pvh (Daniel Kiper) > adjust copyright date (Roger Pau Monné) > V5: update commit message (Daniel Kiper) > move including xen/hvm/start_info.

Re: [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
On Thu, Dec 06, 2018 at 10:37:43AM -0500, Ross Philipson wrote: > On 12/06/2018 08:40 AM, Daniel Kiper wrote: > > Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > > fine-grained signature-verification controlling). > > > > Signed-off-by: Daniel Ki

Re: [PATCH v6.1 09/20] xen: add basic hooks for PVH in current code

2018-12-07 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. This in turn requires to > add an empty kernel.h header for some i386 platforms (efi, coreboot, > ieee1275, xen). > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: xenpvh->xen_pvh (Daniel Kiper) > ad

Re: [PATCH v7 00/20] xen: add pvh guest support

2018-12-07 Thread Daniel Kiper
On Fri, Dec 07, 2018 at 01:11:28PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is us

Re: [PATCH V3 3/3] verifiers: Add TPM documentation

2018-12-12 Thread Daniel Kiper
On Mon, Dec 03, 2018 at 03:48:17PM +0100, Daniel Kiper wrote: > On Thu, Nov 29, 2018 at 11:28:10AM -0800, Matthew Garrett wrote: > > Describe the behaviour of grub when the TPM module is in use. > > > > Signed-off-by: Matthew Garrett > > Reviewed-by: Daniel Kiper >

Re: [PATCH V3 3/3] verifiers: Add TPM documentation

2018-12-17 Thread Daniel Kiper
On Wed, Dec 12, 2018 at 09:57:48AM -0800, Matthew Garrett wrote: > On Wed, Dec 12, 2018 at 6:31 AM Daniel Kiper wrote: > > > > On Mon, Dec 03, 2018 at 03:48:17PM +0100, Daniel Kiper wrote: > > > On Thu, Nov 29, 2018 at 11:28:10AM -0800, Matthew Garrett wrote: > >

Re: [PATCH 1/1] grub-core/loader/efi/fdt.c: do not copy random memory

2018-12-18 Thread Daniel Kiper
end > > with a crash. > > > > Signed-off-by: Heinrich Schuchardt > > Whoops, yes. > Reviewed-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Fixing GRUB build issues on SPARC

2018-12-20 Thread Daniel Kiper
Hey, CC-ing Eric. On Tue, Dec 18, 2018 at 12:24:43PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > Since GRUB is still failing to build from source on SPARC targets due the > fact that binutils upstream dropped support for a.out on SPARC [1, 2, 3], > I have begun working on integrating the

Re: Question about how to submit a grub2 patch

2018-12-20 Thread Daniel Kiper
Hi Liming, On Wed, Dec 19, 2018 at 04:20:06PM +, Liming Sun wrote: > Hi, > > When using grub2 from some Linux distribution, we found that it > doesn't seem to support EFI_VLAN_PATH (device path passed from EFI > with VLAN information). I have a small patch, part of which like > below. There s

Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-20 Thread Daniel Kiper
Hi Jeff, On Wed, Dec 19, 2018 at 12:50:21AM -0600, Jeff Norden wrote: > Greetings. > > The small patch below adds a new variable (for use by 10_linux) that > allows you to tweak the ordering of kernels in grub.cfg > > When the 10_linux script finds more than one installed kernel, it orders > them

Re: [PATCH] grub-mkconfig/20_linux_xen: Support multiple early initrd images

2018-12-20 Thread Daniel Kiper
e to ensure that UUID partition labels > stay disabled when no initrd image is found, even if early images are > present. > > This is basically a copy of a698240d "grub-mkconfig/10_linux: Support > multiple early initrd images" by Matthew S. Turnbull. > > Signed-off-by:

Re: Current status of [PATCH v2] ieee1275: obdisk driver

2019-01-08 Thread Daniel Kiper
Hey, On Tue, Jan 08, 2019 at 11:49:02AM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > I was wondering what the current status of the new obdisk driver for GRUB > was and whether there is still a chance for the driver to be merged? AFAICT Eric is busy with other stuff but he is going to pos

Re: TPM/Verifiers testing bug?

2019-01-14 Thread Daniel Kiper
On Wed, Jan 09, 2019 at 02:16:16PM +, Max Tottenham wrote: > Hi Folks > > I was curious about the upstream work on the verifiers framework (and > the TPM patches). I have both a TPM 2.0 based system and a QEMU + swtpm > setup with which to test. I compiled the head of the master branch, if I >

Re: [PATCH V3 3/3] verifiers: Add TPM documentation

2019-01-14 Thread Daniel Kiper
On Mon, Dec 17, 2018 at 03:47:20PM +0100, Daniel Kiper wrote: > On Wed, Dec 12, 2018 at 09:57:48AM -0800, Matthew Garrett wrote: > > On Wed, Dec 12, 2018 at 6:31 AM Daniel Kiper wrote: > > > > > > On Mon, Dec 03, 2018 at 03:48:17PM +0100, Daniel Kiper wrote: > >

Re: Current Projects

2019-01-14 Thread Daniel Kiper
Hi Levi, On Sun, Dec 23, 2018 at 08:53:56PM -0700, Levi Bradford wrote: > Hello! > > As a longtime user of GRUB, I find myself owing to those who helped > make this excellent system. In return for your usefulness, I want to > aid in development. I haven’t been able to find any current “project > l

Re: [PATCH] Fix emu build and tests after pgp module renaming

2019-01-14 Thread Daniel Kiper
On Wed, Jan 09, 2019 at 02:54:39PM +, Colin Watson wrote: > Commit b07feb8746c3bb845e3f0d33d37c0bded704d14d renamed the "verify" > module to "pgp", but the GRUB_MOD_INIT and GRUB_MOD_FINI macros were > left as "verify", which broke the emu target build; and file_filter_test > still referred to

Re: [PATCH] Fix syslinux_test in out-of-tree builds

2019-01-14 Thread Daniel Kiper
On Wed, Jan 09, 2019 at 02:59:12PM +, Colin Watson wrote: > syslinux_parse simplifies some filenames by removing things like ".." > segments, but the tests assumed that @abs_top_srcdir@ would be > untouched, which is not true in the case of out-of-tree builds where > @abs_top_srcdir@ may contai

Re: [PATCH v2 1/2] mkimage: Simplify header size logic

2019-01-14 Thread Daniel Kiper
padding are: > in the .vaddr_offset member of our target image definition struct as well > as in code in grub_install_generate_image(). > > Remove the latter, so that we only have a single place to modify if we > need to change the padding. > > Signed-off-by: Alexander

Re: [PATCH v2 2/2] mkimage: arm64-efi: Align first section to page

2019-01-14 Thread Daniel Kiper
On Sun, Dec 23, 2018 at 03:52:07AM +0100, Alexander Graf wrote: > In order to enforce NX semantics on non-code pages, UEFI firmware > may require that all code is EFI_PAGE_SIZE (4k) aligned. A similar > change has recently been applied to edk2 to accomodate for the same > fact: > > https://lists.

Re: [PATCH] grub: add grub variable update functionality

2019-01-14 Thread Daniel Kiper
On Fri, Jan 04, 2019 at 07:53:42AM -0500, Prarit Bhargava wrote: > Please be aware I am NOT subscribed to grub-devel. > > P. > > ---8<--- > > Customers and users of the kernel are commenting that there is no way to > update > a grub variable without copy and pasting the existing data. > > For exam

Re: TPM/Verifiers testing bug?

2019-01-15 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 11:42:21AM -0800, Matthew Garrett wrote: > On Mon, Jan 14, 2019 at 6:09 AM 'Max Tottenham' via mjg59 > wrote: > > > I went ahead and did some debugging. Below is a patch that seems to fix > > my problem. Although those calls to grub_efi_open_protocol() in the tpm > > module

Re: [PATCH v3 1/4] mkimage: Simplify header size logic

2019-01-15 Thread Daniel Kiper
padding are: > in the .vaddr_offset member of our target image definition struct as well > as in code in grub_install_generate_image(). > > Remove the latter, so that we only have a single place to modify if we > need to change the padding. > > Signed-off-by: Alexander Graf > Revie

Re: [PATCH v3 2/4] mkimage: Use EFI32_HEADER_SIZE define in arm-efi case

2019-01-15 Thread Daniel Kiper
> -+ 4 * sizeof (struct > grub_pe32_section_table), > -GRUB_PE32_SECTION_ALIGNMENT), > + .vaddr_offset = EFI32_HEADER_SIZE, >.pe_target = GRUB_PE32_MACHINE_ARMTHUMB_MIXED, >.elf_target = EM_ARM, > }, Reviewed-by: Daniel Kiper D

Re: [PATCH v3 3/4] mkimage: arm64-efi: Align header to page granularity

2019-01-15 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 04:27:17PM +0100, Alexander Graf wrote: > In order to enforce NX semantics on non-code pages, UEFI firmware > may require that all code is EFI_PAGE_SIZE (4k) aligned. A similar > change has recently been applied to edk2 to accomodate for the same > fact: > > https://lists.

Re: [PATCH v3 4/4] mkimage: Align efi sections on 4k boundary

2019-01-15 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 04:27:18PM +0100, Alexander Graf wrote: > There is UEFI firmware popping up in the wild now that implements stricter > permission checks using NX and write protect page table entry bits. > > This means that firmware now may fail to load binaries if its individual > sections

Re: [PATCH v3 3/4] mkimage: arm64-efi: Align header to page granularity

2019-01-15 Thread Daniel Kiper
On Tue, Jan 15, 2019 at 01:52:41PM +0100, Alexander Graf wrote: > On 01/15/2019 01:45 PM, Daniel Kiper wrote: > > On Mon, Jan 14, 2019 at 04:27:17PM +0100, Alexander Graf wrote: > > > In order to enforce NX semantics on non-code pages, UEFI firmware > > > may require tha

Re: bash completions in GRUB

2019-01-15 Thread Daniel Kiper
On Thu, Jan 10, 2019 at 11:37:48AM -0600, Bruce Dubbs wrote: > It appears that GRUB is not consistent with other applications when > installing the bash completions script. I suggest the following patch: > > diff --git a/util/bash-completion.d/Makefile.am > b/util/bash-completion.d/Makefile.am > i

Re: [PATCH] Re: MKPasswd idempotency patch

2019-01-15 Thread Daniel Kiper
On Tue, Jan 15, 2019 at 03:43:59PM +0100, grub-de...@agowa338.de wrote: > Hello, > > just wanted to ask, if this patch got unnoticed, or if I just have to wait a > bit longer for a response. > This is my first time submitting a patch to the grub project, so please bear > with me ;-) I am clearin

Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool

2019-01-16 Thread Daniel Kiper
On Wed, Jan 09, 2019 at 12:29:30PM +, Colin Watson wrote: > Upgrade Gnulib files to 20190105. > > It's much easier to maintain GRUB's use of portability support files > from Gnulib when the process is automatic and driven by a single > configuration file, rather than by maintainers occasionally

Re: GRUB Xen PVH chainloading

2019-01-16 Thread Daniel Kiper
econd-stage PVH boot > > loader should be installed into the guest filesystem as > > /boot/xen/pvhboot-.elf, and otherwise things generally behave the > > same way. I'd be happy to draft a patch to the protocol specification > > once a proof-of-concept exists. >

Re: MKPasswd idempotency patch

2019-01-16 Thread Daniel Kiper
On Tue, Dec 25, 2018 at 12:01:12PM +0100, grub-de...@agowa338.de wrote: > Hello, > > I want to use grub-mkpasswd inside of a ansible playbook, therefore a > idempotency or check feature is required. Without it, there is no > posibility to verify, that the configuration is already inplace. > Therefo

Re: [PATCH v2 1/3] grub-editenv: Verify the variable size

2019-01-16 Thread Daniel Kiper
before setting a value. s/variable/argument/ s/size/size greater than zero/ > Signed-off-by: Prarit Bhargava > Cc: mleit...@redhat.com > Cc: pjo...@redhat.com > Cc: javi...@redhat.com > Cc: ar...@redhat.com > Cc: Daniel Kiper > --- > util/grub-editenv.c | 3 +++ > 1 f

Re: [PATCH v2 3/3] grub: add extend variable functionality

2019-01-16 Thread Daniel Kiper
On Wed, Jan 16, 2019 at 01:34:43PM -0500, Prarit Bhargava wrote: > Customers and users of the kernel are commenting that there is no way to > update > a grub variable without copy and pasting the existing data. > > For example, > > [10:57 AM root@intel-wildcatpass-07 grub-2.02]# ./grub-editenv lis

Re: [PATCH v2 2/3] grub: Make grub_envblk_iterate() return an int

2019-01-16 Thread Daniel Kiper
On Wed, Jan 16, 2019 at 01:34:42PM -0500, Prarit Bhargava wrote: > grub_envblk_iterate() is a void. Future functions will require the > ability to interpret return codes from the iteration, so > grub_envblk_iterate() should be an int. > > The value of 0 returned from the hook functions is overload

Re: [PATCH] uboot: Add the missing disk write operation support

2019-01-16 Thread Daniel Kiper
U-Boot loading > and booting GRUB in a QEMU vexpress-a9 environment. > The disk write operations were triggered with GRUB's save_env > command. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Daniel Kiper If there are no objections I will apply

Re: [PATCH v4 00/10] Add RISC-V support

2019-01-17 Thread Daniel Kiper
Hey, Sorry for late reply but I was not able to review the patches due to other important work and holiday season. Now I am taking a stab at it and I hope that it will land soon in the GRUB git tree. On Mon, Nov 26, 2018 at 12:38:05AM +0100, Alexander Graf wrote: > As part of the plan for total w

Re: [PATCH v4 01/10] efi: Rename armxx to arch

2019-01-17 Thread Daniel Kiper
gly. > > Signed-off-by: Alexander Graf > Acked-by: Leif Lindholm > Reviewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https

<    1   2   3   4   5   6   7   8   9   10   >