Re: Wrong format of kernel.img if build on Cygwin (was: no subject)

2010-09-04 Thread Christian Franke
video) This is possibly the problem that libbfd cannot not convert PE to ELF properly. Unfortunately the grub-pe2elf tool does support pe-i386 but not pei-i386. I will try to fix this next week. -- Regards, Christian Franke ___ Grub-devel mailing list

Re: Wrong format of kernel.img if build on Cygwin (was: no subject)

2010-09-02 Thread Christian Franke
as expected then? Thanks for the problem report. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Build fails due to wrong placement of -llibrary options

2010-08-28 Thread Christian Franke
, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Build fails due to wrong placement of -llibrary options

2010-08-28 Thread Christian Franke
BVK Chaitanya wrote: On Sat, Aug 28, 2010 at 5:53 PM, Christian Franke ... wrote: $ grep ^grub_bin2h_LD Makefile grub_bin2h_LDADD = libgrub.a grub_bin2h_LDFLAGS = $(AM_LDFLAGS) $(LDFLAGS_PROGRAM) $(LIBINTL) $(LIBDEVMAPPER) The above should be: grub_bin2h_LDADD = libgrub.a $(LIBINTL

Re: grub2 build under windows environment.

2010-07-28 Thread Christian Franke
a list of necessary development packages. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Optimise memset on i386

2010-07-23 Thread Christian Franke
orl %eax, %edx movl%edx, %eax sall%cl, %eax orl %edx, %eax ret -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix grub.d/10_windows for Cygwin 1.7

2010-05-09 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: This change is already included in Cygwin package grub-1.98-2. - + test -z $needmap || catEOF + drivemap -s (hd0) \$root +EOF You can't be sure on script runtime that C: is on hd0. Ironically especially

[PATCH] Fix grub.d/10_windows for Cygwin 1.7

2010-05-05 Thread Christian Franke
This change is already included in Cygwin package grub-1.98-2. -- Regards, Christian Franke === modified file 'ChangeLog' --- ChangeLog 2010-05-05 19:19:55 + +++ ChangeLog 2010-05-05 20:09:01 + @@ -1,3 +1,9 @@ +2010-05-05 Christian Franke fra...@computer.org + + * util/grub.d

Re: [PATCH] Fix Cygwin path handling

2010-04-26 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: + /* Include leading slash. */ + offset = 0; + break; Why do you make this change? It seems to make the behaviour of make_path_relative_to_its root inconsistent since E.g. /boot/grub - grub

Re: [PATCH] Fix Cygwin path handling

2010-04-26 Thread Christian Franke
/boot/ I actually did not test the / corner case, sorry. New patch attached. -- Regards, Christian Franke === modified file 'ChangeLog' --- ChangeLog 2010-04-26 01:35:55 + +++ ChangeLog 2010-04-26 09:44:43 + @@ -1,5 +1,17 @@ 2010-04-26 Christian Franke fra...@computer.org

Re: NEED_REGISTER_FRAME_INFO can be replaced by -static-libgcc

2010-04-19 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: According to 'gcc -dumpspecs' of Cygwin gcc 4.3.4-3, options '-u ___[de]register_frame_info' are always passed to the linker if -static-libgcc is not specified. This is Cygwin and MinGW specific: In the exe startup code

[PATCH] Remove grub_get_prefix()

2010-04-18 Thread Christian Franke
, Christian Franke === modified file 'ChangeLog' --- ChangeLog 2010-04-18 11:00:06 + +++ ChangeLog 2010-04-18 14:39:41 + @@ -1,3 +1,12 @@ +2010-04-18 Christian Franke fra...@computer.org + + * include/grub/util/getroot.h (grub_get_prefix): Remove prototype. + * util/getroot.c [__CYGWIN__

Re: [PATCH] Fix Cygwin path handling

2010-04-17 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: The Cywin path handling is broken since make_system_path_relative_to_its_root() functionality was moved from the lib script to misc.c. This patch should fix this. It reuses the Cygwin specific code from

Re: NEED_REGISTER_FRAME_INFO can be replaced by -static-libgcc

2010-04-14 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: The *_frame_info symbols are set undefined to force linkage of the libgcc_s shared library or dll. This can be prevented by TARGET_LDFLAGS=-static-libgcc. To build from grub-1.98 tarball on Cygwin, run configure

[PATCH] Fix Cygwin path handling

2010-04-14 Thread Christian Franke
early return by break. [__CYGWIN__] Add conversion to win32 path. -- Regards, Christian Franke === modified file 'util/grub-mkconfig_lib.in' --- util/grub-mkconfig_lib.in 2010-04-13 12:57:56 + +++ util/grub-mkconfig_lib.in 2010-04-14 16:48:44 + @@ -1,5 +1,5 @@ # Helper

NEED_REGISTER_FRAME_INFO can be replaced by -static-libgcc

2010-04-13 Thread Christian Franke
-libgcc. To build from grub-1.98 tarball on Cygwin, run configure with this argument. May also be necessary on other build platforms when -shared-libgcc is the default. It may be possible simply set -static-libgcc unconditionally. -- Regards, Christian Franke

[PATCH] Add missing include to fix build on Cygwin

2010-03-03 Thread Christian Franke
This fixes a regression in grub-pe2elf which breaks build on Cygwin. 2010-03-03 Christian Frankefra...@computer.org * util/grub-pe2elf.c: Add missing include progname.h. This fixes build on Cygwin. -- Regards, Christian Franke === modified file 'util/grub-pe2elf.c' --- util

Re: On gratuitous modularization

2010-02-07 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: Hi Robert, Robert Millan wrote: Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. ... kern/disk.c:struct

Re: On gratuitous modularization

2010-01-25 Thread Christian Franke
'grub_disk_ata_pass_through' is a hack. A cleaner design would be possible with a grub_disk_dev.ioctl(.) call. -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Request: hdparm module with -X transfer mode

2010-01-11 Thread Christian Franke
Nando wrote: It's great to have hdparm output added. Another fixup that would be needed would be setting the ATAPI cable mode to be 80pin, rather than the slower 40pin. Users who add hard drives in place of PATA optical drives are liked affected. Eg:

Re: gettext: commands/hdparm.c

2009-12-09 Thread Christian Franke
, or using qemu). If the alignment is just a cosmetic enhancement, dropping it could be a reasonable option. Yes, it is only cosmetic - feel free to drop it. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: Request: hdparm module with -X transfer mode

2009-12-09 Thread Christian Franke
with ata.mod instead of biosdisk.mod. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Easy grub2 installation for non Linux (Windows) systems?

2009-12-09 Thread Christian Franke
as a Cygwin package, 1.97 will be provided when binutils regression is fixed. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: hdparm documentation

2009-11-08 Thread Christian Franke
(ata0) -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ntldr support

2009-08-10 Thread Christian Franke
at 0x4e10 bootmgr.exe from Vista: ??? grub4dos checks for ntldr as follows: - file starts with 0xe9, 0x??, 0x01, - first sector does not end with bootsector signature 0x55,0xaa, - file size exceeds 0x3. -- Regards Christian Franke ___ Grub-devel

Re: [PATCH] ntldr support

2009-08-10 Thread Christian Franke
load command. For 'ntldr': check that the file size is reasonable and that code starts with a jmp instruction. Allow to override the check with '--force'. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [PATCH] ntldr support

2009-08-08 Thread Christian Franke
is missing. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ntldr support

2009-08-08 Thread Christian Franke
that the 'ntldr' command does simple signature checks and fail on unknown files unless '--force' is specified. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Solving the grub-pe2elf problem

2009-08-08 Thread Christian Franke
compile time by half and generate module file much smaller that the current format. Tested successfully on Cygwin - Nice work! -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub

Re: Solving the grub-pe2elf problem

2009-08-07 Thread Christian Franke
this? No. Then building a Cygwin package would rely on the existence of (tested or untested?) binaries in the a release tarball. Building packages from SVN snapshots would no longer be possible. I really don't want to spent my open-source-time with such kind of feature removal :-) -- Regards, Christian

Re: Solving the grub-pe2elf problem

2009-08-07 Thread Christian Franke
objconv it soon. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ntldr support

2009-08-04 Thread Christian Franke
. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub-pe2elf

2009-08-04 Thread Christian Franke
Commit 1726 is from 2008-07-24, start was here: http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00452.html -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ntldr support

2009-08-04 Thread Christian Franke
' or 'chainloader --ntldr' command is not mandatory. But it is 'nice to have' because it allows to boot even if the boot code (6 sectors) in the area behind the PBR is not present for whatever reason. See my previsions mail with the test case. -- Regards, Christian Franke

Re: grub-pe2elf

2009-08-03 Thread Christian Franke
Robert Millan wrote: On Sat, Aug 01, 2009 at 05:06:46PM +0200, Christian Franke wrote: Since ~r1584, util/grub-* could be build and run on Cygwin. Commit r1726 added support to build kernel and modules on Cygwin. There has to be more to it. I know you were using GRUB on Cygwin

Re: grub-pe2elf

2009-08-01 Thread Christian Franke
Robert Millan wrote: On Fri, Jul 31, 2009 at 08:27:58PM +0200, Christian Franke wrote: First of all, I'm worried that we have discussions to decide things and they are later forgotten or ignored. Bean, please can you provide some explanation on what happened? Also, I think this commit

Re: grub-pe2elf

2009-07-31 Thread Christian Franke
. $ find grub2 -type f -name '*.[ch]' | xargs cat | wc -l 128175 $ cat grub2/util/grub-pe2elf.c | wc -l 521 0.4% of the total LoC is IMO less than 'all costs' :-) -- Regards Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

2009-07-24 Thread Christian Franke
original patch (svn 1353) that was necessary because of missing d_type on Cygwin - Sorry! Meantime I added d_type support to Cygwin itself and therefore learned how this is supposed to work :-) -- Regards, Christian Franke ___ Grub-devel mailing list

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

2009-07-24 Thread Christian Franke
Pavel Roskin wrote: On Fri, 2009-07-24 at 23:02 +0200, Christian Franke wrote: A correct performance-aware solution would look like: #ifdef DT_DIR if (de-d_type == DT_DIR) info.dir = 1; else if (de-type == DT_FILE) There in no DT_FILE in glibc, but there is DT_REG. Yes

[PATCH] add a snapshot version string to GRUB title

2009-07-02 Thread Christian Franke
-1 if 'svn info' is not available. The string is added to grub title only, utils are left out for now. Regards, Christian Franke 2009-07-02 Christian Franke fra...@computer.org Auto-generate a snapshot version string for GRUB title. * Makefile.in: Add targets

Re: [2342] 2009-06-18 Vladimir Serbinenko phco...@gmail.com

2009-06-20 Thread Christian Franke
Pavel Roskin wrote: On Fri, 2009-06-19 at 22:05 +0200, Christian Franke wrote: This was the AC_MSG_RESULT(...) for the AC_MSG_CHECKING([for option to link raw image]) which is still present for the $grub_cv_apple_target_cc != yes case. I would suggest to move the AC_MSG_CHECKING outside

Re: [2342] 2009-06-18 Vladimir Serbinenko phco...@gmail.com

2009-06-19 Thread Christian Franke
the 'if $grub_cv_apple_target_cc = yes ... fi' and re-add the AC_MSG_RESULT. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [2290] 2009-06-10 Pavel Roskin pro...@gnu.org

2009-06-11 Thread Christian Franke
'. -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [2290] 2009-06-10 Pavel Roskin pro...@gnu.org

2009-06-11 Thread Christian Franke
complete linking for target Complete linking is not used during build but during configure. The following tests rely on it: grub_PROG_LD_BUILD_ID_NONE grub_CHECK_BSS_START_SYMBOL grub_CHECK_END_SYMBOL I would suggest to undo commit 2290 for now. -- Regards, Christian Franke

Re: [2290] 2009-06-10 Pavel Roskin pro...@gnu.org

2009-06-11 Thread Christian Franke
Pavel Roskin wrote: We can use -Wl,--defsym,___main=0x8100 as it's done elsewhere in configure.ac. Let me just check it doesn't break anything. This (r2310) works on Cygwin, thanks. -- Regards, Christian Franke ___ Grub-devel mailing list

Re: status grub2 port of grub-legasy map command

2009-05-31 Thread Christian Franke
and SATA-IO) still publicly available: http://www.t13.org/Documents/MinutesDefault.aspx?DocumentType=4DocumentStage=2 -- Regards, Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ata.mod under qemu

2009-05-25 Thread Christian Franke
Pavel Roskin wrote: On Sat, 2009-05-23 at 23:04 +0200, Christian Franke wrote: New patch attached. Please test on the above hardware if possible. It's working fine. (ata6) and (ata7) appear, but (ata0) and (ata1) doesn't. When inserting ata.mod, I get: error: error reading ATA

Re: [PATCH] ata.mod under qemu

2009-05-23 Thread Christian Franke
Christian Franke wrote: Pavel Roskin wrote: It helps detect CD-ROM under qemu. But on the real hardware, it introduces ghost drives. Without the patch, I have (ata7) for the SATA hard drive. With the patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW and two bogus

Re: [PATCH] ata.mod under qemu

2009-05-21 Thread Christian Franke
Pavel Roskin wrote: On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote: The attached patch should fix this. It should also prevents misleading error messages if a device does not exist. It helps detect CD-ROM under qemu. But on the real hardware, it introduces ghost drives

Re: [PATCH] ata.mod under qemu

2009-05-20 Thread Christian Franke
The attached patch should fix this. It should also prevents misleading error messages if a device does not exist. 2009-05-20 Christian Franke fra...@computer.org * disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status register. (grub_ata_identify): Suppress

Re: [PATCH] ata.mod under qemu

2009-05-19 Thread Christian Franke
slave port of some SATA controllers working in IDE-mode. The check can be safely removed, the only drawback is an extra ~1s timeout for each SATA controller. I will commit a fix soon. -- Regards, Christian Franke ___ Grub-devel mailing list Grub

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-18 Thread Christian Franke
it 'grub_start_addr' and '.globl start, _start' are also not used. -- Christian Franke diff --git a/configure.ac b/configure.ac index a048828..e799a79 100644 --- a/configure.ac +++ b/configure.ac @@ -212,15 +212,13 @@ AC_MSG_CHECKING([for option to link raw image]) if test -f ${srcdir}/conf

Re: [2216] Remove incorrect comment that the code must be position independent.

2009-05-15 Thread Christian Franke
: -- trunk/grub2/commands/i386/pc/drivemap_int13h.S Function drivemap.c:install_int13_handler() copies the grub_drivemap_handler code to some low memory allocated by grub_mmap_malign_and_register(). No relocation is done. IMO the code must be position independent. -- Christian

Re: Eliminating nested functions

2009-04-17 Thread Christian Franke
NESTED_FUNC_ATTR on all functions used as an argument to the same function. 7) The grub utils may not run on some 'security hardened' platform which does not allow to enable stack execution. -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org

Re: precision formatting in grub_printf

2009-03-24 Thread Christian Franke
sets format2 to ~0U ('infinite' :-) if no precision is specified. Thanks -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: precision formatting in grub_printf

2009-03-18 Thread Christian Franke
format? (diff -u) I already added (fixed) the precision parsing and added handling of '%s' precision (truncation): http://svn.savannah.gnu.org/viewvc/trunk/grub2/kern/misc.c?root=grubr1=1936r2=1954 The parsing part of this new patch might conflict with this change. -- Christian Franke

Re: [PATCH] implement grub_millisleep in util/misc.c for grub-emu

2009-02-28 Thread Christian Franke
... # ... # else # define _POSIX_C_SOURCE 200112L # endif #endif I would suggest to remove the #define and commit the patch. BTW: compiles fine on Cygwin, with or without the #define. -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] implement grub_millisleep in util/misc.c for grub-emu

2009-02-28 Thread Christian Franke
Christian Franke wrote: There is no warning, because none of the headers define _POSIX_C_SOURCE. This should read: There is a warning, because features.h defines _POSIX_C_SOURCE :-) -- Christian Franke ___ Grub-devel mailing list Grub-devel

Re: Building grub2 for windows

2009-02-27 Thread Christian Franke
Alexandre Bique wrote: On Thu, Feb 26, 2009 at 2:35 PM, Christian Franke ... wrote: What is the error message you got on Cygwin ? The problem is that make install installs elf binaries and not win32 binaries. But win32 binaries are compiled. I moved win32 binaries by hand. I

Re: Building grub2 for windows

2009-02-26 Thread Christian Franke
? -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] hdparm.mod - get/set ATA disk parameters

2009-02-21 Thread Christian Franke
Robert Millan wrote: On Sat, Feb 14, 2009 at 03:13:31PM +0100, Christian Franke wrote: insmod ata_pthru (note that module dependencies should make this unnecessary) This insmod is necessary for now. hdparm.mod does not directly call ata_pthru.mod, it uses kern/disk.c

Re: [PATCH] hdparm.mod - get/set ATA disk parameters

2009-02-21 Thread Christian Franke
Robert Millan wrote: On Sat, Feb 21, 2009 at 07:00:06PM +0100, Christian Franke wrote: Very interesting. Do you think any of these features could be useful as a default option in grub-mkconfig? At least the --health check and --security-freeze are IMO recommended for each disk

Re: Bugfix: ata pass-through broke compilation

2009-02-14 Thread Christian Franke
phcoder wrote: Hello. Here is bugfix Thanks! Yes, I should rename all occurences... (gcc 3.4.4 did not detect this). Committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] hdparm.mod - get/set ATA disk parameters

2009-02-09 Thread Christian Franke
Robert Millan wrote: On Sun, Feb 08, 2009 at 12:12:32AM +0100, Christian Franke wrote: Robert Millan wrote: I would suggest to move grub_ata_pass_through() to a new module (e.g. ata2.mod, atax.mod, ataex.mod, ...) How about ata_something.mod? (consistent with ntfs.mod

Re: [PATCH] hdparm.mod - get/set ATA disk parameters

2009-02-07 Thread Christian Franke
Robert Millan wrote: On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote: This patch adds a command which allows to change a few (S)ATA drive settings. It relies on a new pass-through function in ata.mod. Is this function going to be used for normal use of ata? Note

Re: [PATCH] hdparm.mod - get/set ATA disk parameters

2009-02-07 Thread Christian Franke
Robert Millan wrote: I would suggest to move grub_ata_pass_through() to a new module (e.g. ata2.mod, atax.mod, ataex.mod, ...) How about ata_something.mod? (consistent with ntfs.mod ntfs_comp.mod) ata_pthru.mod ? Christian ___

Re: [PATCH] Skip identical lines in hexdump

2009-02-02 Thread Christian Franke
Christian Franke wrote: This skips identical lines in hexdump output, like 'od' or 'xxd -a' also do. Committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Allow more than one line in option help text

2009-01-30 Thread Christian Franke
Christian Franke wrote: This small patch allows '\n' in option help texts, for example: Patch simplified committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Skip identical lines in hexdump

2009-01-30 Thread Christian Franke
This skips identical lines in hexdump output, like 'od' or 'xxd -a' also do. Christian PS: I would suggest to change hexdump 'buf' parameter from 'char *' to 'const void *' to avoid unnecessary casts. 2009-01-30 Christian Franke fra...@computer.org * lib/hexdump.c (hexdump

Re: [PATCH] remove target_os

2009-01-27 Thread Christian Franke
Javier Martín wrote: Unfortunately, gcc has no '-fno_os' option to specify the bare CPU as target. Might -ffreestanding be what you are looking for? The option '-ffreestanding' is the same as '-fno-hosted'. According to gcc (4.3.1) source, '-fno-hosted' clears variable

Re: [PATCH] remove target_os

2009-01-27 Thread Christian Franke
Javier Martín wrote: El mar, 27-01-2009 a las 18:21 +0100, Christian Franke escribió: Javier Martín wrote: Unfortunately, gcc has no '-fno_os' option to specify the bare CPU as target. Might -ffreestanding be what you are looking for? The option

Re: [PATCH] remove target_os

2009-01-26 Thread Christian Franke
Robert Millan wrote: Hi, Based on the description of host/target triplets in configure.ac: dnl build -- the environment for building GRUB dnl host -- the environment for running utilities dnl target -- the environment for running GRUB it seems that target_os is an oxymoron. There's

Re: [PATCH] (ata.mod) Fix read/write, improve status check

2009-01-22 Thread Christian Franke
Christian Franke wrote: This patch fixes these open issues: - grub_pio_read/write() check the ERR bit without ensuring !BSY. - ata_read fails if (batch % size) == 0. - ata_write does not work at all, it uses the read cmd. Tested on several PC + Committed. Christian

Re: [PATCH] Add 'precision' to grub_printf %s format

2009-01-22 Thread Christian Franke
Christian Franke wrote: This patch adds 'precision' support to grub_printf '%s' format, e.g.: Committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Add 'precision' to grub_printf %s format

2009-01-21 Thread Christian Franke
This patch adds 'precision' support to grub_printf '%s' format, e.g.: grub_printf(data=%.20s...\n, data); This feature of standard printf() is useful to limit output length or to print strings which are not 0-terminated. Christian 2009-01-21 Christian Franke fra...@computer.org

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-20 Thread Christian Franke
Marco Gerards wrote: Committed, plus an additional wait in grub_atapi_identify. Great! :-) Open issues: - grub_pio_read/write() check the ERR bit without ensuring !BSY. - ata_read fails if (batch % size) == 0. - ata_write does not work at all, it uses the read cmd. grub_ata_write

[PATCH] (ata.mod) Fix read/write, improve status check

2009-01-20 Thread Christian Franke
This patch fixes these open issues: - grub_pio_read/write() check the ERR bit without ensuring !BSY. - ata_read fails if (batch % size) == 0. - ata_write does not work at all, it uses the read cmd. Christian 2009-01-20 Christian Franke fra...@computer.org * disk/ata.c

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-19 Thread Christian Franke
Marco Gerards wrote: Christian Franke ... writes: This patch fixes the data I/O protocol of the ATA PACKET command. The current implementation does not read the byte count registers. ATAPI read may not work if the drive sends the data in more than one block. In conjunction

Re: [PATCH] (scsi.mod) Fix SCSI read for blocksize != 512

2009-01-19 Thread Christian Franke
Christian Franke wrote: This patch fixes SCSI blocksize handling, necessary for ATAPI CD/DVD. Committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-19 Thread Christian Franke
Christian Franke wrote: Marco Gerards wrote: Christian Franke ... writes: This patch fixes the data I/O protocol of the ATA PACKET command. The current implementation does not read the byte count registers. ATAPI read may not work if the drive sends the data in more than one block

[PATCH] (ata.mod) Fix ATAPI protocol

2009-01-18 Thread Christian Franke
work. Christian 2008-01-18 Christian Franke fra...@computer.org * disk/ata.c (GRUB_ATAPI_REG_*): New defines. (GRUB_ATAPI_IREASON_*): Likewise. (grub_ata_pio_write): Fix timeout error return. (grub_atapi_wait_drq): New function. (grub_atapi_packet): New

[PATCH] (scsi.mod) Fix SCSI read for blocksize != 512

2009-01-17 Thread Christian Franke
This patch fixes SCSI blocksize handling, necessary for ATAPI CD/DVD. OT: There might be a memory leak in scsi_open(): free(scsi) is missing, at least on open error. Christian 2009-01-17 Christian Franke fra...@computer.org * disk/scsi.c (grub_scsi_read10): Use scsi-blocksize

Re: [PATCH] (ata.mod) Add variable timeouts, fix identify, fix device selection

2009-01-16 Thread Christian Franke
Christian Franke wrote: This patch fixes the following issues in ata.mod I found during testing on several PC and VMs: ... Committed. Christian ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] (ata.mod) Add variable timeouts, fix identify, fix device selection

2009-01-16 Thread Christian Franke
Christian Franke wrote: ... Other issues found, not addressed in this patch: ... - atapi_read does not always work (occasional timeouts, crash on VmWare) Root of this problem is in scsi.mod: It always assumes a sector size of 512 bytes which is not the case for ATAPI CD/DVD. Christian

[PATCH] (ata.mod) Add variable timeouts, fix identify, fix device selection

2009-01-14 Thread Christian Franke
: - ata_read fails if (batch % size) == 0. - ata_write does not work at all, it uses the read cmd. - atapi_read does not always work (occasional timeouts, crash on VmWare) I will provide patches for these later. Christian 2009-01-14 Christian Franke fra...@computer.org * disk/ata.c

[PATCH] Fix ATA compatibility mode check

2009-01-11 Thread Christian Franke
For the compatibility mode check, the ATA driver uses the bits in the Revision byte instead of the Programming Interface Byte of the class value (See T13/1510D). The compat_use[] flags are never set. This patch fixes both issues. Christian 2009-01-11 Christian Franke fra...@computer.org

Re: __FILE__ (Re: [PATCH] framework for building modules externally)

2008-11-06 Thread Christian Franke
Robert Millan wrote: On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote: PS: The current use of __FILE__ may also add extra unexpected size: For packaging, configure is often run outside of $srcdir with a absolute path name. This may result in long __FILE__ strings, like

Re: [PATCH] framework for building modules externally

2008-11-04 Thread Christian Franke
a module with wrong ABI version fails due to undefined symbol. -- Christian Franke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add __enable_execute_stack() if required

2008-09-19 Thread Christian Franke
walt wrote: Robert Millan wrote: On Tue, Sep 16, 2008 at 09:42:50PM +0200, Christian Franke wrote: Some gcc versions generate a call to __enable_execute_stack() in trampolines for nested functions. This is the case for new Cygwin gcc-4.3.2. Other GRUB2 target platforms may be affected

Re: [PATCH] Add __enable_execute_stack() if required

2008-09-17 Thread Christian Franke
Robert Millan wrote: On Tue, Sep 16, 2008 at 09:42:50PM +0200, Christian Franke wrote: Some gcc versions generate a call to __enable_execute_stack() in trampolines for nested functions. This is the case for new Cygwin gcc-4.3.2. Other GRUB2 target platforms may be affected - the following

Re: [PATCH] fix disk-id abuse

2008-09-02 Thread Christian Franke
Robert Millan wrote: On Tue, Sep 02, 2008 at 09:12:04PM +0200, Christian Franke wrote: If disk-id is supposed to be a GUID ('Grub Unique Identifier' in this case :-), then a pointer to the private data structure for the disk should work. This id is unique until disk close. For drivers

Re: [PATCH] Mingw support for grub2

2008-08-24 Thread Christian Franke
Bean wrote: Hi, This patch add support for mingw, now you can create native executable for windows. Nice! Does grub-setup work? ... --- a/include/grub/util/misc.h +++ b/include/grub/util/misc.h ... +#ifdef __MINGW32__ + +#include windows.h + +grub_int64_t fseeko (FILE *fp,

Re: [PATCH] Mingw support for grub2

2008-08-24 Thread Christian Franke
Vesa Jääskeläinen wrote: Bean wrote: On Mon, Aug 25, 2008 at 12:04 AM, Vesa Jääskeläinen [EMAIL PROTECTED] wrote: Bean wrote: Yes, it works, although mingw can't use device names like /dev/sda, but it can use windows special name //./PHYSICALDRIVE0. That should be

Re: [PATCH] Don't install Cygwin specific files elsewhere

2008-08-09 Thread Christian Franke
Christian Franke wrote: This patch prevents the install of grub.d/10_windows on other OS. grub-pe2elf is only installed if requested by --enable-grub-pe2elf. Even on Cygwin, grub-pe2elf is only required during build. Committed. ___ Grub-devel

Re: bug: cygwin support breaks cross compiles on cygwin

2008-08-09 Thread Christian Franke
Felix Zielcke wrote: Am Freitag, den 08.08.2008, 23:13 +0200 schrieb Christian Franke: I agree. I posted a patch which handles both grub.d/10_windows and grub-pe2elf. Thanks I even saw that mail before this. I even reverted now my rm -f 10_windows change to current Debian trunk

Re: bug: cygwin support breaks cross compiles on cygwin

2008-08-08 Thread Christian Franke
Patrick Georgi wrote: Hi, I used cygwin to build grub2/i386-coreboot using an i386-elf cross compiler. unfortunately the test in configure only looks for the host platform and enables pe2elf in that case, even though my compiler emits ELF already. my workaround is to just change that test

Re: bug: cygwin support breaks cross compiles on cygwin

2008-08-08 Thread Christian Franke
Felix Zielcke wrote: Hello, Am Freitag, den 08.08.2008, 14:59 +0200 schrieb Christian Franke: No, grub-pe2elf is build and installed even if is not necessary for the build process. This should be no problem. Well it's the same as with that --enable-debug thingy ;) In our Debian

[PATCH] Don't install Cygwin specific files elsewhere

2008-08-08 Thread Christian Franke
This patch prevents the install of grub.d/10_windows on other OS. grub-pe2elf is only installed if requested by --enable-grub-pe2elf. Even on Cygwin, grub-pe2elf is only required during build. Christian 2008-08-08 Christian Franke [EMAIL PROTECTED] * Makefile.in: Add `target_os

[PATCH] Fix infinite loop in grub_pit_wait()

2008-08-07 Thread Christian Franke
grub2 from current SVN hangs if run in VirtualPC, the problem was introduced with 'svn diff -r 1779:1780'. Here is a proposed fix. Christian 2008-08-07 Christian Franke [EMAIL PROTECTED] * kern/i386/pit.c (TIMER2_SPEAKER): New define. (TIMER2_GATE): Likewise

Re: [PATCH] Fix infinite loop in grub_pit_wait()

2008-08-07 Thread Christian Franke
Robert Millan wrote: On Thu, Aug 07, 2008 at 05:32:42PM +0200, Christian Franke wrote: grub2 from current SVN hangs if run in VirtualPC, the problem was introduced with 'svn diff -r 1779:1780'. I'm not familiar with this part of the PIT interface; why does it hang only on VirtualPC

  1   2   3   >