Re: [PATCH] add kobodeluxe

2016-10-18 Thread Christopher Allan Webber
Stephen Webber writes: > Thank you both for the warm welcome and feedback :) > > I've attached a patch that builds upon Chris's changes. > > Changed: > spelling patch - removed > description - "game" now included in description > patch names - use dashes consistently (thank you Chris) > >

Re: [PATCH] add kobodeluxe

2016-10-17 Thread Stephen Webber
Thank you both for the warm welcome and feedback :) I've attached a patch that builds upon Chris's changes. Changed: spelling patch - removed description - "game" now included in description patch names - use dashes consistently (thank you Chris) Unchanged: whitespace warnings - these are due

Re: [PATCH] add kobodeluxe

2016-10-17 Thread Kei Kebreau
Christopher Allan Webber writes: >> On Sun, Oct 16, 2016 at 9:06 PM, Kei Kebreau wrote: >>> When I applied the patch, git complained about trailing whitespace; a >>> trivial fix. > > Those whitespace "errors" were in the original patches we borrowed

Re: [PATCH] add kobodeluxe

2016-10-17 Thread Ludovic Courtès
Hello! Welcome, Stephen! Christopher Allan Webber skribis: > From c8b122d8c7cf7a574bbbac66963ac355c64effc5 Mon Sep 17 00:00:00 2001 > From: Stephen Webber > Date: Sun, 16 Oct 2016 15:04:35 -0500 > Subject: [PATCH] gnu: Add kobodeluxe. > > *

Re: [PATCH] add kobodeluxe

2016-10-17 Thread Christopher Allan Webber
Stephen Webber writes: > As for the permanent user profile, one of the debian patches I applied > changed the functionality for security reason. I'm not certain I have the > expertise to make a correcting decision at this time, especially that is in > line with guix conventions about state. I

Re: [PATCH] add kobodeluxe

2016-10-16 Thread Stephen Webber
As for the permanent user profile, one of the debian patches I applied changed the functionality for security reason. I'm not certain I have the expertise to make a correcting decision at this time, especially that is in line with guix conventions about state. I'll remember the feedback on patch

Re: [PATCH] add kobodeluxe

2016-10-16 Thread Kei Kebreau
Christopher Allan Webber writes: > I know Stephen, so I helped him put together this package, which is his > first. It's a long time favorite free software game. > > There were a lot of patches to Kobo Deluxe in Debian; we kept finding > that it wouldn't build without

Re: [PATCH] add kobodeluxe

2016-10-16 Thread Christopher Allan Webber
Christopher Allan Webber writes: > I know Stephen, so I helped him put together this package, which is his > first. It's a long time favorite free software game. > > There were a lot of patches to Kobo Deluxe in Debian; we kept finding > that it wouldn't build without one or another of them, and

Re: [PATCH] add kobodeluxe

2016-10-16 Thread Christopher Allan Webber
I know Stephen, so I helped him put together this package, which is his first. It's a long time favorite free software game. There were a lot of patches to Kobo Deluxe in Debian; we kept finding that it wouldn't build without one or another of them, and we read the summary of all of them and

[PATCH] add kobodeluxe

2016-10-16 Thread Stephen Webber
From c8b122d8c7cf7a574bbbac66963ac355c64effc5 Mon Sep 17 00:00:00 2001 From: Stephen Webber Date: Sun, 16 Oct 2016 15:04:35 -0500 Subject: [PATCH] gnu: Add kobodeluxe. * gnu/packages/games.scm (kobodeluxe): New variable. * gnu/packages/patches/kobodeluxe_paths.patch: New