Re: [hackers] [PATCH 1/6] Add custom layouts. Move layouts to single layout.h file & toggle layers via memcpy w/ XK_Cancel. Clean up secondary layout positioning LRDU properly & blanking placeholders.

2020-07-24 Thread Hiltjo Posthuma
On Fri, Jul 24, 2020 at 09:49:55PM +0200, Maarten van Gompel wrote: > From: Miles Alan > > Fix SIGTERM handler - flip terminate flag in sigterm handler & cleanup > properly > > Modify run function to use select() with a timeout since X events will be > blocked otherwise and terminate wouldn't a

Re: [hackers] [quark][PATCH] fix for NOT_MODIFIED being sent in non-GMT timezone

2020-07-21 Thread Hiltjo Posthuma
On Tue, Jul 21, 2020 at 07:51:56PM +0200, Laslo Hunhold wrote: > On Sun, 19 Jul 2020 09:37:31 -0700 > Jeremy wrote: > > Dear Jeremy, > > I wrote this this mail yesterday, but the mailing list had some > technical problems, so I'm resending it. > > > stat(3)'s mtime is in local time while REQ_MO

Re: [hackers] [quark][PATCH] fix for NOT_MODIFIED being sent in non-GMT timezone

2020-07-19 Thread Hiltjo Posthuma
On Sun, Jul 19, 2020 at 09:37:31AM -0700, Jeremy wrote: > From: Jeremy Bobbin > > stat(3)'s mtime is in local time while REQ_MOD is in GMT. > This patch translates mtime to GMT before comparing to REQ_MOD. > --- > http.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a

Re: [hackers] [slstatus][PATCH] Handle SIGUSR1 for forced refreshes

2020-07-14 Thread Hiltjo Posthuma
On Tue, Jul 14, 2020 at 02:45:14PM +0200, Mart Lubbers wrote: > Dear all, > I've submitted this patch before but maybe I did something wrong (it was > before > the confirmation mail of the subscription). If there is anything else off with > this email/patch, please let me know. > Best, > > Origin

Re: [hackers] setsid: add optional -f to force fork()

2020-07-14 Thread Hiltjo Posthuma
ls/setsid.c#n96 > Regards, > Mattias Andrée > > > On Tue, 14 Jul 2020 10:15:43 +0200 > Hiltjo Posthuma wrote: > > > Hi, > > > > The below patch adds an -f flag to force fork(2)ing and creating a new > > process. > > > > > > F

[hackers] setsid: add optional -f to force fork()

2020-07-14 Thread Hiltjo Posthuma
Hi, The below patch adds an -f flag to force fork(2)ing and creating a new process. >From a75ef384c11b64732dd6a3adc9249ba6beb8a67e Mon Sep 17 00:00:00 2001 From: Hiltjo Posthuma Date: Tue, 14 Jul 2020 10:11:43 +0200 Subject: [PATCH] setsid: add optional -f to force fork() --- setsid.1

Re: [hackers] [ii][PATCH] ewritestr: Remove duplicate shift of offset

2020-07-05 Thread Hiltjo Posthuma
On Sun, Jul 05, 2020 at 07:39:19PM +, miz...@protonmail.com wrote: > --- > ii.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ii.c b/ii.c > index 7ca3ee8..426fcff 100644 > --- a/ii.c > +++ b/ii.c > @@ -102,7 +102,6 @@ ewritestr(int fd, const char *s) > for (off = 0; off < le

Re: [hackers] [st][PATCH] x.c: modify xsettitle to work with musl libc

2020-07-03 Thread Hiltjo Posthuma
On Wed, Jul 01, 2020 at 09:29:25PM +0200, joris.k...@gmail.com wrote: > From: Joris Klaasse Bos > > Before this commit, running st on a system with musl libc would > result in a segmentation fault. This is because musl implements > locales differently, which means the function > Xutf8TextListToTe

Re: [hackers] [tabbed][PATCH] Use PWD xprop to set workdir for spawned clients

2020-06-11 Thread Hiltjo Posthuma
On Thu, Jun 11, 2020 at 01:56:21PM +0500, Nikita Zlobin wrote: > workdir could be got from active client via xprop, then set for spawned > client. Terminals can pass it with xprop -id ${WINDOWID} command from > hook, created for PWD change. Setting up hook depends on what shell is > used. For bash

Re: [hackers] [dwm][PATCH] Fix memory leaks in drw

2020-06-11 Thread Hiltjo Posthuma
On Thu, Jun 11, 2020 at 03:28:32PM +0200, Alex Flierl wrote: > The function drw_fontset_free in drw.c was never called. > --- > drw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drw.c b/drw.c > index 8fd1ca4..4cdbcbe 100644 > --- a/drw.c > +++ b/drw.c > @@ -95,6 +95,7 @@ drw_free(Drw

Re: [hackers] [dwm][patch] Make EWMH windows float

2020-06-11 Thread Hiltjo Posthuma
On Sun, Jun 07, 2020 at 08:36:57PM +0200, Jakub Leszczak wrote: > Hi, > > What is the status of this patch? I do not see it being added to the > mainline, nor any new messages for some time. > > Br, > Jakub Leszczak > Hi Jakub, Can you send the last version one more time? The last sent versio

Re: [hackers] [tabbed][PATCH] Fix clients BadDrawable at cleanup with multiple tabs

2020-06-10 Thread Hiltjo Posthuma
On Thu, Jun 04, 2020 at 04:01:17PM +0500, Nikita Zlobin wrote: > unmanage() after killclient() causes at least one BadDrawable from client. > For urxvtd it can crash entire daemon. > --- > tabbed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tabbed.c b/tabbed.c > inde

Re: [hackers] [tabbed][PATCH] Use utf8 for window name

2020-06-10 Thread Hiltjo Posthuma
On Thu, Jun 04, 2020 at 02:13:49PM +0500, Nikita Zlobin wrote: > At least some desktop tools (non-mainstream) are in trouble with tabbed > window name. > At the moment of try I have only tint2 and rofi. First just showes intitled, > but > second - "Invalid encoding". Though xfwm4 has no problem w

Re: [hackers] [dwm][PATCH] Update Vanity Gaps to master

2020-06-10 Thread Hiltjo Posthuma
On Wed, Jun 10, 2020 at 03:20:35PM +, Michel Boaventura wrote: > ‐‐‐ Original Message ‐‐‐ > On Wednesday, June 10, 2020 12:11 PM, Hiltjo Posthuma > wrote: > > > On Wed, Jun 10, 2020 at 02:03:48PM +, Michel Boaventura wrote: > > > > > Hi, >

Re: [hackers] [dwm][PATCH] Update Vanity Gaps to master

2020-06-10 Thread Hiltjo Posthuma
On Wed, Jun 10, 2020 at 02:03:48PM +, Michel Boaventura wrote: > Hi, > > This patch brings Vanity Gaps to master, because the current patch on the > site does not apply after f09418b. > > Thanks. > From c35fd03ec002e1f4476a75203ff9b5cbcc630177 Mon Sep 17 00:00:00 2001 > From: Michel Boavent

Re: [hackers] [tabbed][PATCH] Fixed crash when window height was less or equal to bar height

2020-05-30 Thread Hiltjo Posthuma
On Tue, May 12, 2020 at 05:09:01PM +0200, mi...@aaathats3as.com wrote: > From a29a0142ede7ea8ae7cd2fad351789512789ddef Mon Sep 17 00:00:00 2001 > From: Mikau > Date: Tue, 12 May 2020 15:35:48 +0200 > Subject: [tabbed][PATCH] Fixed crash when window height was less or equal to > bar height > To: h

Re: [hackers] [st][PATCH] Call xsetcursor to set win.cursor in main

2020-05-24 Thread Hiltjo Posthuma
On Wed, May 20, 2020 at 10:24:55PM -0400, Steve Ward wrote: > In xsetcursor, remove "DEFAULT(cursor, 1)" because 0 is a valid value. > Increase max allowed value of cursor from 6 to 7 (st extension). > --- > x.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/x.c

Re: [hackers] [st][PATCH] Add documentation about compiling st on macOS

2020-05-20 Thread Hiltjo Posthuma
On Wed, May 20, 2020 at 05:26:01PM +0200, Juan Cruz Viotti wrote: > I can successfully run `st` on macOS 10.15.3 by installing XQuartz > v2.7.11 and removing `-lrt`, as also explained in the OpenBSD > instructions. > > These instructions should be useful for people wanting to tinker with > `st` on

Re: [hackers] [dwm][patch] Make EWMH windows float

2020-05-18 Thread Hiltjo Posthuma
On Mon, May 18, 2020 at 11:28:51AM +0200, Jakub Leszczak wrote: > Hi, > > > It's been only 4 days since the last reply. > > Sorry. Maybe I am just to eager for reply, I thought you might have > forgotten about this thread. > > > Does removing the updatewindowtype() call cause any regressions? >

Re: [hackers] [dwm][patch] Make EWMH windows float

2020-05-18 Thread Hiltjo Posthuma
On Mon, May 18, 2020 at 09:05:01AM +0200, Jakub Leszczak wrote: > Hi, > > Thread went silent. Do you have any more comments or suggestions? I > don't know whether you are interested in making such change into > mainline or not. > > Br, > Jakub Leszczak > Hi Jakub, It's been only 4 days since

Re: [hackers] [st][PATCH] Allow cursor blink to stop when typing

2020-05-15 Thread Hiltjo Posthuma
On Fri, May 15, 2020 at 09:30:58AM -0400, jvyden wrote: > Heyo. I modified the blinking_cursor patch to stop when the user start > typing, to avoid > distractions. This is also a pretty common feature in other terminal > emulators with blinking > features, so I'd imagine users like me would want

Re: [hackers] [dwm][patch] Make EWMH windows float

2020-05-14 Thread Hiltjo Posthuma
On Tue, May 12, 2020 at 11:07:31AM +0200, Jakub Leszczak wrote: > Hi, > > Commit `8262d9e663a98ab74b938bb5cdf0ddfd733bc5df` added logic to dwm > to make dialog windows float. I think that natural extension of that > commit is to also make a couple other window types float as well. > Types of wind

[hackers] Re: [sent][PATCH] Avoid out-of-bounds access when a slide input line begins with \0

2020-05-12 Thread Hiltjo Posthuma
On Tue, May 12, 2020 at 06:51:02PM +0100, Chris Down wrote: > If we read in a line with \0 at the beginning, blen will be 0. However, > we then try to index our copy of the buffer with > s->lines[s->linecount][blen-1], we'll read (and potentially write if the > data happens to be 0x0A) outside of s

Re: [hackers] [dwm][patch] Fix transparent borders

2020-05-10 Thread Hiltjo Posthuma
On Sun, May 10, 2020 at 02:30:56PM +0200, Jakub Leszczak wrote: > > Maybe it can be added to the wiki page for the alpha patch? > > To me it is also OK. Like I said I personally didn't even think it is > worthy of a patch. > And if you don't want this to be part of mainline, then I guess I > coul

Re: [hackers] [dwm][patch] Fix transparent borders

2020-05-10 Thread Hiltjo Posthuma
On Sun, May 10, 2020 at 11:37:02AM +0200, maxardis wrote: > Hi, > > I personally didn't think this is worthy of a patch, but some people > actually find it useful. > > Issue is that by default when using dwm with compositing window > manager (xcompmgr, picom) whenever client (most often it is ter

Re: [hackers] [st][PATCH] xclearwin clears the window

2020-05-06 Thread Hiltjo Posthuma
On Sun, Apr 19, 2020 at 03:48:27PM +0200, Christian Tenllado wrote: > When an OCS sequence was used to change the bg color, the borders where > dirty. This simple patch just clears the window before the redraw of the > terminal when the bg color has been changed. This is apparently enough > and sea

Re: [hackers] [st][PATCH] replace exit(3) by _exit(2) in signal handler sigchld()

2020-04-29 Thread Hiltjo Posthuma
On Thu, Apr 30, 2020 at 12:10:02AM +0200, Jan Klemkow wrote: > exit(3) is not async-signal-safe but, _exit(2) is. > This change prevents st to crash and dump core. > --- > st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/st.c b/st.c > index 0ce6ac2..2bf133f 100644 > -

Re: [hackers] [dwm][patch] dwm crashes when opening 50+ clients (tile layout)

2020-04-25 Thread Hiltjo Posthuma
On Thu, Apr 23, 2020 at 09:50:54AM +0200, bakkeby wrote: > Many users new to dwm find themselves caught out by being kicked out to the > login manager (dwm crashing) when they open 50+ clients for demonstration > purposes. The number of clients reported varies depending on the resolution > of th

Re: [hackers] [dwm][PATCH] getatomprop: Add forward declaration

2020-04-22 Thread Hiltjo Posthuma
On Wed, Apr 22, 2020 at 03:48:08PM +0100, Chris Down wrote: > No functional changes, but for every other function we have a forward > declaration here. getatomprop should be no exception. > --- > dwm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dwm.c b/dwm.c > index 41c6767..972f261

Re: [hackers] [dwm][PATCH] setmfact: Unify bounds for compile-time and runtime mfact

2020-04-20 Thread Hiltjo Posthuma
On Mon, Apr 20, 2020 at 04:41:52PM +0100, Chris Down wrote: > There are two places that mfact can be set: > > - In the mfact global, which is defined at compile time and passed > into m->mfact during monitor setup. No bounds checks are performed, > but the comment alongside it says that valid

Re: [hackers] Announcing libschrift (a TrueType font rendering library)

2020-04-19 Thread Hiltjo Posthuma
On Sun, Apr 19, 2020 at 04:47:24PM +0200, Thomas Oltmann wrote: > Hello everybody. > > Last year at slcon6, I demo'd a toy TrueType font renderer (*) to a > couple people. > Someone there suggested it'd be really useful to have this as a proper > library for suckless projects to use, > and so afte

Re: [hackers] [libsl] improve lrpad || Hiltjo Posthuma

2020-04-05 Thread Hiltjo Posthuma
Sorry, I accidently pushed to the wrong remote. I've reverted it to the original version. Have a good day, On Sun, Apr 05, 2020 at 05:27:02PM +0200, g...@suckless.org wrote: > commit f33024dd2dbb6471cb2c5c41f901fc19e4c133a8 > Author: Hiltjo Posthuma > AuthorDate: Sun Apr 5

Re: [hackers] [quark] Fix unveil(2) usage || Laslo Hunhold

2020-03-20 Thread Hiltjo Posthuma
On Fri, Mar 20, 2020 at 08:39:10PM +0100, g...@suckless.org wrote: > commit 5ee8c07e7e3e601fce49fbc2b170227924be3804 > Author: Laslo Hunhold > AuthorDate: Fri Mar 20 20:35:34 2020 +0100 > Commit: Laslo Hunhold > CommitDate: Fri Mar 20 20:35:34 2020 +0100 > > Fix unveil(2) usage >

Re: [hackers] [st][PATCH 1/3] Rearrange run with fast exit

2020-03-19 Thread Hiltjo Posthuma
On Thu, Mar 19, 2020 at 09:11:59AM +0800, Ivan Tham wrote: > Quickly swap out of loop to reduce indentation. > --- > x.c | 55 +++ > 1 file changed, 27 insertions(+), 28 deletions(-) > > diff --git a/x.c b/x.c > index 48a6676..03f397f 100644 > -

Re: [hackers] [quark][PATCH] HTML-escape dirlist dynamic content

2020-03-16 Thread Hiltjo Posthuma
On Mon, Mar 16, 2020 at 12:55:42PM +0200, guysv wrote: > Because ",',<,>,& are all valid unix filename characters, > filenames containing those characters can glitch-out a dirlist > response. > > A funny example would be: > "> > This commit escapes dynamic input, and fixes the bug. > --- > resp.

Re: [hackers] [quark][PATCH] HTML-escape dirlist dynamic content

2020-03-11 Thread Hiltjo Posthuma
On Wed, Mar 11, 2020 at 10:33:06PM +0200, guysv wrote: > Because ",',<,>,& are all valid unix filename characters, > filenames containing those characters can glitch-out a dirlist > response. > > A funny example would be: > "> > This commit escapes dynamic input, and fixes the bug. > --- > resp.

Re: [hackers] [quark][PATCH] HTML-escape dirlist dynamic content

2020-03-10 Thread Hiltjo Posthuma
On Tue, Mar 10, 2020 at 07:52:17PM +0200, guysv wrote: > Because ",',<,>,& are all valid unix filename characters, > filenames containing those characters can glitch-out a dirlist > response. > > A funny example would be: > "> > This commit escapes dynamic input, and fixes the bug. > --- > resp.

Re: [hackers] [dwm][PATCH 1/2] don't iterate through monitors in cleanupmon

2020-01-27 Thread Hiltjo Posthuma
On Mon, Jan 27, 2020 at 07:55:57AM -0600, Devin J. Pohly wrote: > Since both updategeom and cleanup are already iterating over the mons > list, it is wasteful to re-iterate the list in their calls to > cleanupmon. Instead, make the caller of cleanupmon responsible for > removing the monitor from m

Re: [hackers] [st][PATCH] Increase XmbLookupString buffer

2020-01-18 Thread Hiltjo Posthuma
On Sat, Jan 18, 2020 at 03:52:25PM +0800, Ivan Tham wrote: > Current buffer is too short to input medium to long sentences from IME. > Input with longer text will show the wrong input, taking 64 instead of > 32 bytes should be enough for most of the cases. Broken cases before, > > Chinese (taken f

Re: [hackers] [PATCH] remove useless c->next = NULL

2020-01-17 Thread Hiltjo Posthuma
On Fri, Jan 17, 2020 at 02:06:13PM +0100, David Demelier wrote: > --- > ii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ii.c b/ii.c > index ef33ed5..7ca3ee8 100644 > --- a/ii.c > +++ b/ii.c > @@ -234,7 +234,7 @@ channel_new(const char *name) > fprintf(s

Re: [hackers] [dwm][PATCH] Display an alternative text for occupied tags

2020-01-04 Thread Hiltjo Posthuma
On Sat, Jan 04, 2020 at 12:56:09PM +0100, Luigi Foscari wrote: > --- > config.def.h | 1 + > config.h | 116 +++ > drw.o| Bin 0 -> 10456 bytes > dwm

Re: [hackers] [sbase] ed: Use reallocarray || Michael Forney

2020-01-02 Thread Hiltjo Posthuma
On Thu, Jan 02, 2020 at 08:28:40AM +, k0ga wrote: > Hi, > > > On Tue, Dec 31, 2019 at 10:47:28PM +0100, g...@suckless.org wrote: > > diff --git a/ed.c b/ed.c > > index b844e86..e998e81 100644 > > --- a/ed.c > > +++ b/ed.c > > @@ -204,7 +204,7 @@ makeline(char *s, int *off) > > if (lastidx

Re: [hackers] [dwm][PATCH] cleanup, saves 7 LOC

2019-12-23 Thread Hiltjo Posthuma
On Sun, Dec 22, 2019 at 11:27:16AM -0600, Devin J. Pohly wrote: > Not too aggressive, stuck to changes that should be uncontroversial: > - XFree, like free, is specified to do nothing when passed NULL, so no > need to duplicate that check ourselves > - Flip if conditions to save lines in enternot

Re: [hackers] [st][PATCH] mouse drag: don't stop sending drag events prematurely

2019-11-24 Thread Hiltjo Posthuma
On Sat, Nov 23, 2019 at 08:29:39PM +0100, Harm te Hennepe wrote: > ST stopped sending mouse drag events after any ButtonRelease event was > received. For example if you were dragging and then scrolled the mouse, > the dragging events stopped. > > Fixed this by locking the dragging button to the fi

Re: [hackers] Unix Windowing System

2019-11-15 Thread Hiltjo Posthuma
On Fri, Nov 15, 2019 at 07:26:34AM +, Jacob Louis Prosser wrote: > Hi all, > > Recently I have been considering developing my own Windowing System/Display > server, mostly for fun and as an educational experience rather than any > practical reason. > I don't think it would be that hard, just

Re: [hackers] [dmenu][patch] avoid some forks in shell scripts

2019-11-11 Thread Hiltjo Posthuma
On Mon, Nov 11, 2019 at 03:41:52PM +0100, Glen Mével wrote: > Hello, > > Glen Mével wrote (2019-08-10, 23:32): > > Explanation: with common shells (sh, bash, zsh at least), the chain > > command `echo cmd args | $SHELL` leaves an unnecessary shell process, > > waiting for its child process `cmd` t

Re: [hackers] [st][PATCH] Fix tmux terminfo extensions Se and Ss

2019-11-05 Thread Hiltjo Posthuma
On Tue, Nov 05, 2019 at 06:16:39PM +0100, Sebastian J. Bronner wrote: > The tmux terminfo extensions Ss and Se are currently specified as > booleans in `st.info`. They should be strings. See > https://github.com/tmux/tmux/blob/eeedb43ae847a0a692ceea965f7556e84bca4fd0/tty-term.c > lines 254 and 265.

Re: [hackers] [dwm][PATCH] Sort screens by horizontal origin

2019-09-27 Thread Hiltjo Posthuma
On Fri, Sep 27, 2019 at 03:28:39PM +0200, Sebastian Sareyko wrote: > Doing a multi-head setup using other means than Xinerama may lead to > XineramaQueryScreens() returning the screens in an order that does not > actually represent the actual screen layout. This in turn may result > in dwm using th

Re: [hackers] [st][patch] Add sendraw as key binding alias for ttywrite

2019-06-08 Thread Hiltjo Posthuma
On Sat, Jun 08, 2019 at 06:09:58PM +0200, Tobias Bengfort wrote: > This is usefull to create key bindings that cannot be defined in a > terminal program itself. For example, this adds C-S-t as mapping for > creating a new tab in tmux: > > { TERMMOD, XK_T, sendraw,{

Re: [hackers] [ii] [PATCH] Fix traversal of addrinfo list

2019-05-26 Thread Hiltjo Posthuma
On Sat, May 25, 2019 at 07:27:36PM -0700, Michael Forney wrote: > Although the loop is executed once for every result, in each iteration > it connects to the first result. > --- > ii.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ii.c b/ii.c > index 6d2bd36..55d5f5

Re: [hackers] [st] Color pre-multiplication

2019-05-24 Thread Hiltjo Posthuma
On Fri, May 24, 2019 at 11:49:06AM +0200, Lucas Lugão wrote: > Dear st hackers, > > Is there any reason why the > https://st.suckless.org/patches/alpha/st-alpha-20180616-0.8.1.diff > pre-multiplication fix was not included in the subsequent versions of > the alpha patch? > > I made a similar fix

Re: [hackers] [PATCH v3][sbase] cmp: Make output of error message POSIX compliant

2019-05-21 Thread Hiltjo Posthuma
On Tue, May 21, 2019 at 05:37:27AM +0100, Richard Ipsum wrote: > On Mon, May 20, 2019 at 07:06:04PM -0700, Michael Forney wrote: > > On 2019-05-20, Laslo Hunhold wrote: > > > On Mon, 20 May 2019 09:36:32 +0100 > > > Richard Ipsum wrote: > > > > > > Dear Richard, > > > > > >> -

Re: [hackers] [dwm][PATCH] ratpoison-like prefix key

2019-05-11 Thread Hiltjo Posthuma
On Wed, May 08, 2019 at 10:21:09PM +0200, Philip Linde wrote: > - Run "prefix" to enter prefix mode. > - Prefix mode is indicated by a flag in the tag bar. > - While prefix mode is enabled, MODKEY is ignored in all bindings. > - Executing prefix while in prefix mode will send the keysym/mod > com

Re: [hackers] [st] [PATCH] Work around BadLength error by disallowing color fonts

2019-04-24 Thread Hiltjo Posthuma
On Wed, Apr 24, 2019 at 09:59:13PM +0200, Laslo Hunhold wrote: > On Wed, 24 Apr 2019 21:47:39 +0200 > Hiltjo Posthuma wrote: > > Dear Hiltjo, > > > I'm not in favor of this. I think this should be fixed upstream. > > > > Now that there has be

Re: [hackers] [st] [PATCH] Work around BadLength error by disallowing color fonts

2019-04-24 Thread Hiltjo Posthuma
On Tue, Apr 23, 2019 at 10:14:32AM +0200, Laslo Hunhold wrote: > Dear fellow hackers, > > this patch will hopefully resolve the many mails we get on dev@ and > hackers@ regarding crashes of st due to emoji-fonts triggering some > voodoo-condition in Xft. > > I hope my port of Anselm's change to d

Re: [hackers] [st] revert part of commit add0211522737b79dad990ccd65c8af63b5cc1dd || Hiltjo Posthuma

2019-04-02 Thread Hiltjo Posthuma
On Tue, Apr 02, 2019 at 01:12:48PM +0300, Lauri Tirkkonen wrote: > Hey, > > On Fri, Mar 15 2019 20:41:37 +0100, g...@suckless.org wrote: > > commit 21367a040f056f6a207fafa066bd1cb2d9cae586 > > Author: Hiltjo Posthuma > > AuthorDate: Fri Mar 15 20:40:16 2019 +

Re: [hackers] [st][patch] replace utf8strchr with wcschr

2019-03-15 Thread Hiltjo Posthuma
On Thu, Mar 14, 2019 at 09:57:02AM +0200, Lauri Tirkkonen wrote: > Hi, > > On Wed, Mar 13 2019 20:35:09 +0100, Hiltjo Posthuma wrote: > > I don't like mixing of the existing functions with wchar_t. > > I think st should (at the very least internally) use utf-8. &

Re: [hackers] [st][patch] replace utf8strchr with wcschr

2019-03-13 Thread Hiltjo Posthuma
On Wed, Mar 13, 2019 at 08:16:05PM +0200, Lauri Tirkkonen wrote: > Changing worddelimiters to wchar_t * allows to use wcschr() instead of > implementing utf8strchr(). > > Also, since there are so many different spaces and punctuation in > unicode, I have another diff that uses iswspace()/iswpunct(

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Hiltjo Posthuma
On Wed, Mar 13, 2019 at 05:12:54PM +0200, Lauri Tirkkonen wrote: > Currently st is outputting the following on stderr when I attach or > detach tmux (on OpenBSD): > > erresc: unknown private set/reset mode 1005 > > diff below fixes it. > > From e3ddd14bacb0037e236b5a2243120b8494c5f054 Mon

Re: [hackers] dwm with statuscolors patch

2019-03-09 Thread Hiltjo Posthuma
On Sat, Mar 09, 2019 at 10:46:48AM +0100, Olivier Regnier wrote: > Hi, > > I am currently testing dwm 6.2 and dwm-statuscolors-20181008-b69c870.diff > patch. > > - Without colors: [my text] > > - With colors: [my text ] > > I see two spaces at the end of the text at the top right of the screen

Re: [hackers] [st][patch] fix use after free in font caching algorithm

2019-03-03 Thread Hiltjo Posthuma
On Thu, Feb 28, 2019 at 04:56:01AM +0300, magras wrote: > Current font caching algorithm contains a use after free error. A font > removed from `frc` might be still listed in `wx.specbuf`. It will lead > to a crash inside `XftDrawGlyphFontSpec()`. > > Steps to reproduce: > $ st -f 'Misc Tamsyn:sca

Re: [hackers] [dwm][tagintostack-onemaster] Fix failed hunk for dwm-6.2

2019-02-26 Thread Hiltjo Posthuma
On Tue, Feb 26, 2019 at 12:21:10AM +, Aleksandrs Stier wrote: > The current version of the tagintostack-onemaster-patch which was released > for dwm-6.1 https://dwm.suckless.org/patches/tagintostack/ doesn't work on > dwm-6.2 due to a failing hunk. This is because some lines are shifted. Here

Re: [hackers] Re: [libsl][PATCH] Workaround Xft BadLength X error

2019-02-17 Thread Hiltjo Posthuma
On Sun, Feb 17, 2019 at 09:13:04AM +, Thomas Spurden wrote: > Excerpts from Thomas Spurden's message of January 16, 2019 9:51 pm: > > Modify the fontconfig pattern to prefer non-color fonts, and discard any > > selected font which has the color flag set. Using these fonts with Xft is > > just

Re: [hackers] [dwm][PATCH] An alternative gaps implementation.

2019-02-16 Thread Hiltjo Posthuma
On Sat, Feb 16, 2019 at 01:28:06PM +0100, Maciej Sumalvico wrote: > In addition to what the "gaps" patch does, this also adds: > - outer gaps, > - a gap between a master and stack area, > - a function and keybindings to increase/decrease/disable gaps. > --- > config.def.h | 4 > dwm.c

Re: [hackers] [st][PATCH] make: add config.def.h as a dep of config.h

2019-02-14 Thread Hiltjo Posthuma
On Thu, Feb 14, 2019 at 06:50:34AM -0800, William Casarin wrote: > Jules Maselbas writes: > > >> config.h isn't getting copied when config.def.h changes > > > > You're going to loose your config.h after a an update of config.def.h ! > > I prefer the build to fail over having my config.h erased. >

Re: [hackers] [ii][PATCH] fix typo in NOTICE messages

2019-02-12 Thread Hiltjo Posthuma
On Tue, Feb 12, 2019 at 03:08:13PM +, Sönke Lambert wrote: > From c60ae8f108011ea7dd6d909cd4740c12fdace52d Mon Sep 17 00:00:00 2001 > From: Soenke Lambert > Date: Tue, 12 Feb 2019 15:58:47 +0100 > Subject: [ii][PATCH] fix typo in NOTICE messages > > --- >  ii.c | 2 +- >  1 file changed, 1

Re: [hackers] [dmenu][PATCH] Replace dmenu_run shell with executed application

2019-02-10 Thread Hiltjo Posthuma
On Sun, Feb 10, 2019 at 11:40:06AM +0100, Leonardo Taccari wrote: > Hello Nick, > > Nick writes: > > [...] > > Ignore if you're too busy, but why is this considered bad practise? > > Is there some case of possible shell escaping or something I'm > > failing to see? I just ask for my own educati

Re: [hackers] [st][patch] Refresh keyboard mapping

2019-02-09 Thread Hiltjo Posthuma
On Sat, Feb 09, 2019 at 02:05:05PM +0100, Axel Svensson wrote: > On Fri, Jan 25, 2019 at 9:14 AM wrote: > > I think it is ok and we should merge it. Evil_Bob, what do you think? > > I noticed that the version was just bumped without merging this. > Forgotten or rejected? > Rejected -- Kind re

Re: [hackers] [dmenu][PATCH] Replace dmenu_run shell with executed application

2019-02-09 Thread Hiltjo Posthuma
On Sat, Feb 09, 2019 at 01:48:34PM +0100, Jan Bessai wrote: > On Sun, Dec 30, 2018 at 02:59:13PM +0100, Jan Bessai wrote: > > Thanks! I've attached the updated patch below. > > Sorry if I'm breaching any rules, but any update on accepting/rejecting > the patch? > Rejected -- Kind regards, Hilt

Re: [hackers] [dev][slstatus] FreeBSD port?

2019-01-25 Thread Hiltjo Posthuma
On Fri, Jan 25, 2019 at 12:15:49AM +, Michael Buch wrote: >Indeed personally I thought the $(OS) directories in the original >Makefile made for a cleaner way to port. Though before working on a >rewrite/revert some consensus on this would be good. >Thanks, >Michael > >A

Re: [hackers] [st][PATCH] Fix crash on IME restart

2019-01-23 Thread Hiltjo Posthuma
On Wed, Jan 23, 2019 at 01:53:56AM +0800, Ivan Tham wrote: > Register XNDestroyCallback on IME to reinstatiate XIM. > > This does not solve: > - IME not usable if st started before IME > - st goes blank with two st in a dwm tag after restarting IME, might be > dwm bug as it is happens to other t

Re: [hackers] [st][PATCH] Let the user specify CPPFLAGS

2019-01-10 Thread Hiltjo Posthuma
On Thu, Jan 10, 2019 at 01:36:09PM +0100, Paride Legovini wrote: > This complements the work done in d4928ed, allowing the user to specify > the preprocessor flags with the CPPFLAGS environment variable. This is > useful for example to specify preprocessor macros with -D. > > CFLAGS could be used

Re: [hackers] [st][PATCH] Set the path of pkg-config in a variable instead of hardcoding it

2019-01-04 Thread Hiltjo Posthuma
On Fri, Jan 04, 2019 at 01:41:33PM +0100, Paride Legovini wrote: > Hiltjo Posthuma wrote on 04/01/2019: > > On Fri, Jan 04, 2019 at 09:48:37AM +0100, Paride Legovini wrote: > >> In this way the path of pkg-config can be overridden from the command > >> line. This is us

Re: [hackers] [st][PATCH] Makefile: fix dependencies on config.h

2019-01-04 Thread Hiltjo Posthuma
On Sun, Dec 30, 2018 at 11:21:58PM +0100, Younes Khoudli wrote: > st.o doesn't depend on config.h, x.o does. > > Signed-off-by: Younes Khoudli > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 0b3cecd..0730757 100644 > ---

Re: [hackers] [st][PATCH] Set the path of pkg-config in a variable instead of hardcoding it

2019-01-04 Thread Hiltjo Posthuma
On Fri, Jan 04, 2019 at 09:48:37AM +0100, Paride Legovini wrote: > In this way the path of pkg-config can be overridden from the command > line. This is useful for example when cross-compiling. > --- > config.mk | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/c

Re: [hackers] [st][PATCH] Makefile: fix dependencies on config.h

2018-12-31 Thread Hiltjo Posthuma
On Sun, Dec 30, 2018 at 11:21:58PM +0100, Younes Khoudli wrote: > st.o doesn't depend on config.h, x.o does. > > Signed-off-by: Younes Khoudli > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 0b3cecd..0730757 100644 > ---

Re: [hackers] [st][patch] output child WEXITSTATUS/WTERMSIG on abnormal termination

2018-12-11 Thread Hiltjo Posthuma
On Tue, Dec 11, 2018 at 11:57:31AM +0200, Lauri Tirkkonen wrote: > Hi, currently st is reporting a somewhat opaque error number when its > child process terminates abnormally: > > % st sh -c 'exit 1' > child finished with error '256' > % st sh -c 'exit 2' > child finished with erro

Re: [hackers]

2018-11-18 Thread Hiltjo Posthuma
On Sun, Nov 18, 2018 at 07:47:00PM +0100, Quentin Rameau wrote: > Hello nzl, > > > Subject: [surf[PATCH] Remove HTTP referer on navigation > > Thank you, but I'm not sure what you want us to do with that. > > Is this for mainline integration? > If so, I find it a bit too drastic, some websites d

Re: [hackers] [st][patch] Increase the buffer size for escape sequences

2018-09-23 Thread Hiltjo Posthuma
On Sun, Sep 23, 2018 at 12:12:27PM +0200, Ingo Heimbach wrote: > Before this commit, long escape sequences (e.g. OSC 52) could be trimmed > due to a quite small escape sequence buffer. This commit increases the > escape sequence buffer from 128 to 1048576 UTF-8 characters. > --- >  st.c | 2 +- >  1

Re: [hackers] [ii][patch] add support for OpenBSD unveil(2)

2018-09-12 Thread Hiltjo Posthuma
On Wed, Sep 12, 2018 at 08:20:38AM +0100, Roberto E. Vargas Caballero wrote: > On Tue, Sep 11, 2018 at 08:14:25PM -0300, Gleydson Soares wrote: > > the following patch brings support for OpenBSD's unveil(2) mechanism for > > ii. > > Guys, we should stop sending this kind of patches. If we begin to

Re: [hackers][sbase][PATCH] Fix build errors on some ARM64 Linux systems

2018-08-27 Thread Hiltjo Posthuma
On Mon, Aug 27, 2018 at 09:37:24PM +0300, Platon Ryzhikov wrote: > These changes are required on Arch Linux ARM to build sbase. This does not > affect x86 build. > --- > ls.c | 1 + > tar.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/ls.c b/ls.c > index b716aba..9e79fcb 100644 >

Re: [hackers] [PATCH] Restore cursor color customization and defaults

2018-07-17 Thread Hiltjo Posthuma
On Tue, Jul 17, 2018 at 10:58:40PM +0200, Jules Maselbas wrote: > defaultcs define the (main) cursor color. defaultcfg define the secondary > cursor color, this is the color taken by the text color when using the > cursor with a block or snowman shape. > > defaultcs and defaultcfg have a variant f

Re: [hackers] [st] Revert "Simplify cursor color handling" || Hiltjo Posthuma

2018-07-17 Thread Hiltjo Posthuma
On Tue, Jul 17, 2018 at 08:05:01PM +0200, g...@suckless.org wrote: > commit 4f4bccd1627c845330235721f593d2e93418723d > Author: Hiltjo Posthuma > AuthorDate: Tue Jul 17 20:01:58 2018 +0200 > Commit: Hiltjo Posthuma > CommitDate: Tue Jul 17 20:01:58 2018 +0200 > >

[hackers] Re: [st][PATCH] Fix crash when cursor color is truecolor

2018-07-15 Thread Hiltjo Posthuma
On Sun, Jul 15, 2018 at 01:53:37PM +0200, Jules Maselbas wrote: > Reported-by: Ivan Tham > --- > x.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/x.c b/x.c > index b51821d..4155a70 100644 > --- a/x.c > +++ b/x.c > @@ -1404,6 +1404,7 @@ void > xdraw

[hackers] Re: [st][PATCH v2 0/2] Cursor color handling

2018-07-14 Thread Hiltjo Posthuma
On Sat, Jul 14, 2018 at 11:16:35AM +0200, Jules Maselbas wrote: > Hi, > > I was looking for a way to make the cursor color behave the same as in > xterm, by having it's color following the underlining text color. The > first patch tries to simplify the existing code for cursor color handling. >

Re: [hackers] [sbase][PATCH] Add test framework with a test for tty(1)

2018-07-08 Thread Hiltjo Posthuma
On Sun, Jul 08, 2018 at 10:19:46AM +0100, Dimitris Papastamos wrote: >> [snip] > > the tests are primarily for the developers, no user cares if you can > pass all the internal regression tests but fail to build firefox. > > time is better spent writing useful test cases rather than some "test > f

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Hiltjo Posthuma
On Mon, Jul 02, 2018 at 07:48:03PM +1200, David Phillips wrote: > On glibc, major, minor, and makedev are all defined in > sys/sysmacros.h with types.h only including this for historical > reasons. A future release of glibc will remove this behaviour, > meaning that major, minor, and makedev will n

Re: [hackers] [dwm][PATCH] Status bar magic numbers replaced with configurable variables.

2018-05-24 Thread Hiltjo Posthuma
On Thu, May 24, 2018 at 10:48:27PM -0400, Christopher Drelich wrote: > Currently in dwm there are two magic numbers relating to the statusbar in > dwm.c: > > sw = TEXTW(stext) - lrpad + 2; /* 2px right padding */ > > bh = drw->fonts->h + 2; > > I made a patch that replaced these magic numbers w

Re: [hackers] slstatus keymap patch idea

2018-05-21 Thread Hiltjo Posthuma
On Sun, May 20, 2018 at 10:52:13PM +0200, Michael Buch wrote: >Cool, I’ll see if i can put something together for linux. >Regards, >Michael >On Sun, 20 May 2018 at 22:42, Aaron Marcher <[1]m...@drkhsh.at> wrote: > > Michael, > > I’ve been using slstatus for a while and am

Re: [hackers] [PATCH slstatus] Add basic backlight percentage support

2018-05-20 Thread Hiltjo Posthuma
On Sun, May 20, 2018 at 02:21:36PM +0200, David Demelier wrote: > At the moment linux only, but will add support for FreeBSD and OpenBSD > as well. > --- > Makefile | 1 + > components/backlight.c | 33 + > slstatus.h | 3 +++ > 3 files c

Re: [hackers] [st][PATCH] Set minimum window size to avoid crash when resizing out of bounds

2018-05-17 Thread Hiltjo Posthuma
On Wed, May 16, 2018 at 09:36:03PM +0100, michaelbuc...@gmail.com wrote: > From: Michael Buch > > The termianl window is created without lower/upper bounds for window > width/height. On resizing the terminal to a size of 1x1 or below we crash. > This patch sets the minimum window height and wid

Re: [hackers] [st][PATCH] Inhibited st from reporting I/O error when process dies

2018-05-13 Thread Hiltjo Posthuma
On Sun, May 13, 2018 at 06:57:23PM +0200, Philip K wrote: > --- > st.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/st.c b/st.c > index 0628707..d5cfd74 100644 > --- a/st.c > +++ b/st.c > @@ -824,10 +824,15 @@ ttyread(void) > static int buflen = 0; >

Re: [hackers] [PATCH] Remove .hgtags

2018-05-11 Thread Hiltjo Posthuma
On Fri, May 11, 2018 at 11:01:43AM +0200, lukáš Hozda wrote: > Jesus, the amount HTML GMail shoves into an email... I figured it was > bad, but doubling its size > > If you have to use gmail, there is an option for plaintext, but watch > out, it appears as if Google is toggling it off on whim.

Re: [hackers] [PATCH] Remove .hgtags

2018-05-10 Thread Hiltjo Posthuma
On Wed, May 09, 2018 at 08:50:09PM +0200, David Demelier wrote: > --- > .hgtags | 10 -- > 1 file changed, 10 deletions(-) > delete mode 100644 .hgtags > > diff --git a/.hgtags b/.hgtags > deleted file mode 100644 > index 98d1562..000 > --- a/.hgtags > +++ /dev/null > @@ -1,10 +0,0 @

Re: [hackers] [dwm][PATCH] Remove BUGS and TODO

2018-05-07 Thread Hiltjo Posthuma
On Sun, May 06, 2018 at 07:59:00PM +0200, David Demelier wrote: > On Thu, May 03, 2018 at 11:34:08PM -0400, Christopher Drelich wrote: > > In terms of bugs in dwm, there seems to be some listed in BUGS and > > some in dwm.1, is this desired behavior or would it be better to have > > them all in one

Re: [hackers] [dwm][PATCH] Remove BUGS and TODO

2018-05-04 Thread Hiltjo Posthuma
ers, but some of the items in the TODO are outdated indeed. > On Thu, May 3, 2018 at 12:06 PM, Hiltjo Posthuma > wrote: > > On Wed, May 02, 2018 at 07:40:54PM -0400, Christopher Drelich wrote: > >> It is not clear if BUGS and TODO are up-to-date, and if people are &g

Re: [hackers] [dwm][PATCH] Remove BUGS and TODO

2018-05-03 Thread Hiltjo Posthuma
On Wed, May 02, 2018 at 07:40:54PM -0400, Christopher Drelich wrote: > It is not clear if BUGS and TODO are up-to-date, and if people are > already working on (or have solved these issues.) We also don't know > much about an individuals setup. There are much better methods of > keeping track of thi

Re: [hackers] [PATCH] update copyright year

2018-03-29 Thread Hiltjo Posthuma
On Wed, Mar 28, 2018 at 09:39:39PM +0200, Daniel Tameling wrote: > --- > x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x.c b/x.c > index c343ba2..7df20f0 100644 > --- a/x.c > +++ b/x.c > @@ -1925,7 +1925,7 @@ main(int argc, char *argv[]) > opt_embed =

Re: [hackers] [st] [PATCH] set sel.alt in selstart instead of selextend

2018-03-29 Thread Hiltjo Posthuma
On Wed, Mar 28, 2018 at 09:27:58PM +0200, Daniel Tameling wrote: > --- > > When selecting something via doubleclick after entering or leaving the > altscreen mode, the selection is not highlighted with st 0.8. But it > gets copied to the primary, so the problem is only the highlighting. > > To re

Re: [hackers] [sent] [PATCH] Add toggle fullscreen shortcut: f

2018-03-29 Thread Hiltjo Posthuma
On Wed, Mar 28, 2018 at 08:03:37PM -0300, Héctor Monacci wrote: > 2018-03-28 5:54 GMT-03:00 Markus Teich > >> Thank you Markus! Sure I can wait! > > > > > > Cool, please resend the fixed patch. > > > > Here it goes. I hope it is OK! > > From 37637d82867278bad5593db9a2687bc95c1bdb13 Mon Sep 17 00:

<    1   2   3   4   5   >