Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-16 Thread Silvan Jegen
Dear Laslo On Thu, Mar 15, 2018 at 10:39 PM, Laslo Hunhold wrote: > On Thu, 15 Mar 2018 22:17:25 +0100 > Silvan Jegen wrote: > > Dear Silvan, > >> I see, thanks! >> >> Still sounds to me like having patches as attachments just causes me >> to have to change my

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-16 Thread Silvan Jegen
On Thu, Mar 15, 2018 at 10:38 PM, Eric Pruitt wrote: > On Thu, Mar 15, 2018 at 10:17:25PM +0100, Silvan Jegen wrote: >> Still sounds to me like having patches as attachments just causes me to >> have to change my default configuration though. > > Change the world or change

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Laslo Hunhold
On Thu, 15 Mar 2018 22:17:25 +0100 Silvan Jegen wrote: Dear Silvan, > I see, thanks! > > Still sounds to me like having patches as attachments just causes me > to have to change my default configuration though. > > What is the advantage of attaching the patches instead of

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Eric Pruitt
On Thu, Mar 15, 2018 at 10:17:25PM +0100, Silvan Jegen wrote: > Still sounds to me like having patches as attachments just causes me to > have to change my default configuration though. Change the world or change your configuration: the choice is yours! By adding a handful of bytes to your Mutt

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Silvan Jegen
On Thu, Mar 15, 2018 at 12:51:38PM -0700, Eric Pruitt wrote: > On Thu, Mar 15, 2018 at 08:44:02PM +0100, Silvan Jegen wrote: > > Ah, I wasn't aware that the tags also work on attachments, neat. Thanks > > for the tip! > > > > That means both are equally convenient for me. However, if you send > >

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Eric Pruitt
On Thu, Mar 15, 2018 at 08:44:02PM +0100, Silvan Jegen wrote: > Ah, I wasn't aware that the tags also work on attachments, neat. Thanks > for the tip! > > That means both are equally convenient for me. However, if you send > patches inline (not as attachments) commenting on specific parts of >

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Silvan Jegen
On Thu, Mar 15, 2018 at 12:35:07PM -0700, Eric Pruitt wrote: > On Thu, Mar 15, 2018 at 08:28:26PM +0100, Silvan Jegen wrote: > > > That depends on what email client you use. Mutt makes piping both whole > > > messages and individual attachments to arbitrary commands pretty > > > painless IMO. > >

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Eric Pruitt
On Thu, Mar 15, 2018 at 08:28:26PM +0100, Silvan Jegen wrote: > > That depends on what email client you use. Mutt makes piping both whole > > messages and individual attachments to arbitrary commands pretty > > painless IMO. > > I use mutt as well but I don't know how to deal with attachments

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Silvan Jegen
On Thu, Mar 15, 2018 at 09:53:41AM -0700, Eric Pruitt wrote: > On Thu, Mar 15, 2018 at 05:11:10PM +0100, Silvan Jegen wrote: > > The disadvantage of this is that you will have to save those > > attachments somewhere and then apply them. When using "git send-email" > > you can just feed the emails

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Eric Pruitt
On Thu, Mar 15, 2018 at 05:11:10PM +0100, Silvan Jegen wrote: > The disadvantage of this is that you will have to save those > attachments somewhere and then apply them. When using "git send-email" > you can just feed the emails directly to "git am". That depends on what email client you use.

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Silvan Jegen
On Thu, Mar 15, 2018 at 4:28 PM, Laslo Hunhold wrote: > On Wed, 14 Mar 2018 13:24:53 -0400 > Christopher Drelich wrote: > > Hey Christopher, > >> Ok, so that is an absolute requirement then, and the only issue? Was >> doing the patching in a very unconfigured

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Laslo Hunhold
On Wed, 14 Mar 2018 13:24:53 -0400 Christopher Drelich wrote: Hey Christopher, > Ok, so that is an absolute requirement then, and the only issue? Was > doing the patching in a very unconfigured chroot environment on a > temporary computer, so hadn't setup email on there. I

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-15 Thread Silvan Jegen
Hi On Wed, Mar 14, 2018 at 6:24 PM, Christopher Drelich wrote: > Ok, so that is an absolute requirement then, and the only issue? Was doing > the patching in a very unconfigured chroot environment on a temporary > computer, so hadn't setup email on there. I will for next time.

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-14 Thread Christopher Drelich
Ok, so that is an absolute requirement then, and the only issue? Was doing the patching in a very unconfigured chroot environment on a temporary computer, so hadn't setup email on there. I will for next time. I know there are plenty of patches for dwm available, and I've made plenty of my own

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-14 Thread Silvan Jegen
Hi On Wed, Mar 14, 2018 at 5:58 PM, Christopher Drelich wrote: > Any idea what I might have done wrong in creating the patch? I figure > learning now will save us all time in the future. > > I followed the instructions on the website and used a fresh pull of dwm. > Looking at

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-14 Thread Christopher Drelich
Any idea what I might have done wrong in creating the patch? I figure learning now will save us all time in the future. I followed the instructions on the website and used a fresh pull of dwm. Looking at what's in git, it seems the same to me, other than my email as you noted. Chris On Wed, Mar

Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-14 Thread Hiltjo Posthuma
On Wed, Mar 14, 2018 at 10:12:55AM -0400, Christopher Drelich wrote: >My first patch, I'm hoping this is the way you want them submitted. I >couldn't find any reason for ColBorder to be a #define while ColFg and >ColBg are in an enum together. >--- >From

[hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

2018-03-14 Thread Christopher Drelich
My first patch, I'm hoping this is the way you want them submitted. I couldn't find any reason for ColBorder to be a #define while ColFg and ColBg are in an enum together. --- >From eefea3c310db3c9460c5fdee3e8a8d0cb45c9819 Mon Sep 17 00:00:00 2001 From: ude Date: Wed, 14 Mar 2018