Re: [1.9 HEAD] HAProxy using 100% CPU

2019-05-12 Thread Maciej Zdeb
Ok, I'll wait for update from you! :) pon., 13 maj 2019 o 08:03 Willy Tarreau napisał(a): > Hi Maciej, > > On Mon, May 13, 2019 at 07:21:59AM +0200, Maciej Zdeb wrote: > > Hi, > > > > I'm not observing any issues, so I think it's fixed. :) > > > > Willy, Olivier thank you very much! > > Great, t

Re: [PATCH] BUG/MINOR: Fix memory leak in cfg_parse_peers

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 10:54:50PM +0200, Tim Duesterhus wrote: > cfg_parse_peers previously leaked the contents of the `kws` string, > as it was unconditionally filled using bind_dump_kws, but only used > (and freed) within the error case. (...) Applied, thanks Tim! Willy

Re: [1.9 HEAD] HAProxy using 100% CPU

2019-05-12 Thread Willy Tarreau
Hi Maciej, On Mon, May 13, 2019 at 07:21:59AM +0200, Maciej Zdeb wrote: > Hi, > > I'm not observing any issues, so I think it's fixed. :) > > Willy, Olivier thank you very much! Great, thanks. I'm going to issue 1.9.8 with the patch I sent you then. However after discussing about it with Olivie

Re: [PATCH v2 1/2] MINOR: systemd: Use the variables from /etc/default/haproxy

2019-05-12 Thread Vincent Bernat
❦ 8 mai 2019 13:44 +00, Veiko Kukk : >> It was slightly modified to cleanly apply, because HAProxy's default >> unit file does not include rsyslog.service as an 'After' dependency. >> Also the subject line was modified to include the proper subsystem >> and severity. > > I think, instead of Afte

Re: [1.9 HEAD] HAProxy using 100% CPU

2019-05-12 Thread Maciej Zdeb
Hi, I'm not observing any issues, so I think it's fixed. :) Willy, Olivier thank you very much! Kind regards, niedz., 12 maj 2019 o 12:11 Willy Tarreau napisał(a): > On Sun, May 12, 2019 at 12:00:44PM +0200, Maciej Zdeb wrote: > > As for now it is stable, no looping. I'll leave it till monday

How to set cookie for specific URL path in hapyoxy configuration

2019-05-12 Thread jack Linux
I have a WordPress website running on haproxy server with round-robin between two servers that run httpd and MySQL replication I found problems occur while using haproxy without setting persistence connection in WordPress media gallery while uploading pictures or change the view grid for a specifi

[PATCH] BUG/MINOR: Fix memory leak in cfg_parse_peers

2019-05-12 Thread Tim Duesterhus
cfg_parse_peers previously leaked the contents of the `kws` string, as it was unconditionally filled using bind_dump_kws, but only used (and freed) within the error case. Move the dumping into the error case to: 1. Ensure that the registered keywords are actually printed as least once. 2. The cont

Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-12 Thread Chris Packham
On 12/05/19 5:29 AM, Willy Tarreau wrote: > On Fri, May 10, 2019 at 11:52:31AM +0200, Willy Tarreau wrote: >>> Actually I think there's an additional change needed in my patch. By >>> passing the parameters to HA_ATOMIC_CAS we end up attempting to >>> dereference a void *. So this should needs to c

Re: [PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 06:01:26PM +0200, Tim Düsterhus wrote: > Willy, > > Am 11.05.19 um 05:53 schrieb Willy Tarreau: > >> diff --git a/src/vars.c b/src/vars.c > >> index 477a14632..d32310270 100644 > >> --- a/src/vars.c > >> +++ b/src/vars.c > >> @@ -510,6 +510,7 @@ int vars_check_arg(struct ar

Re: [PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-12 Thread Tim Düsterhus
Willy, Am 11.05.19 um 05:53 schrieb Willy Tarreau: >> diff --git a/src/vars.c b/src/vars.c >> index 477a14632..d32310270 100644 >> --- a/src/vars.c >> +++ b/src/vars.c >> @@ -510,6 +510,7 @@ int vars_check_arg(struct arg *arg, char **err) >> err); >> if (!name) >>

Re: cygwin compilation error

2019-05-12 Thread Gil Bahat
it turns out 1.8.20 does compile neatly, this should suffice for us for the time being. this is also a strong indication that whatever needs fixing is minor enough. Gil On Sun, May 12, 2019 at 11:12 AM Willy Tarreau wrote: > On Sun, May 12, 2019 at 09:26:18AM +0300, Gil Bahat wrote: > > none of

Re: [1.9 HEAD] HAProxy using 100% CPU

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 12:00:44PM +0200, Maciej Zdeb wrote: > As for now it is stable, no looping. I'll leave it till monday and return > with feedback! :) Many thanks Maciej for this positive feedback. I'll merge it and issue 1.9.8 then. There are definitely enough pending fixes for a release!

Re: [1.9 HEAD] HAProxy using 100% CPU

2019-05-12 Thread Maciej Zdeb
As for now it is stable, no looping. I'll leave it till monday and return with feedback! :) Thanks, sob., 11.05.2019, 15:44 użytkownik Maciej Zdeb napisał: > Patch applied, finger crossed, testing! :-) > > Thanks! > > sob., 11 maj 2019 o 14:58 Willy Tarreau napisał(a): > >> On Sat, May 11, 201

Re: [PATCH] new contrib proposal / exec Python & Lua scripts

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 08:23:54AM +0200, Thierry Fournier wrote: > Hi Willy, > > Great ! I thinked this patch for the trash. You can merge this work. The > main goal is providing an environment to process spoe with lua or python. OK perfect, I'll take it for 2.0 then. Thank you! Willy

Re: cygwin compilation error

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 09:26:18AM +0300, Gil Bahat wrote: > none of these work for me to resolve the problem. guess it's a bit more > complicated than that. OK, thanks for trying at least. willy