Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 11:16:32PM +0200, ??? wrote: > ??, 29 ???. 2023 ?. ? 16:45, Willy Tarreau : > > > On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > > > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > > > However, I noticed there is a problem

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

вт, 29 авг. 2023 г. в 16:45, Willy Tarreau : > On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > > However, I noticed there is a problem now with the FreeBSD test. Have > you > > > already looked into it? > >

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > However, I noticed there is a problem now with the FreeBSD test. Have you > > already looked into it? > > Ah no, I had not noticed. I first pushed into a

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > However, I noticed there is a problem now with the FreeBSD test. Have you > already looked into it? Ah no, I had not noticed. I first pushed into a temporary branch and everything was OK so I pushed into master again without

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Willy, > And I was wrong, they were indeed for the first one. However I had to also > remove the NOT_LAST from the intermediate patches using the list_for_each(). > I put quotes around the symbolic names in the doc to make it clearer which > one was to be used and which one it corresponds

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 03:15:48PM +0200, Willy Tarreau wrote: > Overall yes. There are just two small parts in the first patch that are > for the immediately following patches ("refactor...") that I'm going to > move there. And I was wrong, they were indeed for the first one. However I had to

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Mon, Aug 28, 2023 at 12:38:45PM +, Stephan, Alexander wrote: > > I'm fine with this, however I find that the doc is not very clear about > > what is permitted > I agree that doc needs some more details. I added the note about the > iterations and described all the symbolic