Re: [PATCH v3] BUG/MINOR: dns: allow 63 char in hostname

2020-01-26 Thread Илья Шипицин
вс, 26 янв. 2020 г. в 23:12, William Dauchy : > On Sun, Jan 26, 2020 at 7:08 PM Илья Шипицин wrote: > > such things are fragile. once fixed, they can silently break during > further refactoring. > > on other hand, such functions are good candidates to write unit tests

Re: [PATCH v3] BUG/MINOR: dns: allow 63 char in hostname

2020-01-26 Thread Илья Шипицин
such things are fragile. once fixed, they can silently break during further refactoring. on other hand, such functions are good candidates to write unit tests. maybe we should consider things like cmocka ? вс, 26 янв. 2020 г. в 22:44, William Dauchy : > hostname were limited to 62 char, which

Re: Disabling regtests in Travis ?

2020-01-24 Thread Илья Шипицин
пт, 24 янв. 2020 г. в 20:44, Илья Шипицин : > > > пт, 24 янв. 2020 г. в 20:34, Willy Tarreau : > >> On Fri, Jan 24, 2020 at 04:31:07PM +0100, Willy Tarreau wrote: >> > So I'm proposing that we try a last time to run with >> > "REGTESTS_TYPES=default,b

Re: Disabling regtests in Travis ?

2020-01-24 Thread Илья Шипицин
пт, 24 янв. 2020 г. в 20:34, Willy Tarreau : > On Fri, Jan 24, 2020 at 04:31:07PM +0100, Willy Tarreau wrote: > > So I'm proposing that we try a last time to run with > > "REGTESTS_TYPES=default,bug,devel" > > That should probably give this : > > diff --git a/.travis.yml b/.travis.yml > index

[PATCH] switch to clang-9 in Linux/travis-ci builds

2020-01-23 Thread Илья Шипицин
Hello, let us use clang-9 instead of default clang-7 for linux builds. Cheers, Ilya Shipitsin From e1f7c5d551e6ab0c593f633846bf338c0fed64f1 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 24 Jan 2020 11:36:41 +0500 Subject: [PATCH] BUILD: CI: use clang-9 for travis-ci builds ---

Re: [PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 15:20, Willy Tarreau : > On Wed, Jan 22, 2020 at 11:10:05PM +0100, Tim Düsterhus wrote: > > > both travis and github actions do offer 4 parallel builds, while > cirrus and > > > app veyor offer 1 parallel build. > > > > Parallel Builds just improve test speed. I don't

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
пт, 24 янв. 2020 г. в 01:04, Илья Шипицин : > > > пт, 24 янв. 2020 г. в 00:54, Willy Tarreau : > >> On Fri, Jan 24, 2020 at 12:46:12AM +0500, ??? wrote: >> > > diff --git a/Makefile b/Makefile >> > > index 8399f6ca35..4757bc77e6 100644 &

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
пт, 24 янв. 2020 г. в 00:54, Willy Tarreau : > On Fri, Jan 24, 2020 at 12:46:12AM +0500, ??? wrote: > > > diff --git a/Makefile b/Makefile > > > index 8399f6ca35..4757bc77e6 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -199,6 +199,7 @@ SPEC_CFLAGS += $(call >

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 23:17, Willy Tarreau : > On Thu, Jan 23, 2020 at 10:59:00PM +0500, ??? wrote: > > > Could you please try to use (size_t) instead of (unsigned int) ? If > it's > > > enough to shut it up, I'm fine with doing that change. Otherwise we'll > > > probably get rid of that

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 15:14, Willy Tarreau : > On Thu, Jan 23, 2020 at 01:09:22PM +0500, ??? wrote: > > hello, > > > > I tried to build using cross compiler (arm32 on amd64). sorry for > > screenshot. > > Willy, do you mean errors like that ? > > So for those not seeing the screenshot,

Re: [PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 20:54, Willy Tarreau : > On Thu, Jan 23, 2020 at 08:40:19PM +0500, ??? wrote: > > those timeouts are not related to travis itself, I beleive they are > mostly > > related to either real failures or tests instability (race condition). > > These tests are racy by

Re: [PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 15:20, Willy Tarreau : > On Wed, Jan 22, 2020 at 11:10:05PM +0100, Tim Düsterhus wrote: > > > both travis and github actions do offer 4 parallel builds, while > cirrus and > > > app veyor offer 1 parallel build. > > > > Parallel Builds just improve test speed. I don't

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 15:14, Willy Tarreau : > On Thu, Jan 23, 2020 at 01:09:22PM +0500, ??? wrote: > > hello, > > > > I tried to build using cross compiler (arm32 on amd64). sorry for > > screenshot. > > Willy, do you mean errors like that ? > > So for those not seeing the screenshot,

Re: arm64 builds?

2020-01-23 Thread Илья Шипицин
hello, I tried to build using cross compiler (arm32 on amd64). sorry for screenshot. Willy, do you mean errors like that ? [image: Screenshot from 2020-01-23 13-03-49.png] ср, 6 нояб. 2019 г. в 12:26, Willy Tarreau : > Hi Ilya, > > On Tue, Nov 05, 2019 at 07:20:43PM +0500, ???

Re: [PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-22 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 03:10, Tim Düsterhus : > Ilya, > > Am 22.01.20 um 23:04 schrieb Илья Шипицин: > >> Yes, that's my understanding of GitHub actions as well. However I > >> dislike having three types of CI (Travis, Cirrus and GitHub Actions). > >> Can Tr

Re: [PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-22 Thread Илья Шипицин
чт, 23 янв. 2020 г. в 02:59, Tim Düsterhus : > Ilya, > > Am 22.01.20 um 22:41 schrieb Илья Шипицин: > > let us move it to Github Actions. > > as far as I tried no extra step are required for enabling, just proper > file > > in > > > > .github/workflows

[PATCH[ re-enable cygwin CI builds (Github Actions)

2020-01-22 Thread Илья Шипицин
Hello, I spent lots of time trying to get cygwin on travis working. no luck. let us move it to Github Actions. as far as I tried no extra step are required for enabling, just proper file in .github/workflows (attached in patch). Cheers, Ilya Shipitcin From

[PATCH] temporarily mark openssl-1.0.2 builds as allowed failure

2020-01-22 Thread Илья Шипицин
Hello, this is a follow up patch for the recent travis-ci improvement. Cheers, Ilya Shipitcin From f13c8cd8c28d376c914cee24ac9b7e09a7203473 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 22 Jan 2020 15:23:51 +0500 Subject: [PATCH] BUILD: CI: temporarily mark openssl-1.0.2 as allowed

Re: [PATCH] introduce ARM64 travis-ci builds

2020-01-22 Thread Илья Шипицин
ср, 22 янв. 2020 г. в 10:49, Willy Tarreau : > On Sun, Jan 19, 2020 at 12:18:00PM +0500, ??? wrote: > > hello, > > > > sometimes arm64 builds fails, I think it is good chance to introduce > > regular builds > > and fix them. > > > > also, few small improvements. > occasionely, I

Re: [PATCH] improving ssl defines

2020-01-21 Thread Илья Шипицин
ср, 22 янв. 2020 г. в 11:24, Willy Tarreau : > Hi Ilya, > > On Sat, Jan 18, 2020 at 06:47:48PM +0500, ??? wrote: > > Hello, > > > > let us switch to constants check, not versions. > > > > cheers, > > Ilya Shipitcin > > > From a8b68e746bb71c4fee65a05bea8287ad970c979c Mon Sep 17 00:00:00

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-19 Thread Илья Шипицин
вс, 19 янв. 2020 г. в 14:09, Willy Tarreau : > On Sun, Jan 19, 2020 at 12:38:43PM +0500, ??? wrote: > > > > how noisy is ubsan ? should we add it to CI ? > > > > > > > > > > No idea. I created a dedicated test executable and copied over the > > > implementation to avoid needing to

Re: ARM(64) builds

2020-01-19 Thread Илья Шипицин
вс, 19 янв. 2020 г. в 13:13, Martin Grigorov : > Hi, > > On Sat, Jan 18, 2020, 22:10 Илья Шипицин wrote: > >> tests on ARM64 randomly fail >> https://travis-ci.com/chipitsine/haproxy/jobs/277236120 >> >> (after restart there's a good chance to success

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-18 Thread Илья Шипицин
сб, 18 янв. 2020 г. в 15:30, Tim Düsterhus : > Ilya, > > Am 18.01.20 um 10:02 schrieb Илья Шипицин: > > how noisy is ubsan ? should we add it to CI ? > > > > No idea. I created a dedicated test executable and copied over the > implementation to avoid needing t

[PATCH] better anti replay check

2020-01-18 Thread Илья Шипицин
Hello, let us check constants, not openssl versions. Cheers, Ilya Shipitcin From eab262bda04f0f0caf8020a6837a75cdd5821e94 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 19 Jan 2020 12:20:14 +0500 Subject: [PATCH] BUILD: ssl: more elegant anti-reply feature presence check ---

[PATCH] introduce ARM64 travis-ci builds

2020-01-18 Thread Илья Шипицин
hello, sometimes arm64 builds fails, I think it is good chance to introduce regular builds and fix them. also, few small improvements. cheers, Ilya Shipicin From e13a8d0e0e324c49f6a34d74b889a1c3fae6b6d9 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 19 Jan 2020 12:14:02 +0500

Re: ARM(64) builds

2020-01-18 Thread Илья Шипицин
tests on ARM64 randomly fail https://travis-ci.com/chipitsine/haproxy/jobs/277236120 (after restart there's a good chance to success) сб, 18 янв. 2020 г. в 09:52, Martin Grigorov : > > > On Fri, Jan 17, 2020 at 11:17 PM Martin Grigorov < > martin.grigo...@gmail.com> wrote: > >> >> >> On Fri,

[PATCH] improving ssl defines

2020-01-18 Thread Илья Шипицин
Hello, let us switch to constants check, not versions. cheers, Ilya Shipitcin From a8b68e746bb71c4fee65a05bea8287ad970c979c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 18 Jan 2020 18:42:45 +0500 Subject: [PATCH] BUG/MINOR: ssl: fix build on openssl-1.1.0 while working on issue

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-18 Thread Илья Шипицин
how noisy is ubsan ? should we add it to CI ? сб, 18 янв. 2020 г. в 06:07, Tim Duesterhus : > Left shifting of large signed values and negative values is undefined. > > In a test script clang's ubsan rightfully complains: > > > runtime error: left shift of 1934242336581872173 by 13 places cannot

Re: ARM(64) builds

2020-01-17 Thread Илья Шипицин
ssed (after few failures due to timing > issues (I guess) > timing out might happen because of https://github.com/haproxy/haproxy/commit/ac8147446c7a3d1aa607042bc782095b03bc8dc4 your fork is 16 commits behind current master. try to rebase to master > > >> Regards, >> Marti

Re: ARM(64) builds

2020-01-16 Thread Илья Шипицин
привет! пт, 17 янв. 2020 г. в 11:42, Martin Grigorov : > Привет Илья, > > On Thu, Jan 16, 2020 at 10:37 AM Илья Шипицин > wrote: > >> >> >> чт, 16 янв. 2020 г. в 13:26, Martin Grigorov : >> >>> Hi Илья, >>> >>> On Thu, Jan

Re: ARM(64) builds

2020-01-16 Thread Илья Шипицин
чт, 16 янв. 2020 г. в 13:37, Илья Шипицин : > > > чт, 16 янв. 2020 г. в 13:26, Martin Grigorov : > >> Hi Илья, >> >> On Thu, Jan 16, 2020 at 10:19 AM Илья Шипицин >> wrote: >> >>> >>> Hello, Martin! >>> >>> btw, ju

Re: ARM(64) builds

2020-01-16 Thread Илья Шипицин
чт, 16 янв. 2020 г. в 13:26, Martin Grigorov : > Hi Илья, > > On Thu, Jan 16, 2020 at 10:19 AM Илья Шипицин > wrote: > >> >> Hello, Martin! >> >> btw, just curious, how is Apache Foundation (or you personally) >> interested in all that ? >> ple

Re: ARM(64) builds

2020-01-16 Thread Илья Шипицин
Hello, Martin! btw, just curious, how is Apache Foundation (or you personally) interested in all that ? please do not blame me, I really like to know. чт, 16 янв. 2020 г. в 12:32, Martin Grigorov : > Hello HAProxy developers, > > At work we are going to use more and more ARM64 based servers

Re: freebsd ci is broken - commit 08fa16e - curl download stalls in reg-tests/compression/lua_validation.vtc

2020-01-14 Thread Илья Шипицин
ср, 15 янв. 2020 г. в 04:18, PiBa-NL : > Hi Ilya, Willy, > > Op 14-1-2020 om 21:40 schreef Илья Шипицин: > > PiBa, how many CPU cores are you running ? > > > > it turned out that I run tests on very low vm, which only has 1 core. > > and tests pass. > > cirr

Re: freebsd ci is broken - commit 08fa16e - curl download stalls in reg-tests/compression/lua_validation.vtc

2020-01-14 Thread Илья Шипицин
14-1-2020 om 07:48 schreef Илья Шипицин: > > Hello, > > since > > https://github.com/haproxy/haproxy/commit/08fa16e397ffb1c6511b98ade2a3bfff9435e521 > > freebsd CI is red: https://cirrus-ci.com/task/5960933184897024 > > I'd say "it is something with CI itself

freebsd ci is broken

2020-01-13 Thread Илья Шипицин
Hello, since https://github.com/haproxy/haproxy/commit/08fa16e397ffb1c6511b98ade2a3bfff9435e521 freebsd CI is red: https://cirrus-ci.com/task/5960933184897024 I'd say "it is something with CI itself", when I run the same tests locally on freebsd, it is green. PiBa ? thanks, Ilya Shipitcin

Re: [PATCH] CLEANUP: server: remove unused err section in server_finalize_init

2020-01-08 Thread Илья Шипицин
btw, if you add "Fixes: #438", the issue will be closed automatically https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords чт, 9 янв. 2020 г. в 01:33, William Dauchy : > Since commit 980855bd953c ("BUG/MEDIUM: server: initialize the orphaned > conns lists

[PATCH] adapt regtest for travis-ci

2020-01-08 Thread Илья Шипицин
Hello, for some reason "echo -e" does not work at least in travis-ci. as discussed in #423 it is good to use "printf" instead. Cheers, Ilya Shipitcin From e0ae24b754b6f660b0d942df25ed1e0bfe189967 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 8 Jan 2020 22:56:30 +0500 Subject: [PATCH]

[PATCH] cirrus-ci: choose proper openssl package name

2020-01-07 Thread Илья Шипицин
hello, freebsd-11.3 names package "openssl" freebsd-12.1 names package "openssl111" I added switch for that Cheers, Ilya Shipitcin From 614d7497641f0a2459c5f0b584fc84345ba5aeee Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 7 Jan 2020 23:41:24 +0500 Subject: [PATCH] BUILD:

learning SSL stuff

2020-01-01 Thread Илья Шипицин
Hello, while working on #429, I noticed strange things that I do not understand for example if (ecdhe == NULL) { (void)SSL_CTX_set_ecdh_auto(ctx, 1); return cfgerr; } why do we need to call SSL_CTX_set_ecdh_auto right before returning error ? Cheers, Ilya Shipitsin

[PATCH] modernize cirrus-ci

2019-12-26 Thread Илья Шипицин
Hello, small refinement of cirrus-ci magic. Cheers, Ilya Shipicin From bc6989debcd3b2e4a45f18d2a58e65fa4ab2f555 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 26 Dec 2019 13:37:36 +0500 Subject: [PATCH] BUILD: CI: modernize cirrus-ci use freebsd-12.1 instead of freebsd-12.0, add

[PATCH] reenable ASAN for travis-ci builds

2019-12-21 Thread Илья Шипицин
Hello, ASAN stands for address sanitizer, it is powerful tool for detecting memory allocation issues (it already detected several of them). ASAN was temporarily disabled. Now (I guess after getting rid of LD_LIBRARY_PATH) let us enable it again. Cheers, Ilya Shipitcin From

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Илья Шипицин
сб, 21 дек. 2019 г. в 01:44, Rosen Penev : > On Fri, Dec 20, 2019 at 10:54 AM Илья Шипицин > wrote: > > > > > > > > пт, 20 дек. 2019 г. в 22:39, Lukas Tribus : > >> > >> Hello Ilya, > >> > >> > >> > >> sorry ab

[PATCH] isolating ssl lib with rpath instead of LD_LIBRARY_PATH

2019-12-20 Thread Илья Шипицин
hello, initially modyfing LD_LIBRARY_PATH seemed to be good, but it turned out that other dynamically linked utilities also use ssl lib which is not wanted. using rpath in turn is more intelligent way of dynamic linking. Cheers, Ilya Shipitcin From e9f95cc6fd8b61ee1a4aef05adade30fa72e5cd7 Mon

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Илья Шипицин
пт, 20 дек. 2019 г. в 22:39, Lukas Tribus : > Hello Ilya, > > > > sorry about the delay ... > > > On Wed, 27 Nov 2019 at 07:11, Илья Шипицин wrote: > > > > -#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) > > +#if (HA_OPENSSL_VERSION_NUMBER >=

Re: [RFC PATCH] BUILD: ssl: improve SSL_CTX_set_ecdh_auto compatibility

2019-12-20 Thread Илья Шипицин
пт, 20 дек. 2019 г. в 22:47, Lukas Tribus : > SSL_CTX_set_ecdh_auto() is not defined when OpenSSL 1.1.1 is compiled > with the no-deprecated option. Remove existing, incomplete guards and > add a compatibility macro in openssl-compat.h, just as OpenSSL does: > > >

Re: How to "unit" test HAProxy configurations (and HTTP servers in general)

2019-12-18 Thread Илья Шипицин
чт, 19 дек. 2019 г. в 01:07, Ciprian Dorin Craciun < ciprian.crac...@gmail.com>: > On Wed, Dec 18, 2019 at 8:23 PM Илья Шипицин wrote: > >> redirects are easy to test. using any framework. > > > > for example, jmeter (or any other http query tool) > > &g

Re: How to "unit" test HAProxy configurations (and HTTP servers in general)

2019-12-18 Thread Илья Шипицин
ср, 18 дек. 2019 г. в 22:34, Ciprian Dorin Craciun < ciprian.crac...@gmail.com>: > On Wed, Dec 18, 2019 at 6:47 PM Илья Шипицин wrote: > > you are talking about testing ACL. can you provide some example ? > > > So let's assume I have a given HAProxy configuration, f

Re: How to "unit" test HAProxy configurations (and HTTP servers in general)

2019-12-18 Thread Илья Шипицин
ср, 18 дек. 2019 г. в 21:16, Ciprian Dorin Craciun < ciprian.crac...@gmail.com>: > Hello all! > > [First of all this question isn't only HAProxy specific, but can be > extended to any HTTP server (including Apache, Nginx, and any other > web application out there); however I think it is

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-16 Thread Илья Шипицин
вт, 17 дек. 2019 г. в 00:55, Rosen Penev : > On Mon, Dec 16, 2019 at 10:21 AM Илья Шипицин > wrote: > > > > > > > > пн, 16 дек. 2019 г. в 22:40, Rosen Penev : > >> > >> On Mon, Dec 16, 2019 at 4:49 AM Lukas Tribus wrote: > >> > >

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-16 Thread Илья Шипицин
> > > The SSL compatibility layer is already complex enough and needs > > continuous adjustments, we need to understand the reason for changes > > very well. Fast fixes are continually coming back to hunt us. > > > > > > On Mon, 16 Dec 2019 at 08:19, Илья Шип

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-16 Thread Илья Шипицин
пн, 16 дек. 2019 г. в 22:42, Rosen Penev : > LIBRESSL_VERSION_NUMBER evaluates to 0 under OpenSSL, making the condition > always true. Check for the define before checking it. > > Signed-off-by: Rosen Penev > --- > include/common/openssl-compat.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-16 Thread Илья Шипицин
also, BoringSSL fails after applying your patch https://travis-ci.com/chipitsine/haproxy/jobs/267601286 пн, 16 дек. 2019 г. в 12:07, Rosen Penev : > LIBRESSL_VERSION_NUMBER evaluates to 0 under OpenSSL, making the condition > always true. Check for the define before checking it. > >

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-16 Thread Илья Шипицин
пн, 16 дек. 2019 г. в 12:47, William Lallemand : > Hello Rosen, > > On Sun, Dec 15, 2019 at 11:04:37PM -0800, Rosen Penev wrote: > > -#if (OPENSSL_VERSION_NUMBER < 0x1010L) || (LIBRESSL_VERSION_NUMBER > < 0x2070L) > > +#if (OPENSSL_VERSION_NUMBER < 0x1010L) || \ > > +

Re: [PATCH] openssl-compat: Fix getm_ defines

2019-12-15 Thread Илья Шипицин
hello, seems OpenWRT guys here :-) please have a look at https://github.com/haproxy/haproxy/issues/367 (it still misses germ part, I tried things like you send, but reg-tests fail. do you have travis-ci passed ?) also, there's a patch already sent, Lukas Tribus promised to review it пн, 16 дек.

adding 0RTT to some reg test ?

2019-11-28 Thread Илья Шипицин
hello, what do you think if we add something like that ? --- a/reg-tests/ssl/wrong_ctx_storage.vtc +++ b/reg-tests/ssl/wrong_ctx_storage.vtc @@ -30,7 +30,7 @@ haproxy h1 -conf { listen frt mode http ${no-htx} option http-use-htx -bind "fd@${frt}" ssl crt ${testdir}/common.pem +

Re: [PATCH] CLEANUP: dns: resolution can never be null

2019-11-28 Thread Илья Шипицин
indeed it is checked earlier https://github.com/haproxy/haproxy/blob/master/src/dns.c#L1574 чт, 28 нояб. 2019 г. в 12:18, William Dauchy : > On Thu, Nov 28, 2019 at 11:10:34AM +0500, Илья Шипицин wrote: > > Willy thinks it should be "eb" instead of "res" > >

Re: [PATCH] CLEANUP: dns: resolution can never be null

2019-11-27 Thread Илья Шипицин
oduces potential dead code. > > also fix a typo in associated comment > > This should fix issue #349 > > Reported-by: Илья Шипицин > Signed-off-by: William Dauchy > --- > src/dns.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/src/d

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Илья Шипицин
ср, 27 нояб. 2019 г. в 05:02, Lukas Tribus : > Hello, > > On Tue, Nov 26, 2019 at 10:50 PM Илья Шипицин > wrote: > > > > Hello, > > > > I resolved `CRYPTO_set_id_callback', `ERR_remove_state', > `SSL_CTX_set_ecdh_auto' issues. > > >

PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Илья Шипицин
Hello, I resolved `CRYPTO_set_id_callback', `ERR_remove_state', `SSL_CTX_set_ecdh_auto' issues. the following two will be addressed later: `X509_get_notBefore', `X509_get_notAfter' Cheers, Ilya Shipitsin From 158e07f29cbd40c7cd159330ffd748cb1b926647 Mon Sep 17 00:00:00 2001 From: Ilya

Re: HAProxy 2.0.10 and 2.1.0 RPM's

2019-11-26 Thread Илья Шипицин
ср, 27 нояб. 2019 г. в 01:10, Russell Eason : > Hello, > > Fedora upstream added it > https://src.fedoraproject.org/rpms/haproxy/c/45c57ba71174f308a5f59569bac0598bb31ef767 > , and can be seen as far back as F24 here > https://src.fedoraproject.org/rpms/haproxy/blob/f24/f/haproxy.spec . LUA >

Re: HAProxy 2.0.10 and 2.1.0 RPM's

2019-11-26 Thread Илья Шипицин
ср, 27 нояб. 2019 г. в 01:03, William Lallemand : > On Tue, Nov 26, 2019 at 08:33:41PM +0100, Julien Pivotto wrote: > > Dear HAProxy Community, > > > > I have started building HAProxy 2.x packages for CentOS. > > > > It includes HAProxy 2.0.10 and 2.1.0. > > > > You can find them here: > >

Re: HAProxy 2.0.10 and 2.1.0 RPM's

2019-11-26 Thread Илья Шипицин
thank for the rpm it was faster than I did )) any plans to add Lua ? ср, 27 нояб. 2019 г. в 00:36, Julien Pivotto : > Dear HAProxy Community, > > I have started building HAProxy 2.x packages for CentOS. > > It includes HAProxy 2.0.10 and 2.1.0. > > You can find them here: >

Re: [PATCH] MINOR: contrib/prometheus-exporter: allow to select the exported metrics

2019-11-21 Thread Илья Шипицин
чт, 21 нояб. 2019 г. в 15:18, William Dauchy : > On Thu, Nov 21, 2019 at 03:09:30PM +0500, Илья Шипицин wrote: > > I understand. However, those patches add complexity (which might be moved > > to another dedicated tool) > > those patch makes sense for heavy haproxy instanc

Re: [PATCH] MINOR: contrib/prometheus-exporter: allow to select the exported metrics

2019-11-21 Thread Илья Шипицин
чт, 21 нояб. 2019 г. в 15:07, William Dauchy : > On Thu, Nov 21, 2019 at 03:00:02PM +0500, Илья Шипицин wrote: > > is it common thing in Prometheus world to perform cascade export ? like > > "exporter" --> "filter out" --> "aggregate" --> &quo

Re: [PATCH] MINOR: contrib/prometheus-exporter: allow to select the exported metrics

2019-11-21 Thread Илья Шипицин
btw, side question... is it common thing in Prometheus world to perform cascade export ? like "exporter" --> "filter out" --> "aggregate" --> "deliver to prometheus" in order to keep things simple and not to push everything into single tool чт, 21 нояб. 2019 г. в 14:49, Christopher Faulet : >

Re: travis-ci: should we drop openssl-1.1.0 and replace it with 3.0 ?

2019-11-19 Thread Илья Шипицин
branch. 3.0 doesn’t > exist yet, and won’t until later in 2020 which is unfortunate since that > means there will be no FIPS validated branch for several months. > > > > *From:* Илья Шипицин [mailto:chipits...@gmail.com] > *Sent:* Tuesday, November 19, 2019 12:48 PM > *To:* HA

Re: travis-ci: should we drop openssl-1.1.0 and replace it with 3.0 ?

2019-11-19 Thread Илья Шипицин
well, we can actually build bigger matrix by adding builds. I just want to save some electricity on non needed builds. вт, 19 нояб. 2019 г. в 22:41, Илья Шипицин : > hello, > > https://www.openssl.org/source/ says "The 1.1.0 series is currently only > receiving security fixe

travis-ci: should we drop openssl-1.1.0 and replace it with 3.0 ?

2019-11-19 Thread Илья Шипицин
hello, https://www.openssl.org/source/ says "The 1.1.0 series is currently only receiving security fixes and will go out of support on 11th September 2019" what if we drop it ? and replace with 3.0 ? cheers, Ilya Shipitcin

http-buffer-request details

2019-11-19 Thread Илья Шипицин
hello, how is that supposed to work ? https://github.com/haproxy/haproxy/blob/master/doc/configuration.txt#L6225 does it buffer the entire body ? does it use memory / hdd for buffering ? how are those buffers allocated ? what if I do not have a lot of RAM ? thanks, Ilya Shipitcin

Re: [PATCH] BUG/MINOR: init: fix set-dumpable when using uid/gid

2019-11-19 Thread Илья Шипицин
вт, 19 нояб. 2019 г. в 14:15, William Dauchy : > in mworker mode used with uid/gid settings, it was not possible to get > a coredump despite the set-dumpable option. > indeed prctl(2) manual page specifies the dumpable attribute is reverted > to `/proc/sys/fs/suid_dumpable` in a few conditions

Re: arm64 builds?

2019-11-05 Thread Илья Шипицин
пн, 4 нояб. 2019 г. в 17:49, Willy Tarreau : > Hi Ilya, > > On Mon, Nov 04, 2019 at 12:18:49AM +0500, ??? wrote: > > hello, > > > > should we switch some builds to arm64? > > > > https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support > > Ah that's interesting! I frequently

arm64 builds?

2019-11-03 Thread Илья Шипицин
hello, should we switch some builds to arm64? https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support thanks, Ilya Shipitsin

interoperation between SCVMM and HAProxy dataplane api

2019-10-30 Thread Илья Шипицин
hi, is anybody running things like https://www.poppelgaard.com/microsoft-scvmm-2012citrix-netscaler-o ? I mean using SCVMM in so called "services management", i.e. dataplane api ? thanks, Ilya Shipitsin

google summer of code 2020 ?

2019-10-30 Thread Илья Шипицин
hello, are there any plans to participate GSoC 2020 ? thanks, Ilya Shipitsin

Re: cygwin builds

2019-10-27 Thread Илья Шипицин
, here's link https://travis-ci.community/t/cygwin-issue-cygheap-base-mismatch-detected/5359/2 ) openssl upgraded to 1.0.2t, 1.1.0l, 1.1.1d libressl are upgraded (2.9.2, 2.8.3, 2.7.5) --> (3.0.2, 2.9.2, 2.8.3) вс, 27 окт. 2019 г. в 19:29, Илья Шипицин : > hi, > > I spent few

cygwin builds

2019-10-27 Thread Илья Шипицин
hi, I spent few days getting travis-ci / cygwin work. no luck I'm going to disable them unless someone knows how to resolve that thanks, Ilya Shipitsin

Re: Possible optimization to 51d in multithread

2019-10-24 Thread Илья Шипицин
, > > > > Ben Shillito > Developer > > [image: 51Degrees] <https://51degrees.com/> > > O: +44 1183 287152 > E: b...@51degrees.com > @51Degrees <http://twitter.com/51Degreesmobi> > 51Degrees <https://www.linkedin.com/company/2171864> > >

Re: Possible optimization to 51d in multithread

2019-10-24 Thread Илья Шипицин
Hello, Ben. since you are going to touch 51d code, can you please review the following coverity finding (it thinks there might be null pointer dereference) ? 239 // No need to null check as this has already been carried out in the 240// calling method 2. returned_null: smp_prefetch_htx

freebsd builds are broken for few days

2019-10-13 Thread Илья Шипицин
https://cirrus-ci.com/github/haproxy/haproxy I'll bisect if noone else knows what's going on

"official" rpm repo ?

2019-10-08 Thread Илья Шипицин
hi, I played a bit with Fedora COPR (it is nice) https://copr.fedorainfracloud.org/coprs/chipitsine/haproxy/build/1041926/ few questions 1) do we insist on Lua support ? (it is hard to get Lua-5.3 for EPEL7) 2) any best practice on building new packages ? anyway, I do not insist in running

using hashicorp vault for storing SSL certs

2019-09-29 Thread Илья Шипицин
hello, is anybody using https://www.vaultproject.io/docs/secrets/pki/index.html for storing certs ? (I want to avoid reinventing the wheel here) thanks, Ilya Shipitcin

Re: [PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-23 Thread Илья Шипицин
пн, 23 сент. 2019 г. в 22:02, Willy Tarreau : > Hi guys, > > On Fri, Sep 20, 2019 at 03:47:17PM +0200, Lukas Tribus wrote: > > Hello Patrick, > > > > > > > I dunno, I've personally never been fond of it when bug reporters are > blindly asked to upgrade to the latest version. > > > > Everything

[PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-19 Thread Илья Шипицин
hello, please find attached patch Ilya Shipitsin From 2d4b8bf119bf470c2c607a1fd22cee8267e6843b Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 20 Sep 2019 00:07:11 +0500 Subject: [PATCH] DOC: kindly ask people whether they run latest HAProxy --- .github/ISSUE_TEMPLATE/Bug.md | 4

[PATCH] enabling slz, pcre2 builds in travis-ci

2019-09-19 Thread Илья Шипицин
hello, please consider attached patch Ilya Shipitsin From b65dc30f1c07aca067ebb31d373833fe66486b7b Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 19 Sep 2019 23:32:30 +0500 Subject: [PATCH] BUILD: travis-ci: add PCRE2, SLZ build --- .travis.yml | 9 - 1 file changed, 8

Re: PATCH: install golang-1.13 during travis-ci build as it is required for BoringSSL

2019-09-17 Thread Илья Шипицин
Willy, can you apply this ? boringssl builds are bloody murder пн, 16 сент. 2019 г. в 16:14, Илья Шипицин : > please see attached patch >

PATCH: install golang-1.13 during travis-ci build as it is required for BoringSSL

2019-09-16 Thread Илья Шипицин
please see attached patch From 5fa12aec93f1e8989e06628fc5e41fc2556f532b Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Mon, 16 Sep 2019 16:13:10 +0500 Subject: [PATCH] BUILD: CI: install golang-1.13 when building BoringSSL --- scripts/build-ssl.sh | 4 1 file changed, 4 insertions(+)

Re: Linux Builds broken on Travis CI

2019-09-14 Thread Илья Шипицин
it turned out that ASAN is "the root cause" of those failures. let us disable it for a while (I attached patch) пт, 13 сент. 2019 г. в 19:23, Илья Шипицин : > > > On Fri, Sep 13, 2019, 3:49 PM Willy Tarreau wrote: > >> On Fri, Sep 13, 2019 at 03:45:21PM +0500, ?

Re: Linux Builds broken on Travis CI

2019-09-13 Thread Илья Шипицин
On Fri, Sep 13, 2019, 3:49 PM Willy Tarreau wrote: > On Fri, Sep 13, 2019 at 03:45:21PM +0500, ??? wrote: > > now build fails with > > > > "** h1 debug|[ALERT] 255/081449 (8721) : failed to allocate resources for > > thread 1." > > That's exactly the issues I was talking about that

Re: Linux Builds broken on Travis CI

2019-09-13 Thread Илья Шипицин
now build fails with "** h1 debug|[ALERT] 255/081449 (8721) : failed to allocate resources for thread 1." no more failures due to leaks. пт, 13 сент. 2019 г. в 13:33, Willy Tarreau : > On Fri, Sep 13, 2019 at 01:23:12PM +0500, ??? wrote: > > Build was failed due to memory leak

Re: Linux Builds broken on Travis CI

2019-09-13 Thread Илья Шипицин
Build was failed due to memory leak detected by asan https://github.com/haproxy/haproxy/issues/256 I think we can change the way asan works, I.e. log errors and do not stop tests On Fri, Sep 13, 2019, 7:59 AM Willy Tarreau wrote: > Hi Tim, > > On Fri, Sep 06, 2019 at 04:30:24PM +0200, Tim

Re: Docker Image update to OpenSSL 1.1.1d

2019-09-11 Thread Илья Шипицин
чт, 12 сент. 2019 г. в 01:01, Aleksandar Lazic : > Hi. > > Am 11.09.2019 um 20:48 schrieb Илья Шипицин: > > Hello, > > > > it was a surprize for me that official images are also available (I used > to > > think your images are only available) >

Re: Docker Image update to OpenSSL 1.1.1d

2019-09-11 Thread Илья Шипицин
oops. I did have a look at https://hub.docker.com/search?q=haproxytech=image (built from https://github.com/haproxytech ) so... there are many many many docker images. when should I use either of these images? ср, 11 сент. 2019 г. в 23:48, Илья Шипицин : > Hello, > > it was a surpri

Re: Docker Image update to OpenSSL 1.1.1d

2019-09-11 Thread Илья Шипицин
Hello, it was a surprize for me that official images are also available (I used to think your images are only available) https://hub.docker.com/_/haproxy is there some documentation when your images should be used (instead of official) ? ср, 11 сент. 2019 г. в 22:58, Aleksandar Lazic : > Hi.

Re: Coverity scan findings

2019-09-11 Thread Илья Шипицин
it depends on how haproxy is built (number of flags) we use most of available options when testing on coverity https://github.com/haproxy/haproxy/blob/master/.travis.yml#L8 can you share build command ? we may also set up sonar in travis-ci schedules. (personally, I find sonar too much noisy,

Re: [PATCH] basic CentOS6 CI

2019-09-08 Thread Илья Шипицин
Good good good. On Sun, Sep 8, 2019, 3:11 PM Willy Tarreau wrote: > On Fri, Sep 06, 2019 at 11:24:44PM +0500, ??? wrote: > > here's another CI patch (which skips alpn testing on CentOS 6) > > Thanks Ilya, I've merged it and added a commit message based on the > explanation in the

Re: [PATCH] basic CentOS6 CI

2019-09-06 Thread Илья Шипицин
hello, here's another CI patch (which skips alpn testing on CentOS 6) пт, 6 сент. 2019 г. в 15:48, Илья Шипицин : > great. > > I'll resolve ALPN testing soon. let those builds be red for a while. > > пт, 6 сент. 2019 г. в 14:45, Willy Tarreau : > >> On Mon, Sep 02,

Re: [PATCH] basic CentOS6 CI

2019-09-06 Thread Илья Шипицин
great. I'll resolve ALPN testing soon. let those builds be red for a while. пт, 6 сент. 2019 г. в 14:45, Willy Tarreau : > On Mon, Sep 02, 2019 at 12:10:11AM +0500, ??? wrote: > > please review the following patch > > No particular opinion on it so I merged it. > > Thanks Ilya. > Willy

Re: [PATCH] basic CentOS6 CI

2019-09-05 Thread Илья Шипицин
hi, any update ? пн, 2 сент. 2019 г. в 10:56, Илья Шипицин : > any idea how to skip "alpn" test on CentOS 6 ? > > (I think, I should "rm" particular reg test, however, it does not look > nice) > > пн, 2 сент. 2019 г. в 00:10, Илья Шипицин : > >> please review the following patch >> >

Re: [PATCH] basic CentOS6 CI

2019-09-01 Thread Илья Шипицин
any idea how to skip "alpn" test on CentOS 6 ? (I think, I should "rm" particular reg test, however, it does not look nice) пн, 2 сент. 2019 г. в 00:10, Илья Шипицин : > please review the following patch >

<    4   5   6   7   8   9   10   11   12   >