Re: MINOR: Revert part of clarifying samples support per os commit

On 9/3/2022 12:12 AM, Willy Tarreau wrote: On Thu, Aug 25, 2022 at 11:13:38PM -0400, Brad Smith wrote: Commit 5c83e3a1563cd7face299bf08037e51f976eb5e3 made some adjustments to clarify which TCP_INFO information is supported by each respective OS. (...) Merged, thank you Brad! Willy Can you

Re: [PATCH] BUILD: makefile: enable crypt(3) for NetBSD

On 9/3/2022 12:11 AM, Willy Tarreau wrote: On Sat, Aug 13, 2022 at 12:57:31AM -0400, Brad Smith wrote: Allow NetBSD to support encrypted passwords in Userlists. Mergd, thank you Brad! Willy You should be able to bring that back to 2.4.

Re: MINOR: Revert part of clarifying samples support per os commit

ping. On 8/25/2022 11:13 PM, Brad Smith wrote: Commit 5c83e3a1563cd7face299bf08037e51f976eb5e3 made some adjustments to clarify which TCP_INFO information is supported by each respective OS. There was a comment like so.. Note that fc_rtt and fc_rttvar are supported on any OS that has TCP_INFO

Re: [PATCH] BUILD: makefile: enable crypt(3) for NetBSD

ping. On 8/13/2022 12:57 AM, Brad Smith wrote: Allow NetBSD to support encrypted passwords in Userlists. diff --git a/Makefile b/Makefile index 580cf6f9e..10c9ef7b4 100644 --- a/Makefile +++ b/Makefile @@ -453,8 +453,8 @@ endif # NetBSD 8 and above ifeq ($(TARGET),netbsd

MINOR: Revert part of clarifying samples support per os commit

Commit 5c83e3a1563cd7face299bf08037e51f976eb5e3 made some adjustments to clarify which TCP_INFO information is supported by each respective OS. There was a comment like so.. Note that fc_rtt and fc_rttvar are supported on any OS that has TCP_INFO, not just linux/freebsd/netbsd, so we continue to

Re: [PATCH] MINOR: tcp_sample: extend support for get_tcp_info to OpenBSD

On 8/23/2022 11:22 PM, Willy Tarreau wrote: On Tue, Aug 23, 2022 at 10:37:28PM -0400, Brad Smith wrote: On 8/23/2022 10:22 PM, Willy Tarreau wrote: Hi Brad, On Sat, Aug 13, 2022 at 11:25:32PM -0400, Brad Smith wrote: I'm not sure if MINOR is right. Currently the build is broken since

Re: [PATCH] MINOR: tcp_sample: extend support for get_tcp_info to OpenBSD

On 8/23/2022 10:22 PM, Willy Tarreau wrote: Hi Brad, On Sat, Aug 13, 2022 at 11:25:32PM -0400, Brad Smith wrote: I'm not sure if MINOR is right. Currently the build is broken since TCP_INFO was added. Just to be certain, you mean the build is broken without your patch or with it ? If it's

Re: [PATCH] MINOR: tcp_sample: extend support for get_tcp_info to OpenBSD

ping. On 8/12/2022 10:23 PM, Brad Smith wrote: extend support for get_tcp_info to OpenBSD. diff --git a/src/tcp_sample.c b/src/tcp_sample.c index 2e8a62173..300ce1c8d 100644 --- a/src/tcp_sample.c +++ b/src/tcp_sample.c @@ -357,8 +357,8 @@ static inline int get_tcp_info(const struct arg *args

Re: [PATCH] MINOR: tcp_sample: extend support for get_tcp_info to OpenBSD

I'm not sure if MINOR is right. Currently the build is broken since TCP_INFO was added. On 8/12/2022 10:23 PM, Brad Smith wrote: extend support for get_tcp_info to OpenBSD. diff --git a/src/tcp_sample.c b/src/tcp_sample.c index 2e8a62173..300ce1c8d 100644 --- a/src/tcp_sample.c +++ b/src

[PATCH] BUILD: makefile: enable crypt(3) for NetBSD

Allow NetBSD to support encrypted passwords in Userlists. diff --git a/Makefile b/Makefile index 580cf6f9e..10c9ef7b4 100644 --- a/Makefile +++ b/Makefile @@ -453,8 +453,8 @@ endif # NetBSD 8 and above ifeq ($(TARGET),netbsd) set_target_defaults = $(call default_opts, \ -USE_POLL

[PATCH] MINOR: tcp_sample: extend support for get_tcp_info to OpenBSD

extend support for get_tcp_info to OpenBSD. diff --git a/src/tcp_sample.c b/src/tcp_sample.c index 2e8a62173..300ce1c8d 100644 --- a/src/tcp_sample.c +++ b/src/tcp_sample.c @@ -357,8 +357,8 @@ static inline int get_tcp_info(const struct arg *args, struct sample *smp, case 5:

Re: [PR] Fix -v flag usage with install(1) on OpenBSD/NetBSD/Solaris/AIX

On 7/16/2022 12:52 PM, Willy Tarreau wrote: On Sat, Jul 16, 2022 at 05:18:50AM -0400, Brad Smith wrote: On Sat, Jul 16, 2022 at 11:09:19AM +0200, Willy Tarreau wrote: Looks good. Let's just add a commit message and I'll merge it. BUILD: makefile: Fix install(1) handling for OpenBSD/NetBSD

Re: [PR] Fix -v flag usage with install(1) on OpenBSD/NetBSD/Solaris/AIX

On Sat, Jul 16, 2022 at 11:09:19AM +0200, Willy Tarreau wrote: > Looks good. Let's just add a commit message and I'll merge it. BUILD: makefile: Fix install(1) handling for OpenBSD/NetBSD/Solaris/AIX Add a new INSTALL variable to allow overridiing the flags passed to install(1). install(1) on

Re: [PR] Fix -v flag usage with install(1) on OpenBSD/NetBSD/Solaris/AIX

On Sat, Jul 16, 2022 at 06:25:52AM +0200, Willy Tarreau wrote: > On Sat, Jul 16, 2022 at 12:22:49AM -0400, Brad Smith wrote: > > On 7/15/2022 11:59 PM, Willy Tarreau wrote: > > > Hello, > > > > > > On Fri, Jul 15, 2022 at 07:27:12PM -0400, Brad Smith

Re: [PR] Fix -v flag usage with install(1) on OpenBSD/NetBSD/Solaris/AIX

On 7/15/2022 11:59 PM, Willy Tarreau wrote: Hello, On Fri, Jul 15, 2022 at 07:27:12PM -0400, Brad Smith wrote: On 7/15/2022 1:34 AM, ??? wrote: I wonder how do NetBSD/OpenBSD ports work, do they use their own "install" invocation instead of "make install" ? s

Re: [PR] Fix -v flag usage with install(1) on OpenBSD/NetBSD/Solaris/AIX

v flag. OpenBSD used it's own install target but I'm trying to remove that special casing and I had basically the same sort of diff NetBSD has. Can't switch to the make install target until the Makfile is fixed. пт, 15 июл. 2022 г. в 10:25, PR Bot : Dear list! Author: Brad S

Re: [PATCH]: DragonFlyBSD little build update

On 12/2/2020 2:27 PM, Willy Tarreau wrote: Hi David, On Wed, Dec 02, 2020 at 10:50:52AM +, David CARLIER wrote: Hi, heere a little build update for DragonFlyBSD proposal. I'm having a concern here, which is that by relying on pthread_setaffinity_np it will add an implicit dependency on

Warning during Haiku build

Just FYI the only warning during the build on Haiku is the following... cc -Iinclude -O2 -g -Wall -Wextra -Wdeclaration-after-statement -fwrapv -Wno-unused-label -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered -Wno-missing-field-initializers -Wno-cast-function-type -Wtype-limits

Haiku and Cygwin targets

Haiku has getaddrinfo(). Cygwin also appears to have getaddrinfo(). Also the target can be simplified a bit as 2009 was quite some time ago and IPv6 is the norm now.

[PATCH] BUILD: makefile: Enable getaddrinfo() on OS/X

Enable getaddrinfo() on OS/X. diff --git a/Makefile b/Makefile index db9bbe7e9..2fb05c719 100644 --- a/Makefile +++ b/Makefile @@ -382,7 +382,8 @@ endif # Mac OS/X ifeq ($(TARGET),osx) set_target_defaults = $(call default_opts, \ -USE_POLL USE_TPROXY USE_LIBCRYPT USE_THREAD

[PATCH] BUILD: makefile: Update feature flags for NetBSD

This updates the feature flags for NetBSD. NetBSD 8 adds support for accept4(). Enable getaddrinfo(). diff --git a/INSTALL b/INSTALL index 0263cf34c..2ae98bf6b 100644 --- a/INSTALL +++ b/INSTALL @@ -377,7 +377,7 @@ and assign it to the TARGET variable : - solaris for Solaris 10

[PATCH] BUILD: Add a DragonFlyBSD target

Add a target for DragonFlyBSD 4.3 and above. diff --git a/INSTALL b/INSTALL index f562a7102..0263cf34c 100644 --- a/INSTALL +++ b/INSTALL @@ -376,6 +376,7 @@ and assign it to the TARGET variable : - linux-musl for Linux kernel 2.6.28 and above with musl libc - solaris

[PATCH] DOC: update INSTALL with supported OpenBSD / FreeBSD versions

Update INSTALL with the OpenBSD / FreeBSD versions that are supported. diff --git a/INSTALL b/INSTALL index 04b034908..f562a7102 100644 --- a/INSTALL +++ b/INSTALL @@ -375,10 +375,10 @@ and assign it to the TARGET variable : - linux-glibc-legacy for Linux kernel 2.6.28 and above without new

Re: [PATCH] BUILD: makefile: Enable closefrom() support on Solaris

On Thu, Oct 01, 2020 at 10:08:47AM +0200, Willy Tarreau wrote: > On Wed, Sep 30, 2020 at 04:54:30PM -0400, Brad Smith wrote: > > On 9/30/2020 4:22 PM, ??? wrote: > > > there also several documentation files like this one > > > https://github.com/haproxy/hapro

Re: [PATCH] BUILD: makefile: Enable closefrom() support on Solaris

On 9/30/2020 4:22 PM, Илья Шипицин wrote: there also several documentation files like this one https://github.com/haproxy/haproxy/blob/master/INSTALL#L159 can you please review documentation as well ? That seems to be the only

[PATCH] BUILD: makefile: Enable closefrom() support on Solaris

Solaris 9 (released 2002) added support for closefrom(). I bumped the version in the comment to 10 as the default feature flags already has event ports enabled which were introduced in Solaris 10. diff --git a/Makefile b/Makefile index 197126db5..e7d716dd3 100644 --- a/Makefile +++ b/Makefile

Re: [PATCH] BUILD: makefile: Fix building with closefrom() support enabled

Looks like this should be back ported to 2.0, 2.1 and 2.2. On 9/30/2020 1:04 AM, Brad Smith wrote: I noticed the USE_CLOSEFROM define was not being passed along like the rest during the build. Looking around I see this was broken with the following two commits and related series.. BUILD

[PATCH] BUILD: makefile: Fix building with closefrom() support enabled

I noticed the USE_CLOSEFROM define was not being passed along like the rest during the build. Looking around I see this was broken with the following two commits and related series.. BUILD: Makefile: also report disabled options in the BUILD_OPTIONS variable

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

On 9/29/2020 5:12 AM, Willy Tarreau wrote: On Tue, Sep 15, 2020 at 03:10:04AM -0400, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). >From the FreeBSD port / package. Applied, thanks Brad! And sorry for miss

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

S}" On 9/15/2020 3:10 AM, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile @@ -36

[PATCH] BUILD: makefile: Update feature flags for OpenBSD

Update the OpenBSD target features being enabled. I updated the list of features after noticing "BUILD: makefile: disable threads by default on OpenBSD". The Makefile utilizing gcc(1) by default resulted in utilizing our legacy and obsolete compiler (GCC 4.2.1) instead of the proper system

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

ping. On 9/15/2020 3:10 AM, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile

Re: [PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

On 9/15/2020 3:45 AM, Lukas Tribus wrote: On Tue, 15 Sep 2020 at 09:05, Brad Smith wrote: NetBSD 8.0 adds support for accept4() and closefrom(). Enable getaddrinfo(). We just had to disable threading on OpenBSD 6.7 for the build to succeed: https://github.com/haproxy/haproxy/issues/725 Did

[PATCH] BUILD: makefile: Update feature flags for FreeBSD

This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). >From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile @@ -363,11 +363,11 @@ ifeq ($(TARGET),solaris)

Re: [PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

On 9/14/2020 5:39 AM, Lukas Tribus wrote: Hello Brad, On Sun, 13 Sep 2020 at 09:08, Brad Smith wrote: The following diff updates the feature flags for Solaris / FreeBSD / NetBSD / OpenBSD. Bump the baseline Solaris to 9 which intruduced closefrom(). FreeBSD 10 is already EOL for support

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

On 9/15/2020 1:31 AM, Willy Tarreau wrote: On Mon, Sep 14, 2020 at 11:42:47PM -0400, Brad Smith wrote: It's not about package maintainers as they know to do the right thing. It's about end users that don't know any better. In this case someone submitted a bogus patch which was commited based

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

On 9/14/2020 11:25 PM, Илья Шипицин wrote: вт, 15 сент. 2020 г. в 02:42, Brad Smith <mailto:b...@comstyle.com>>: On 9/14/2020 5:26 AM, Willy Tarreau wrote: > Hi Brad, > > On Sun, Sep 13, 2020 at 02:53:06AM -0400, Brad Smith wrote: >> Change the

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

On 9/14/2020 5:26 AM, Willy Tarreau wrote: Hi Brad, On Sun, Sep 13, 2020 at 02:53:06AM -0400, Brad Smith wrote: Change the default value of CC from gcc to cc to be more appropriate for modern day mix of compilers. On GCC based OS's cc -> gcc. On Clang based OS's cc -> clang. FreeBSD / O

[PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

The following diff updates the feature flags for Solaris / FreeBSD / NetBSD / OpenBSD. Bump the baseline Solaris to 9 which intruduced closefrom(). FreeBSD 10 is already EOL for support but its the new baseline. Introduces accept4(). Enable getaddrinfo(). The FreeBSD port enables these.

[PATCH] BUILD: makefile: change default value of CC from gcc to cc

Change the default value of CC from gcc to cc to be more appropriate for modern day mix of compilers. On GCC based OS's cc -> gcc. On Clang based OS's cc -> clang. FreeBSD / OpenBSD have switched to Clang and this corrects building with the proper compiler on OS's using Clang as the default