[PATCH 22/22] MEDIUM: Add external check

2013-07-23 Thread Simon Horman
Add an external check which makes use of an external process to check the status of a server. --- v4 * Remove stray use of s-check in process_chk() The check parameter should be used throughout process_chk() * Layer 7 timeouts of agent checks should be ignored * Ensure that argc is never used

[PATCH 15/22] MEDIUM: Add http-check agent-hdr option

2013-07-23 Thread Simon Horman
Allow agent checks to obtain information in an HTTP header of the response to an http check. Signed-off-by: Simon Horman ho...@verge.net.au --- v4 * Do not duplicate code that is in process_result() v2 - v3 * No change --- doc/configuration.txt | 24 -- include/types/proxy.h

[PATCH 19/22] MEDIUM: Set rise and fall of agent checks to 1

2013-07-23 Thread Simon Horman
this has not been implemented at this stage. Signed-off-by: Simon Horman ho...@verge.net.au --- include/common/defaults.h |2 ++ include/types/server.h|6 +++--- src/cfgparse.c| 28 +++- src/checks.c | 36

[PATCH 21/22] MEDIUM: Break out check establishment into establish_chk()

2013-07-23 Thread Simon Horman
This is in preparation for adding a new type of check that uses a process rather than a socket. Signed-off-by: Simon Horman ho...@verge.net.au --- v4 * Use check-type in establish_conn_chk() Use check-type instead of s-proxy-options2 PR_O2_CHK_ANY as the former is specific to the check

[PATCH 12/22] MEDIUM: checks: Add supplementary agent checks

2013-07-23 Thread Simon Horman
127.0.0.1:80 check agent-port 1 The agent-inter parameter may also be used to specify the interval and timeout for agent checks. If either the health or agent check determines that a server is down then it is marked as being down, otherwise it is marked as being up. Signed-off-by: Simon Horman

[PATCH 09/22] MEDIUM: Add name element to struct check

2013-07-23 Thread Simon Horman
This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman horms+rene...@verge.net.au --- include/types/server.h |1 + src/cfgparse.c |1 + src/checks.c |2 +- 3 files changed, 3

Re: ACL HTTP not capture all the HTTP traffic ?

2013-07-21 Thread k simon
state has disappeared. Regards Simon

[PATCH 08/22] MEDIUM: Add state to struct check

2013-07-19 Thread Simon Horman
as well as the server's existing check. Signed-off-by: Simon Horman horms+rene...@verge.net.au --- include/types/server.h |5 - src/checks.c |8 src/dumpstats.c|2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/types/server.h b

[PATCH 02/22] CLEANUP: Make parameters of srv_downtime and srv_getinter const

2013-07-19 Thread Simon Horman
The parameters of srv_downtime and srv_getinter are not modified and thus may be const. Signed-off-by: Simon Horman ho...@verge.net.au --- include/proto/server.h |4 ++-- src/server.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/proto/server.h

[PATCH 13/22] MEDIUM: Add helper for agent check events.

2013-07-19 Thread Simon Horman
Break agent check handling out of event_srv_chk_r(). This is in preparation for supporting agent check results returned in an HTTP header. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c | 97 +++--- 1 file changed, 52

[PATCH 07/22] MEDIUM: cfgparse: Factor out check initialisation

2013-07-19 Thread Simon Horman
This is in preparation for struct server having two elements of type struct check. Signed-off-by: Simon Horman ho...@verge.net.au --- src/cfgparse.c | 59 +--- 1 file changed, 35 insertions(+), 24 deletions(-) diff --git a/src/cfgparse.c b

[PATCH 10/22] MEDIUM: Move health element to struct check

2013-07-19 Thread Simon Horman
This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h |3 ++- src/cfgparse.c | 10 +- src/checks.c | 50

[PATCH 00/22] Agent Check Enhancements and External Check

2013-07-19 Thread Simon Horman
Hi, this series comprises of several components A. Patches 0-1 are cleanup patches DOC: Clarify documentation of option lb-agent-chk CLEANUP: Make parameters of srv_downtime and srv_getinter const B. Patches 2 - 12 add support for a secondary agent health check In this mode, a

[PATCH 06/22] MEDIUM: Paramatise functions over the check of a server

2013-07-19 Thread Simon Horman
check-server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. By paramatising these functions they may act on each of the checks without further significant modification. Signed-off-by: Simon Horman ho...@verge.net.au

[PATCH 20/22] MEDIUM: Add set agent pause|unpause unix socket command

2013-07-19 Thread Simon Horman
. The motivation for this option is to allow weight setting is to allow the weight changing effects of the agent checks to be paused to allow the weight of a server to be configured using set weight without being overridden by the agent. The default state is unpaused. Signed-off-by: Simon Horman ho

[PATCH 14/22] MEDIUM: Parser to allow matching of HTTP header

2013-07-19 Thread Simon Horman
Replace the current header parser, which simply skips the headers, with a version that allows matching of a key in a header. This is in preparation for supporting agent check results returned in an HTTP header. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c | 94

[PATCH 03/22] MEDIUM: Split up struct server's check element

2013-07-19 Thread Simon Horman
, this will not be so easy once a second struct check element is added to struct server to accommodate an agent health check. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h | 31 +++ src/cfgparse.c | 15 --- src/checks.c

[PATCH 01/22] DOC: Clarify documentation of option lb-agent-chk

2013-07-19 Thread Simon Horman
Avoid referring to check-port as this is not a configuration parameter. Signed-off-by: Simon Horman ho...@verge.net.au --- doc/configuration.txt |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 5140ff1..5297cfd

[PATCH 04/22] MEDIUM: Move {,fast,down}inter to struct check

2013-07-19 Thread Simon Horman
Move {,fast,down}inter elements from struct server to struct check. This allows those elements of a check to be independent of the check's server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho

[PATCH 05/22] MEDIUM: Move result element to struct check

2013-07-19 Thread Simon Horman
Move result element from struct server to struct check This allows check results to be independent of the check's server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho...@verge.net.au

[PATCH 16/22] MEDIUM: Add DRAIN state and report it on the stats page

2013-07-19 Thread Simon Horman
Add a DRAIN sub-state for a server which will be shown on the stats page instead of UP if an agent check is in use and the agent has most recently returned drain. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h |3 ++- src/checks.c |7 +++ src

RE: Remotely accessible stats socket and HATop

2013-07-09 Thread Simon Green
Hi Willy, Ref: Since a recent enough version, maybe dev16 or 17, you can even have your stats socket listen to TCP directly :-) How is that done? I'm struggling to find it in the docs. That would be much cleaner than using socat! Simon -Original Message- From: Willy Tarreau [mailto:w

HTTP 502 errors when backend returns 302

2013-06-07 Thread Simon Green
error/debug logging out of HAProxy. For example if one of the headers is invalid, how can I find out which header? Thanks in advance, Simon

RE: HTTP 502 errors when backend returns 302

2013-06-07 Thread Simon Green
. Simon -Original Message- From: Cyril Bonté [mailto:cyril.bo...@free.fr] Sent: 07 June 2013 19:04 To: Simon Green Cc: 'haproxy@formilux.org' Subject: Re: HTTP 502 errors when backend returns 302 Hi Simon, Le 07/06/2013 18:53, Simon Green a écrit : Hi List, We are having a problem that's

Re: trouble building on solaris

2013-05-01 Thread Simon Horman
...@gmail.com wrote: src/proxy.c:46: error: initializer element is not constant Hi Willy, It seems that this issue has crept into the latest haproxy-1.5-dev18 release. indeed :-( I'm CCing Simon and Marc-Antoine who last included stdbool. We fixed

Re: [PATCH 0/3] Add http-check agent-hdr option

2013-04-17 Thread Simon Horman
On Wed, Apr 17, 2013 at 08:03:11AM +0200, Willy Tarreau wrote: Hi Simon, On Wed, Apr 17, 2013 at 02:36:36PM +0900, Simon Horman wrote: Hi Willy, On Mon, Apr 01, 2013 at 11:29:12PM +0200, Willy Tarreau wrote: Hi Simon, Sorry for the long delay and thanks for waiting. I've just

Re: [PATCH 0/3] Add http-check agent-hdr option

2013-04-16 Thread Simon Horman
Hi Willy, On Mon, Apr 01, 2013 at 11:29:12PM +0200, Willy Tarreau wrote: Hi Simon, Sorry for the long delay and thanks for waiting. I've just reviewed your two patch series (16 total). They're pretty good in my opinion. likewise, sorry for the delay. I'm seeing a few points we'll probably

[PATCH 0/3] Add http-check agent-hdr option

2013-03-17 Thread Simon Horman
on the [PATCH 00/13] checks: Add supplementary agent checks series that I posted in late February. Simon Horman (3): MEDIUM: Add helper for agent check events. MEDIUM: Parser to allow matching of HTTP header MEDIUM: Add http-check agent-hdr option doc/configuration.txt | 24 - include

[PATCH 2/3] MEDIUM: Parser to allow matching of HTTP header

2013-03-17 Thread Simon Horman
Replace the current header parser, which simply skips the headers, with a version that allows matching of a key in a header. This is in preparation for supporting agent check results returned in an HTTP header. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c | 94

[PATCH 3/3] MEDIUM: Add http-check agent-hdr option

2013-03-17 Thread Simon Horman
Allow agent checks to obtain information in an HTTP header of the response to an http check. Signed-off-by: Simon Horman ho...@verge.net.au --- doc/configuration.txt | 24 -- include/types/proxy.h |2 ++ src/cfgparse.c| 38 +++-- src

[PATCH 1/3] MEDIUM: Add helper for agent check events.

2013-03-17 Thread Simon Horman
Break agent check handling out of event_srv_chk_r(). This is in preparation for supporting agent check results returned in an HTTP header. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c | 97 +++--- 1 file changed, 52

Question about logging HTTP Auth username

2013-03-13 Thread Simon Dick
Is it possible in the haproxy logs to log the HTTP username if it's sent across in an HTTP request? I know I could log the whole header but that doesn't strile me as being a good idea... :)

Re: haproxy and SSL

2013-02-26 Thread Simon Dick
This article may be useful: http://blog.exceliance.fr/2013/01/21/mitigating-the-ssl-beast-attack-using-the-aloha-load-balancer-haproxy/ On 26 February 2013 08:39, Christophe Rahier christo...@qualifio.comwrote: Hi, Actually, I configured haproxy to decrypt traffic SSL between haproxy and

[PATCH 02/13] CLEANUP: Make parameters of srv_downtime and srv_getinter const

2013-02-25 Thread Simon Horman
The parameters of srv_downtime and srv_getinter are not modified and thus may be const. Signed-off-by: Simon Horman ho...@verge.net.au --- include/proto/server.h |4 ++-- src/server.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/proto/server.h

[PATCH 00/13] checks: Add supplementary agent checks

2013-02-25 Thread Simon Horman
its check. It is only the last patch that actually adds the second check. Simon Horman (13): DOC: Clarify documentation of option lb-agent-chk CLEANUP: Make parameters of srv_downtime and srv_getinter const MEDIUM: Split up struct server's check element MEDIUM: Move {,fast,down}inter

[PATCH 04/13] MEDIUM: Move {,fast,down}inter to struct check

2013-02-25 Thread Simon Horman
Move {,fast,down}inter elements from struct server to struct check. This allows those elements of a check to be independent of the check's server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho

[PATCH 03/13] MEDIUM: Split up struct server's check element

2013-02-25 Thread Simon Horman
, this will not be so easy once a second struct check element is added to struct server to accommodate an agent health check. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h | 31 +++ src/cfgparse.c | 15 --- src/checks.c

[PATCH 09/13] MEDIUM: Add name element to struct check

2013-02-25 Thread Simon Horman
This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman horms+rene...@verge.net.au --- include/types/server.h |1 + src/cfgparse.c |5 +++-- src/checks.c |2 +- 3 files changed

[PATCH 05/13] MEDIUM: Move result element to struct check

2013-02-25 Thread Simon Horman
Move result element from struct server to struct check This allows check results to be independent of the check's server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho...@verge.net.au

[PATCH 11/13] MEDIUM: Add type type to struct check

2013-02-25 Thread Simon Horman
This is used to indicate the type of a check independent of its server's proxy's check type. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h |1

[PATCH 07/13] MEDIUM: cfgparse: Factor out check initialisation

2013-02-25 Thread Simon Horman
This is in preparation for struct server having two elements of type struct check. Signed-off-by: Simon Horman ho...@verge.net.au --- src/cfgparse.c | 56 +--- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/src/cfgparse.c b

[PATCH 06/13] MEDIUM: Paramatise functions over the check of a server

2013-02-25 Thread Simon Horman
check-server. This is in preparation for associating a agent check with a server which runs as well as the server's existing check. By paramatising these functions they may act on each of the checks without further significant modification. Signed-off-by: Simon Horman ho...@verge.net.au

[PATCH 10/13] MEDIUM: Move health element to struct check

2013-02-25 Thread Simon Horman
This is in preparation for associating a agent check with a server which runs as well as the server's existing check. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/server.h |3 ++- src/cfgparse.c | 10 +- src/checks.c | 50

[PATCH 08/13] MEDIUM: Add state to struct check

2013-02-25 Thread Simon Horman
as well as the server's existing check. Signed-off-by: Simon Horman horms+rene...@verge.net.au --- include/types/server.h |5 - src/checks.c |8 src/dumpstats.c|2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/types/server.h b

[PATCH 12/13] MEDIUM: Add helper for task creation for checks

2013-02-25 Thread Simon Horman
This helper is in preparation for adding a second struct check element to struct server. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/checks.c b/src

[PATCH 13/13] MEDIUM: checks: Add supplementary agent checks

2013-02-25 Thread Simon Horman
127.0.0.1:80 check agent-port 1 The agent-inter parameter may also be used to specify the interval and timeout for agent checks. If either the health or agent check determines that a server is down then it is marked as being down, otherwise it is marked as being up. Signed-off-by: Simon Horman

Re: [PATCH 1/7] Correct logic in cut_crlf()

2013-02-23 Thread Simon Horman
On Wed, Feb 20, 2013 at 06:33:08AM +0100, Krzysztof Olędzki wrote: On 2013-02-13 09:48, Simon Horman wrote: CUT And add: while (*s == '\r' || *s == '\n') before *s++ = '\0'; .. so we properly split line1\r\nline2. I see cut_crlf used to truncate strings at the end of the first

Re: [PATCH 1/7] Correct logic in cut_crlf()

2013-02-13 Thread Simon Horman
On Tue, Feb 12, 2013 at 04:03:14AM +0100, Krzysztof Olędzki wrote: On 2013-02-12 02:45, Simon Horman wrote: This corrects what appears to be logic errors in cut_crlf(). I assume that the intention of this function is to truncate a string at the first cr or lf. However, currently lf are ignored

Re: [PATCH 0/7 v2] Agent Health Check

2013-02-13 Thread Simon Horman
On Wed, Feb 13, 2013 at 11:08:35AM +0100, Willy Tarreau wrote: Hi Simon, On Tue, Feb 12, 2013 at 10:45:47AM +0900, Simon Horman wrote: Hi, this series was previously sent as [PATCH 0/5] Dynamic Health Check. (...) OK these patches looked fine, I have applied them all. Great, thanks!

[PATCH 2/7] checks: Make desc argument to set_server_check_status const

2013-02-11 Thread Simon Horman
This parameter is not modified by set_server_check_status() and thus may be const. Signed-off-by: Simon Horman ho...@verge.net.au --- src/checks.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/checks.c b/src/checks.c index a933bba..ca5a7ec 100644 --- a/src/checks.c

[PATCH 1/7] Correct logic in cut_crlf()

2013-02-11 Thread Simon Horman
Piotr Oledzki o...@ans.pl Signed-off-by: Simon Horman ho...@verge.net.au --- include/common/standard.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/common/standard.h b/include/common/standard.h index b1db821..d931925 100644 --- a/include/common/standard.h +++ b

[PATCH 0/7 v2] Agent Health Check

2013-02-11 Thread Simon Horman
to 833eb76c333baf8594ff1882e7b8e03edf801777: checks: Add agent health check (2013-02-12 10:42:56 +0900) Simon Horman (7): Correct logic in cut_crlf() checks: Make desc argument to set_server_check_status const dumpstats

[PATCH 3/7] dumpstats: Make cli_release_handler() static

2013-02-11 Thread Simon Horman
Make cli_release_handler() static, it is only used inside dumpstats.c Signed-off-by: Simon Horman ho...@verge.net.au --- src/dumpstats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 94e94f2..5954e8c 100644 --- a/src/dumpstats.c

[PATCH 4/7] server: Break out set weight processing code

2013-02-11 Thread Simon Horman
Break out set weight processing code. This is in preparation for reusing the code. Also, remove duplicate check in nested if clauses. {px-lbprm.algo BE_LB_PROP_DYN) is checked by the immediate outer if clause, so there is no need to check it a second time. Signed-off-by: Simon Horman ho

[PATCH 6/7] server: Tighten up parsing of weight string

2013-02-11 Thread Simon Horman
-off-by: Simon Horman ho...@verge.net.au --- src/server.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/server.c b/src/server.c index 4c1762f..98a9fbe 100644 --- a/src/server.c +++ b/src/server.c @@ -164,7 +164,8 @@ const char

[PATCH 5/7] server: Allow relative weights greater than 100%

2013-02-11 Thread Simon Horman
Allow relative weights greater than 100%, capping the absolute value to 256 which is the largest supported absolute weight. Signed-off-by: Simon Horman ho...@verge.net.au --- doc/configuration.txt | 25 + src/server.c |7 ++- 2 files changed, 19

[PATCH 7/7] checks: Add agent health check

2013-02-11 Thread Simon Horman
. option lb-agent-chk server http1_1 10.0.0.10:80 check port 1 weight 100 Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Rebase - Use server_parse_weight_change_request() instead of process_weight_change_request() and description returned on error. * Remove disable

Re: [PATCH 5/5] dynamic health check

2013-02-04 Thread Simon Horman
On Fri, Feb 01, 2013 at 08:22:24AM +0100, Willy Tarreau wrote: Hi Simon, On Fri, Feb 01, 2013 at 01:56:01PM +0900, Simon Horman wrote: Hi Malcolm, Hi Willy, after a bit of a hiatus I'd like to restart this discussion. Cool, I wanted to ping you on this last week-end but forgot to do

Re: [PATCH 2/5] dumpstats: Break out set weight processing code

2013-01-31 Thread Simon Horman
On Mon, Dec 24, 2012 at 07:58:13AM +0100, Willy Tarreau wrote: Hi Simon, I have some minor comments below for this patch : On Mon, Dec 24, 2012 at 10:33:54AM +0900, Simon Horman wrote: +static int stats_sock_parse_weight_change_request(struct stream_interface *si

Re: [PATCH 3/5] dumpstats: Remove duplicate check in nested if clauses

2013-01-31 Thread Simon Horman
On Mon, Dec 24, 2012 at 07:58:52AM +0100, Willy Tarreau wrote: On Mon, Dec 24, 2012 at 10:33:55AM +0900, Simon Horman wrote: {px-lbprm.algo BE_LB_PROP_DYN) is checked by the immediate outer if clause, so there is no need to check it a second time. Good catch, this one could be merged

Re: [PATCH 5/5] dynamic health check

2013-01-31 Thread Simon Horman
Hi Malcolm, Hi Willy, after a bit of a hiatus I'd like to restart this discussion. On Mon, Dec 24, 2012 at 10:23:15AM +0100, Willy Tarreau wrote: Hi Malcolm, On Mon, Dec 24, 2012 at 09:06:25AM +, Malcolm Turnbull wrote: Willy / Simon, I'm very happy to add a down option, my

[PATCH 0/5] Dynamic Health Check

2012-12-23 Thread Simon Horman
://github.com/horms/haproxy.git dynamic-chk for you to fetch changes up to 6ee39106a01194656240fc0d1f8b651f: dynamic health check (2012-12-24 10:25:08 +0900) Simon Horman (5): dumpstats: Make cli_release_handler() static

[PATCH 1/5] dumpstats: Make cli_release_handler() static

2012-12-23 Thread Simon Horman
Make cli_release_handler() static, it is only used inside dumpstats.c Signed-off-by: Simon Horman ho...@verge.net.au --- src/dumpstats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 24de6d0..c79b1d6 100644 --- a/src/dumpstats.c

[PATCH 3/5] dumpstats: Remove duplicate check in nested if clauses

2012-12-23 Thread Simon Horman
{px-lbprm.algo BE_LB_PROP_DYN) is checked by the immediate outer if clause, so there is no need to check it a second time. Signed-off-by: Simon Horman ho...@verge.net.au --- src/dumpstats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c

[PATCH 4/5] Allow relative weights greater than 100%

2012-12-23 Thread Simon Horman
Allow relative weights greater than 100%, capping the absolute value to 256 which is the largest supported absolute weight. Signed-off-by: Simon Horman ho...@verge.net.au --- doc/configuration.txt | 25 + src/dumpstats.c |7 ++- 2 files changed, 19

[PATCH 2/5] dumpstats: Break out set weight processing code

2012-12-23 Thread Simon Horman
Break out set weight processing code. This is in preparation for reusing the code. Signed-off-by: Simon Horman ho...@verge.net.au --- include/proto/dumpstats.h |1 + src/dumpstats.c | 146 ++--- 2 files changed, 87 insertions(+), 60

[PATCH 5/5] dynamic health check

2012-12-23 Thread Simon Horman
to the port of the service, may be useful in conjunction with this option. e.g. option dynamic-chk server http1_1 10.0.0.10:80 check port 1 weight 100 Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/peers.h |1 + include/types/proxy.h |3 ++- src/cfgparse.c

[PATCH] Fix HCHK spelling errors

2012-03-18 Thread Simon Horman
--- include/types/checks.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/types/checks.h b/include/types/checks.h index a414630..fd15c95 100644 --- a/include/types/checks.h +++ b/include/types/checks.h @@ -19,7 +19,7 @@ enum { /* Below we have finished

recording stats

2012-02-16 Thread Simon Ollivier
Hi, I'm using HAPROXY in order to load balance my 2 http servers. On theses servers i want to get the apache access_log files with the real IP source address (not the haproxy server address) I have not found any solution. I have the full haproxy logs (real ip src - real ip dest), so thats

RE: Resp error on stats page

2012-02-09 Thread Dwyer, Simon
/Application%20Images/Mail.png HTTP/1.1 Feb 9 16:42:06 localhost haproxy[2283]: 10.37.0.53:51041 [09/Feb/2012:16:39:52.732] 10-35-31-135 HUB/SPWFW1 0/0/2/5/133879 401 6839 - - SDVN 7/7/7/7/0 0/0 POST /_vti_bin/Lists.asmx HTTP/1.1 Does this mean anything to anyone? Cheers, Simon

RE: Resp error on stats page

2012-02-08 Thread Dwyer, Simon
? is that something i should be worried about or could that just be normal process? Cheers all, Simon From: Baptiste [bed...@gmail.com] Sent: Wednesday, February 08, 2012 9:34 PM To: Dwyer, Simon Cc: haproxy@formilux.org Subject: Re: Resp error on stats

Resp error on stats page

2012-02-07 Thread Dwyer, Simon
much explaining what it is. Cheers, Simon

Re: HAProxy stuck on TCP Retransmission

2011-12-04 Thread Simon Schmid
) and everything worked fine. So I assume the problem is rather related to the datacenter's hardware firewall/router than the machine's kernel. I hope they can turn off the firewall completely for further testing. I keep you posted. Thanks for your help Simon

HAProxy stuck on TCP Retransmission

2011-11-29 Thread Simon Schmid
5000 server node1 127.0.0.1:3200 weight 1 maxconn 4096 Thanks for reading! :) Simon

Re: status of master/worker model in 1.5

2011-09-27 Thread Simon Horman
On Mon, Sep 19, 2011 at 12:13:14PM -0400, Adam Kocoloski wrote: Hi all, Simon Horman posted a patch set back in March that enabled haproxy to reload its configuration without refusing connections. I don't think the patches have been merged yet -- are they on track for the 1.5 release

RE: SNMP Perl script with Centos 6.0

2011-09-13 Thread Dwyer, Simon
Not a problem Willy. I should also note in that case that the initial error error on subcontainer 'ia_addr' insert (-1) Is due to the face i am using keepalived and i have an ip address without an interface. I believe its a bug in the snmp libraries for centos. Cheers, Simon

RE: SNMP Perl script with Centos 6.0

2011-09-12 Thread Dwyer, Simon
Ok i have nailed this down to its working if i fire off snmpd by hand as root but not when i run it with the init script. i am running the command by hand the same as its called in the init script so i am stuck to see a difference. Anyone have any ideas? Cheers, Simon

RE: SNMP Perl script with Centos 6.0

2011-09-12 Thread Dwyer, Simon
Issue resolved. I thought i had already turn selinux to permissive. Apparently not :) From: Dwyer, Simon [sdw...@federalit.net] Sent: Tuesday, September 13, 2011 10:33 AM To: haproxy@formilux.org Subject: RE: SNMP Perl script with Centos 6.0 Ok i have

Stress test

2011-09-12 Thread Dwyer, Simon
I am trying to do some load testing on a new HA Proxy pair. Is there a common way to do this? i have done some searching but have not found anything solid. Cheers, Simon

RE: Stress test

2011-09-12 Thread Dwyer, Simon
Cheers, I will have a look at ab. I more just want to make sure it doesnt crash and burn while its in test. doing more of a proof of concept atm :) From: Baptiste [bed...@gmail.com] Sent: Tuesday, September 13, 2011 3:07 PM To: Dwyer, Simon Cc: haproxy

[PATCH 5/5] [MINOR] Use DPRINTF in assign_server()

2011-08-12 Thread Simon Horman
Use DPRINTF in assign_server() rather than open-coding its logic. --- src/backend.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/backend.c b/src/backend.c index 2cbc888..31e29d3 100644 --- a/src/backend.c +++ b/src/backend.c @@ -471,9 +471,7 @@ int

[PATCH 1/5] [MEDIUM] Fix stick-table replication on soft-restart

2011-08-12 Thread Simon Horman
[MINOR] session: add a pointer to the new target into the session (664beb8) introduced a regression by changing the type of a peer's target from TARG_TYPE_PROXY to TARG_TYPE_NONE. The effect of this is that during a soft-restart the new process no longer tries to connect to the old process to

[PATCH 2/5] [MEDIUM] Correct ipmask() logic

2011-08-12 Thread Simon Horman
The netmask applied to table entries as configured using ipmask() is stored in arg_p-data.ip not arg_i (which will be 1 if the netmask is set). --- src/pattern.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pattern.c b/src/pattern.c index e705f00..59ff010 100644

[PATCH 3/5] [MINOR] Correct type in table dump examples

2011-08-12 Thread Simon Horman
When dumping tables the table type is displayed as a type name not an integer. --- doc/configuration.txt | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index ffa5c5f..14a4b84 100644 --- a/doc/configuration.txt +++

Re: Thoughts on the master-worker model

2011-07-28 Thread Simon Horman
Hi Willy, sorry for not responding earlier. On Mon, Jul 18, 2011 at 04:40:56PM +0200, Willy Tarreau wrote: Hi Simon ! Last week I could find some time with a quiet place at work to dig again into the master-worker patch series. I went back to what we discussed a few weeks ago concerning

[PATCH 2/6] [MINOR] Consistently free expr on error in cfg_parse_listen()

2011-07-14 Thread Simon Horman
It seems to me that without this change cfg_parse_listen() may leak memory. --- src/cfgparse.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index 145d21f..6e38962 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -2918,6 +2918,7 @@

[PATCH 3/6] [MINOR] Free rdp_cookie_name on denint()

2011-07-14 Thread Simon Horman
The motivation for this is that when soft-restart is merged it will be come more important to free all relevant memory in deinit() Discovered using valgrind. --- src/haproxy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/haproxy.c b/src/haproxy.c index

[PATCH 0/6] Free memory on exit

2011-07-14 Thread Simon Horman
The motivation for this is that when soft-restart is merged it will be come more important to free all relevant memory in deinit(

[PATCH 1/6] [MINOR] Consistently use error in tcp_parse_tcp_req()

2011-07-14 Thread Simon Horman
It seems to me that without this change tcp_parse_tcp_req() may leak memory. --- src/proto_tcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/proto_tcp.c b/src/proto_tcp.c index cdaf150..3b6d39d 100644 --- a/src/proto_tcp.c +++ b/src/proto_tcp.c @@ -1213,7 +1213,7

[PATCH 5/6] [MINOR] Free stick table pool on denint()

2011-07-14 Thread Simon Horman
The motivation for this is that when soft-restart is merged it will be come more important to free all relevant memory in deinit() Discovered using valgrind. --- src/haproxy.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/haproxy.c b/src/haproxy.c index

[PATCH 6/6] [MINOR] Free stick rules on denint()

2011-07-14 Thread Simon Horman
The motivation for this is that when soft-restart is merged it will be come more important to free all relevant memory in deinit() Discovered using valgrind. --- src/haproxy.c | 67 +--- 1 files changed, 54 insertions(+), 13 deletions(-)

Re: [PATCH] [MINOR] Add non-stick server option

2011-06-26 Thread Simon Horman
On Sat, Jun 25, 2011 at 09:15:59PM +0200, Willy Tarreau wrote: Simon, I have applied all of your 4 patches. I really like the idea behind non-stick and stick on the RDP cookie, those are nice improvements. Thanks, I was pretty happy with how it turned out too.

Re: [PATCH] [CLEANUP] Remove unnecessary casts

2011-06-26 Thread Simon Horman
On Sat, Jun 25, 2011 at 09:13:52PM +0200, Willy Tarreau wrote: Hi Simon, On Fri, Jun 24, 2011 at 03:11:37PM +0900, Simon Horman wrote: There is no need to cast when going to or from void * Sometimes the void* is used as an easy cast (this is dirty but handy). This was the case here

[PATCH] [CLEANUP] Remove unnecessary casts

2011-06-24 Thread Simon Horman
There is no need to cast when going to or from void * --- src/proto_tcp.c | 46 +++--- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/proto_tcp.c b/src/proto_tcp.c index f03d3f3..a8540e4 100644 --- a/src/proto_tcp.c +++

[PATCH] [MINOR] Add non-stick server option

2011-06-24 Thread Simon Horman
Never add connections allocated to this sever to a stick-table. This may be used in conjunction with backup to ensure that stick-table persistence is disabled for backup servers. --- doc/configuration.txt |5 + include/types/server.h |1 + src/cfgparse.c |4

[PATCH] [MINOR] Make appsess{,ion}_refresh static

2011-06-23 Thread Simon Horman
apsession_refresh() and apsess_refressh are only used inside apsession.c and thus can be made static. The only use of apsession_refresh() is appsession_task_init(). These functions have been re-ordered to avoid the need for a forward-declaration of apsession_refresh(). ---

[PATCH] [MINOR] Add rdp_cookie pattern fetch function

2011-06-23 Thread Simon Horman
This pattern fetch function extracts the value of the rdp cookie name as a string and uses this value to match. This enables implementation of persistence based on the mstshash cookie. This is typically done if there is no msts cookie present. This differs from balance rdp-cookie in that any

[PATCH 5/5] [MINOR] Add down termination condition

2011-06-21 Thread Simon Horman
If a connection is closed by because the backend became unavailable then log 'D' as the termination condition. Signed-off-by: Simon Horman ho...@verge.net.au --- include/types/session.h |3 ++- src/checks.c|1 + src/log.c |2 +- 3 files changed, 4 insertions

[PATCH 3/5] [MINOR] Add active connection list to server

2011-06-21 Thread Simon Horman
The motivation for this is to allow iteration of all the connections of a server without the expense of iterating over the global list of connections. The first use of this will be to implement an option to close connections associated with a server when is is marked as being down or in

[PATCH 4/5] [MINOR] Allow shutdown of sessions when a server becomes unavailable

2011-06-21 Thread Simon Horman
unless on-marked-down shutdown-sessions is set - fixed logic bug Signed-off-by: Simon Horman ho...@verge.net.au --- doc/configuration.txt |9 + include/proto/session.h |4 ++-- include/types/checks.h |6 ++ include/types/server.h |1 + src/cfgparse.c

<    1   2   3   4   >