Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-11 Thread Vincent Bernat
❦ 9 janvier 2020 20:07 +01, Tim Düsterhus : > If you would package the haproxy-lua-http library for Debian > (https://github.com/haproxytech/haproxy-lua-http) [1], what would you > believe would be most "useful" / "in spirit of Debian packaging" / "your > choice"? > > a) Install the library

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-10 Thread Thierry Fournier
> On 9 Jan 2020, at 22:02, Willy Tarreau wrote: > > On Thu, Jan 09, 2020 at 08:22:29PM +0100, Tim D�sterhus wrote: >> Bob, >> >> Am 09.01.20 um 19:44 schrieb Zakharychev, Bob: >>> I'd say that since the issue can be solved naturally and completely within >>> the confines of Lua itself, new

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Willy Tarreau
On Thu, Jan 09, 2020 at 08:22:29PM +0100, Tim Düsterhus wrote: > Bob, > > Am 09.01.20 um 19:44 schrieb Zakharychev, Bob: > > I'd say that since the issue can be solved naturally and completely within > > the confines of Lua itself, new parameters should not be introduced in > > HAProxy to give

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Willy, Am 09.01.20 um 21:57 schrieb Willy Tarreau: > OK so the second path will be looked up before the first one. This is > something I'll probably add to the doc as well then. Yes. Look up works left to right as within the PATH you know and by prepending we are adding to the left. Best

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Willy Tarreau
On Thu, Jan 09, 2020 at 07:35:45PM +0100, Tim Düsterhus wrote: > > > Prepends the given string followed by a semicolon to Lua's package.path > variable. > > Lua's package.path is a semicolon delimited list of patterns that > specify how the `require` function attempts to find the source

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Bob, Am 09.01.20 um 19:44 schrieb Zakharychev, Bob: > I'd say that since the issue can be solved naturally and completely within > the confines of Lua itself, new parameters should not be introduced in > HAProxy to give one ability to solve it differently while obscuring the > solution in

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Willy, Vincent, Am 09.01.20 um 17:41 schrieb Willy Tarreau: > I'm seeing some merit in this for quite some stuff which annoys us by > requiring a dedicated file. I'm just a bit anxious about how this can > steer from the original intent, with users seeing it as a way to inline > code anywhere,

RE: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Zakharychev, Bob
look. Just my two cents. Bob -Original Message- From: Willy Tarreau Sent: Thursday, January 9, 2020 11:42 AM To: Tim Düsterhus Cc: Adis Nezirovic ; haproxy@formilux.org; tfourn...@arpalert.org Subject: Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option On Thu, Jan 09

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Willy, Am 09.01.20 um 17:38 schrieb Willy Tarreau: >> I concede that the HAProxy documentation should mention `package.path` >> to be clear what kind of path it refers to. But I disagree that we >> should explain how this works in detail, because this is not about any >> HAProxy specific stuff,

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Willy Tarreau
On Thu, Jan 09, 2020 at 03:00:34PM +0100, Tim Düsterhus wrote: > However this morning I started thinking whether it might make sense to > generalize `lua-prepend-path` to `lua-run-string` that would execute the > Lua script given as the parameter. It might provide better flexibility > and would be

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Willy Tarreau
On Thu, Jan 09, 2020 at 03:27:17PM +0100, Tim Düsterhus wrote: > Willy, > > Am 09.01.20 um 04:07 schrieb Willy Tarreau: > > I'm personally not opposed to this at all, however after reading the link > > above and given that Lua's concept of "path" is all but obvious as described > > in the link

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Willy, Am 09.01.20 um 04:07 schrieb Willy Tarreau: > I'm personally not opposed to this at all, however after reading the link > above and given that Lua's concept of "path" is all but obvious as described > in the link above, we definitely need a bit more text in the doc to quickly > explain

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Tim Düsterhus
Adis, Am 09.01.20 um 10:27 schrieb Adis Nezirovic: > global >   lua-load /path/to/config.lua >   lua-load /path/to/app.lua > […] > And now for the main topic, if you need to set any paths for Lua > scripts/libraries in non standard locations, you can directly use > package.path in config.lua

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-09 Thread Adis Nezirovic
On 1/8/20 10:54 PM, Tim Duesterhus wrote: List, while working on updating my haproxy-auth-request [1] to make use of haproxy-lua-http [2] instead of the crappy lua-socket [3] I realized that it would be difficult for the administrator to use the script afterwards. The reason is that `require`

Re: [PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-08 Thread Willy Tarreau
Hi Tim, On Wed, Jan 08, 2020 at 10:54:47PM +0100, Tim Duesterhus wrote: > global > lua-prepend-path /etc/haproxy/lua-modules/?/init.lua > lua-prepend-path /etc/haproxy/lua-modules/?.lua > lua-load /etc/haproxy/lua-modules/auth-request.lua (...) > diff --git

[PATCH] MINOR: lua: Add lua-prepend-path configuration option

2020-01-08 Thread Tim Duesterhus
` to automatically cut the commit message. -- >8 -- Subject: [PATCH] MINOR: lua: Add lua-prepend-path configuration option lua-prepend-path allows the administrator to specify a custom Lua library path to load custom Lua modules that are useful within the context of HAProxy without pollut