Re: Regression in 2.1 with Host header sent by backends

2019-11-27 Thread Christopher Faulet
Le 27/11/2019 à 11:59, Christopher Faulet a écrit : Le 27/11/2019 à 04:03, Willy Tarreau a écrit : On Wed, Nov 27, 2019 at 12:31:48AM +0100, Lukas Tribus wrote: That said, I'm not sure this was really the intention of the change in question (commit 531b83e03 "MINOR: h1: Reject requests if the

Re: Regression in 2.1 with Host header sent by backends

2019-11-27 Thread Christopher Faulet
Le 27/11/2019 à 04:03, Willy Tarreau a écrit : On Wed, Nov 27, 2019 at 12:31:48AM +0100, Lukas Tribus wrote: That said, I'm not sure this was really the intention of the change in question (commit 531b83e03 "MINOR: h1: Reject requests if the authority does not match the header host").

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Willy Tarreau
On Wed, Nov 27, 2019 at 12:31:48AM +0100, Lukas Tribus wrote: > That said, I'm not sure this was really the intention of the change in > question (commit 531b83e03 "MINOR: h1: Reject requests if the > authority does not match the header host"). Christopher? I'm pretty sure it was not intended and

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Lukas Tribus
Hello Julien, On Wed, Nov 27, 2019 at 12:47 AM Julien Pivotto wrote: > Yes indeed. I tested too and it works. I indeed tried > accept-invalid-http-request like in the commit message > instead of accept-invalid-http-response. > > My concern with the workaround is that there might be huge > side

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Julien Pivotto
On 27 Nov 00:39, Lukas Tribus wrote: > On Wed, Nov 27, 2019 at 12:36 AM Julien Pivotto > wrote: > > > > On 27 Nov 00:31, Lukas Tribus wrote: > > > Hello Julien, > > > > > > > > > > > > On Wed, Nov 27, 2019 at 12:21 AM Julien Pivotto > > > wrote: > > > > Haproxy 2.1 blocks a response with PH--

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Lukas Tribus
On Wed, Nov 27, 2019 at 12:36 AM Julien Pivotto wrote: > > On 27 Nov 00:31, Lukas Tribus wrote: > > Hello Julien, > > > > > > > > On Wed, Nov 27, 2019 at 12:21 AM Julien Pivotto > > wrote: > > > Haproxy 2.1 blocks a response with PH-- if the response has a Host header. > > > > A Host header

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Julien Pivotto
On 27 Nov 00:31, Lukas Tribus wrote: > Hello Julien, > > > > On Wed, Nov 27, 2019 at 12:21 AM Julien Pivotto > wrote: > > Haproxy 2.1 blocks a response with PH-- if the response has a Host header. > > A Host header belongs to the request, not the response. Haproxy 2.1 is > more strict in

Re: Regression in 2.1 with Host header sent by backends

2019-11-26 Thread Lukas Tribus
Hello Julien, On Wed, Nov 27, 2019 at 12:21 AM Julien Pivotto wrote: > Haproxy 2.1 blocks a response with PH-- if the response has a Host header. A Host header belongs to the request, not the response. Haproxy 2.1 is more strict in that regard. You can configure "option