[PATCH 6/6] CLEANUP: fcgi: Use `istadv()` in `fcgi_strm_send_params`

2022-03-04 Thread Tim Duesterhus
Found manually, while creating the previous commits to turn `struct proxy` members into ists. There is an existing Coccinelle rule to replace this pattern by `istadv()` in `ist.cocci`: @@ struct ist i; expression e; @@ - i.ptr += e; - i.len -= e; + i = istadv(i, e);

[PATCH 5/6] CLEANUP: fcgi: Replace memcpy() on ist by istcat()

2022-03-04 Thread Tim Duesterhus
This is a little cleaner, because the length of the resulting string does not need to be calculated manually. --- src/mux_fcgi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mux_fcgi.c b/src/mux_fcgi.c index a22bc9391..0a8679019 100644 --- a/src/mux_fcgi.c +++

[PATCH 0/6] 'ist'ify members of struct proxy

2022-03-04 Thread Tim Duesterhus
Willy, Christopher, find a series that converts a few members of `struct proxy` into ists. All of them have already been converted into ists when operating on them, so directly storing them as ists makes that code cleaner. One drawback is that `struct proxy` grows by 16 bytes. It might or might

[PATCH 1/6] MINOR: proxy: Store monitor_uri as a `struct ist`

2022-03-04 Thread Tim Duesterhus
The monitor_uri is already processed as an ist in `http_wait_for_request`, lets also just store it as such. see 0643b0e7e ("MINOR: proxy: Make `header_unique_id` a `struct ist`") for a very similar past commit. --- include/haproxy/proxy-t.h | 3 +-- src/cfgparse-listen.c | 9 +++--

[PATCH 4/6] MEDIUM: proxy: Store server_id_hdr_name as a `struct ist`

2022-03-04 Thread Tim Duesterhus
The server_id_hdr_name is already processed as an ist in various locations lets also just store it as such. see 0643b0e7e ("MINOR: proxy: Make `header_unique_id` a `struct ist`") for a very similar past commit. --- include/haproxy/proxy-t.h | 3 +-- src/cfgparse-listen.c | 9 -

[PATCH 3/6] MINOR: proxy: Store orgto_hdr_name as a `struct ist`

2022-03-04 Thread Tim Duesterhus
The orgto_hdr_name is already processed as an ist in `http_process_request`, lets also just store it as such. see 0643b0e7e ("MINOR: proxy: Make `header_unique_id` a `struct ist`") for a very similar past commit. --- include/haproxy/proxy-t.h | 3 +-- src/cfgparse-listen.c | 14

[PATCH 2/6] MINOR: proxy: Store fwdfor_hdr_name as a `struct ist`

2022-03-04 Thread Tim Duesterhus
The fwdfor_hdr_name is already processed as an ist in `http_process_request`, lets also just store it as such. see 0643b0e7e ("MINOR: proxy: Make `header_unique_id` a `struct ist`") for a very similar past commit. --- include/haproxy/proxy-t.h | 3 +-- src/cfgparse-listen.c | 14

Re: [PATCH] BUILD/MEDIUM kFreeBSD build fix

2022-03-04 Thread Willy Tarreau
On Fri, Mar 04, 2022 at 03:59:27PM +, David CARLIER wrote: > Hi, > > here the patch related to the GH issue #1555. Thank you David, now merged! Willy

[PATCH] BUILD/MEDIUM kFreeBSD build fix

2022-03-04 Thread David CARLIER
Hi, here the patch related to the GH issue #1555. Kind regards. From 02bd5ee5089c20a99ad3dfba433dd0e3eda2ceee Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 4 Mar 2022 15:50:48 + Subject: [PATCH] BUILD/MEDIUM: fix kFreeBSD build. kFreeBSD needs to be treated as a distinct target

Peers using heavily single cpu core

2022-03-04 Thread Maciej Zdeb
Hi, I'm experiencing high CPU usage on a single core, idle drops below 40% while other cores are at 80% idle. Peers cluster is quite big (12 servers, each server running 12 threads) and is used for synchronization of 3 stick-tables of 1 million entries size. Is peers protocol single threaded and

Re: SV: Incompatible with 'frontend http-request header rule'

2022-03-04 Thread Christopher Faulet
Le 3/4/22 à 00:42, Henning Svane a écrit : Hi Christopher I tried your rule and it did not compile, but I am trying to understand it. /haproxy02.cfg:20] : error detected while parsing an 'http-request tarpit' condition : no such ACL : 'http-response' I placed the rule in the frontend, but was