RE: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

[Daniel Corbett]

Sorry, I forgot to add the area the patch touches to the commit title.

 

New patch attached to add that.

 

Thanks,

-- Daniel

 



0001-DOC-config-Fix-a-few-grammar-spelling-issues-and-cas.patch
Description: Binary data

Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

[Willy Tarreau]

Hi Daniel,

On Sat, May 08, 2021 at 12:57:57PM -0400, Daniel Corbett wrote:
> Hello,
> 
> This patch fixes a few grammar and spelling issues in configuration.txt.
> It was also noted that there was a wide range of case usage
> (i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them
> all to be consistently "HAProxy" except where a binary is mentioned.

Thank you for going through this painful task. After carefully reviewing
it, I only found two that I had to revert (one occurrence of "HAProxy -vv"
and the process name for "kill"), and applied it.

There's still the version reported on startup that I want to fix (and
will have to adjust the regtest script as well I think). It's been
consistently reported as "HA-Proxy" for 20 years and it's the only
place I can think of where it's reported like this. I think it was
Bertrand who proposed a patch for this a few months ago but it had
to be split.

Willy

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

[Илья Шипицин]

I've created "proof of concept" OT support for CI

https://github.com/chipitsine/haproxy/runs/2535689580

Tim, are you ok with that approach ? If yes, I will polish things a bit.


currently "building OT and satellites" takes 2min 11sec. seem, I will add
similar caching level as for SSL variants (i.e. checking version in "opt"
and skip build if version is there).

also, I caught an error on clang:
https://github.com/haproxy/haproxy/issues/1242

I'm not very happy with unconditionally adding OT flags
https://github.com/chipitsine/haproxy/commit/dcf1812b17bd2907939eaa8d3310378d419d90c5#diff-b525f86b1f4925509959f857496dff18a9c4ed34fcc7f49357c5a6d00fb64d17R91
Tim, do you know how to add it using ${{ contains(matrix.FLAGS, 'USE_OT=1')
}} condition ?



чт, 8 апр. 2021 г. в 14:44, Илья Шипицин :

>
>
> чт, 8 апр. 2021 г. в 14:25, Willy Tarreau :
>
>> On Wed, Apr 07, 2021 at 05:26:24PM +0500,  ??? wrote:
>> > we run "all features anebled" gcc and clang builds, for example
>> > BUG/MINOR: tools: fix parsing "us" unit for timers ·
>> > haproxy/haproxy@a683805 (github.com)
>> > <
>> https://github.com/haproxy/haproxy/runs/2275440914?check_suite_focus=true
>> >
>> >
>> > <
>> https://github.com/haproxy/haproxy/runs/2275440914?check_suite_focus=true
>> >
>> > if
>> > additional libraries are easy to install (building will increase total
>> time
>> > a lot), I'd add opentracing to those "all features" builds
>>
>> I managed to build it myself so it's reasonably accessible, however we'd
>> possibly need to cache the builds, or we'll really start to spend a lot
>> of time building dependencies.
>>
>
> That is what I meant. if build is cheap - ok.
> if packages are available - ok.
>
> other options would be either caching dependencies (github ci supports
> caches) or provisioning custom docker images for our builds
>
>
>>
>> Willy
>>
>

[PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

[Daniel Corbett]

Hello,

 

 

This patch fixes a few grammar and spelling issues in configuration.txt.

It was also noted that there was a wide range of case usage

(i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them

all to be consistently "HAProxy" except where a binary is mentioned.

 

 

Thanks,

-- Daniel

 

 



0001-DOC-Fix-a-few-grammar-spelling-issues-and-casing-of-.patch
Description: Binary data