Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Willy Tarreau
On Thu, Nov 25, 2021 at 04:29:55PM +, David CARLIER wrote: > Ok I applied your suggestions and move back the malloc_trim/mallinfo > part as it was before. Thanks, now merged! Willy

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread David CARLIER
Ok I applied your suggestions and move back the malloc_trim/mallinfo part as it was before. On Thu, 25 Nov 2021 at 14:37, Willy Tarreau wrote: > > On Thu, Nov 25, 2021 at 01:19:39PM +, David CARLIER wrote: > > Here a patchset instead :) > > Thanks! > > I've reviewed it, I'm having some

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Willy Tarreau
On Thu, Nov 25, 2021 at 01:19:39PM +, David CARLIER wrote: > Here a patchset instead :) Thanks! I've reviewed it, I'm having some comments below: > From e8daa477b53a43ab39113cf0e9c43d9bbda1e9a9 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Thu, 25 Nov 2021 10:26:50 + >

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Илья Шипицин
чт, 25 нояб. 2021 г. в 18:22, David CARLIER : > On Thu, 25 Nov 2021 at 12:25, Willy Tarreau wrote: > > > > On Thu, Nov 25, 2021 at 04:38:27PM +0500, ??? wrote: > > > > Thus I think that instead of focusing on the OS we ought to continue > > > > to focus on the allocator and improve

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread David CARLIER
On Thu, 25 Nov 2021 at 12:25, Willy Tarreau wrote: > > On Thu, Nov 25, 2021 at 04:38:27PM +0500, ??? wrote: > > > Thus I think that instead of focusing on the OS we ought to continue > > > to focus on the allocator and improve runtime detection: > > > > > > - glibc (currently detected

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread David CARLIER
Here a patchset instead :) On Thu, 25 Nov 2021 at 12:25, Willy Tarreau wrote: > > On Thu, Nov 25, 2021 at 04:38:27PM +0500, ??? wrote: > > > Thus I think that instead of focusing on the OS we ought to continue > > > to focus on the allocator and improve runtime detection: > > > > > >

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Willy Tarreau
On Thu, Nov 25, 2021 at 04:38:27PM +0500, ??? wrote: > > Thus I think that instead of focusing on the OS we ought to continue > > to focus on the allocator and improve runtime detection: > > > > - glibc (currently detected using detect_allocator) > > => use malloc_trim() > > -

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread David CARLIER
On Thu, 25 Nov 2021 at 11:38, Илья Шипицин wrote: > > > > чт, 25 нояб. 2021 г. в 14:54, Willy Tarreau : >> >> Hi David, >> >> On Wed, Nov 24, 2021 at 08:08:39PM +, David CARLIER wrote: >> > Hi >> > >> > here a little patch for FreeBSD to support memory arenas trimming. >> (...) >> > FreeBSD

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Илья Шипицин
чт, 25 нояб. 2021 г. в 14:54, Willy Tarreau : > Hi David, > > On Wed, Nov 24, 2021 at 08:08:39PM +, David CARLIER wrote: > > Hi > > > > here a little patch for FreeBSD to support memory arenas trimming. > (...) > > FreeBSD uses a slighty simplified version of jemalloc as libc allocator > >

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Willy Tarreau
On Thu, Nov 25, 2021 at 01:29:13PM +0300, Dmitry Sivachenko wrote: > > > On 25 Nov 2021, at 13:09, Willy Tarreau wrote: > > > > Please try the two attached patches. They re-backport something that > > we earlier failed to backport that simplifies the ugly ifdefs everywhere > > that virtually

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Dmitry Sivachenko
> On 25 Nov 2021, at 13:29, Amaury Denoyelle wrote: > > Dmitry, the patches that Willy provided you should fix the issue. Now, > do you need a 2.4.10 to be emitted early with it or is it possible for > you to keep the patches in your tree so we can have a more substantial > list of change for

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Amaury Denoyelle
On Thu, Nov 25, 2021 at 11:42:01AM +0300, Dmitry Sivachenko wrote: > On 24 Nov 2021, at 12:57, Christopher Faulet wrote: > > > > Hi, > > > HAProxy 2.4.9 was released on 2021/11/23. It added 36 new commits > > after version 2.4.8. > > > Hello, > version 2.4.9 fails to build with OpenSSL turned

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Dmitry Sivachenko
> On 25 Nov 2021, at 13:09, Willy Tarreau wrote: > > Please try the two attached patches. They re-backport something that > we earlier failed to backport that simplifies the ugly ifdefs everywhere > that virtually break every single backport related to SSL. > > For me they work with/without

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Willy Tarreau
On Thu, Nov 25, 2021 at 11:02:52AM +0100, Amaury Denoyelle wrote: > On Thu, Nov 25, 2021 at 11:42:01AM +0300, Dmitry Sivachenko wrote: > > On 24 Nov 2021, at 12:57, Christopher Faulet wrote: > > > > > Hi, > > > > HAProxy 2.4.9 was released on 2021/11/23. It added 36 new commits > > > after

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Amaury Denoyelle
On Thu, Nov 25, 2021 at 11:42:01AM +0300, Dmitry Sivachenko wrote: > On 24 Nov 2021, at 12:57, Christopher Faulet wrote: > > > > Hi, > > > HAProxy 2.4.9 was released on 2021/11/23. It added 36 new commits > > after version 2.4.8. > > > Hello, > version 2.4.9 fails to build with OpenSSL turned

Re: [PATCH]: MEDIUM: pool little FreeBSD support improvement.

2021-11-25 Thread Willy Tarreau
Hi David, On Wed, Nov 24, 2021 at 08:08:39PM +, David CARLIER wrote: > Hi > > here a little patch for FreeBSD to support memory arenas trimming. (...) > FreeBSD uses a slighty simplified version of jemalloc as libc allocator > since many years (there is thoughts to eventually switch to

Re: [ANNOUNCE] haproxy-2.4.9

2021-11-25 Thread Dmitry Sivachenko
On 24 Nov 2021, at 12:57, Christopher Faulet wrote: > > > Hi, > > HAProxy 2.4.9 was released on 2021/11/23. It added 36 new commits > after version 2.4.8. > Hello, version 2.4.9 fails to build with OpenSSL turned off: src/server.c:207:51: error: no member named 'ssl_ctx' in 'struct

Re: [PATCH 1/1] BUG/MINOR: lua: remove loop initial declarations

2021-11-25 Thread Christopher Faulet
Le 11/24/21 à 22:16, Bertrand Jacquin a écrit : HAProxy is documented to support gcc >= 3.4 as per INSTALL file, however hlua.c makes use of c11 only loop initial declarations leading to build failure when using gcc-4.9.4: x86_64-unknown-linux-gnu-gcc -Iinclude -Wchar-subscripts -Wcomment