Re: [PATCH]: DragonFlyBSD little build update

2020-12-02 Thread Brad Smith
On 12/2/2020 2:27 PM, Willy Tarreau wrote: Hi David, On Wed, Dec 02, 2020 at 10:50:52AM +, David CARLIER wrote: Hi, heere a little build update for DragonFlyBSD proposal. I'm having a concern here, which is that by relying on pthread_setaffinity_np it will add an implicit dependency on

Warning during Haiku build

2020-10-12 Thread Brad Smith
Just FYI the only warning during the build on Haiku is the following... cc -Iinclude -O2 -g -Wall -Wextra -Wdeclaration-after-statement -fwrapv -Wno-unused-label -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered -Wno-missing-field-initializers -Wno-cast-function-type -Wtype-limits

Haiku and Cygwin targets

2020-10-10 Thread Brad Smith
Haiku has getaddrinfo(). Cygwin also appears to have getaddrinfo(). Also the target can be simplified a bit as 2009 was quite some time ago and IPv6 is the norm now.

[PATCH] BUILD: makefile: Enable getaddrinfo() on OS/X

2020-10-09 Thread Brad Smith
Enable getaddrinfo() on OS/X. diff --git a/Makefile b/Makefile index db9bbe7e9..2fb05c719 100644 --- a/Makefile +++ b/Makefile @@ -382,7 +382,8 @@ endif # Mac OS/X ifeq ($(TARGET),osx) set_target_defaults = $(call default_opts, \ -USE_POLL USE_TPROXY USE_LIBCRYPT USE_THREAD

[PATCH] BUILD: makefile: Update feature flags for NetBSD

2020-10-08 Thread Brad Smith
This updates the feature flags for NetBSD. NetBSD 8 adds support for accept4(). Enable getaddrinfo(). diff --git a/INSTALL b/INSTALL index 0263cf34c..2ae98bf6b 100644 --- a/INSTALL +++ b/INSTALL @@ -377,7 +377,7 @@ and assign it to the TARGET variable : - solaris for Solaris 10

[PATCH] BUILD: Add a DragonFlyBSD target

2020-10-07 Thread Brad Smith
Add a target for DragonFlyBSD 4.3 and above. diff --git a/INSTALL b/INSTALL index f562a7102..0263cf34c 100644 --- a/INSTALL +++ b/INSTALL @@ -376,6 +376,7 @@ and assign it to the TARGET variable : - linux-musl for Linux kernel 2.6.28 and above with musl libc - solaris

[PATCH] DOC: update INSTALL with supported OpenBSD / FreeBSD versions

2020-10-02 Thread Brad Smith
Update INSTALL with the OpenBSD / FreeBSD versions that are supported. diff --git a/INSTALL b/INSTALL index 04b034908..f562a7102 100644 --- a/INSTALL +++ b/INSTALL @@ -375,10 +375,10 @@ and assign it to the TARGET variable : - linux-glibc-legacy for Linux kernel 2.6.28 and above without new

Re: [PATCH] BUILD: makefile: Enable closefrom() support on Solaris

2020-10-01 Thread Brad Smith
On Thu, Oct 01, 2020 at 10:08:47AM +0200, Willy Tarreau wrote: > On Wed, Sep 30, 2020 at 04:54:30PM -0400, Brad Smith wrote: > > On 9/30/2020 4:22 PM, ??? wrote: > > > there also several documentation files like this one > > > https://github.com/haproxy/hapro

Re: [PATCH] BUILD: makefile: Enable closefrom() support on Solaris

2020-09-30 Thread Brad Smith
On 9/30/2020 4:22 PM, Илья Шипицин wrote: there also several documentation files like this one https://github.com/haproxy/haproxy/blob/master/INSTALL#L159 can you please review documentation as well ? That seems to be the only

[PATCH] BUILD: makefile: Enable closefrom() support on Solaris

2020-09-30 Thread Brad Smith
Solaris 9 (released 2002) added support for closefrom(). I bumped the version in the comment to 10 as the default feature flags already has event ports enabled which were introduced in Solaris 10. diff --git a/Makefile b/Makefile index 197126db5..e7d716dd3 100644 --- a/Makefile +++ b/Makefile

Re: [PATCH] BUILD: makefile: Fix building with closefrom() support enabled

2020-09-29 Thread Brad Smith
Looks like this should be back ported to 2.0, 2.1 and 2.2. On 9/30/2020 1:04 AM, Brad Smith wrote: I noticed the USE_CLOSEFROM define was not being passed along like the rest during the build. Looking around I see this was broken with the following two commits and related series.. BUILD

[PATCH] BUILD: makefile: Fix building with closefrom() support enabled

2020-09-29 Thread Brad Smith
I noticed the USE_CLOSEFROM define was not being passed along like the rest during the build. Looking around I see this was broken with the following two commits and related series.. BUILD: Makefile: also report disabled options in the BUILD_OPTIONS variable

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

2020-09-29 Thread Brad Smith
On 9/29/2020 5:12 AM, Willy Tarreau wrote: On Tue, Sep 15, 2020 at 03:10:04AM -0400, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). >From the FreeBSD port / package. Applied, thanks Brad! And sorry for miss

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

2020-09-27 Thread Brad Smith
S}" On 9/15/2020 3:10 AM, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile @@ -36

[PATCH] BUILD: makefile: Update feature flags for OpenBSD

2020-09-26 Thread Brad Smith
Update the OpenBSD target features being enabled. I updated the list of features after noticing "BUILD: makefile: disable threads by default on OpenBSD". The Makefile utilizing gcc(1) by default resulted in utilizing our legacy and obsolete compiler (GCC 4.2.1) instead of the proper system

Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

2020-09-22 Thread Brad Smith
ping. On 9/15/2020 3:10 AM, Brad Smith wrote: This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile

Re: [PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

2020-09-15 Thread Brad Smith
On 9/15/2020 3:45 AM, Lukas Tribus wrote: On Tue, 15 Sep 2020 at 09:05, Brad Smith wrote: NetBSD 8.0 adds support for accept4() and closefrom(). Enable getaddrinfo(). We just had to disable threading on OpenBSD 6.7 for the build to succeed: https://github.com/haproxy/haproxy/issues/725 Did

[PATCH] BUILD: makefile: Update feature flags for FreeBSD

2020-09-15 Thread Brad Smith
This updates the feature flags for FreeBSD. FreeBSD 10 adds support for accept4(). Enable getaddrinfo(). >From the FreeBSD port / package. diff --git a/Makefile b/Makefile index 934ca1666..e69870595 100644 --- a/Makefile +++ b/Makefile @@ -363,11 +363,11 @@ ifeq ($(TARGET),solaris)

Re: [PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

2020-09-15 Thread Brad Smith
On 9/14/2020 5:39 AM, Lukas Tribus wrote: Hello Brad, On Sun, 13 Sep 2020 at 09:08, Brad Smith wrote: The following diff updates the feature flags for Solaris / FreeBSD / NetBSD / OpenBSD. Bump the baseline Solaris to 9 which intruduced closefrom(). FreeBSD 10 is already EOL for support

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

2020-09-15 Thread Brad Smith
On 9/15/2020 1:31 AM, Willy Tarreau wrote: On Mon, Sep 14, 2020 at 11:42:47PM -0400, Brad Smith wrote: It's not about package maintainers as they know to do the right thing. It's about end users that don't know any better. In this case someone submitted a bogus patch which was commited based

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

2020-09-14 Thread Brad Smith
On 9/14/2020 11:25 PM, Илья Шипицин wrote: вт, 15 сент. 2020 г. в 02:42, Brad Smith <mailto:b...@comstyle.com>>: On 9/14/2020 5:26 AM, Willy Tarreau wrote: > Hi Brad, > > On Sun, Sep 13, 2020 at 02:53:06AM -0400, Brad Smith wrote: >> Change the

Re: [PATCH] BUILD: makefile: change default value of CC from gcc to cc

2020-09-14 Thread Brad Smith
On 9/14/2020 5:26 AM, Willy Tarreau wrote: Hi Brad, On Sun, Sep 13, 2020 at 02:53:06AM -0400, Brad Smith wrote: Change the default value of CC from gcc to cc to be more appropriate for modern day mix of compilers. On GCC based OS's cc -> gcc. On Clang based OS's cc -> clang. FreeBSD / O

[PATCH] BUILD: makefile: Update feature flags for Solaris / FreeBSD / NetBSD / OpenBSD

2020-09-13 Thread Brad Smith
The following diff updates the feature flags for Solaris / FreeBSD / NetBSD / OpenBSD. Bump the baseline Solaris to 9 which intruduced closefrom(). FreeBSD 10 is already EOL for support but its the new baseline. Introduces accept4(). Enable getaddrinfo(). The FreeBSD port enables these.

[PATCH] BUILD: makefile: change default value of CC from gcc to cc

2020-09-13 Thread Brad Smith
Change the default value of CC from gcc to cc to be more appropriate for modern day mix of compilers. On GCC based OS's cc -> gcc. On Clang based OS's cc -> clang. FreeBSD / OpenBSD have switched to Clang and this corrects building with the proper compiler on OS's using Clang as the default