Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Fri, Apr 08, 2022 at 04:45:46PM +0200, Miroslav Zagorac wrote: > On 08.04.2022 16:24, Willy Tarreau wrote: > > My concern is essentially this one: is there any risk that a 2.5 user > > currently using opentracing would be hit by a bug introduced with this > > patch ? The code *seems* to be

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Miroslav Zagorac
On 08.04.2022 16:24, Willy Tarreau wrote: > My concern is essentially this one: is there any risk that a 2.5 user > currently using opentracing would be hit by a bug introduced with this > patch ? The code *seems* to be isolated only in the parts that are > enabled by OT_USE_VARS but I'm asking

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Willy Tarreau
On Fri, Apr 08, 2022 at 04:04:07PM +0200, Miroslav Zagorac wrote: > > - 0014-MAJOR-opentracing-reenable-usage-of-vars-to-transmit.patch > >=> while I'm fine for 2.6, I'm really not for 2.5 without a big > > compelling reason. It's a feature addition, not a bug fix. > > Either

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Miroslav Zagorac
On 08.04.2022 15:47, Willy Tarreau wrote: Thanks, but now I'm having further questions: - 0006-BUG-MINOR-opentracing-setting-the-return-value-in-fu.patch - 0016-BUG-BUILD-opentracing-fixed-OT_DEFINE-variable-setti.patch => these ones are bug fixes that are independent on the series, and