Re: [PATCH 2/3] BUG/MINOR: select: remove uneeded free in thread init

2020-05-13 Thread William Dauchy
On Wed, May 13, 2020 at 11:50:50AM +0200, Willy Tarreau wrote: > It's not a bug, it's just a way to ensure a common error path undoes > everything that was done before reaching it. If another operation is > added after the DIR_WR malloc, it will only have to add its own undo > operation to the

Re: [PATCH 2/3] BUG/MINOR: select: remove uneeded free in thread init

2020-05-13 Thread Willy Tarreau
On Mon, May 11, 2020 at 03:20:04PM +0200, William Dauchy wrote: > we wrongly free `tmp_evts[DIR_RD]` in error case. It's not a bug, it's just a way to ensure a common error path undoes everything that was done before reaching it. If another operation is added after the DIR_WR malloc, it will only

[PATCH 2/3] BUG/MINOR: select: remove uneeded free in thread init

2020-05-11 Thread William Dauchy
we wrongly free `tmp_evts[DIR_RD]` in error case. it could be backported from v1.8 to v2.1. Fixes: d4604adeaa8c ("MAJOR: threads/fd: Make fd stuffs thread-safe") Signed-off-by: William Dauchy --- src/ev_select.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git