Re: [PATCH 0/3] prometheus info fields description merge

2021-01-21 Thread Willy Tarreau
On Thu, Jan 21, 2021 at 11:11:15AM +0100, William Dauchy wrote: > On Thu, Jan 21, 2021 at 9:39 AM Willy Tarreau wrote: > > I didn't understand that it was a question. Well, as I mentioned previously, > > we could have units stored in the stats structure so that the promex code > > automatically

Re: [PATCH 0/3] prometheus info fields description merge

2021-01-21 Thread William Dauchy
On Thu, Jan 21, 2021 at 9:39 AM Willy Tarreau wrote: > I didn't understand that it was a question. Well, as I mentioned previously, > we could have units stored in the stats structure so that the promex code > automatically performs the conversion. This would make everything more > homogenous I

Re: [PATCH 0/3] prometheus info fields description merge

2021-01-21 Thread Willy Tarreau
On Thu, Jan 21, 2021 at 09:32:43AM +0100, William Dauchy wrote: > On Wed, Jan 20, 2021 at 4:33 PM William Dauchy wrote: > > On Wed, Jan 20, 2021 at 4:08 PM Christopher Faulet > > wrote: > > > Sorry for the delay. I reviewed your patches and that seems good for me. > > > In > > > fact, I was

Re: [PATCH 0/3] prometheus info fields description merge

2021-01-21 Thread William Dauchy
On Wed, Jan 20, 2021 at 4:33 PM William Dauchy wrote: > On Wed, Jan 20, 2021 at 4:08 PM Christopher Faulet > wrote: > > Sorry for the delay. I reviewed your patches and that seems good for me. In > > fact, I was first a bit annoyed by the first one, because it adds 3 new > > fields > > just to

Re: [PATCH 0/3] prometheus info fields description merge

2021-01-20 Thread William Dauchy
Thanks Christopher. On Wed, Jan 20, 2021 at 4:08 PM Christopher Faulet wrote: > Sorry for the delay. I reviewed your patches and that seems good for me. In > fact, I was first a bit annoyed by the first one, because it adds 3 new fields > just to change the unit (MB vs bytes). But the unit

Re: [PATCH 0/3] prometheus info fields description merge

2021-01-20 Thread Christopher Faulet
Le 15/01/2021 à 22:41, William Dauchy a écrit : Hello Christopher, Here is a new small patch set which targets the merge of the info fields description. I choose to add new fields to be more coherent and facilitate the merging work. William Dauchy (3): MINOR: stats: duplicate 3 fields in

[PATCH 0/3] prometheus info fields description merge

2021-01-15 Thread William Dauchy
Hello Christopher, Here is a new small patch set which targets the merge of the info fields description. I choose to add new fields to be more coherent and facilitate the merging work. William Dauchy (3): MINOR: stats: duplicate 3 fields in bytes in info MINOR: stats: add new start time