Hi Miroslav,
On Tue, Jan 30, 2024 at 03:42:20AM +0100, Miroslav Zagorac wrote:
> Hello all,
>
> In several places in the source, there was the same block of code that was
> used to deinitialize the log buffer. There were even two functions that
> did this, but they were called only from the code
52ef575d77a47ef7338004fbad31d8199e59c752 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 30 Jan 2024 03:14:09 +0100
Subject: [PATCH] CLEANUP: log: deinitialization of the log buffer in one
function
In several places in the source, there was the same block of code that was
used to deinitialize the log
On Thu, Sep 21, 2017 at 04:41:55PM +0100, David CARLIER wrote:
> There are valid points especially about possible usage in memprintf :-)
Thanks, now merged.
Willy
rom 4c694b4ff20a6ec88bc73c51a93c23de3f781c01 Mon Sep 17 00:00:00 2001
> > From: David Carlier
> > Date: Thu, 21 Sep 2017 14:36:43 +
> > Subject: [PATCH] CLEANUP: log
>
> Please be a bit more indicative on the subject line so that when we work
> on backports to -stable
od enough.
Just a few comments (I always have comments ;-))
> Kind regards.
> From 4c694b4ff20a6ec88bc73c51a93c23de3f781c01 Mon Sep 17 00:00:00 2001
> From: David Carlier
> Date: Thu, 21 Sep 2017 14:36:43 +0000
> Subject: [PATCH] CLEANUP: log
Please be a bit more indicative on
Carlier
Date: Thu, 21 Sep 2017 14:36:43 +
Subject: [PATCH] CLEANUP: log
since we do not log the sample fetch when it is invalid, we can
free the log data.
---
src/log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/log.c b/src/log.c
index 5c42f6b2a..0fb0f68e0 100644
--- a/src/log.c
Hi David,
On Mon, Feb 29, 2016 at 07:55:45PM +, David CARLIER wrote:
> Hi I hope this looks better this time.
Yes, thanks. I'll split it in two, one for the API update and the other one
for the logs. That way it's easier to know what to backport when we later
clean up all other call places.
you
>> interested
>> in working on the solution I proposed ?
>>
>> Thanks,
>> Willy
>>
>>
>
From 1c42759fbd31a18c6d3efe669c316a53c4ad6251 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Feb 2016 19:51:17 +
Subject: [PATCH] CLEANUP: log
Different ap
Sorry I did not see the whole email, just realized ok why not :-)
On 29 February 2016 at 11:18, Willy Tarreau wrote:
> On Mon, Feb 29, 2016 at 10:37:33AM +, David CARLIER wrote:
> > Hi no problems it is not a bugfix at all, usually just better to copy a
> > const char instead of casting it i
On Mon, Feb 29, 2016 at 10:37:33AM +, David CARLIER wrote:
> Hi no problems it is not a bugfix at all, usually just better to copy a
> const char instead of casting it in this sort of situation. Nothing else.
Yes clearly, but as I said it's better to fix it anyway. Are you interested
in workin
posal for the log component.
>
>
> From f1924d813f37cd6444d9251605fdd823efb7fe20 Mon Sep 17 00:00:00 2001
> From: David Carlier
> Date: Thu, 18 Feb 2016 21:46:48 +
> Subject: [PATCH] CLEANUP: log
>
> The string to be escaped is not marked at const,
> and it would be safer to copy in
is a tiny patch proposal for the log component.
>From f1924d813f37cd6444d9251605fdd823efb7fe20 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Thu, 18 Feb 2016 21:46:48 +0000
Subject: [PATCH] CLEANUP: log
The string to be escaped is not marked at const,
and it would be safer to cop
HI all,
There is a tiny patch proposal for the log component.
Cheers.
From f1924d813f37cd6444d9251605fdd823efb7fe20 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Thu, 18 Feb 2016 21:46:48 +
Subject: [PATCH] CLEANUP: log
The string to be escaped is not marked at const,
and it would
13 matches
Mail list logo
