Re: [PATCHv3] openssl-compat: Fix getm_ defines

2019-12-20 Thread Willy Tarreau
On Fri, Dec 20, 2019 at 04:17:44PM +0100, Lukas Tribus wrote: > On Fri, 20 Dec 2019 at 16:00, Willy Tarreau wrote: > > taking it now. > > Note that 1.9 needs to access OPENSSL_VERSION_NUMBER instead of > HA_OPENSSL_VERSION_NUMBER. Argh good catch, I'll fix it then. I didn't notice any issue here

Re: [PATCHv3] openssl-compat: Fix getm_ defines

2019-12-20 Thread Lukas Tribus
On Fri, 20 Dec 2019 at 16:00, Willy Tarreau wrote: > taking it now. Note that 1.9 needs to access OPENSSL_VERSION_NUMBER instead of HA_OPENSSL_VERSION_NUMBER. lukas

Re: [PATCHv3] openssl-compat: Fix getm_ defines

2019-12-20 Thread Willy Tarreau
On Fri, Dec 20, 2019 at 02:50:46PM +0100, Lukas Tribus wrote: > Should be backported to 1.9. Thank you guys, I've been following remotely, cowardly waiting for this to settle :) taking it now. Thanks! Willy

Re: [PATCHv3] openssl-compat: Fix getm_ defines

2019-12-20 Thread Lukas Tribus
On Thu, 19 Dec 2019 at 21:54, Rosen Penev wrote: > > LIBRESSL_VERSION_NUMBER evaluates to 0 under OpenSSL, making the condition > always true. Check for the define before checking it. > > Signed-off-by: Rosen Penev > --- > v3: Added BoringSSL support > v2: Switched to HA_OPENSSL_VERSION_NUMBER

[PATCHv3] openssl-compat: Fix getm_ defines

2019-12-19 Thread Rosen Penev
LIBRESSL_VERSION_NUMBER evaluates to 0 under OpenSSL, making the condition always true. Check for the define before checking it. Signed-off-by: Rosen Penev --- v3: Added BoringSSL support v2: Switched to HA_OPENSSL_VERSION_NUMBER as it's cleaner. include/common/openssl-compat.h | 3 ++- 1 file