Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

Hello, 2017-11-21 11:18 GMT+01:00 Willy Tarreau : >> That's not it, the hold-off timer is only a consequence of this >> problem. > > OK but if it's really 100ms, it can be a problem for people loading GeoIP > maps of millions of entries, or large configs (the largest I saw had

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

On Tue, Nov 21, 2017 at 11:28:55AM +0100, Willy Tarreau wrote: > On Tue, Nov 21, 2017 at 11:19:41AM +0100, William Lallemand wrote: > > I don't like the idea of the "daemon" keyword being ignored, > > We already do that with -D which ignores "debug" for example. The command > line purposely has

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

On Tue, Nov 21, 2017 at 11:12:45AM +0100, Lukas Tribus wrote: > Hello, > > 2017-11-21 8:39 GMT+01:00 William Lallemand : > > That's not it, the hold-off timer is only a consequence of this > problem. I believe the notification does not work in my case, which is > why for

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

Hi Lukas, On Tue, Nov 21, 2017 at 11:12:45AM +0100, Lukas Tribus wrote: > > I suggest we configure it to a greater value per default, it can be set to > > infinity too, but I don't like the idea. > > That's not it, the hold-off timer is only a consequence of this > problem. OK but if it's

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

Hello, 2017-11-21 8:39 GMT+01:00 William Lallemand : > On Tue, Nov 21, 2017 at 07:16:19AM +0100, Willy Tarreau wrote: >> >> I really don't like this. My fears with becoming more systemd-friendly >> was that we'd make users helpless when something decides not to work >>

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

On Tue, Nov 21, 2017 at 07:16:19AM +0100, Willy Tarreau wrote: > > I really don't like this. My fears with becoming more systemd-friendly > was that we'd make users helpless when something decides not to work > just to annoy them, and this reports seems to confirm this feeling :-/ > > Tim, have

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

Hi Lukas, On Tue, Nov 21, 2017 at 01:12:10AM +0100, Lukas Tribus wrote: > 2017-11-20 15:58 GMT+01:00 Tim Düsterhus : > > From: Tim Duesterhus > > > > This patch adds support for `Type=notify` to the systemd unit. > > > > Supporting `Type=notify` improves

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

Hello Tim, 2017-11-20 15:58 GMT+01:00 Tim Düsterhus : > From: Tim Duesterhus > > This patch adds support for `Type=notify` to the systemd unit. > > Supporting `Type=notify` improves both starting as well as reloading > of the unit, because systemd will be

Re: [PATCH v3 1/1] MEDIUM: mworker: Add systemd `Type=notify` support

On Mon, Nov 20, 2017 at 03:58:35PM +0100, Tim Düsterhus wrote: > From: Tim Duesterhus > > This patch adds support for `Type=notify` to the systemd unit. Looks good to me, thanks! Willy can you merge it? -- William Lallemand