[
https://issues.apache.org/jira/browse/HDFS-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056713#comment-15056713
]
James Clampffer commented on HDFS-9538:
---
"To be able to re-use the calculations for Java classpaths
[
https://issues.apache.org/jira/browse/HDFS-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053649#comment-15053649
]
James Clampffer commented on HDFS-9537:
---
Thanks for the updates!
"The rapidxml library modifies the
[
https://issues.apache.org/jira/browse/HDFS-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053497#comment-15053497
]
James Clampffer commented on HDFS-9537:
---
"Have thing public methods that call into a template to do
[
https://issues.apache.org/jira/browse/HDFS-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053555#comment-15053555
]
James Clampffer commented on HDFS-9538:
---
Just a little early feedback based on a quick look. Once
[
https://issues.apache.org/jira/browse/HDFS-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051140#comment-15051140
]
James Clampffer commented on HDFS-9523:
---
Yep, just checked.
> libhdfs++: failure to connect to ipv6
[
https://issues.apache.org/jira/browse/HDFS-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049494#comment-15049494
]
James Clampffer commented on HDFS-9523:
---
[~bobthansen] - I was able to get the shim test to fail
[
https://issues.apache.org/jira/browse/HDFS-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9523:
--
Attachment: failed_docker_run.txt
> libhdfs++: failure to connect to ipv6 host causes CI unit
[
https://issues.apache.org/jira/browse/HDFS-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047015#comment-15047015
]
James Clampffer commented on HDFS-9489:
---
Thanks for the patch Stephen! This will help prevent a lot
[
https://issues.apache.org/jira/browse/HDFS-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047009#comment-15047009
]
James Clampffer commented on HDFS-9460:
---
+1
Thanks for the rebase, apologies for not reviewing it
[
https://issues.apache.org/jira/browse/HDFS-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047033#comment-15047033
]
James Clampffer commented on HDFS-9417:
---
Looks good to me, will be nice to see some more green text
[
https://issues.apache.org/jira/browse/HDFS-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9417:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to HDFS-8707.
[
https://issues.apache.org/jira/browse/HDFS-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9460:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to HDFS-8707.
[
https://issues.apache.org/jira/browse/HDFS-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9489:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to HDFS-8707.
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045022#comment-15045022
]
James Clampffer commented on HDFS-9486:
---
That's odd considering how tiny this patch is. The local
[
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9228:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Looks good to me, +1.
I've
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045582#comment-15045582
]
James Clampffer commented on HDFS-9486:
---
I didn't expect this patch to fix the issue with the CI
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045596#comment-15045596
]
James Clampffer commented on HDFS-9486:
---
Given that this falls into [~bobhansen]'s former case I went
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> libhdfs++ Fix valgrind
[
https://issues.apache.org/jira/browse/HDFS-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045607#comment-15045607
]
James Clampffer commented on HDFS-9464:
---
Thanks for the info [~aw]! I'm hoping to get to this in the
[
https://issues.apache.org/jira/browse/HDFS-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045606#comment-15045606
]
James Clampffer commented on HDFS-9464:
---
Thanks for the info [~aw]! I'm hoping to get to this in the
[
https://issues.apache.org/jira/browse/HDFS-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045689#comment-15045689
]
James Clampffer commented on HDFS-9465:
---
Thanks for the help [~aw]!
"IIRC, I built on OS X after
[
https://issues.apache.org/jira/browse/HDFS-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045873#comment-15045873
]
James Clampffer commented on HDFS-9460:
---
Looks good to me. Would you mind rebasing it? It doesn't
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Summary: libhdfs++ Fix valgrind failures when using more than 1 io_service
worker thread. (was:
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Attachment: HDFS-9486.HDFS-8707.001.patch
Thanks for the review [~bobthansen].
Added new patch;
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Attachment: HDFS-9486.HDFS-8707.000.patch
Attached patch.
The issue here was stale code meant
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Status: Patch Available (was: Open)
> Valgrind failures when using more than 1 io_service
[
https://issues.apache.org/jira/browse/HDFS-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9504:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> libhdfs++ Initialize
[
https://issues.apache.org/jira/browse/HDFS-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042199#comment-15042199
]
James Clampffer commented on HDFS-9504:
---
Thanks for the review Bob, I've committed this to HDFS-8707.
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037729#comment-15037729
]
James Clampffer commented on HDFS-9144:
---
Thanks for reviewing the rebase [~bobthansen]. I've
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9144:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Refactor libhdfs into
[
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037877#comment-15037877
]
James Clampffer commented on HDFS-9228:
---
Thanks for the updates [~bobthansen], would you mind
[
https://issues.apache.org/jira/browse/HDFS-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9504:
--
Status: Patch Available (was: Open)
> libhdfs++ Initialize BadNodeTracker in FileSystemImpl
[
https://issues.apache.org/jira/browse/HDFS-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038656#comment-15038656
]
James Clampffer commented on HDFS-9497:
---
Committed to HDFS-8707. Thanks for the patch Bob!
>
[
https://issues.apache.org/jira/browse/HDFS-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9497:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> libhdfs++: move
[
https://issues.apache.org/jira/browse/HDFS-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9504:
--
Attachment: HDFS-9504.HDFS-8707.000.patch
Attached fix, just adds a BadDataNodeTracker to the
James Clampffer created HDFS-9504:
-
Summary: libhdfs++ Initialize BadNodeTracker in FileSystemImpl
constructor
Key: HDFS-9504
URL: https://issues.apache.org/jira/browse/HDFS-9504
Project: Hadoop HDFS
[
https://issues.apache.org/jira/browse/HDFS-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9486:
--
Attachment: HDFS-9486-stacks-sanitized.txt
Attached a set of stacks to give a snapshot of what
[
https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036601#comment-15036601
]
James Clampffer commented on HDFS-9448:
---
This looks good to me, but I'd like to get a +1 from [~aw]
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9144:
--
Attachment: HDFS-9144.HDFS-8707.006.patch
I took a stab at rebasing this to the head to get it
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036541#comment-15036541
]
James Clampffer commented on HDFS-9144:
---
And by HDFS-9559 I meant HDFS-9359.
> Refactor libhdfs into
[
https://issues.apache.org/jira/browse/HDFS-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036561#comment-15036561
]
James Clampffer commented on HDFS-9497:
---
Seems straightforward to me. +1.
I plan on committing
[
https://issues.apache.org/jira/browse/HDFS-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9464:
--
Assignee: (was: James Clampffer)
> Documentation needs to be exposed
>
James Clampffer created HDFS-9489:
-
Summary: Enable CI infrasructure to use libhdfs++ hdfsRead
Key: HDFS-9489
URL: https://issues.apache.org/jira/browse/HDFS-9489
Project: Hadoop HDFS
Issue
[
https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033970#comment-15033970
]
James Clampffer commented on HDFS-9448:
---
Thanks for the patch Bob. Everything looks good to me.
[
https://issues.apache.org/jira/browse/HDFS-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9465:
--
Assignee: (was: James Clampffer)
> No header files in mvn package
>
[
https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033986#comment-15033986
]
James Clampffer commented on HDFS-9448:
---
I'll roll it back then.
> Enable valgrind for libhdfspp
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032026#comment-15032026
]
James Clampffer commented on HDFS-9452:
---
Committed to HDFS-8707.
Thanks for the pointer to std::tie
James Clampffer created HDFS-9487:
-
Summary: libhdfs++ Enable builds with no compiler optimizations
Key: HDFS-9487
URL: https://issues.apache.org/jira/browse/HDFS-9487
Project: Hadoop HDFS
[
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032635#comment-15032635
]
James Clampffer commented on HDFS-9228:
---
Looks good to me, just found 2 small things worth fixing.
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9452:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> libhdfs++ Fix memory stomp
James Clampffer created HDFS-9486:
-
Summary: Valgrind failures when using more than 1 io_service
worker thread.
Key: HDFS-9486
URL: https://issues.apache.org/jira/browse/HDFS-9486
Project: Hadoop
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9117:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to HDFS-8707.
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9452:
--
Attachment: HDFS-9452.HDFS-8707.001.patch
New patch to use std::tuple in the synchronized
[
https://issues.apache.org/jira/browse/HDFS-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026875#comment-15026875
]
James Clampffer commented on HDFS-9464:
---
Hi Allen,
Is there a canonical example of a subproject that
[
https://issues.apache.org/jira/browse/HDFS-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer reassigned HDFS-9465:
-
Assignee: James Clampffer
> No header files in mvn package
>
[
https://issues.apache.org/jira/browse/HDFS-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026865#comment-15026865
]
James Clampffer commented on HDFS-9465:
---
Hi Allen, thanks for reporting this!
Where are header files
[
https://issues.apache.org/jira/browse/HDFS-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer reassigned HDFS-9464:
-
Assignee: James Clampffer
> Documentation needs to be exposed
>
[
https://issues.apache.org/jira/browse/HDFS-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025635#comment-15025635
]
James Clampffer commented on HDFS-9359:
---
I just committed this. Thanks Stephen!
> Test libhdfs++
[
https://issues.apache.org/jira/browse/HDFS-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9359:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Note: Until HDFS-9452 is
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025256#comment-15025256
]
James Clampffer commented on HDFS-9117:
---
+1.
I'll get this committed soon. There's a substantial
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025577#comment-15025577
]
James Clampffer commented on HDFS-9368:
---
Committed this earlier today.
> Implement reads with
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9368:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Implement reads with
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024662#comment-15024662
]
James Clampffer commented on HDFS-9452:
---
Good point Bob, I'll get another patch up soon that does
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022627#comment-15022627
]
James Clampffer commented on HDFS-9144:
---
"It's to ensure that the BlockReaderImpl's lifecycle is tied
James Clampffer created HDFS-9452:
-
Summary: libhdfs++ Fix memory stomp in OpenFileForRead.
Key: HDFS-9452
URL: https://issues.apache.org/jira/browse/HDFS-9452
Project: Hadoop HDFS
Issue
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9452:
--
Attachment: HDFS-9452.HDFS-8707.000.patch
Value of promise was being set before other other
[
https://issues.apache.org/jira/browse/HDFS-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9452:
--
Status: Patch Available (was: Open)
> libhdfs++ Fix memory stomp in OpenFileForRead.
>
James Clampffer created HDFS-9453:
-
Summary: Fix protobuf runtime warnings
Key: HDFS-9453
URL: https://issues.apache.org/jira/browse/HDFS-9453
Project: Hadoop HDFS
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022414#comment-15022414
]
James Clampffer commented on HDFS-9117:
---
Feedback for patch 17:
-Needs to be updated to head, patch
[
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022959#comment-15022959
]
James Clampffer commented on HDFS-9228:
---
Thanks for the updates!
"The shared_this is to maintain the
[
https://issues.apache.org/jira/browse/HDFS-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023080#comment-15023080
]
James Clampffer commented on HDFS-9359:
---
That's a nice trick. Looks good to me. +1
Will commit
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018585#comment-15018585
]
James Clampffer commented on HDFS-9144:
---
The rebased changes look good to me. Hopefully the changes
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014569#comment-15014569
]
James Clampffer commented on HDFS-9144:
---
Some feedback, as well as some questions to make sure I
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013752#comment-15013752
]
James Clampffer commented on HDFS-9368:
---
Nice, thanks.
I'm not able to commit at the moment because
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9368:
--
Attachment: HDFS-9368.HDFS-8707.002.patch
New patch:
-file ops return status rather than posix
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9368:
--
Attachment: HDFS-9368.HDFS-8707.003.patch
Thanks for the feedback [~wheat9], I wasn't sure which
[
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008979#comment-15008979
]
James Clampffer commented on HDFS-9228:
---
Some comments, mostly small stuff:
It looks like
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009787#comment-15009787
]
James Clampffer commented on HDFS-9368:
---
Thanks for the feedback!
"Instead of returning -1, these
[
https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9103:
--
Attachment: HDFS-9103.HDFS-8707.010.patch
Thanks for the clarification [~wheat9]
New patch
[
https://issues.apache.org/jira/browse/HDFS-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer reassigned HDFS-9227:
-
Assignee: James Clampffer
> Check block checksums for integrity
>
[
https://issues.apache.org/jira/browse/HDFS-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer reassigned HDFS-9271:
-
Assignee: James Clampffer
> Implement basic NN operations
> -
[
https://issues.apache.org/jira/browse/HDFS-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9271:
--
Assignee: Aliaksei Sandryhaila (was: James Clampffer)
> Implement basic NN operations
>
[
https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007307#comment-15007307
]
James Clampffer commented on HDFS-9103:
---
"It can be moved into the bindings/c instead of being a
[
https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9103:
--
Attachment: HDFS-9103.HDFS-8707.009.patch
New patch:
-Addessed [~bobthansen]'s concerns about
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9368:
--
Attachment: HDFS-9368.HDFS-8707.001.patch
New patch:
-Added bounds checks, turns out
[
https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002298#comment-15002298
]
James Clampffer commented on HDFS-9419:
---
Not much to it. Looks good to me.
+1
> Add Optional class
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9328:
--
Attachment: HDFS-9328.HDFS-8707.004.patch
New patch:
-added ASF license like
[
https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002302#comment-15002302
]
James Clampffer commented on HDFS-9408:
---
Looks good to me.
+1
> extend the build system to produce
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000646#comment-15000646
]
James Clampffer commented on HDFS-9328:
---
"The markdown doesn't seem to be rendered correctly under
[
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9368:
--
Status: Patch Available (was: Open)
Simple patch to unblock HDFS-9359.
I think doing the
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9328:
--
Attachment: HDFS-9328.HDFS-8707.003.patch
-fixed markdown so that it looks nice in atom as well
[
https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9103:
--
Attachment: HDFS-9103.HDFS-8707.008.patch
I still need to get rid of some test duplication and
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9328:
--
Attachment: HDFS-9328.HDFS-8707.002.patch
Get rid of trailing whitespace
> Formalize coding
[
https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997890#comment-14997890
]
James Clampffer commented on HDFS-9103:
---
Thanks for taking a look! I was hoping for some feedback
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997424#comment-14997424
]
James Clampffer commented on HDFS-9144:
---
There's a few things I like about this:
-std::function for
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994193#comment-14994193
]
James Clampffer commented on HDFS-9328:
---
Good idea on the markdown.
I'd really like this to be a
[
https://issues.apache.org/jira/browse/HDFS-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993919#comment-14993919
]
James Clampffer commented on HDFS-9144:
---
We're using this branch as an opportunity to try using
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994179#comment-14994179
]
James Clampffer commented on HDFS-9328:
---
I'll change it to markdown as you and [~wheat9] suggested.
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9328:
--
Attachment: HDFS-9328.HDFS-8707.001.patch
New Patch:
-left in clang-format
-changed name to
[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-9328:
--
Attachment: HDFS-9328.HDFS-8707.000.patch
I've put together basic coding requirements based on
701 - 800 of 918 matches
Mail list logo
