[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590698#comment-16590698
]
Hudson commented on HDDS-328:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14821 (See
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590491#comment-16590491
]
genericqa commented on HDDS-328:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590428#comment-16590428
]
Xiaoyu Yao commented on HDDS-328:
-
Thanks [~elek] for the update. +1 pending Jenkins.
> Support export and
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590378#comment-16590378
]
Elek, Marton commented on HDDS-328:
---
WOW. Didn't know that the Preconditions checks have return values.
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589170#comment-16589170
]
Xiaoyu Yao commented on HDDS-328:
-
[~elek], thanks for the update and investigation.
The findbugsExclude
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589005#comment-16589005
]
genericqa commented on HDDS-328:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588686#comment-16588686
]
genericqa commented on HDDS-328:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588586#comment-16588586
]
Elek, Marton commented on HDDS-328:
---
This is a false positive warning and I didn't find any workaround.
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587606#comment-16587606
]
Elek, Marton commented on HDDS-328:
---
Working on the last remaining issue. Will be fixed soon
>
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583755#comment-16583755
]
genericqa commented on HDDS-328:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583428#comment-16583428
]
Xiaoyu Yao commented on HDDS-328:
-
Thanks [~elek] for the update. The patch v4 looks excellent to me.
Can
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582442#comment-16582442
]
genericqa commented on HDDS-328:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582375#comment-16582375
]
Elek, Marton commented on HDDS-328:
---
Thank you [~hanishakoneru] and [~xyao] the review comments. In the
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581281#comment-16581281
]
Xiaoyu Yao commented on HDDS-328:
-
Thanks [~elek] for working on this. The patch v3 looks excellent to me
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576956#comment-16576956
]
Hanisha Koneru commented on HDDS-328:
-
Thanks [~elek] for updating the patch.
The patch LGTM overall.
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574933#comment-16574933
]
genericqa commented on HDDS-328:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574842#comment-16574842
]
Elek, Marton commented on HDDS-328:
---
Thank you the very valuable review for both of you.
I uploaded the
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572447#comment-16572447
]
Hanisha Koneru commented on HDDS-328:
-
Thanks [~elek] for working on this improvement.
A few comments:
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572403#comment-16572403
]
Bharat Viswanadham commented on HDDS-328:
-
Few questions:
1. In KeyValueHandler
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572385#comment-16572385
]
Bharat Viswanadham commented on HDDS-328:
-
Hi [~elek]
Thanks for the patch. Overall patch LGTM.
[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570356#comment-16570356
]
genericqa commented on HDDS-328:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
21 matches
Mail list logo