[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794909#comment-16794909
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Thank you, [~Sammi].
> Detect Ozone Network topology
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794886#comment-16794886
]
Hudson commented on HDDS-699:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16227 (See
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794857#comment-16794857
]
Sammi Chen commented on HDDS-699:
-
Yes, the test failures are not relative. I will commit the patch to
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794735#comment-16794735
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794683#comment-16794683
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
+1 the 09 patch looks good.
The test failures do not
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794441#comment-16794441
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793352#comment-16793352
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
> ... In testConcurrentAccess, all the individual
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793279#comment-16793279
]
Sammi Chen commented on HDDS-699:
-
Hi [~szetszwo], thanks very much for all your time to review the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793055#comment-16793055
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
The 08 patch look good other than the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793053#comment-16793053
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Tried to run TestNetworkTopologyImpl locally. There
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792422#comment-16792422
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792372#comment-16792372
]
Sammi Chen commented on HDDS-699:
-
08.patch fixed the issues reported by check style.
> Detect Ozone
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791830#comment-16791830
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791774#comment-16791774
]
Sammi Chen commented on HDDS-699:
-
bq. In InnerNodeImpl.getNode(String loc), we should first check if loc
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791100#comment-16791100
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Some final comments:
- There are some code duplication
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791097#comment-16791097
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Just found that NetUtils.removeDuplicate has already
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791051#comment-16791051
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Thanks [~Sammi] for the 06 patch. The example in the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790825#comment-16790825
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790752#comment-16790752
]
Sammi Chen commented on HDDS-699:
-
[~szetszwo], thanks for the further information. 06.patch addressed all
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787126#comment-16787126
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
> I think here you mean getAncestorCounts. ...
I do
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786885#comment-16786885
]
Sammi Chen commented on HDDS-699:
-
Thanks [~szetszwo] for such detail comments. Yes, getLeaf() in
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786253#comment-16786253
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Some other comments:
- Move getNumOfLeaves() from
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786248#comment-16786248
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Thanks [~Sammi]. Just found that the logic for
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785646#comment-16785646
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785569#comment-16785569
]
Sammi Chen commented on HDDS-699:
-
05.patch addressed the concerns [~szetszwo] raised so far, rebased
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784986#comment-16784986
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Some initial comments on the 04 patch. (will continue
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784979#comment-16784979
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784948#comment-16784948
]
Arpit Agarwal commented on HDDS-699:
This compile error was just fixed by HDDS-1218.
> Detect Ozone
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784946#comment-16784946
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
> cp: cannot stat
>
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784122#comment-16784122
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784040#comment-16784040
]
Sammi Chen commented on HDDS-699:
-
Hi [~szetszwo], thanks for the time. 04.patch is uploaded to address
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783831#comment-16783831
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
[~Sammi], I have checked the 03 patch. It looks good
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783674#comment-16783674
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783561#comment-16783561
]
Sammi Chen commented on HDDS-699:
-
Changes in 03. patch,
# add Network Topology interface
# use single
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780842#comment-16780842
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
> ... I think it's a trade off between performance
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780445#comment-16780445
]
Sammi Chen commented on HDDS-699:
-
Hi [~szetszwo], thanks for the comments. I think it's a trade off
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777522#comment-16777522
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
[~Sammi] thanks for the update. Thanks for adding many
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771543#comment-16771543
]
Sammi Chen commented on HDDS-699:
-
Thanks [~szetszwo] and [~xyao] for the great suggestion. I uploaded 02
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755460#comment-16755460
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Two suggestions:
# Move the root level locking to the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755329#comment-16755329
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
> ... For the NetworkTopology performance, at the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754644#comment-16754644
]
Sammi Chen commented on HDDS-699:
-
Hi [~szetszwo], thanks for the comments. For the NetworkTopology
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754403#comment-16754403
]
Tsz Wo Nicholas Sze commented on HDDS-699:
--
Thanks [~Sammi] for working the patch. Some
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753814#comment-16753814
]
Sammi Chen commented on HDDS-699:
-
[~xyao], thanks for your time.
{quote}
Line 72: do we really want to
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753763#comment-16753763
]
Sammi Chen commented on HDDS-699:
-
Hi [~junjie], thanks for your review and feedbacks.
{code:java}
+
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753757#comment-16753757
]
Sammi Chen commented on HDDS-699:
-
Hi [~linyiqun] thanks for the review effort.
{quote}Can we address
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752183#comment-16752183
]
Yiqun Lin commented on HDDS-699:
For the unit test, some comments from me:
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751901#comment-16751901
]
Xiaoyu Yao commented on HDDS-699:
-
Thanks [~Sammi] for working on this. Patch v2 LGTM overall. Here are
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748482#comment-16748482
]
Junjie Chen commented on HDDS-699:
--
Thanks Sammi,
Just finish basic first round, some comments below:
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747999#comment-16747999
]
Yiqun Lin commented on HDDS-699:
Thanks [~Sammi]. I am still reviewing some details of this patch. It looks
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747625#comment-16747625
]
Sammi Chen commented on HDDS-699:
-
Hi [~linyiqun], thanks for your good suggestion. Normally I will go with
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745760#comment-16745760
]
Yiqun Lin commented on HDDS-699:
Thanks for the hard-work, [~Sammi]! Haven't looked into details, but the
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744980#comment-16744980
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744911#comment-16744911
]
Sammi Chen commented on HDDS-699:
-
Fix check style issues and failed test
> Detect Ozone Network topology
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744003#comment-16744003
]
Hadoop QA commented on HDDS-699:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743952#comment-16743952
]
Sammi Chen commented on HDDS-699:
-
Separate patch for detect ozone network topology. Multiple layer
55 matches
Mail list logo
