[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742651#comment-16742651
]
Dinesh Chitlangia commented on HDDS-960:
Thanks all for review and [~bharatviswa] f
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742601#comment-16742601
]
Bharat Viswanadham commented on HDDS-960:
-
+1 LGTM.
A minor comment in the doc, use
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742577#comment-16742577
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742540#comment-16742540
]
Dinesh Chitlangia commented on HDDS-960:
[~bharatviswa] Attached patch 05 with docs
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742518#comment-16742518
]
Bharat Viswanadham commented on HDDS-960:
-
Hi [~dineshchitlangia]
One thing is miss
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742516#comment-16742516
]
Bharat Viswanadham commented on HDDS-960:
-
Thank You [~dineshchitlangia] for addres
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740046#comment-16740046
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740016#comment-16740016
]
Dinesh Chitlangia commented on HDDS-960:
Patch 04 fixes checkstyle violations, test
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739844#comment-16739844
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739824#comment-16739824
]
Dinesh Chitlangia commented on HDDS-960:
[~ajayydv] Thanks for review comments.
For
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739807#comment-16739807
]
Ajay Kumar commented on HDDS-960:
-
[~dineshchitlangia] thanks for the updated patch. LGTM.
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739150#comment-16739150
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739108#comment-16739108
]
Dinesh Chitlangia commented on HDDS-960:
[~bharatviswa] Attached patch 02 to addres
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739034#comment-16739034
]
Bharat Viswanadham commented on HDDS-960:
-
Hi,
Thank You [~dineshchitlangia] for th
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737744#comment-16737744
]
Dinesh Chitlangia commented on HDDS-960:
failures unrelated to patch. these test fa
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737657#comment-16737657
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737604#comment-16737604
]
Dinesh Chitlangia commented on HDDS-960:
[~bharatviswa] Yeah, my bad. Patch 02 was
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737539#comment-16737539
]
Bharat Viswanadham commented on HDDS-960:
-
Hi [~dineshchitlangia]
This should be p
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736755#comment-16736755
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736743#comment-16736743
]
Dinesh Chitlangia commented on HDDS-960:
Attached patch 02 to address checkstyle is
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736726#comment-16736726
]
Hadoop QA commented on HDDS-960:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Su
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736294#comment-16736294
]
Dinesh Chitlangia commented on HDDS-960:
[~bharatviswa] Yes, I also checked with [~
[
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733626#comment-16733626
]
Bharat Viswanadham commented on HDDS-960:
-
Instead of passing the username and have
23 matches
Mail list logo
