[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398322#comment-16398322
]
Hudson commented on HDFS-12773:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13833 (See
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398035#comment-16398035
]
Íñigo Goiri commented on HDFS-12773:
{quote}
Failed unit test are not related. I'd like to help commit
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398023#comment-16398023
]
Yiqun Lin commented on HDFS-12773:
--
Failed unit test are not related. I'd like to help commit this.
>
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398007#comment-16398007
]
Yiqun Lin commented on HDFS-12773:
--
LGTM, +1.
> RBF: Improve State Store FS implementation
>
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397596#comment-16397596
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397376#comment-16397376
]
Íñigo Goiri commented on HDFS-12773:
Trunk is broken right now.
The error was introduced in HDFS-12505
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397348#comment-16397348
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397276#comment-16397276
]
Íñigo Goiri commented on HDFS-12773:
Thanks, [~linyiqun] for the comments. Uploaded
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396618#comment-16396618
]
Yiqun Lin commented on HDFS-12773:
--
Hi [~elgoiri], thanks for your comments. Comments make sense to me.
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396498#comment-16396498
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396250#comment-16396250
]
Íñigo Goiri commented on HDFS-12773:
[~ywskycn], {{TestStateStoreFileBase}} now fails because of the
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396242#comment-16396242
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395887#comment-16395887
]
Wei Yan commented on HDFS-12773:
+1 for [^HDFS-12773.005.patch]
> RBF: Improve State Store FS
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395879#comment-16395879
]
Íñigo Goiri commented on HDFS-12773:
Uploaded [^HDFS-12773.005.patch] for the warn message.
I also
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395836#comment-16395836
]
Wei Yan commented on HDFS-12773:
{noformat}
It looks to me like a very particular implementation detail.
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395825#comment-16395825
]
Íñigo Goiri commented on HDFS-12773:
Thanks [~ywskycn] for the comments, updated it in
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395670#comment-16395670
]
Wei Yan commented on HDFS-12773:
Thanks for the patch, [~elgoiri] .
Some minors on
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395435#comment-16395435
]
Íñigo Goiri commented on HDFS-12773:
Thanks [~linyiqun] for the comments.
Basically the change is to
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395005#comment-16395005
]
Yiqun Lin commented on HDFS-12773:
--
Hi [~elgoiri], I just take a quick look of the patch, some places not
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393744#comment-16393744
]
Íñigo Goiri commented on HDFS-12773:
The failed unit tests are unrelated.
The related unit tests were
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393702#comment-16393702
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393373#comment-16393373
]
Íñigo Goiri commented on HDFS-12773:
[~zhengxg3] encountered this issue again.
I posted
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290296#comment-16290296
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290090#comment-16290090
]
genericqa commented on HDFS-12773:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238117#comment-16238117
]
Íñigo Goiri commented on HDFS-12773:
In addition to the safer FS implementation:
* Added the test
[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238076#comment-16238076
]
Íñigo Goiri commented on HDFS-12773:
Internally, we use the ZooKeeper implementation from HDFS-10631.
26 matches
Mail list logo
