[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728492#comment-16728492 ] Hudson commented on HDFS-14146: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15662 (See

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-14 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721821#comment-16721821 ] Erik Krogen commented on HDFS-14146: +1. Thanks for this [~csun]! I just committed it to branch

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721811#comment-16721811 ] Hadoop QA commented on HDFS-14146: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-14 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721675#comment-16721675 ] Chao Sun commented on HDFS-14146: - Attached patch v3 to address the checkstyle issues as well as removing

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720672#comment-16720672 ] Hadoop QA commented on HDFS-14146: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720615#comment-16720615 ] Hadoop QA commented on HDFS-14146: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720569#comment-16720569 ] Erik Krogen commented on HDFS-14146: +1 from me pending Jenkins. Thanks [~csun]! > Handle exception

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720518#comment-16720518 ] Chao Sun commented on HDFS-14146: - Thanks [~xkrogen]. Attached patch v2 to address the comments. >

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720468#comment-16720468 ] Erik Krogen commented on HDFS-14146: Nice job [~csun], this looks great! I have a few very minor

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-13 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720451#comment-16720451 ] Chao Sun commented on HDFS-14146: - Thanks [~vagarychen]. Uploaded patch v1 to address the comments. >

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719675#comment-16719675 ] Hadoop QA commented on HDFS-14146: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719613#comment-16719613 ] Chen Liang commented on HDFS-14146: --- This is a good discussion and good point on the deadlock

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719587#comment-16719587 ] Erik Krogen commented on HDFS-14146: {quote} I couldn't come up with an example (It would be great if

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719577#comment-16719577 ] Chao Sun commented on HDFS-14146: - Thanks [~vagarychen] and [~xkrogen] for the quick response. {quote}in

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719583#comment-16719583 ] Chao Sun commented on HDFS-14146: - {quote} We may need a way to indicate to {{doResponse()}}  ... {quote}

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719556#comment-16719556 ] Chen Liang commented on HDFS-14146: --- Thanks [~csun] for reporting! Interesting...in what situation did

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719557#comment-16719557 ] Erik Krogen commented on HDFS-14146: Hey [~csun], this is a good find. I actually think this problem

[jira] [Commented] (HDFS-14146) Handle exception from internalQueueCall

2018-12-12 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719542#comment-16719542 ] Chao Sun commented on HDFS-14146: - Attached patch v0 to return a proper response to client when error