[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906748#comment-16906748
]
Hudson commented on HDFS-14625:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17109 (See
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906449#comment-16906449
]
Wei-Chiu Chuang commented on HDFS-14625:
+1
> Make DefaultAuditLogger class in FSnamesystem to
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904825#comment-16904825
]
hemanthboyina commented on HDFS-14625:
--
updated the patch
please check [~jojochuang]
> Make
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904107#comment-16904107
]
Wei-Chiu Chuang commented on HDFS-14625:
[~hemanthboyina] patch no longer applies. would you mind
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887807#comment-16887807
]
hemanthboyina commented on HDFS-14625:
--
yes [~elgoiri] , TestDirectoryScanner was even failing in
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885393#comment-16885393
]
Íñigo Goiri commented on HDFS-14625:
TestDirectoryScanner has been consistently failing in all the
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884169#comment-16884169
]
Íñigo Goiri commented on HDFS-14625:
Having the fields as protected is better than public.
Checkstyle
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884152#comment-16884152
]
Hadoop QA commented on HDFS-14625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884019#comment-16884019
]
hemanthboyina commented on HDFS-14625:
--
thanks [~elgoiri]
the check style issues are of visibility
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883129#comment-16883129
]
Íñigo Goiri commented on HDFS-14625:
Makes sense, let's avoid touching HdfsAuditLogger and
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883104#comment-16883104
]
hemanthboyina commented on HDFS-14625:
--
thanks [~elgoiri] for the comments
* _I know it is
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881394#comment-16881394
]
Íñigo Goiri commented on HDFS-14625:
Thanks [~hemanthboyina] for the changes:
* I know it is painful
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880925#comment-16880925
]
hemanthboyina commented on HDFS-14625:
--
submitted patch with new changes made
please check
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880636#comment-16880636
]
Hadoop QA commented on HDFS-14625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879761#comment-16879761
]
Íñigo Goiri commented on HDFS-14625:
[~hemanthboyina], nothing major, just that now you have:
{code}
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879666#comment-16879666
]
hemanthboyina commented on HDFS-14625:
--
thanks [~elgoiri] for your review and suggestions
have
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879443#comment-16879443
]
Íñigo Goiri commented on HDFS-14625:
As we are moving it to a separate class, I think we can use this
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878855#comment-16878855
]
Hadoop QA commented on HDFS-14625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878124#comment-16878124
]
Íñigo Goiri commented on HDFS-14625:
It would be nice to extend the description of the
[
https://issues.apache.org/jira/browse/HDFS-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878103#comment-16878103
]
Hadoop QA commented on HDFS-14625:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
