[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135841#comment-17135841
]
Hadoop QA commented on HDFS-15346:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135819#comment-17135819
]
Yiqun Lin commented on HDFS-15346:
--
[~LiJinglun], the refactor looks great. I find you decrease the
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135615#comment-17135615
]
Jinglun commented on HDFS-15346:
Your are genius [~linyiqun] ! Thanks your brilliant comments, the
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135024#comment-17135024
]
Yiqun Lin commented on HDFS-15346:
--
[~LiJinglun], thanks for addressing remaining comments.
These two
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134195#comment-17134195
]
Hadoop QA commented on HDFS-15346:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134069#comment-17134069
]
Jinglun commented on HDFS-15346:
Hi [~linyiqun], thanks your great comments ! Follow all your advices.
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130903#comment-17130903
]
Yiqun Lin commented on HDFS-15346:
--
[~LiJinglun] , thanks for addressing the comments, almost looks good
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130351#comment-17130351
]
Hadoop QA commented on HDFS-15346:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130008#comment-17130008
]
Jinglun commented on HDFS-15346:
Upload v09, fix unit test.
> RBF: DistCpFedBalance implementation
>
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129686#comment-17129686
]
Hadoop QA commented on HDFS-15346:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129283#comment-17129283
]
Jinglun commented on HDFS-15346:
Upload v08. All the comments are fixed except the 'read only in normal
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128305#comment-17128305
]
Jinglun commented on HDFS-15346:
Hi [~linyiqun], thanks your great comments and valuable suggestions !
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127498#comment-17127498
]
Yiqun Lin commented on HDFS-15346:
--
Review comments for unit tests:
*TestDistCpProcedure.java*
# Use
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127489#comment-17127489
]
Yiqun Lin commented on HDFS-15346:
--
Some more detailed review comments:
*HdfsConstants.java*
Can we
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126332#comment-17126332
]
Yiqun Lin commented on HDFS-15346:
--
Will give detailed review on this weekend, [~LiJinglun].
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125790#comment-17125790
]
Jinglun commented on HDFS-15346:
Hi [~linyiqun], v07 has passed the tests. Could you help to review it.
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124637#comment-17124637
]
Hadoop QA commented on HDFS-15346:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124152#comment-17124152
]
Hadoop QA commented on HDFS-15346:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123824#comment-17123824
]
Jinglun commented on HDFS-15346:
Upload v06 fix checkstyle and unit tests.
> RBF: DistCpFedBalance
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123467#comment-17123467
]
Yiqun Lin commented on HDFS-15346:
--
[~LiJinglun], can you fix related failure ut and generated
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123441#comment-17123441
]
Hadoop QA commented on HDFS-15346:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121517#comment-17121517
]
Jinglun commented on HDFS-15346:
Hi [~linyiqun], thanks your great comments ! Yes it is a big patch,
[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120981#comment-17120981
]
Yiqun Lin commented on HDFS-15346:
--
Hi [~LiJinglun] , some initial review comments from me:
23 matches
Mail list logo
