[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-12-01 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508011#comment-13508011 ] Daryn Sharp commented on HDFS-4248: --- Odd, I was having some renames rewrite paths to nest

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-12-01 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508033#comment-13508033 ] Kihwal Lee commented on HDFS-4248: -- Since the leases are used to track all

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-12-01 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508035#comment-13508035 ] Daryn Sharp commented on HDFS-4248: --- bq. As for what happens to the leases after renaming

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507783#comment-13507783 ] Daryn Sharp commented on HDFS-4248: --- The code for renaming and leasing handling is

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507785#comment-13507785 ] Daryn Sharp commented on HDFS-4248: --- I should mention that pushing the change lease calls

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507840#comment-13507840 ] Hadoop QA commented on HDFS-4248: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507844#comment-13507844 ] Jing Zhao commented on HDFS-4248: - The patch looks very good. +1 for the patch. The only

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507853#comment-13507853 ] Tsz Wo (Nicholas), SZE commented on HDFS-4248: -- Hi Daryn, I think the bug of

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507872#comment-13507872 ] Hadoop QA commented on HDFS-4248: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4248) Renames may cause dangling leases

2012-11-30 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507895#comment-13507895 ] Jing Zhao commented on HDFS-4248: - I tried to run Daryn's new testcase without his fix, and