[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186762#comment-15186762
]
Hudson commented on HDFS-7866:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9446 (See
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186632#comment-15186632
]
Kai Zheng commented on HDFS-7866:
-
Thanks [~zhz], [~lirui] and all for making of this major moving!
>
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186623#comment-15186623
]
Rui Li commented on HDFS-7866:
--
Thanks guys for the review!
> Erasure coding: NameNode manages multiple
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186426#comment-15186426
]
Jing Zhao commented on HDFS-7866:
-
Yes, the plan sounds good to me. +1 on the v13 patch.
> Erasure coding:
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186359#comment-15186359
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Jing for the clarification.
bq. So we're good to leave the field
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186314#comment-15186314
]
Rui Li commented on HDFS-7866:
--
Thanks [~jingzhao] and [~zhz] for the great discussions. So we're good to
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186286#comment-15186286
]
Kai Zheng commented on HDFS-7866:
-
Thanks for the nice discussions.
bq. Because EC is only in 3.0, we can
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186270#comment-15186270
]
Jing Zhao commented on HDFS-7866:
-
Sorry for the confusion. I mean the change on
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186217#comment-15186217
]
Zhe Zhang commented on HDFS-7866:
-
bq. ErasureCodingPolicyProto is only used in getFileStatus RPC
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186205#comment-15186205
]
Zhe Zhang commented on HDFS-7866:
-
Thanks for pointing out the change in protobuf 3. Yes I think we can
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186089#comment-15186089
]
Jing Zhao commented on HDFS-7866:
-
I checked the current code again. {{ErasureCodingPolicyProto}} is only
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186073#comment-15186073
]
Jing Zhao commented on HDFS-7866:
-
There are already too many debates about optional and required. Maybe
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185855#comment-15185855
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Jing for the review. Changing the proto field to optional is a
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1518#comment-1518
]
Jing Zhao commented on HDFS-7866:
-
The patch also LGTM. Thanks for the great work, [~lirui].
My only
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185526#comment-15185526
]
Zhe Zhang commented on HDFS-7866:
-
Sure Jing. Would be great to have your opinion.
> Erasure coding:
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185414#comment-15185414
]
Jing Zhao commented on HDFS-7866:
-
Thanks for the work and review, [~lirui], [~zhz] and [~walter.k.su]!
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185056#comment-15185056
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184856#comment-15184856
]
Walter Su commented on HDFS-7866:
-
Sorry for the confusion, now the javadoc looks verbose. But thanks for
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184300#comment-15184300
]
Rui Li commented on HDFS-7866:
--
Thanks Walter for the suggestions.
bq. separating the logic of manipulation of
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184267#comment-15184267
]
Walter Su commented on HDFS-7866:
-
1. Not only javadoc, what I mean was separating the logic of
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183969#comment-15183969
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Rui for updating the patch. The latest version (v12) LGTM.
I
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183118#comment-15183118
]
Walter Su commented on HDFS-7866:
-
What do you think let it diverge instead of forcing unification? It
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182845#comment-15182845
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180373#comment-15180373
]
Zhe Zhang commented on HDFS-7866:
-
bq. We're using 11 bits to store the policy ID, which means it could
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179541#comment-15179541
]
Rui Li commented on HDFS-7866:
--
Thanks Zhe for your comments.
1. We're using 11 bits to store the policy ID,
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179513#comment-15179513
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Rui! I think we are pretty close.
# To save mem overhead we
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177063#comment-15177063
]
Rui Li commented on HDFS-7866:
--
Test failures cannot be reproduced. I'll fix the checkstyle in next update.
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175448#comment-15175448
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175128#comment-15175128
]
Zhe Zhang commented on HDFS-7866:
-
And yes, {{RS_6_3_POLICY_ID}} sounds good. If we later support multiple
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175122#comment-15175122
]
Zhe Zhang commented on HDFS-7866:
-
Sorry for the confusion Rui. I meant some text-base illustration like
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174861#comment-15174861
]
Rui Li commented on HDFS-7866:
--
Thanks Zhe for the review and comments!
Forgive my ignorance but what do you
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174741#comment-15174741
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Rui, very nice work here!
I only finished reviewing the
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171824#comment-15171824
]
Rui Li commented on HDFS-7866:
--
The latest failures are not related.
> Erasure coding: NameNode manages
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171647#comment-15171647
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171367#comment-15171367
]
Kai Zheng commented on HDFS-7866:
-
bq. The methods in INodeFileAttributes are all public so not sure why
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171326#comment-15171326
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167653#comment-15167653
]
Hadoop QA commented on HDFS-7866:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129089#comment-15129089
]
Zhe Zhang commented on HDFS-7866:
-
[~lirui] [~drankye] Thanks for the discussions.
bq. As to policy ID
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127923#comment-15127923
]
Kai Zheng commented on HDFS-7866:
-
bq. For striped blocks, we will possibly support replication factor in
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127885#comment-15127885
]
Rui Li commented on HDFS-7866:
--
Thanks [~zhz] for pointing me to the discussion and
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127930#comment-15127930
]
Kai Zheng commented on HDFS-7866:
-
bq. If we want to support custom policies later, we still need a way to
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127149#comment-15127149
]
Zhe Zhang commented on HDFS-7866:
-
Thanks Rui for the work. I think HDFS-9658 is almost ready.
I think the
[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105209#comment-15105209
]
Rui Li commented on HDFS-7866:
--
Thanks Kai for the suggestions. I just filed HDFS-9658 to break this task into
43 matches
Mail list logo
