[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173280#comment-15173280 ] Hudson commented on HDFS-9733: -- SUCCESS: Integrated in Hadoop-trunk-Commit #9399 (See

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173273#comment-15173273 ] Kai Zheng commented on HDFS-9733: - Thanks Uma for the review and commit! Then I can go on with HDFS-9694,

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173271#comment-15173271 ] Uma Maheswara Rao G commented on HDFS-9733: --- I have just committed this to trunk. Thanks a lot,

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173270#comment-15173270 ] Uma Maheswara Rao G commented on HDFS-9733: --- +1 on the latest patch. > Refactor

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171743#comment-15171743 ] Kai Zheng commented on HDFS-9733: - Having checked the test failures and they're passed locally as not

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171736#comment-15171736 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169165#comment-15169165 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168838#comment-15168838 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163228#comment-15163228 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-24 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162815#comment-15162815 ] Kai Zheng commented on HDFS-9733: - OK, it makes sense and I will do the fix here. Thanks Uma. > Refactor

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-24 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162737#comment-15162737 ] Uma Maheswara Rao G commented on HDFS-9733: --- Thanks Kai for updating the patch. For your

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-24 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162700#comment-15162700 ] Kai Zheng commented on HDFS-9733: - The update didn't fix check styles like below. I'm thinking the

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-23 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159942#comment-15159942 ] Kai Zheng commented on HDFS-9733: - Thanks Uma for the digging and analysis for me! Yes I will fix the

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-23 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159607#comment-15159607 ] Uma Maheswara Rao G commented on HDFS-9733: --- [~drankye] I think one reason for test failure could

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-23 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158723#comment-15158723 ] Uma Maheswara Rao G commented on HDFS-9733: --- Hi [~drankye], Test failures seems to be related.

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158616#comment-15158616 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-22 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158354#comment-15158354 ] Uma Maheswara Rao G commented on HDFS-9733: --- Thanks Kai for updating the patch. The latest patch

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-21 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156555#comment-15156555 ] Kai Zheng commented on HDFS-9733: - Thanks Uma for the great comments! bq. Why do you think we need 2

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-21 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156529#comment-15156529 ] Uma Maheswara Rao G commented on HDFS-9733: --- Thanks for the refactor Kai. Overall it looks good

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148246#comment-15148246 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147560#comment-15147560 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum

2016-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127273#comment-15127273 ] Hadoop QA commented on HDFS-9733: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||