[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455445#comment-16455445
]
Hudson commented on HDFS-13326:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454851#comment-16454851
]
Hudson commented on HDFS-13326:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14069 (See
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454690#comment-16454690
]
Íñigo Goiri commented on HDFS-13326:
Thanks [~ywskycn].
I'll go ahead and commit in the next hour if
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454468#comment-16454468
]
Wei Yan commented on HDFS-13326:
Sorry for late review, +1 [^HDFS-13326.002.patch]. Also created
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454389#comment-16454389
]
Íñigo Goiri commented on HDFS-13326:
[~ywskycn], [~linyiqun], thoughts on [^HDFS-13326.002.patch]?
>
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449050#comment-16449050
]
Íñigo Goiri commented on HDFS-13326:
The errors for [^HDFS-13326.002.patch] are because of HDFS and
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449024#comment-16449024
]
genericqa commented on HDFS-13326:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449011#comment-16449011
]
genericqa commented on HDFS-13326:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448810#comment-16448810
]
Íñigo Goiri commented on HDFS-13326:
[^HDFS-13326.002.patch] LGTM.
This can go all the way to 2.9 as
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448740#comment-16448740
]
Gang Li commented on HDFS-13326:
Hi, guys, i just uploaded two patches. [^HDFS-13326.002.patch] does not
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441094#comment-16441094
]
Íñigo Goiri commented on HDFS-13326:
In that case, I would prefer for splitting this JIRA in two:
*
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441052#comment-16441052
]
Wei Yan commented on HDFS-13326:
{quote}But one thing I'm concerning that this will be a incompatible
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440353#comment-16440353
]
Yiqun Lin commented on HDFS-13326:
--
[~ywskycn], I'm also OK with adding new option of -update. But one
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439843#comment-16439843
]
Íñigo Goiri commented on HDFS-13326:
I'm OK with the change itself; making a -update option makes
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439714#comment-16439714
]
Wei Yan commented on HDFS-13326:
Thanks [~gangli2384] for [^HDFS-13326.001.patch]. Please fix the
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438139#comment-16438139
]
genericqa commented on HDFS-13326:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437968#comment-16437968
]
Gang Li commented on HDFS-13326:
I just uploaded [^HDFS-13326.001.patch] supporting new add and update in
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429077#comment-16429077
]
Wei Yan commented on HDFS-13326:
[~gangli2384], some comments on [^HDFS-13326.000.patch].
(1) For add
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427203#comment-16427203
]
Wei Yan commented on HDFS-13326:
Thanks [~gangli2384] for the patch. Will put comments soon.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426312#comment-16426312
]
genericqa commented on HDFS-13326:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426252#comment-16426252
]
Gang Li commented on HDFS-13326:
Thanks for the comment. I will change the code accordingly.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426245#comment-16426245
]
Íñigo Goiri commented on HDFS-13326:
Thanks [~gangli2384], as a general comment, I would prefer to
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426240#comment-16426240
]
Gang Li commented on HDFS-13326:
I just uploaded [^HDFS-13326.000.patch] supporting the update in the
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413313#comment-16413313
]
Íñigo Goiri commented on HDFS-13326:
The last patch in HDFS-13204 covers the read only icon issue.
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412267#comment-16412267
]
Íñigo Goiri commented on HDFS-13326:
Thanks [~gangli2384] for the comments.
Only adding new sources is
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412234#comment-16412234
]
Gang Li commented on HDFS-13326:
Hi, guys, currently the add and update functionalities are mixed in
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410179#comment-16410179
]
Gang Li commented on HDFS-13326:
Thank you [~elgoiri]
> RBF: Improve the interfaces to modify and view
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410043#comment-16410043
]
Wei Yan commented on HDFS-13326:
thanks, [~elgoiri]
> RBF: Improve the interfaces to modify and view
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410037#comment-16410037
]
Íñigo Goiri commented on HDFS-13326:
Awesome. Assigned [~gangli2384] to this JIRA.
> RBF: Improve
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410029#comment-16410029
]
Wei Yan commented on HDFS-13326:
[~elgoiri], could u help add [~gangli2384] as a contributor? we have one
30 matches
Mail list logo
