[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486837#comment-16486837 ] Hudson commented on HDFS-13601: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14260 (See

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-23 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486786#comment-16486786 ] Xiao Chen commented on HDFS-13601: -- {quote}setPoolId will throw an NPE if the value is null {quote} I'm

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-23 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486777#comment-16486777 ] Andrew Wang commented on HDFS-13601: Thanks for reviewing Xiao! I think this current behavior is

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-23 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486766#comment-16486766 ] Xiao Chen commented on HDFS-13601: -- Thanks Andrew. +1 pending: I think poolId could be null

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486759#comment-16486759 ] genericqa commented on HDFS-13601: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-22 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486602#comment-16486602 ] Andrew Wang commented on HDFS-13601: I think this latest rev will pass precommit, and also

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486537#comment-16486537 ] genericqa commented on HDFS-13601: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483607#comment-16483607 ] genericqa commented on HDFS-13601: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-22 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483545#comment-16483545 ] Xiao Chen commented on HDFS-13601: -- Thanks Andrew for the work here. Looks pretty good to me overall.

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-21 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483423#comment-16483423 ] genericqa commented on HDFS-13601: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13601) Optimize ByteString conversions in PBHelper

2018-05-21 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483210#comment-16483210 ] Andrew Wang commented on HDFS-13601: I've attached a patch for some flavor and a precommit run. The