[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598955#comment-16598955 ] Erik Krogen commented on HDFS-13779: Good catches, Konstantin! I should have taken a closer look

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598123#comment-16598123 ] Konstantin Shvachko commented on HDFS-13779: Erik, this looks good. Two minor nits from my

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598050#comment-16598050 ] Erik Krogen commented on HDFS-13779: Looks like me and Konstantin hit a race condition :) Comments 2

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597855#comment-16597855 ] Konstantin Shvachko commented on HDFS-13779: Looks good, Erik. Two comments from me: # In

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597827#comment-16597827 ] Erik Krogen commented on HDFS-13779: Just attached v001 patch addressing the review comments as

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595743#comment-16595743 ] Erik Krogen commented on HDFS-13779: Thanks for the review [~vagarychen]! # Sure, it is only used for

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595716#comment-16595716 ] Chen Liang commented on HDFS-13779: --- Thanks for the patch [~xkrogen]! LGTM overall, only some minor

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594397#comment-16594397 ] genericqa commented on HDFS-13779: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590979#comment-16590979 ] Erik Krogen commented on HDFS-13779: I had some offline discussion with [~shv] and we realized that

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583130#comment-16583130 ] Chen Liang commented on HDFS-13779: --- Thanks for the correction [~xkrogen]! Makes sense to me. I recall

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583012#comment-16583012 ] Erik Krogen commented on HDFS-13779: {quote} And {{getProxy}} will trigger {{getAllProxies}} which

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581729#comment-16581729 ] Chen Liang commented on HDFS-13779: --- I see, so I guess the incremented {{currentIndex}} only takes

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581593#comment-16581593 ] Erik Krogen commented on HDFS-13779: Thanks for looking [~vagarychen]! For #1, the {{currentIndex}}

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581498#comment-16581498 ] Chen Liang commented on HDFS-13779: --- Thanks for the patch [~xkrogen], looking good to me overall, some

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574081#comment-16574081 ] Erik Krogen commented on HDFS-13779: Attaching a WIP patch which covers this and HDFS-13780, and

[jira] [Commented] (HDFS-13779) Implement performFailover logic for ObserverReadProxyProvider.

[ https://issues.apache.org/jira/browse/HDFS-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568558#comment-16568558 ] Konstantin Shvachko commented on HDFS-13779: Also reuse one of the existing retry policies