[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410380#comment-16410380
]
Hudson commented on HDFS-9117:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13869 (See
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025256#comment-15025256
]
James Clampffer commented on HDFS-9117:
---
+1.
I'll get this committed soon. There's a substantial
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024935#comment-15024935
]
Bob Hansen commented on HDFS-9117:
--
[~James Clampffer]: rebased and explicitly cleared out ERANGE.
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025038#comment-15025038
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022414#comment-15022414
]
James Clampffer commented on HDFS-9117:
---
Feedback for patch 17:
-Needs to be updated to head, patch
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011683#comment-15011683
]
Haohui Mai commented on HDFS-9117:
--
bq. When implementing 14 simple functions is our largest barrier to
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011670#comment-15011670
]
Haohui Mai commented on HDFS-9117:
--
bq. When implementing 14 simple functions is our largest barrier to
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011089#comment-15011089
]
Bob Hansen commented on HDFS-9117:
--
[~wheat9]: thanks for your feedback, and moving the conversation
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011015#comment-15011015
]
Stephen commented on HDFS-9117:
---
IMO explicit methods more clearly document the API and any ease of
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009074#comment-15009074
]
Haohui Mai commented on HDFS-9117:
--
bq. We will also need a non-static method to load another batch of
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009201#comment-15009201
]
Bob Hansen commented on HDFS-9117:
--
{quote}
bq. We will also need a non-static method to load another
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009206#comment-15009206
]
Bob Hansen commented on HDFS-9117:
--
{quote}
bq. With the templated getter, there is no way to tell whether
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009761#comment-15009761
]
Haohui Mai commented on HDFS-9117:
--
bq. Looking at decl.h, consumers don't know what types are supported
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009349#comment-15009349
]
Haohui Mai commented on HDFS-9117:
--
Just an example:
{code:title=decl.h}
#include
template
struct
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009519#comment-15009519
]
Bob Hansen commented on HDFS-9117:
--
Yes, that is in line with what you wrote earlier, but still doesn't
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007150#comment-15007150
]
Bob Hansen commented on HDFS-9117:
--
[~wheat9]: thanks for the review.
bq. In the first cut maybe we can
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002991#comment-15002991
]
Haohui Mai commented on HDFS-9117:
--
Thanks for splitting it up.
{code}
+bool
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002058#comment-15002058
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000265#comment-15000265
]
Bob Hansen commented on HDFS-9117:
--
bq. Unfortunately requiring c++ exceptions might not be an option for
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001591#comment-15001591
]
Bob Hansen commented on HDFS-9117:
--
Submitted a patch for Optional in HDFS-9419.
There's still the open
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001321#comment-15001321
]
Haohui Mai commented on HDFS-9117:
--
bq. should that be a distinct Jira for bringing in third party code?
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999662#comment-14999662
]
Haohui Mai commented on HDFS-9117:
--
bq. This interface can't be supported while still not using exceptions
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998531#comment-14998531
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998536#comment-14998536
]
Bob Hansen commented on HDFS-9117:
--
[~wheat9]:
I have trimmed down the interface considerably, but kept
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997815#comment-14997815
]
Haohui Mai commented on HDFS-9117:
--
bq. I can strip it down to the API you provided, but I wonder what use
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994679#comment-14994679
]
Bob Hansen commented on HDFS-9117:
--
[~wheat9] - do you agree that we should be reading in xml streams that
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994598#comment-14994598
]
Haohui Mai commented on HDFS-9117:
--
bq. As an example, let's say we are writing a native replacement for
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994468#comment-14994468
]
Haohui Mai commented on HDFS-9117:
--
Thinking about the patch a little bit more, I believe that there is
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994534#comment-14994534
]
Bob Hansen commented on HDFS-9117:
--
[~wheat9]: thanks for the feedback and carrying the conversation
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994539#comment-14994539
]
Bob Hansen commented on HDFS-9117:
--
bq. 2. Adding search paths and parsing them can be replaced by passing
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992575#comment-14992575
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985948#comment-14985948
]
James Clampffer commented on HDFS-9117:
---
That sounds good to me.
+1 on the new patch
> Config file
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981582#comment-14981582
]
James Clampffer commented on HDFS-9117:
---
"The principle is that the C++ APIs should be able to solely
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981699#comment-14981699
]
Bob Hansen commented on HDFS-9117:
--
[~James Clampffer]: My current notion is that it will take as many as
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978590#comment-14978590
]
Bob Hansen commented on HDFS-9117:
--
bq. 1. It's beneficial to further separate the patch, such as
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978780#comment-14978780
]
Haohui Mai commented on HDFS-9117:
--
bq. I disagree; the code is required for a pure C++ implementation
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978833#comment-14978833
]
Bob Hansen commented on HDFS-9117:
--
The current design has the core of the C++ engine (FileSystem,
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979090#comment-14979090
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979682#comment-14979682
]
Hadoop QA commented on HDFS-9117:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977436#comment-14977436
]
Haohui Mai commented on HDFS-9117:
--
Some high level comments:
1. It's beneficial to further separate the
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974473#comment-14974473
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974789#comment-14974789
]
James Clampffer commented on HDFS-9117:
---
+1
> Config file reader / options classes for libhdfs++
>
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971142#comment-14971142
]
James Clampffer commented on HDFS-9117:
---
Thanks for the update Bob! The last patch covered all of my
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969675#comment-14969675
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969321#comment-14969321
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969352#comment-14969352
]
Haohui Mai commented on HDFS-9117:
--
Thanks for the work, [~bobhansen]. Can you please separate the task of
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967395#comment-14967395
]
James Clampffer commented on HDFS-9117:
---
Some Feedback:
More comments would be nice, particularly
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966780#comment-14966780
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965630#comment-14965630
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965111#comment-14965111
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964214#comment-14964214
]
Hadoop QA commented on HDFS-9117:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901722#comment-14901722
]
Haohui Mai commented on HDFS-9117:
--
I suggest bringing in RapidXML (http://rapidxml.sourceforge.net/) to
52 matches
Mail list logo
