[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591248#comment-16591248
]
genericqa commented on HDFS-1:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDFS-1 does not apply to HDFS-7240. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-1 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918501/HDFS-1-HDFS-7240.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/24867/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch,
> HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch,
> HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591238#comment-16591238 ] LiXin Ge commented on HDFS-1: - Hi [~nandakumar131], I'm wonder whether this Jira is still necessary, shall we rebase or close it? Thanks. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, > HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch, > HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439309#comment-16439309 ] LiXin Ge commented on HDFS-1: - [~nandakumar131] Thanks for paying attention on this work. I'm back you up on your idea of introducing a new interface. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, > HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch, > HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433604#comment-16433604
]
Nanda kumar commented on HDFS-1:
Thanks [~GeLiXin] for the work.
I'm thinking of introducing a new interface for HddsService plugins so that we
can have more fine-grained control over how the plugin is initialized, started
and stopped by {{HddsDatanodeService}}. With this new interface, we can define
new exception(s) which will be thrown in case of failure and
{{HddsDatanodeService}} can decide if it can proceed when it is not able to
start the plugin.
The new plugin will look something like:
{code:java}
public interface HddsServicePlugin {
void init() throws ServiceInitializationException;
void start(Object service) throws ServiceException;
void stop() throws IOException;
}
{code}
cc: [~xyao] [~anu]
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch,
> HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch,
> HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433509#comment-16433509
]
LiXin Ge commented on HDFS-1:
-
Hi, [~nandakumar131] [~elek], the Ozone branch moves so fast, that's amazing.
After HDFS-13395 contributed by [~nandakumar131],
{{HddsDatanodeService#HddsDatanodeService}} integrated to
{{HddsDatanodeService#start}}, and as discussed with [~elek],
{{HddsDatanodeService#start}} should better not throw any checked exception, So
seems there is no need to Introduce a new exception here that what's this Jira
tried to do?
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch,
> HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch,
> HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433357#comment-16433357
]
genericqa commented on HDFS-1:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDFS-1 does not apply to HDFS-7240. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-1 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918501/HDFS-1-HDFS-7240.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23871/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch,
> HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch,
> HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433348#comment-16433348
]
LiXin Ge commented on HDFS-1:
-
[~elek] Thanks for your review and advice, you suddenly remind me of the
compatibility and universality that slip from my memory when I modifying the
interface of {{ServicePlugin}}, agree with you.
For the code logic itself, an appointed exception type will be better. For the
Ozone system, compatibility is a problem but not the unacceptable one in
consideration of the user number currently we have. As you mentioned,
universality that affect all the plugin we will have in the future is the
really problem in my opinion.
In patch 003 I revert the {{HddsDatanodeService#start}} to just throw
RuntimeException, but still retained the specified log for different exception
type.
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch,
> HDFS-1-HDFS-7240.002.patch, HDFS-1-HDFS-7240.003.patch,
> HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432424#comment-16432424
]
genericqa commented on HDFS-1:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
31s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m
49s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
12s{color} | {color:green} HDFS-7240 passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
24s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
25s{color} | {color:red} common in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 57s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
1s{color} | {color:red} hadoop-hdds/common in HDFS-7240 has 2 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} common in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
22s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
21s{color} | {color:red} common in HDFS-7240 failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
10s{color} | {color:red} common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 27m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
23s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
23s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 24s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
20s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
24s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
22s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
23s{color} | {color:red} common in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432227#comment-16432227 ] Elek, Marton commented on HDFS-1: - Thank you very much [~GeLiXin] to addressing this issue, I think it's a good step forward to improve the usability with more meaningful errors. Just one comment: You added a new checked exception(IOException) to the signature of ServicePlugin.stop(). This is a non-compatible change, every existing ServicePlugin should be modified. Also it limits the places where we can use the datanode service plugin (can we use it after this change from hadoop 2.7?). Is there any other solution without changing ServicePlugin? For me, an unchecked RuntimeException is also acceptable (but it's a matter of taste. Others prefer checked exceptions). > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, > HDFS-1-HDFS-7240.002.patch, HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432206#comment-16432206 ] LiXin Ge commented on HDFS-1: - [~nandakumar131] Thanks for your quick response, HDFS-13414 is really helpful. Patch 002 for this issue is available now, I would appreicate it if you can help to review when you are convenient. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, > HDFS-1-HDFS-7240.002.patch, HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431768#comment-16431768 ] Nanda kumar commented on HDFS-1: Thanks [~GeLiXin] for taking this up and working on it. bq. both the shell usage and Ozone document are not up-to-date... Yeah, sorry about that. We are continuously working on updating the doc as the usage changes, sometimes the doc falls behind. HDFS-13414 is created for tracking and updating the doc. bq. MiniOzoneClassicCluster always failing in my computer... This is an open issue, HDFS-13360 is for tracking it. This issue is also covered as part of HDFS-13395. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430460#comment-16430460 ] LiXin Ge commented on HDFS-1: - My patch conflict with the Ozone branch after the HDSL renamed to HDDS. Sorry for that and will rebase it tomorrow. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > Labels: newbie > Attachments: HDFS-1-HDFS-7240.001.patch, HDFS-1.001.patch > > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430364#comment-16430364
]
genericqa commented on HDFS-1:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HDFS-1 does not apply to HDFS-7240. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-1 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918066/HDFS-1-HDFS-7240.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23834/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1-HDFS-7240.001.patch, HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430310#comment-16430310
]
genericqa commented on HDFS-1:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HDFS-1 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-1 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918051/HDFS-1.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23833/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[
https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430308#comment-16430308
]
LiXin Ge commented on HDFS-1:
-
Patch is available now, please help to review it whether it meets the
requirements, many thanks.
More time spent than expected:
1.It's not friendly for new comer to run the Ozone system: both the shell
usage and Ozone document are not up-to-date after Ozone get independent from
HDFS. Maybe a new Jira to update these help information is necessary.
2.I have tried to add some new unit test for this patch, but the basic test
function such as create a {{MiniOzoneClassicCluster}} always failing in my
computer, give it up
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> -
>
> Key: HDFS-1
> URL: https://issues.apache.org/jira/browse/HDFS-1
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: LiXin Ge
>Priority: Major
> Labels: newbie
> Attachments: HDFS-1.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417051#comment-16417051 ] Nanda kumar commented on HDFS-1: Yeah, sure [~GeLiXin]. Thanks for the interest, I have assigned the jira to you. > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Nanda kumar >Assignee: LiXin Ge >Priority: Major > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
[ https://issues.apache.org/jira/browse/HDFS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416949#comment-16416949 ] LiXin Ge commented on HDFS-1: - Hi [~nandakumar131], this Jira seems applicable for the newbie to Ozone, I'm interesting in Ozone and can I take this as the first step? > Ozone: Introduce a new SCM Exception which will be thrown when mandatory > property is missing > - > > Key: HDFS-1 > URL: https://issues.apache.org/jira/browse/HDFS-1 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Nanda kumar >Priority: Major > > It's better to have a separate SCM Exception to indicate a missing mandatory > property. This was proposed by [~xyao] in [this comment| > https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
