[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871633#comment-16871633
]
Hudson commented on HDFS-13480:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853287#comment-16853287
]
Hadoop QA commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853217#comment-16853217
]
Íñigo Goiri commented on HDFS-13480:
+1 on [^HDFS-13480-HDFS-13891-08.patch].
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853213#comment-16853213
]
Ayush Saxena commented on HDFS-13480:
-
Thanx [~elgoiri] for the review.
Have made the
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853210#comment-16853210
]
Hadoop QA commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853171#comment-16853171
]
Íñigo Goiri commented on HDFS-13480:
The spacing for the second variable doesn't look
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853079#comment-16853079
]
Ayush Saxena commented on HDFS-13480:
-
Uploaded patch with the said changes.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852067#comment-16852067
]
Íñigo Goiri commented on HDFS-13480:
I like the {{isRouterHeartbeatEnabled}} extracit
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851988#comment-16851988
]
Hadoop QA commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851942#comment-16851942
]
Ayush Saxena commented on HDFS-13480:
-
I agree, We should maintain compatibility.
Hav
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851104#comment-16851104
]
Íñigo Goiri commented on HDFS-13480:
My only question is what to do if the value is n
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850485#comment-16850485
]
Ayush Saxena commented on HDFS-13480:
-
I had a version to current, forgot to upload w
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850477#comment-16850477
]
Hadoop QA commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850286#comment-16850286
]
Íñigo Goiri commented on HDFS-13480:
[~maobaolong], I can rebase to HDFS-13891 if you
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850164#comment-16850164
]
Hadoop QA commented on HDFS-13480:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611013#comment-16611013
]
Hadoop QA commented on HDFS-13480:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611008#comment-16611008
]
Íñigo Goiri commented on HDFS-13480:
[~maobaolong] can you provide an updated patch?
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480861#comment-16480861
]
Íñigo Goiri commented on HDFS-13480:
The error in TestRouterQuota seems suspicious.
BT
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480440#comment-16480440
]
maobaolong commented on HDFS-13480:
---
[~linyiqun] [~elgoiri] Thank you for your these day
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480340#comment-16480340
]
genericqa commented on HDFS-13480:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479303#comment-16479303
]
Íñigo Goiri commented on HDFS-13480:
Yes, let's hold this until we reach clarity.
I ma
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478780#comment-16478780
]
Yiqun Lin commented on HDFS-13480:
--
The latest patch looks good to me but only some check
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478680#comment-16478680
]
genericqa commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vot
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478607#comment-16478607
]
maobaolong commented on HDFS-13480:
---
[~linyiqun] I've formatted my code-style, add the j
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477226#comment-16477226
]
genericqa commented on HDFS-13480:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vot
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477201#comment-16477201
]
Yiqun Lin commented on HDFS-13480:
--
[~maobaolong], I did a quick review:
Can you add the
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477176#comment-16477176
]
maobaolong commented on HDFS-13480:
---
[~elgoiri] Thank you for your great review, it make
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474459#comment-16474459
]
Íñigo Goiri commented on HDFS-13480:
A couple comments for the docu:
* For the example
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474089#comment-16474089
]
genericqa commented on HDFS-13480:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474030#comment-16474030
]
maobaolong commented on HDFS-13480:
---
[~linyiqun] [~elgoiri] Thank you for your review.
*
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472288#comment-16472288
]
Íñigo Goiri commented on HDFS-13480:
Agree with [~linyiqun], we shouldn't change {{DFS
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471655#comment-16471655
]
Yiqun Lin commented on HDFS-13480:
--
Some comments from me:
* It's a not good way to chan
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471517#comment-16471517
]
genericqa commented on HDFS-13480:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471511#comment-16471511
]
maobaolong commented on HDFS-13480:
---
[~elgoiri] [~linyiqun] Please take a look. Thank yo
34 matches
Mail list logo