[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029061#comment-17029061
]
Ahmed Hussein commented on HDFS-14651:
--
Thanks [~leosun08], Feel free to take over HDFS-15149.
>
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028269#comment-17028269
]
Lisheng Sun commented on HDFS-14651:
Thanks [~ahussein] for your questions.
{quote}1.what is the
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027943#comment-17027943
]
Ahmed Hussein commented on HDFS-14651:
--
Hi [~leosun08] and [~linyiqun]!
I am looking at the timeouts
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979802#comment-16979802
]
Hudson commented on HDFS-14651:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17684 (See
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979791#comment-16979791
]
Yiqun Lin commented on HDFS-14651:
--
LGTM, +1. Commit this shortly.
> DeadNodeDetector checks dead node
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979539#comment-16979539
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979487#comment-16979487
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979407#comment-16979407
]
Lisheng Sun commented on HDFS-14651:
{quote}Also can we update the asset check to following, we
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979370#comment-16979370
]
Yiqun Lin commented on HDFS-14651:
--
Thanks for updating the patch, [~leosun08]. The patch looks very
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979148#comment-16979148
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979043#comment-16979043
]
Yiqun Lin commented on HDFS-14651:
--
The latest patch almost looks good now, only some minor comments:
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979026#comment-16979026
]
Lisheng Sun commented on HDFS-14651:
[~linyiqun]
I updated the patch and uploaed the v006 patch.
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978356#comment-16978356
]
Yiqun Lin commented on HDFS-14651:
--
Review comments for the latest patch:
*DeadNodeDetector.java*
1.
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978285#comment-16978285
]
Lisheng Sun commented on HDFS-14651:
To add suspicious list‘s main purpose is to distinguish between
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978266#comment-16978266
]
Yiqun Lin commented on HDFS-14651:
--
For the second case, if we add the node to the dead node by mistake
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978253#comment-16978253
]
Lisheng Sun commented on HDFS-14651:
[~linyiqun]
when client read failed from Datanode, there are
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978193#comment-16978193
]
Yiqun Lin commented on HDFS-14651:
--
{quote}
HDFS-14649 will add CHECK_SUSPICIOUS type. it is executed in
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978063#comment-16978063
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977992#comment-16977992
]
Lisheng Sun commented on HDFS-14651:
v005 fixs compile failed.
> DeadNodeDetector checks dead node
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977699#comment-16977699
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977657#comment-16977657
]
Lisheng Sun commented on HDFS-14651:
Thanks [~linyiqun] for deep review.
{quote}When we remove one
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977534#comment-16977534
]
Yiqun Lin commented on HDFS-14651:
--
Some comments for the variable/setting naming, so that it will look
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977420#comment-16977420
]
Yiqun Lin commented on HDFS-14651:
--
Thanks for addressing the comment, [~leosun08]. Some review
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976587#comment-16976587
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976418#comment-16976418
]
Lisheng Sun commented on HDFS-14651:
i have addressed other comments and uploaded the v003 patch.
>
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976383#comment-16976383
]
Yiqun Lin commented on HDFS-14651:
--
Okay, got it. It will be better to comment why you add probe thread
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976380#comment-16976380
]
Lisheng Sun commented on HDFS-14651:
hi [~linyiqun]
{quote}Why we define additional probeThreadPool
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976366#comment-16976366
]
Yiqun Lin commented on HDFS-14651:
--
Hi [~leosun08], thanks for the follow-up work! I am reviewing on
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976290#comment-16976290
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976119#comment-16976119
]
Hadoop QA commented on HDFS-14651:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
30 matches
Mail list logo
