[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410372#comment-16410372
]
Hudson commented on HDFS-8766:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13869 (See
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978366#comment-14978366
]
Bob Hansen commented on HDFS-8766:
--
Yow, [~wheat9]! That's a good catch on the promise/future bug. The
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978378#comment-14978378
]
James Clampffer commented on HDFS-8766:
---
Thanks for the review Haohui!
Good catch on the "using
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979012#comment-14979012
]
James Clampffer commented on HDFS-8766:
---
"Please wrap the statement with braces though it is a single
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978816#comment-14978816
]
Haohui Mai commented on HDFS-8766:
--
Looks good to me overall. A few nitpicks:
{code}
+ if (!s.ok())
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978819#comment-14978819
]
Haohui Mai commented on HDFS-8766:
--
Things that be a
{code}
+#include "libhdfspp/hdfs.h"
+ auto callback
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979418#comment-14979418
]
Haohui Mai commented on HDFS-8766:
--
bq. Currently the only way people can find out that this project
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979415#comment-14979415
]
Haohui Mai commented on HDFS-8766:
--
+1.
> Implement a libhdfs(3) compatible API
>
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977288#comment-14977288
]
Bob Hansen commented on HDFS-8766:
--
{code}
third_party/asio-1.10.2/include
third_party/gmock-1.7.0
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977422#comment-14977422
]
James Clampffer commented on HDFS-8766:
---
I'm not sure what I'm missing with regards to style stuff:
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977494#comment-14977494
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977440#comment-14977440
]
James Clampffer commented on HDFS-8766:
---
Thanks for the +1!
I agree that we should be able to
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977386#comment-14977386
]
Haohui Mai commented on HDFS-8766:
--
Looks like many of the comments listed in
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977458#comment-14977458
]
Haohui Mai commented on HDFS-8766:
--
Sorry looked at the wrong patch. Good work, [~James Clampffer]!
Some
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976459#comment-14976459
]
Bob Hansen commented on HDFS-8766:
--
[~James Clampffer] - re: namespaces - I think that the FileHandle and
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975188#comment-14975188
]
James Clampffer commented on HDFS-8766:
---
Thanks for the input Haohui!
I have the bulk of the next
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971680#comment-14971680
]
Haohui Mai commented on HDFS-8766:
--
{code}
+add_library(bindings hdfs.cc)
+add_dependencies(bindings fs
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971767#comment-14971767
]
Haohui Mai commented on HDFS-8766:
--
{code}
+typedef struct hdfsFile_internal {
{code}
This will tie the
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970096#comment-14970096
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967515#comment-14967515
]
Haohui Mai commented on HDFS-8766:
--
Thanks for the comments, Bob.
bq. I'm unsure if you see all of them
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967884#comment-14967884
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965443#comment-14965443
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964024#comment-14964024
]
James Clampffer commented on HDFS-8766:
---
Thanks Bob and Haohui for the feedback.
Bob, I'll make
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963963#comment-14963963
]
Bob Hansen commented on HDFS-8766:
--
Haohui - thanks for those explicit and actionable items. I'm unsure
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961217#comment-14961217
]
Haohui Mai commented on HDFS-8766:
--
Thanks for updating the patch. Some comments:
1. Remove {[hdfs.h}},
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959780#comment-14959780
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958164#comment-14958164
]
Haohui Mai commented on HDFS-8766:
--
As far as I can see there are multiple issues with the current patch
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955252#comment-14955252
]
Haohui Mai commented on HDFS-8766:
--
I'd like to proceed with this patch after HDFS-9207. The reason is
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953933#comment-14953933
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941988#comment-14941988
]
Haohui Mai commented on HDFS-8766:
--
bq. I added a simple timeout to clear out the bad datanodes after a
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939954#comment-14939954
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940047#comment-14940047
]
James Clampffer commented on HDFS-8766:
---
Thanks for the review Bob.
1) Thanks for pointing that out.
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940089#comment-14940089
]
Haohui Mai commented on HDFS-8766:
--
Thanks for updating the patch!.
{code}
+ if (!s.ok()) {
+// for
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940090#comment-14940090
]
Haohui Mai commented on HDFS-8766:
--
bq. For now I'd really like to avoid shared_ptr and unique_ptr until I
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940001#comment-14940001
]
Bob Hansen commented on HDFS-8766:
--
Minor nits:
* Still have a shared_ptr to a promise in
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940462#comment-14940462
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939049#comment-14939049
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936199#comment-14936199
]
Haohui Mai commented on HDFS-8766:
--
Thanks for updating the patch.
{code}
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934158#comment-14934158
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905406#comment-14905406
]
Haohui Mai commented on HDFS-8766:
--
Thanks for the work.
It looks like that the code needs a lot of clean
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905218#comment-14905218
]
Hadoop QA commented on HDFS-8766:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905488#comment-14905488
]
James Clampffer commented on HDFS-8766:
---
Thanks for the input!
Re: It looks like that the code needs
[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905513#comment-14905513
]
Haohui Mai commented on HDFS-8766:
--
bq. Agreed. I didn't know we were using automated tools to check the
43 matches
Mail list logo
