Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-21 Thread Steve Ebersole
What's being returned instead of the fallback? Is that configured somewhere for Hibernate to use that? Like a testing hibernate.properties? On Fri, Sep 21, 2018 at 12:03 PM Scott Marlow wrote: > > > On 9/21/18 10:29 AM, Steve Ebersole wrote: > > Honestly Scott, I am thoroughly confused now as

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-21 Thread Scott Marlow
On 9/21/18 10:29 AM, Steve Ebersole wrote: > Honestly Scott, I am thoroughly confused now as to what you are wanting > and what you are reporting. > > Your last code fragment[1] is close.  As I said earlier, building a > SessionFactory typically involves individual service registries being >

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-21 Thread Steve Ebersole
Honestly Scott, I am thoroughly confused now as to what you are wanting and what you are reporting. Your last code fragment[1] is close. As I said earlier, building a SessionFactory typically involves individual service registries being used for each SF. You have to go out of your way for that

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-21 Thread Scott Marlow
I verified that SessionFactoryServiceContributor doesn't help WF either, as we see the same problem. I did hack together a unit test under ORM (using the WF integration testing) that shows that we don't see the same problem when the

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-20 Thread Scott Marlow
On 9/20/18 3:17 PM, Scott Marlow wrote: > I'm going to try some more changes on the WF side, to see if I can work > around this problem.  I'll report back on how that goes. :) I tried overriding the ServiceRegistryImplementor#initiateService(Map configurationValues, ServiceRegistryImplementor

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-20 Thread Scott Marlow
I'm going to try some more changes on the WF side, to see if I can work around this problem. I'll report back on how that goes. :) On 9/20/18 12:05 PM, Scott Marlow wrote: > Is https://gist.github.com/scottmarlow/63241549820243923aab16e664c3c6c3 > closer to what we need? > > On 9/19/18 3:47

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Steve Ebersole
StandardServiceRegistry`No, it's not. Each call to `registry.getService( RegionFactory.class )` in your test returns the same `RegionFactory` - by design. By default each SF bootstrap uses a unique StandardServiceRegistry which is what the ServiceContributor contributes services to. In terms of

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Scott Marlow
Please look at https://github.com/scottmarlow/hibernate-orm/tree/ServiceContributorTest and let me know if this is a valid test. I added a test that calls registry.getService( RegionFactory.class ) twice and fails if the RegionFactoryInitiator doesn't get called twice. Is that the same as

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Scott Marlow
On 9/19/18 9:22 AM, Steve Ebersole wrote: > Ohhh... Sorry I misunderstood.  I thought you were asking about ways to > have the contributor only apply to one of the PUs... > > I'm surprised it isn't applied to each actually.  I'd consider that a > bug.  Can you put together a test? Yes, I

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Steve Ebersole
Ohhh... Sorry I misunderstood. I thought you were asking about ways to have the contributor only apply to one of the PUs... I'm surprised it isn't applied to each actually. I'd consider that a bug. Can you put together a test? On Wed, Sep 19, 2018, 8:12 AM Scott Marlow wrote: > > > On

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Scott Marlow
On 9/19/18 5:41 AM, Gunnar Morling wrote: > Would SessionFactoryServiceContributor [1] be of use to you? It lets you > add services to the SF-scoped service registry; not sure whether that > suits your requirements or no. Thanks, I will give that a try. We currently use

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-19 Thread Gunnar Morling
Would SessionFactoryServiceContributor [1] be of use to you? It lets you add services to the SF-scoped service registry; not sure whether that suits your requirements or no. --Gunnar [1]

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-18 Thread Scott Marlow
On 9/14/18 6:15 PM, Steve Ebersole wrote: > Another thought.  If you are specifically talking about JPA container > integration we could always accept ServiceContributor(s) via the > integration values Map. This is for both JPA container integration and not container integration. > > On

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-18 Thread Scott Marlow
On 9/14/18 6:14 PM, Steve Ebersole wrote: > Doing so would require a programatic call while bootstrapping > Hibernate.  The ServiceContributors are applied during > `org.hibernate.boot.registry.StandardServiceRegistryBuilder#build` > processing.  So we'd need a call to register a

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-14 Thread Steve Ebersole
Doing so would require a programatic call while bootstrapping Hibernate. The ServiceContributors are applied during `org.hibernate.boot.registry.StandardServiceRegistryBuilder#build` processing. So we'd need a call to register a ServiceContributor with the StandardServiceRegistryBuilder. Of

Re: [hibernate-dev] Is there a way to have ServiceContributor per SessionFactory/EMF instead of per application classloader?

2018-09-14 Thread Steve Ebersole
Another thought. If you are specifically talking about JPA container integration we could always accept ServiceContributor(s) via the integration values Map. On Fri, Sep 14, 2018 at 10:14 PM Steve Ebersole wrote: > Doing so would require a programatic call while bootstrapping Hibernate. > The