Re: [hwloc-devel] [hwloc-svn] svn:hwloc r2149

2010-05-28 Thread Bert Wesarg
Hi, sorry to chime in so late. Jeff you may remember that I reported a similar problem to open-mpi some years ago. But I didn't use CFLAGS=-m32 but CC="gcc -m32" and CXX="g++ -m32", which is still in my eyes the correct way to pass this flag to all compile commands. The problem in open-mpi back

Re: [hwloc-devel] [hwloc-svn] svn:hwloc r1986

2010-04-21 Thread Bert Wesarg
On Wed, Apr 21, 2010 at 14:27, wrote: > Author: jsquyres > Date: 2010-04-21 08:27:33 EDT (Wed, 21 Apr 2010) > New Revision: 1986 > URL: https://svn.open-mpi.org/trac/hwloc/changeset/1986 > > Log: > Refs #18.  Fix some compiler warnings: > >  * Note the change of typeof to

Re: [hwloc-devel] [hwloc-svn] svn:hwloc r1940

2010-04-06 Thread Bert Wesarg
On Tue, Apr 6, 2010 at 17:36, wrote: > Author: bgoglin > Date: 2010-04-06 11:36:17 EDT (Tue, 06 Apr 2010) > New Revision: 1940 > URL: https://svn.open-mpi.org/trac/hwloc/changeset/1940 > > Log: > Stop using HWLOC_NBMAXCPUS in Linux hwloc_linux_set/get_tid_cpubind > Text files

Re: [hwloc-devel] [hwloc-svn] svn:hwloc r1865

2010-03-27 Thread Bert Wesarg
Hi, thanks for sharing this early. On Sat, Mar 27, 2010 at 08:53, wrote: > Modified: branches/dyncpusets/src/cpuset.c > == > --- branches/dyncpusets/src/cpuset.c    (original) > +++

Re: [hwloc-devel] Strange difference

2010-03-27 Thread Bert Wesarg
On Sat, Mar 27, 2010 at 01:50, Jeff Squyres wrote: > On Mar 26, 2010, at 5:35 PM, Brice Goglin wrote: > >> > Fair enough.  How about still just keeping "P" in the graphic output, >> > then?  But "processor" in the prettyprint? >> >> IIRC, somebody said "PU" (for "processing

Re: [hwloc-devel] Strange difference

2010-03-26 Thread Bert Wesarg
On Fri, Mar 26, 2010 at 22:05, Jeff Squyres wrote: > On Mar 26, 2010, at 4:16 PM, Samuel Thibault wrote: > >> > Is it a crime to use the full word "Processor"?  At least on my machine, >> > the output width is still far less than 80 characters, so the full word >> > should

Re: [hwloc-devel] Attribute unsed not regognized

2010-03-26 Thread Bert Wesarg
On Fri, Mar 26, 2010 at 11:57, Brice Goglin <brice.gog...@inria.fr> wrote: > Bert Wesarg wrote: >> There is also a problem, that these __hwloc_attributes defines don't >> get through after install: >> > > Are you using the embedding stuff ? Or only including our h

Re: [hwloc-devel] Attribute unsed not regognized

2010-03-26 Thread Bert Wesarg
There is also a problem, that these __hwloc_attributes defines don't get through after install: $ gcc -DHAVE_CONFIG_H -I. -DSYSCONFDIR=\"/home/wesarg/opt/htop-dev/etc\" -I/home/wesarg/opt/hwloc-dev/include -W -Wunused-parameter -Wall -std=gnu99 -D_XOPEN_SOURCE_EXTENDED -g -O2 -MT

[hwloc-devel] Attribute unsed not regognized

2010-03-26 Thread Bert Wesarg
Hi, I still get warnings for unused parameters from the hwloc/helper.h header. The code to check this attribute is this: int square(int arg1 __attribute__ ((__unused__)), int arg2); int square(int arg1, int arg2) { return arg2; } But this results in this conflig.log output:

Re: [hwloc-devel] 1.0-rc1

2010-03-22 Thread Bert Wesarg
On Mon, Mar 22, 2010 at 21:49, Jeff Squyres <jsquy...@cisco.com> wrote: > On Mar 22, 2010, at 4:34 PM, Bert Wesarg wrote: > >> > Same question again :) >> >> I suspect, I can't propose API changes after that, right? ;-) > > It would be good, yes.  :-) &g

Re: [hwloc-devel] 1.0-rc1

2010-03-22 Thread Bert Wesarg
On Mon, Mar 22, 2010 at 21:29, Brice Goglin wrote: > Brice Goglin wrote: >> Are we doing a 1.0-rc1 soon ? >> > > Same question again :) I suspect, I can't propose API changes after that, right? ;-) Bert > > Brice >

Re: [hwloc-devel] Change bind API.

2010-03-22 Thread Bert Wesarg
On Mon, Mar 22, 2010 at 11:21, Samuel Thibault <samuel.thiba...@inria.fr> wrote: > Bert Wesarg, le Sun 21 Mar 2010 13:31:14 +0100, a écrit : >> I would like to propose an interface change for these function, so >> that the caller provide the to-be-filled cpuset, to red

[hwloc-devel] Change bind API.

2010-03-21 Thread Bert Wesarg
Hi, as some of you may know, I've once done some work to teach htop a topology aware affinity setting dialog with the help the PLPA. Recently Jeff pinged me that hwloc is looking for a topology aware top like tool too. So I've start looking into the htop and hwloc code again. What caught my

[hwloc-devel] Problem with hwloc_linux_foreach_proc_tid()

2010-03-17 Thread Bert Wesarg
Hi all, I have a problem with this retry algorithm of hwloc_linux_foreach_proc_tid(). For example with the hwloc_linux_get_pid_cpubind() function. hwloc_linux_get_pid_cpubind() should collect all affinity mask from the threads. But if the retry is triggered and the new tid list does not have a

Re: [hwloc-devel] Proposal for cpuset API change

2010-03-17 Thread Bert Wesarg
On Wed, Mar 17, 2010 at 20:26, Brice GOGLIN wrote: >> Hi, >> >> I think it is necessary to make a small change to the cpuset API. The >> current API was made fit to allow dynamically sized cpusets. I.e. an >> alloc/modify/free style life cycle. The problem I see is, from

[hwloc-devel] Proposal for cpuset API change

2010-03-17 Thread Bert Wesarg
Hi, I think it is necessary to make a small change to the cpuset API. The current API was made fit to allow dynamically sized cpusets. I.e. an alloc/modify/free style life cycle. The problem I see is, from where should hwloc_cpuset_alloc() get the size of the cpuset? The solution I see is to pass

[hwloc-devel] [PATCH] Avoid expensive ffsl/flsl calls in cpuset operations

2010-03-13 Thread Bert Wesarg
Testing if a word does have any bit set should be considered less expansive than calling ffsl/flsl first and than test this. Regards, Bert --- src/cpuset.c | 44 +++- 1 files changed, 23 insertions(+), 21 deletions(-) diff --git a/src/cpuset.c

Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines

2010-03-12 Thread Bert Wesarg
On Fri, Mar 12, 2010 at 08:45, Brice Goglin wrote: > I just fixed escaped characters and used your strsep loop for parsing > options. I'll keep your patch on the side in case we find a solution > that is compatible with fsroot. Thanks a lot. Thank you. Unfortunately, I

[hwloc-devel] [PATCH 2/2] Provide hwloc_cpuset_next() and use it in hwloc_cpuset_foreach

2010-03-11 Thread Bert Wesarg
The hwloc_cpuset_next() will calculate the next cpu behind a given one. Use hwloc_cpuset_first() and hwloc_cpuset_next() in hwloc_cpuset_foreach() to sparsely iterate over a cpuset. Regards, Bert --- doc/Makefile.am|1 + include/hwloc/cpuset.h |9

Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines

2010-03-11 Thread Bert Wesarg
On Fri, Mar 12, 2010 at 00:18, Bert Wesarg <bert.wes...@googlemail.com> wrote: > On Fri, Mar 12, 2010 at 00:14, Bert Wesarg <bert.wes...@googlemail.com> wrote: >> On Fri, Mar 12, 2010 at 00:03, Brice Goglin <brice.gog...@inria.fr> wrote: >>> >>> Did

Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines

2010-03-11 Thread Bert Wesarg
On Fri, Mar 12, 2010 at 00:14, Bert Wesarg <bert.wes...@googlemail.com> wrote: > On Fri, Mar 12, 2010 at 00:03, Brice Goglin <brice.gog...@inria.fr> wrote: >> >> Did you actually test this ? The way I am reading the manpage is that >> you need to open with setmnten

Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines

2010-03-11 Thread Bert Wesarg
On Fri, Mar 12, 2010 at 00:03, Brice Goglin wrote: > > Did you actually test this ? The way I am reading the manpage is that > you need to open with setmntent and close with endmntent. I have read the man page, but only about getmntent, and than read the source code for

[hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines

2010-03-11 Thread Bert Wesarg
This does multiple things at once: I) it uses getmntent_r(3) to parse lines from /proc/mounts II) while doing this, it uses the correct un-escape rules for this file format. The current code converts "\ " to " ", while linux uses a "\040" to " " escaping rule. III) it