Re: [hwloc-devel] dynamic cpuset_t?

2009-10-07 Thread Samuel Thibault
Jeff Squyres, le Wed 07 Oct 2009 12:28:00 -0400, a écrit : > On Oct 7, 2009, at 12:20 PM, Brice Goglin wrote: > > >> One comment, I see that you have a > >> hwloc_cpuset_copy (which I would have called duplicate) > >> but copy in the sense of assignment is not really possible (i.e. > >> reusi

Re: [hwloc-devel] dynamic cpuset_t?

2009-10-07 Thread Jeff Squyres
On Oct 7, 2009, at 12:20 PM, Brice Goglin wrote: > One comment, I see that you have a > hwloc_cpuset_copy (which I would have called duplicate) > but copy in the sense of assignment is not really possible (i.e. > reusing an existing allocated cpuset, and initialize it with the > content of

Re: [hwloc-devel] dynamic cpuset_t?

2009-10-07 Thread Brice Goglin
Fawzi Mohamed wrote: > One comment, I see that you have a > hwloc_cpuset_copy (which I would have called duplicate) > but copy in the sense of assignment is not really possible (i.e. > reusing an existing allocated cpuset, and initialize it with the > content of another. I need to think about

Re: [hwloc-devel] dynamic cpuset_t?

2009-10-07 Thread Fawzi Mohamed
On 7-ott-09, at 17:44, Brice Goglin wrote: I just pushed a huge commit converting everything to dynamic cpusets. The new API is visable at https://svn.open-mpi.org/trac/hwloc/browser/trunk/include/hwloc/cpuset.h?rev=1109 The implementation is pretty much the same than our old inlines, see h

Re: [hwloc-devel] dynamic cpuset_t?

2009-10-07 Thread Brice Goglin
I just pushed a huge commit converting everything to dynamic cpusets. The new API is visable at https://svn.open-mpi.org/trac/hwloc/browser/trunk/include/hwloc/cpuset.h?rev=1109 The implementation is pretty much the same than our old inlines, see https://svn.open-mpi.org/trac/hwloc/browser/tr

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-29 Thread Fawzi Mohamed
On 29-set-09, at 20:51, Fawzi Mohamed wrote: On 29-set-09, at 20:43, Samuel Thibault wrote: Fawzi Mohamed, le Tue 29 Sep 2009 20:39:02 +0200, a écrit : It comes down to what you want to have, if you think you might want to go the sparse full granularity way then indeed alloc/copy/free sh

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-29 Thread Fawzi Mohamed
On 29-set-09, at 20:43, Samuel Thibault wrote: Fawzi Mohamed, le Tue 29 Sep 2009 20:39:02 +0200, a écrit : It comes down to what you want to have, if you think you might want to go the sparse full granularity way then indeed alloc/copy/free should be added Yes, that's my point: do we reall

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-29 Thread Samuel Thibault
Fawzi Mohamed, le Tue 29 Sep 2009 20:39:02 +0200, a écrit : > It comes down to what you want to have, if you think you might want to > go the sparse full granularity way then indeed alloc/copy/free should > be added Yes, that's my point: do we really want it? Samuel

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-29 Thread Fawzi Mohamed
On 29-set-09, at 19:18, Samuel Thibault wrote: Samuel Thibault, le Wed 23 Sep 2009 23:51:30 +0200, a écrit : Also, dynamic-size cpuset_t is actually more efficient for small boxes for most operations, as the bitmask will be smaller. As raised in another thread, dynamic-size cpuset_t could

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-29 Thread Samuel Thibault
Samuel Thibault, le Wed 23 Sep 2009 23:51:30 +0200, a écrit : > Also, dynamic-size cpuset_t is actually more efficient for small boxes > for most operations, as the bitmask will be smaller. As raised in another thread, dynamic-size cpuset_t could also permit a sparse implementation for really big

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-28 Thread Samuel Thibault
Jeff Squyres, le Fri 25 Sep 2009 16:02:15 -0400, a écrit : > If we anticipate changing the fixed-size items now, how about adding > some kind of version control in the type name now? Or -- more > specifically -- what are the exact ABI goals? I.e., if we change the > size of the type, will w

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-25 Thread Jeff Squyres
Sorry for not replying earlier. If we anticipate changing the fixed-size items now, how about adding some kind of version control in the type name now? Or -- more specifically -- what are the exact ABI goals? I.e., if we change the size of the type, will we just require a recompile? Or w

Re: [hwloc-devel] dynamic cpuset_t?

2009-09-25 Thread Samuel Thibault
Hello, Just to give my personal opinion: having another ABI shouldn't hurt if we put the cpuset size in the soname for instance. In comparison, having to use functions that allocate/free cpusets like I've done for the AIX and OSF is a bit tedious (those don't have the choice, they have to preserv

[hwloc-devel] dynamic cpuset_t?

2009-09-23 Thread Samuel Thibault
Hello, One thing we weren't so sure about while designing libtopology was whether to use fixed-size cpuset_t or dynamic-size cpuset_t. The advantage of the former is simplicity of course. The currently defined size is 1024 cpus and can easily be configured if one needs more. We could think that 10