Re: proposing Alexander Wels as an ovirt-engine UI maintainer

2015-01-13 Thread Tal Nisan
On 01/21/2014 05:39 PM, Einav Cohen wrote: Hello UI Maintainers, I would like to propose Alexander Wels as an ovirt-engine UI maintainer. +1 Alexander started his ovirt involvement more than a year ago, contributing over 100 patches (to 'master' alone), including the branding mechanism,

Proposing Liron Aravot as an engine-core maintainer

2015-01-13 Thread Tal Nisan
Hi core maintainers, I would like to propose Liron Aravot as an engine-core maintainer. Liron joined the oVirt project on June 2012, and has since contributed over 170 patches to master (not counting backports to various stable branches). He has been instrumental in implementing oVirt's Backup

Re: [ovirt-devel] [URGENT][ACTION REQUIRED] oVirt engine on branch 3.5 doesn't build anymore

2015-01-13 Thread Tal Nisan
This was the commit that introduced this change - http://gerrit.ovirt.org/#/c/32542/ As you see it passed compilation successfully so no one really had a chance to know something was about to break On 09/11/2014 10:02 AM, Sandro Bonazzola wrote: Il 11/09/2014 08:47, Tomas Jelinek ha scritto:

Re: [Engine-devel] proposing Arik Hadas as a maintainer of engine core

2015-01-13 Thread Tal Nisan
On 01/30/2014 10:47 AM, Michal Skrivanek wrote: Dear engine-core maintainers, I'd like to propose Arik Hadas as a maintainer of oVirt engine backend Since he started with oVirt project in October 2012 he was working in various areas in engine core, demonstrated his abilities with more than 200

Re: proposing Greg Sheremeta as an ovirt-engine UI maintainer

2015-03-25 Thread Tal Nisan
+1 from me :)On 25 Mar 2015 14:59, Einav Cohen eco...@redhat.com wrote: Hello UI Maintainers, I would like to propose Greg Sheremeta as an ovirt-engine UI maintainer. Greg started being actively involved in ovirt on July 2013, contributing over 150 patches (to 'master' alone),

Permissions on stable branches

2015-08-19 Thread Tal Nisan
Hi all, In order to better manage the branches I maintain (ovirt-engine 3.5 3.6) I'd like to have permissions to abandon patches and change patch topics, can you please give me those? ___ Infra mailing list Infra@ovirt.org

Re: Permissions on stable branches

2015-08-20 Thread Tal Nisan
Great, then it's all good, thank you! On 08/20/2015 11:34 AM, David Caro wrote: On 08/20, Tal Nisan wrote: It seems that I can abandon 3.6 patches now as well, are you sure I need to be on that group? Nop, you are right, just missed to see that 6 was included in the regexp: ^refs/heads/ovirt

Re: Permissions on stable branches

2015-08-20 Thread Tal Nisan
It seems that I can abandon 3.6 patches now as well, are you sure I need to be on that group? On 08/20/2015 11:19 AM, David Caro wrote: On 08/19, Tal Nisan wrote: Hi all, In order to better manage the branches I maintain (ovirt-engine 3.5 3.6) I'd like to have permissions to abandon patches

Gerrit login with Google opened a new user

2015-08-10 Thread Tal Nisan
I've been using tnisan.id.fedoraproject.org up till now, now I've logged in with tni...@redhat.com Can the two account can be merged to my old user? Thanks. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
the account id you are using? (on the upper right corner, hit your name - settings) On 08/26, Tal Nisan wrote: ovirt-engine-3.6 ovirt-engine-3.5 On Aug 26, 2015 19:07, David Caro dc...@redhat.com wrote: What are your branches? On 08/26, Tal Nisan wrote: Just noticed

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users for that matter) On 08/26/2015 08:00 PM, David Caro wrote: I'm not aware of any changes, maybe you got a duplicated account, that's why I ask for the account id On 08/26, Tal Nisan wrote: I can

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
Just noticed that I now don't have the ability to remove reviews in my branches, can someone have a look why it changed? On 08/20/2015 11:34 AM, David Caro wrote: On 08/20, Tal Nisan wrote: It seems that I can abandon 3.6 patches now as well, are you sure I need to be on that group? Nop, you

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
ovirt-engine-3.6 ovirt-engine-3.5 On Aug 26, 2015 19:07, David Caro dc...@redhat.com wrote: What are your branches? On 08/26, Tal Nisan wrote: Just noticed that I now don't have the ability to remove reviews in my branches, can someone have a look why it changed? On 08/20/2015

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
This is the patch I was talking about: https://gerrit.ovirt.org/#/c/45376/ I cannot remove the Jenkins CI reviewer On 08/26/2015 08:47 PM, David Caro wrote: On 08/26, Tal Nisan wrote: User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users

Re: Permissions on stable branches

2015-08-26 Thread Tal Nisan
It seems that log in and log out solved the problem, thanks for the help David! On 08/26/2015 08:47 PM, David Caro wrote: On 08/26, Tal Nisan wrote: User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users for that matter) I'll need the patch

Re: 3.6.1 branch is not treated as a stable branch, no CI as well

2015-12-01 Thread Tal Nisan
, David Caro <dc...@redhat.com> wrote: > On 12/01 19:25, Tal Nisan wrote: > > Well, it's not my decision but of the integration team, for me as the > > stable branches maintainer it will help a lot to have the gerrit hooks > (I'd > > say even a must) and CI (not a mu

Re: 3.6.1 branch is not treated as a stable branch, no CI as well

2015-12-01 Thread Tal Nisan
even not > having to > change any yaml, but for now it's what we have) > > On 12/01 10:52, Tal Nisan wrote: > > The 3.6.1 branch is not treated by the hooks as a stable branch [1] > > Aside for that, CI is not running on new patches there > > > > [1] > >

Gerrit hooks doesn't recognize 3.6.2 stable branch as a stable branch

2015-12-22 Thread Tal Nisan
Example: https://gerrit.ovirt.org/#/c/50900/ This one should have failed since a patch was still open in a previous branch ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Missing package on one of the Fedora 23 slaves?

2015-11-30 Thread Tal Nisan
Hey guys, It seems that one package is missing on this slave, if I remember correctly it happened in the past in one of the other slaves, can you check? http://jenkins.ovirt.org/job/vdsm_3.6_check-patch-fc23-x86_64/78/console ___ Infra mailing list

3.6.1 branch is not treated as a stable branch, no CI as well

2015-12-01 Thread Tal Nisan
The 3.6.1 branch is not treated by the hooks as a stable branch [1] Aside for that, CI is not running on new patches there [1] - Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1

Re: [ovirt-devel] Request permissions for otopi maintainership

2016-01-12 Thread Tal Nisan
You got my +1 On Tue, Jan 12, 2016 at 3:18 PM, Yedidyah Bar David wrote: > Hi, > > otopi access lists have as unique member Alon Bar-Lev who recently > left the project. > Since I work a lot on engine-setup which is based on otopi, I have > some good experience with it, and

Re: [ovirt-devel] Request permissions for ovirt-host-deploy maintainership

2016-01-12 Thread Tal Nisan
You got my +1 On Tue, Jan 12, 2016 at 3:05 PM, David Caro wrote: > On 01/12 08:02, Martin Perina wrote: > > > > > > - Original Message - > > > From: "Yedidyah Bar David" > > > To: "Eyal Edri" > > > Cc: "David Caro"

Old Jenkins findbugs error ignored

2016-06-06 Thread Tal Nisan
Check out this patch: https://gerrit.ovirt.org/#/c/58652/ Old Jenkins failed on Findbugs (seems like an env problem, not a findbugs analysis failure for that matter). Patch was marked as failed CI yet as soon as the new Jenkins finished its run it overwritten the failed CI of the old Jenkins and

Re: Old Jenkins findbugs error ignored

2016-06-06 Thread Tal Nisan
and work will continue to move it to STD CI, which is more > complex. > > e. > > On Mon, Jun 6, 2016 at 11:34 AM, Tal Nisan <tni...@redhat.com> wrote: > >> Check out this patch: >> >> https://gerrit.ovirt.org/#/c/58652/ >> >> Old Jenkins failed on Fin

Re: DAO test and upgrade appear not to run on 4.0 branch

2016-05-25 Thread Tal Nisan
On Wed, May 25, 2016 at 5:43 PM, David Caro <dc...@redhat.com> wrote: > On 05/25 16:03, Tal Nisan wrote: > > On Wed, May 25, 2016 at 4:00 PM, Eyal Edri <ee...@redhat.com> wrote: > > > > > > > > > > > On Wed, May 25

3.6.3 bugs are wrongly moved to MODIFIED

2016-01-28 Thread Tal Nisan
After merging a patch for a 3.6.3 bug on the ovirt-engine-3.6 branch the bug is moved to MODIFIED, since the 3.6.3 branch was opened yesterday the bug should stay in POST until merged in ovirt-engine-3.6.3 branch as well ___ Infra mailing list

Re: 3.6.3 bugs are wrongly moved to MODIFIED

2016-01-28 Thread Tal Nisan
> (i.e ovirt-engine-3.6.3) ? > > On Thu, Jan 28, 2016 at 3:52 PM, Tal Nisan <tni...@redhat.com> wrote: > >> It makes life easier for everyone when automation moves the bug to >> MODIFIED, if the work is not done then the developer can always move it >> back to POST l

Re: 3.6.3 bugs are wrongly moved to MODIFIED

2016-01-28 Thread Tal Nisan
siest solution to drop this bot, but i belive it will do more > > damage than good. > > Perhaps, then, run it once a day and move to MODIFIED only if last patch > was merged at least X hours ago? Hopefully developers will not wait more > than X before pushing an additional patch for t

3.6.5 is not treated as a monitored stable branch

2016-04-11 Thread Tal Nisan
Quite sure we handled this issue but it seems that it's not treated as monitored still: (Taken from https://gerrit.ovirt.org/#/c/55938) - Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-engine-3.5 ovirt-engine-3.4

Re: 3.6.5 is not treated as a monitored stable branch

2016-04-12 Thread Tal Nisan
>> Build Successful >> >> >> http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el7-x86_64/35/ >> : SUCCESS >> >> >> http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-fc23-x86_64/36/ >> : SUCCESS >> >> >> http://je

Re: [ovirt-devel] [ATN] [ACTION REQUIRED] Tweaking engine CI flow

2016-03-30 Thread Tal Nisan
On Wed, Mar 30, 2016 at 11:45 AM, Roy Golan wrote: > Hi all, > > Eyal and I sat together to analyse and tweak the engine CI and this is > what we came up with: > > - dao test excludes updated - exclude dal/src/main/bundles from invoking > dao tests > A trivial update of

ovirt-engine-3.6.5 branch is not treated by the hooks as a stable branch

2016-03-29 Thread Tal Nisan
Taken from https://gerrit.ovirt.org/55385 - - Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.5.2 ovirt-engine-3.4.0

Re: Build broken cause of commit aeb98b5a5ac807d23008ed26293244efab103bde, please fix ASAP

2016-05-19 Thread Tal Nisan
Oh I see now what you are talking about, indeed in patchset 20 jobs were marked as successful even though the actually failed, a bug indeed On Thu, May 19, 2016 at 5:33 PM, Martin Perina <mper...@redhat.com> wrote: > > > On Thu, May 19, 2016 at 4:26 PM, Tal Nisan <tni...

Re: Build broken cause of commit aeb98b5a5ac807d23008ed26293244efab103bde, please fix ASAP

2016-05-19 Thread Tal Nisan
2/ > > > > The problematic patch is build on patch set 20. It's marked as > successfull, > > although engine build failed: > > > > > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250/console > > > > > > Anyway, we are prep

Cannot clone bugs with more than 2^16 characters in the comments

2016-05-02 Thread Tal Nisan
I've encountered this in this job: http://jenkins-ci.eng.lab.tlv.redhat.com/job/system_bugzilla_clone_zstream_milestone/141/console For this bug: https://bugzilla.redhat.com/1301083 ___ Infra mailing list Infra@ovirt.org

Findbugs job didn't run on a broken patch

2016-05-08 Thread Tal Nisan
Upon looking at another patch I saw that there's a new findbugs issue: http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/ I've fixed the issue in this patch - https://gerrit.ovirt.org/57209 so it's all good now but I'm wondering why the findbugs job

Re: Findbugs job didn't run on a broken patch

2016-05-09 Thread Tal Nisan
ommon/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java > It's configured in Jenkins gerrit filters as a trigger. > > Best Regards, > > Shlomi Ben-David | Software Engineer | Red Hat ISRAEL > IRC: sbendavi > > OPEN SOURCE - 1 4 011 &&

Re: [ovirt-devel] [ATTN] oVirt Engine 4.0 stable branch was created

2016-05-25 Thread Tal Nisan
ilures on CI, > As usual, we should expect some noise and load on CI as it happens usually > when we add a new branch. > > e. > > On Wed, May 25, 2016 at 12:30 PM, Tal Nisan <tni...@redhat.com> wrote: > >> As noted yesterday a stable branch for oVirt Engine 4.0 was

Re: DAO test and upgrade appear not to run on 4.0 branch

2016-05-25 Thread Tal Nisan
On Wed, May 25, 2016 at 4:00 PM, Eyal Edri <ee...@redhat.com> wrote: > > > On Wed, May 25, 2016 at 3:43 PM, Tal Nisan <tni...@redhat.com> wrote: > >> >> >> On Wed, May 25, 2016 at 3:37 PM, Eyal Edri <ee...@redhat.com> wrote: >> >&

DAO test and upgrade appear not to run on 4.0 branch

2016-05-25 Thread Tal Nisan
Encountered that in this patch: https://gerrit.ovirt.org/#/c/58034/ It introduces both an upgrade script change and a change in the DAO layer yet it seems that DAO tests and upgrade test did not run ___ Infra mailing list Infra@ovirt.org

Re: DAO test and upgrade appear not to run on 4.0 branch

2016-05-25 Thread Tal Nisan
d-jenkins. >> > What's needed for that migration? > >> >> >> On Wed, May 25, 2016 at 3:11 PM, Tal Nisan <tni...@redhat.com> wrote: >> >>> Encountered that in this patch: >>> https://gerrit.ovirt.org/#/c/58034/ >>> >>> It intro

Re: DAO test and upgrade appear not to run on 4.0 branch

2016-05-25 Thread Tal Nisan
On Wed, May 25, 2016 at 3:37 PM, Eyal Edri <ee...@redhat.com> wrote: > > > On Wed, May 25, 2016 at 3:33 PM, Tal Nisan <tni...@redhat.com> wrote: > >> >> >> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <ee...@redhat.com> wrote: >> >>>

A patch with wrong target milestone was not blocked in 3.6 stable branch

2016-07-20 Thread Tal Nisan
This patch in 3.6 branch contains a 4.0.2 bug in the Bug-Url: https://gerrit.ovirt.org/#/c/60920 For some reason the Gerrit hooks approved it and did not block ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: [ovirt-devel] gerrit.ovirt.org migration

2016-07-10 Thread Tal Nisan
It was up for a few minutes but it seems to be down now On Sun, Jul 10, 2016 at 5:28 PM, Shlomo Ben David wrote: > Hi All, > > The gerrit.ovirt.org migration process completed successfully. > The server is up and running. > > Best Regards, > > Shlomi Ben-David | Software

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 31.01.2017 ] [add_secondary_storage_domains]

2017-02-01 Thread Tal Nisan
Link? On Tue, Jan 31, 2017 at 7:08 PM, Arik Hadas wrote: > Fixed > > On Tue, Jan 31, 2017 at 6:34 PM, Arik Hadas wrote: > >> Working on a fix >> >> On Tue, Jan 31, 2017 at 5:42 PM, Yaniv Kaul wrote: >> >>> >>> >>> On Tue, Jan 31, 2017 at

Jenkins findbugs issue since yesterday

2017-01-23 Thread Tal Nisan
http://jenkins.ovirt.org/job/ovirt-engine_4.1_find-bugs_created/421/ All builds seem to fail ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Wrong target milestone bugs should be blocked with -verified on the stable branches

2017-01-30 Thread Tal Nisan
Example: https://gerrit.ovirt.org/#/c/71374/ I'd expect the Gerrit hooks to give -1 on verified when a 4.2 bug is pushed into the 4.1 stable branch Thanks. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: Wrong target milestone bugs should be blocked with -verified on the stable branches

2017-01-30 Thread Tal Nisan
> > On Mon, Jan 30, 2017 at 3:29 PM, Tal Nisan <tni...@redhat.com> wrote: > >> Yeah I've noticed the hook identified the situation, I'm asking you to >> make it more stricter, hence the email :) >> >> On Mon, Jan 30, 2017 at 3:22 PM, Eyal Edri <ee...@redhat.com

Re: Wrong target milestone bugs should be blocked with -verified on the stable branches

2017-01-30 Thread Tal Nisan
> > We can make it more strict and give VERIFY -1. > Adding infra-support to open a ticket on it. > > We intentionally didn't enforce Verify as default since we wanted to give > time to the hook > to work and see we don't have false positives on it. > > > On Mon, Jan 30,

Re: Gerrit hooks sometimes doesn't update bugs status

2017-01-18 Thread Tal Nisan
I will try, gotta finish the build issues first, head to the office and then On Wed, Jan 18, 2017 at 11:07 AM, Eyal Edri <ee...@redhat.com> wrote: > > > On Wed, Jan 18, 2017 at 11:06 AM, Tal Nisan <tni...@redhat.com> wrote: > >> We should assume that many bugs th

Re: Gerrit hooks sometimes doesn't update bugs status

2017-01-18 Thread Tal Nisan
URCE - 1 4 011 && 011 4 1 > > On Wed, Jan 18, 2017 at 10:57 AM, Eyal Edri <ee...@redhat.com> wrote: > >> >> >> On Tue, Jan 17, 2017 at 11:06 PM, Tal Nisan <tni...@redhat.com> wrote: >> >>> I've encountered that a few times tod

Re: Gerrit hooks sometimes doesn't update bugs status

2017-01-18 Thread Tal Nisan
Check all of the oVirt 4.1 beta bugs in POST status, seems like all should be on POST as they are not merged on the stable branches On Wed, Jan 18, 2017 at 11:08 AM, Tal Nisan <tni...@redhat.com> wrote: > I will try, gotta finish the build issues first, head to the office and > the

Gerrit hooks sometimes doesn't update bugs status

2017-01-17 Thread Tal Nisan
I've encountered that a few times today, here's on example: https://gerrit.ovirt.org/#/c/70701/ Patch Set 1: Verified-1 - Update Tracker::#1413961::OK, status: POST While the tracker was indeed added, you can see that the bug was not updated to post status After the merge: - Update

Clone job failing although all criteria is met

2017-02-26 Thread Tal Nisan
Trying to clone this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1418280 With the new clone job fails on a missing flag although all flags exist: https://rhev-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/bugzilla_clone_bugs/39/console ___ Infra

Patch pushed to stable branch not by a maintainer (?)

2016-09-06 Thread Tal Nisan
Hi, Roy Golan pushed this patch to the stable branch ovirt-engine-3.6 - https://gerrit.ovirt.org/#/c/62425 and it was merged, can someone please check how can a patch be merged not by Gerrit and by someone who is not a stabke branch maintainer? ___

Re: ovirt-engine-4.0.5 is not treated as a monitored stable branch

2016-10-27 Thread Tal Nisan
', 'ovirt-engine-4.0.4']) On Thu, Oct 27, 2016 at 9:55 AM, Gil Shinar <gshi...@redhat.com> wrote: > Can you please elaborate? > > Thanks > Gil > > On Wed, Oct 26, 2016 at 11:50 AM, Tal Nisan <tni...@redhat.com> wrote: > >> This patch for example

Can not rebase or push updates to patches with different author

2016-10-19 Thread Tal Nisan
Hi, Up till not long ago it was possible to rebase or push updates to patches even if I was not the author of the patch, now I've noticed that when trying to do so I encounter "invalid author" error. For maintainers (especially in the stable branches) this is crucial and makes the cycle much

Cannot run D/S clone jobs

2016-10-18 Thread Tal Nisan
Hi, For some reason I cannot run D/S clone jobs anymore when using this link: https://rhev-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/RHEV-CI/view/system%20jobs/job/system_bugzilla_clone_zstream/ Tal. ___ Infra mailing list Infra@ovirt.org

Add ovirt-engine-4.0.6 branch to the list of stable branches

2016-11-28 Thread Tal Nisan
Otherwise gerrit-hooks ignores it: (taken from gerrit.ovirt.org/67324) gerrit-hooks Nov 25 19:19 ↩ Patch Set 1: - Update Tracker::#1398550::IGNORE, not relevant for Red Hat classification - Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification - Check Public

Seems like every user can remove Gerrit-hooks vote on stable branch

2016-11-28 Thread Tal Nisan
This is wrong, please revert it to how it was before when only stable branch maintainers could remove it ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-26 Thread Tal Nisan
Should be fixed now on master as those patches were just merged: - https://gerrit.ovirt.org/#/c/65738/ - "Move InjectorRule to VdsBroker": aligns the InjectorRule's package with the Injector so it can essentially be used wherever the Injector is used [+12, -4] - https://gerrit.ovirt.org/#/c/65739

ovirt-engine-4.0.5 is not treated as a monitored stable branch

2016-10-26 Thread Tal Nisan
This patch for example: https://gerrit.ovirt.org/#/c/65398/ ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: ovirt-engine-4.0.5 is not treated as a monitored stable branch

2016-10-30 Thread Tal Nisan
; Best Regards, > > Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL > RHCSA | RHCE > IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Sun, Oct 30, 2016 at 9:45 AM, Eyal Edri <ee...@redhat.com> wrote: >

Re: Gerrit hooks doesn't mark open patches in other branches as -verified

2016-12-21 Thread Tal Nisan
; RHCSA | RHCE > IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Wed, Dec 21, 2016 at 1:20 PM, Tal Nisan <tni...@redhat.com> wrote: > >> The hook found out that the patch is open in master which precedes >>

Re: Gerrit hooks doesn't mark open patches in other branches as -verified

2016-12-21 Thread Tal Nisan
HCE > IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Wed, Dec 21, 2016 at 12:39 PM, Tal Nisan <tni...@redhat.com> wrote: > >> Check out this patches for instance: https://gerrit.ovirt.org/#/c/68862 >> ht

Gerrit hooks doesn't mark open patches in other branches as -verified

2016-12-21 Thread Tal Nisan
Check out this patches for instance: https://gerrit.ovirt.org/#/c/68862 https://gerrit.ovirt.org/#/c/68861 Those are 4.1 and 4.0 patches that are open on master, I'd expect to see them get -verified from the hooks which they didn't: - Update Tracker::#1406042::OK, status: POST - Check

Re: Gerrit hooks doesn't mark open patches in other branches as -verified

2016-12-21 Thread Tal Nisan
OK great, in any way I'm there to solve any false positives as I can remove those votes and as you see I notify you team immediately of any failure so should be a problem On Wed, Dec 21, 2016 at 1:40 PM, Eyal Edri <ee...@redhat.com> wrote: > > > On Wed, Dec 21, 2016 at 1:35 PM,

Gerrit hooks change 4.1 bugs status to MODIFIED if merged on master

2016-12-20 Thread Tal Nisan
This should be change to move to MODIFIED only after the bug is merged on the 4.1 branch. Here's an example: https://gerrit.ovirt.org/#/c/68739/ Thanks. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

2016-12-20 Thread Tal Nisan
Heard it from a couple of guys, yesterday it appeared to be working fine, today it's not ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

2016-12-20 Thread Tal Nisan
Master On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri <ee...@redhat.com> wrote: > stable branch maintainers or master branch maintainers? > > On Dec 20, 2016 4:40 PM, "Tal Nisan" <tni...@redhat.com> wrote: > >> Heard it from a couple of guys, yesterday it ap

Gerrit don't check for "Signed-Off" anymore

2016-12-28 Thread Tal Nisan
Last night I've push a serious of patches and forgot to sign off, up until not long ago there was a hook that enforces that but it seems like it's not working anymore and I was able to push the patches without the sign off: https://gerrit.ovirt.org/#/c/69219/1

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

2016-12-20 Thread Tal Nisan
need +2 (w/o merge) to stable branches? > > On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan <tni...@redhat.com> wrote: > >> Master >> >> On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri <ee...@redhat.com> wrote: >> >>> stable branch maintainers or mast

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

2016-12-20 Thread Tal Nisan
#rhev-integ, #rhev-dev, #rhev-ci) > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Tue, Dec 20, 2016 at 6:10 PM, Tal Nisan <tni...@redhat.com> wrote: > >> None, just +2, especially not remove other reviewers as sometimes people >> remove the gerrit-hooks wi

Findbugs issues not reported correctly on Jenkins master jobs?

2017-05-15 Thread Tal Nisan
I've pushed this patch to master: https://gerrit.ovirt.org/#/c/75994/ Jenkins showed no findbugs error and I moved on to merging it Then I've pushed the same patch to 4.1: https://gerrit.ovirt.org/#/c/76803/ And it resulted in two findbugs errors (though minor and style related):

Re: Findbugs issues not reported correctly on Jenkins master jobs?

2017-05-15 Thread Tal Nisan
you provide the log from your local run? which files were exported on > your local run? > > On Mon, May 15, 2017 at 11:51 AM Tal Nisan <tni...@redhat.com> wrote: > >> I've pushed this patch to master: >> https://gerrit.ovirt.org/#/c/75994/ >> Jenkins showed n

Every user can abandon patches that are not his

2017-06-07 Thread Tal Nisan
Hi, I've discovered that every user can abandon patches even if they are not his, here's an example of Shani abandoning my patch which shouldn't be allowed: https://gerrit.ovirt.org/#/c/77919/ ___ Infra mailing list Infra@ovirt.org

Rerun-hooks doesn't work

2018-05-09 Thread Tal Nisan
The Rerun-hooks: all used to rerun the hooks after changing something in the commit message doesn't work for a few months now and it's quite needed ___ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-le...@ovirt.org

Check patch jobs for Fedora 28 are failing

2018-06-04 Thread Tal Nisan
Example: http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc28-x86_64/67/console Exception snippet: *12:12:36* Traceback (most recent call last):*12:12:36* File "/usr/bin/isort", line 6, in *12:12:36* from pkg_resources import load_entry_point*12:12:36* File

Re: Check patch jobs for Fedora 28 are failing

2018-06-04 Thread Tal Nisan
Great, thanks On Mon, Jun 4, 2018 at 5:08 PM, Sandro Bonazzola wrote: > > > 2018-06-04 16:00 GMT+02:00 Tal Nisan : > >> Also on 4.2? >> > > 4.2 fc28 jobs should have disappeared from jenkins 3 hours ago > > > >> >> On Mon, Jun 4, 2018 at 4:25

Re: Check patch jobs for Fedora 28 are failing

2018-06-04 Thread Tal Nisan
> Thanks, > > >> >> >> On 4 June 2018 at 15:31, Tal Nisan wrote: >> >>> Example: >>> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch >>> -fc28-x86_64/67/console >>> >>> Exception snippet: >>>

fcraw Jenkins build fails on import error

2018-02-05 Thread Tal Nisan
*http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fcraw-x86_64/29/consoleFull * *10:53:31* ERRORS *10:53:31* ERROR

Re: [ovirt-devel] Re: [ OST Failure Report ] [ oVirt master (ovirt-engine) ] [ 6-08-2018 ] [ TEST NAME ]

2018-08-07 Thread Tal Nisan
Eli, Daniel is on PTO today, as the main DB guy can you please have a look? On Mon, Aug 6, 2018 at 5:38 PM, Tal Nisan wrote: > Daniel please check it ASAP tomorrow, we cannot release the async without > being sure the script doesn't fail > -- Forwarded message -- >

Re: [ovirt-devel] Re: [ OST Failure Report ] [ oVirt master (ovirt-engine) ] [ 6-08-2018 ] [ TEST NAME ]

2018-08-06 Thread Tal Nisan
Daniel please check it ASAP tomorrow, we cannot release the async without being sure the script doesn't fail -- Forwarded message -- From: Sandro Bonazzola Date: Mon, Aug 6, 2018 at 3:48 PM Subject: [ovirt-devel] Re: [ OST Failure Report ] [ oVirt master (ovirt-engine) ] [

Re: [CQ Failure Report] [Ovirt 4.2] [4.7.18]

2018-07-05 Thread Tal Nisan
The task is stuck and never cleared after the restart or we just have to wait for it to be finished and cleared? On Thu, Jul 5, 2018 at 12:30 PM, Dafna Ron wrote: > Jira opened: https://ovirt-jira.atlassian.net/browse/OVIRT-2286 > > Tal, can you help fix the test? > > thanks, > Dafna > > > On

Jenkins sometimes does't mark CI+1

2018-03-13 Thread Tal Nisan
For instance: https://gerrit.ovirt.org/#/c/88604/ ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Clone job broken?

2018-12-18 Thread Tal Nisan
Tried to close a bug, it failed with ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618) https://rhv-devops-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/bugzilla_clone_bugs/150/console ___ Infra mailing list --

Fwd: [ovirt-devel] Re: Proposing Fred Rolland as a Storage backend maintainer

2018-11-19 Thread Tal Nisan
ats :) On Thu, Nov 15, 2018 at 5:34 PM Nir Soffer wrote: > +1 > > My only concern Fred will spend even less time on vdsm now :-) > > On Thu, Nov 15, 2018 at 1:03 PM Tal Nisan wrote: > >> Hi everyone, >> I'd like to propose Fred as a backend maintainer in Engine for the

Re: [ovirt-devel] Re: ovirt-engine has been tagged (ovirt-engine-4.3.1)

2019-02-19 Thread Tal Nisan
On Tue, Feb 19, 2019 at 5:34 PM Eyal Edri wrote: > > > On Tue, Feb 19, 2019 at 5:26 PM Sandro Bonazzola > wrote: > >> >> >> Il giorno mar 19 feb 2019 alle ore 15:59 Tal Nisan >> ha scritto: >> >>> >>> >>> On Tue, Feb 19, 2

Re: Storage test case needs to be fixed: 002_bootstrap.resize_and_refresh_storage_domain

2019-05-21 Thread Tal Nisan
Sure, Shani can you please have a look? On Mon, May 20, 2019 at 8:30 PM Dafna Ron wrote: > Hi Tal, > > I am seeing random failures for test > 002_bootstrap.resize_and_refresh_storage_domain > It looks like this is a timing issue since by the time we print out the > error we actually see the

Re: URGENT - ovirt-engine master is failing for the past 9 days

2019-09-01 Thread Tal Nisan
OST failing for 9 days is totally unacceptable, the only reason I'm not sending a revert patch is that it'll make a bloody mess with the upgrade scripts as we have two on top of it, this needs to be fixed ASAP On Sun, Sep 1, 2019 at 3:27 PM Dafna Ron wrote: > Hi, > > We have been failing CQ

Re: URGENT - ovirt-engine master is failing for the past 9 days

2019-09-02 Thread Tal Nisan
; On Mon, 2 Sep 2019 at 10:16, Andrej Krejcir wrote: >> >>> I will post a fix later today. Sorry for the delay, It took me a while >>> to figure out what is the problem. >>> >>> On Sun, 1 Sep 2019 at 14:58, Tal Nisan wrote: >>> >>>> OST f

[JIRA] (OVIRT-515) Re: Cannot clone bugs with more than 2^16 characters in the comments

2016-05-02 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309#comment-15309 ] Tal Nisan commented on OVIRT-515: - Any ETA on the fix? On Mon, May 2, 2016 at 12:41 PM, David Caro <

[JIRA] (OVIRT-1089) Re: Wrong target milestone bugs should be blocked with -verified on the stable branches

2017-01-30 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=26435#comment-26435 ] Tal Nisan commented on OVIRT-1089: -- Yeah I've noticed the hook identified the situation, I'm asking you

[JIRA] (OVIRT-1089) Re: Wrong target milestone bugs should be blocked with -verified on the stable branches

2017-01-30 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=26437#comment-26437 ] Tal Nisan commented on OVIRT-1089: -- I will, I'm dedicated to make my life as a stable branch maintainer

[JIRA] (OVIRT-1046) Re: Gerrit hooks sometimes doesn't update bugs status

2017-01-18 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=25901#comment-25901 ] Tal Nisan commented on OVIRT-1046: -- We should assume that many bugs that will be included in today's build

[JIRA] (OVIRT-1046) Re: Gerrit hooks sometimes doesn't update bugs status

2017-01-18 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=25904#comment-25904 ] Tal Nisan commented on OVIRT-1046: -- Check all of the oVirt 4.1 beta bugs in POST status, seems like all

[JIRA] (OVIRT-990) Re: Gerrit don't check for "Signed-Off" anymore

2017-01-03 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=25086#comment-25086 ] Tal Nisan commented on OVIRT-990: - Tested yesterday and it seems to be working OK, can close On Tue, Jan 3

[JIRA] (OVIRT-990) Re: Gerrit don't check for "Signed-Off" anymore

2016-12-28 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=25029#comment-25029 ] Tal Nisan commented on OVIRT-990: - Not ideal, it's used for rebasing other users patches, set it to maintainers

[JIRA] (OVIRT-1381) Re: Findbugs issues not reported correctly on Jenkins master jobs?

2017-05-18 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=30909#comment-30909 ] Tal Nisan commented on OVIRT-1381: -- mvn findbugs:findbugs, it generates the report On Thu, May 18, 2017 at 2

[JIRA] (OVIRT-1381) Re: Findbugs issues not reported correctly on Jenkins master jobs?

2017-05-22 Thread Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=31116#comment-31116 ] Tal Nisan commented on OVIRT-1381: -- Quoting amuerini: "Hi guys, There's a good chance that

  1   2   >