[Intel-gfx] [PATCH] drm/i915: Address broxton phy registers based on phy and channel number

The port registers related to the phys in broxton map to different channels and specific phys. Make that mapping explicit. v2: Pass enum dpio_phy to macros instead of mmio base. (Imre) v3: Fix typo in macros. (Imre) Signed-off-by: Ander Conselvan de Oliveira

Re: [Intel-gfx] [PATCH v4 i-g-t 3/3] aubdump: add --command option to stream aubdump to another program

>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Thursday, October 06, 2016 8:17 AM >To: intel-gfx@lists.freedesktop.org >Cc: Gandikota, Sirisha >Subject: [Intel-gfx] [PATCH v4 i-g-t

Re: [Intel-gfx] [PATCH i-g-t 1/3] tools: intel_aubdump: avoid initializing multiple times

>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Thursday, October 06, 2016 8:17 AM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH i-g-t 1/3] tools: intel_aubdump: avoid initializing >multiple

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to handle GuC when GuC is not supported.

On Thu, 2016-10-06 at 09:36 -0300, Paulo Zanoni wrote: > Em Qua, 2016-10-05 às 23:37 +, Vivi, Rodrigo escreveu: > > Hi Daniel, > > > > So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573 > > with > > wontfix or notabug? > > > > I don't have a strong side on that actually, but

Re: [Intel-gfx] [PATCH 1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

On Wed, Oct 05, 2016 at 03:56:39PM +0200, Daniel Vetter wrote: > On Mon, Sep 26, 2016 at 12:20:44PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf. > > > > According to [1]

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Move down skl/kbl ddi iboost and n_edp_entires fixup (rev2)

== Series Details == Series: series starting with [1/2] drm/i915: Move down skl/kbl ddi iboost and n_edp_entires fixup (rev2) URL : https://patchwork.freedesktop.org/series/13171/ State : warning == Summary == Series 13171v2 Series without cover letter

Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

I also asked that same question many times. Maybe they can be unified later when we enable submission by default, but right now I believe this is the way to go, so Reviewed-by: Rodrigo Vivi On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha

Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

>-Original Message- >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] >Sent: Wednesday, October 5, 2016 11:57 PM >To: Srivatsa, Anusha >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default > >On Wed, Oct

[Intel-gfx] [PATCH] drm/i915: KBL - Recommended buffer translation programming for DisplayPort

According to spec: "KBL re-uses SKL values, except where specific KBL values are listed." And recently spec has changed adding different table for Display Port only. But for all SKUs (H,S,U,Y) we have slightly different values. v2: Fix wrong condition spotted by Jani. Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.BAT: warning for Broxton ddi phy refactoring (rev2)

== Series Details == Series: Broxton ddi phy refactoring (rev2) URL : https://patchwork.freedesktop.org/series/13320/ State : warning == Summary == Series 13320v2 Broxton ddi phy refactoring https://patchwork.freedesktop.org/api/1.0/series/13320/revisions/2/mbox/ Test kms_pipe_crc_basic:

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On Thu, Oct 06, 2016 at 05:38:12PM +0100, Tvrtko Ursulin wrote: > > On 05/10/2016 18:11, Ville Syrjälä wrote: > > On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> Use types of more appropriate size in struct > >>

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Reset the breadcrumbs IRQ more carefully (rev2)

== Series Details == Series: drm/i915: Reset the breadcrumbs IRQ more carefully (rev2) URL : https://patchwork.freedesktop.org/series/13375/ State : warning == Summary == Series 13375v2 drm/i915: Reset the breadcrumbs IRQ more carefully

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On 05/10/2016 18:11, Ville Syrjälä wrote: On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH v2 5/9] drm/i915: Move DPIO phy documentation section to intel_dpio_phy.c

Move the DPIO phy documentation section to intel_dpio_phy.c, since that is a more suitable place now that there is a source file dedicated for those phys. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre Deak ---

[Intel-gfx] [PATCH v2 3/9] drm/i915: Pass lane count to bxt_ddi_phy_calc_lane_optmin_mask()

Pass lane count to bxt_ddi_phy_calc_lane_optmin_mask() instead of having it extract that number from a pipe_config to decouple the phy code from intel_crtc_state. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre Deak ---

[Intel-gfx] [PATCH v2 8/9] drm/i915: Add location of the Rcomp resistor to bxt_ddi_phy_info

Use struct bxt_ddi_phy_info to hold information of where the Rcomp resistor is located, instead of hard coding it in the init sequence. Note that this moves the enabling of the phy with the Rcomp resistor out of the power well enable code. That should be safe since bxt_ddi_phy_init() is called

[Intel-gfx] [PATCH v2 2/9] drm/i915: Explicitly map broxton DPIO power wells to phys

The mapping from the BXT_DPIO_CMN_* power wells to their respective phys required a detour implemented in the bxt_power_well_to_phy() function. Instead, embed that information directly into the power_well struct, by resurrecting the data field. Signed-off-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH v2 6/9] drm/i915: Move broxton vswing sequence to intel_dpio_phy.c

The vswing sequence is related to the DPIO phy, so move it closer to the rest of DPIO phy related code. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre Deak --- drivers/gpu/drm/i915/i915_drv.h | 3 ++-

[Intel-gfx] [PATCH v2 7/9] drm/i915: Create a struct to hold information about the broxton phys

Information about which phy is dual channel is hardcoded in the phy init sequence. Split that to a separate struct so the init sequence is more generic. v2: Restore mangled part that ended up in following patch. (Imre) Signed-off-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH v2 1/9] drm/i915: Rename struct i915_power_well field data to id

Calling it data seems to imply arbitrary data can be associated with the power well. However, that field is used for look ups and expected to be unique, so rename it. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre Deak

[Intel-gfx] [PATCH v2 0/9] Broxton ddi phy refactoring

Update series with review addressed. Changes since v1: - Use lockdep_assert_help() in bxt_ddi_phy_init(). - Fix mangled patch. - Pass enum dpio_phy instead of mmio base to macroc. Thanks, Ander Ander Conselvan de Oliveira (9): drm/i915: Rename struct i915_power_well field data to id

[Intel-gfx] [PATCH v2 4/9] drm/i915: Move broxton phy code to intel_dpio_phy.c

The phy in broxton is also a dpio phy, similar to cherryview but with programming through MMIO. So move the code together with the other similar phys. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre Deak ---

[Intel-gfx] [PATCH v2 9/9] drm/i915: Address broxton phy registers based on phy and channel number

The port registers related to the phys in broxton map to different channels and specific phys. Make that mapping explicit. v2: Pass enum dpio_phy to macros instead of mmio base. (Imre) Signed-off-by: Ander Conselvan de Oliveira ---

[Intel-gfx] [PATCH v2] drm/i915: Reset the breadcrumbs IRQ more carefully

Along with the interrupt, we want to restore the fake-irq and wait-timeout detection. If we use the breadcrumbs interface to setup the interrupt as it wants, the auxiliary timers will also be restored. v2: Cancel both timers as well, sanitize the IMR. Fixes: 821ed7df6e2a ("drm/i915: Update reset

[Intel-gfx] [PATCH v11 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov ---

[Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

The core provides now an ABI to userspace for generation of frame CRCs, so implement the ->set_crc_source() callback and reuse as much code as possible with the previous ABI implementation. When handling the pageflip interrupt, we skip 1 or 2 frames depending on the HW because they contain wrong

[Intel-gfx] [PATCH v11 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. v9: Have

[Intel-gfx] [PATCH v11 0/4] New debugfs API for capturing CRC of frames

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers

[Intel-gfx] [PATCH i-g-t 2/3] tools: intel_aubdump: pass configuration through file descriptor

This makes parsing options less complicated and easier to extend. Signed-off-by: Lionel Landwerlin --- tools/aubdump.c| 32 ++-- tools/intel_aubdump.in | 22 +++--- 2 files changed, 37 insertions(+), 17

[Intel-gfx] [PATCH i-g-t 1/3] tools: intel_aubdump: avoid initializing multiple times

For some reason init() seems to be called multiple times. Let's move the initialization to the first ioctl(). Signed-off-by: Lionel Landwerlin --- tools/aubdump.c | 44 1 file changed, 28 insertions(+), 16 deletions(-)

[Intel-gfx] [PATCH v4 i-g-t 3/3] aubdump: add --command option to stream aubdump to another program

This comes handy if you want to look at your application output without having to save it into a file. For example, use this with aubinator from Mesa : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app v2: Fix handling empty command line option v3: Fix command line concatenation

[Intel-gfx] [PATCH v10 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov ---

[Intel-gfx] [PATCH v10 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. v9: Have

[Intel-gfx] [PATCH v10 3/4] drm/i915: Use new CRC debugfs API

The core provides now an ABI to userspace for generation of frame CRCs, so implement the ->set_crc_source() callback and reuse as much code as possible with the previous ABI implementation. When handling the pageflip interrupt, we skip 1 or 2 frames depending on the HW because they contain wrong

[Intel-gfx] [PATCH v10 0/4] New debugfs API for capturing CRC of frames

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Unwind GuC workqueue reservation if request construction fails

== Series Details == Series: drm/i915/guc: Unwind GuC workqueue reservation if request construction fails URL : https://patchwork.freedesktop.org/series/13390/ State : success == Summary == Series 13390v1 drm/i915/guc: Unwind GuC workqueue reservation if request construction fails

Re: [Intel-gfx] [PATCH] drm/i915: Reset the breadcrumbs IRQ more carefully

On Thu, Oct 06, 2016 at 05:02:44PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote: > >> Chris Wilson writes: > >> > >> > Along with the interrupt, we want to restore the

Re: [Intel-gfx] [PATCH] drm/i915/guc: Unwind GuC workqueue reservation if request construction fails

On Thu, Oct 06, 2016 at 02:34:46PM +0100, Chris Wilson wrote: > We reserve space in the GuC workqueue for submitting the request in the > future. However, if we fail to construct the request, we need to give > that reserved space back to the system. > > Fixes: dadd481bfe55 ("drm/i915/guc: Prepare

Re: [Intel-gfx] [PATCH] drm/i915: Reset the breadcrumbs IRQ more carefully

Chris Wilson writes: > On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote: >> Chris Wilson writes: >> >> > Along with the interrupt, we want to restore the fake-irq and >> > wait-timeout detection. If we use the breadcrumbs

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: Delay GuC workqueue reservation

== Series Details == Series: drm/i915/guc: Delay GuC workqueue reservation URL : https://patchwork.freedesktop.org/series/13388/ State : warning == Summary == Series 13388v1 drm/i915/guc: Delay GuC workqueue reservation https://patchwork.freedesktop.org/api/1.0/series/13388/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/i915: Reset the breadcrumbs IRQ more carefully

On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > Along with the interrupt, we want to restore the fake-irq and > > wait-timeout detection. If we use the breadcrumbs interface to setup the > > interrupt as it wants, the

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Leave basic breadcrumbs in dmesg

On Thu, Oct 06, 2016 at 03:37:50PM +0300, Ville Syrjälä wrote: > On Thu, Oct 06, 2016 at 03:17:45PM +0300, Jani Nikula wrote: > > On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > Leave the normal "executing" and

[Intel-gfx] [PATCH i-g-t 3/5] tests/vgem_reload_basic: Leave breadcrumbs in dmesg

From: Ville Syrjälä Source drm_lib.sh instead of drm_getopt.sh so that we get the "executing", and "exiting" breadcrumbs in dmesg. Signed-off-by: Ville Syrjälä --- tests/vgem_reload_basic | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH i-g-t 4/5] tests/tools_test: Fix it up for intel_reg

From: Ville Syrjälä intel_reg_read and intel_reg_dumper are no more. Switch over to intel_reg. Signed-off-by: Ville Syrjälä --- tests/tools_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t 5/5] tools/intel_reg: Return SUCCESS after a succesful dump

From: Ville Syrjälä No reason why 'intel_reg dump' can't declare success after a succesful dumping. Spotted after fixing tools_test to use the right tool :) Signed-off-by: Ville Syrjälä --- tools/intel_reg.c | 2 +- 1 file changed,

[Intel-gfx] [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests

From: Ville Syrjälä Leave the normal "executing" and "exiting" breadcrumbs into dmesg when running the test. Signed-off-by: Ville Syrjälä --- tests/drm_lib.sh | 24 1 file changed, 24 insertions(+) diff

[Intel-gfx] [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh

From: Ville Syrjälä debugfs_wedged and drm_lib.sh are already using bashism so switch over to using #!/bin/bash instead of #!/bin/sh. Signed-off-by: Ville Syrjälä --- tests/debugfs_wedged | 2 +- tests/drm_lib.sh | 2 +- 2

[Intel-gfx] [PATCH] drm/i915/guc: Unwind GuC workqueue reservation if request construction fails

We reserve space in the GuC workqueue for submitting the request in the future. However, if we fail to construct the request, we need to give that reserved space back to the system. Fixes: dadd481bfe55 ("drm/i915/guc: Prepare for nonblocking execbuf submission") Bugzilla:

Re: [Intel-gfx] [PATCH] drm/i915: Reset the breadcrumbs IRQ more carefully

Chris Wilson writes: > Along with the interrupt, we want to restore the fake-irq and > wait-timeout detection. If we use the breadcrumbs interface to setup the > interrupt as it wants, the auxiliary timers will also be restored. > > Fixes: 821ed7df6e2a ("drm/i915:

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to handle GuC when GuC is not supported.

On Thu, 06 Oct 2016, Paulo Zanoni wrote: > Em Qua, 2016-10-05 às 23:37 +, Vivi, Rodrigo escreveu: >> Hi Daniel, >> >> So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573 >> with >> wontfix or notabug? >> >> I don't have a strong side on that

Re: [Intel-gfx] [PATCH] drm/i915/guc: Delay GuC workqueue reservation

On Thu, Oct 06, 2016 at 03:14:19PM +0200, Michał Winiarski wrote: > We're reserving space in the workqueue early during request allocation. > This can be problematic if we get interrupted later in the process, > because we can end up in a state where GuC workqueue is seemingly full, > while the HW

[Intel-gfx] [PATCH] drm/i915/guc: Delay GuC workqueue reservation

We're reserving space in the workqueue early during request allocation. This can be problematic if we get interrupted later in the process, because we can end up in a state where GuC workqueue is seemingly full, while the HW is idle and no work has been submitted. Let's delay the reservation to

Re: [Intel-gfx] [PATCH v3 i-g-t] aubdump: add --command option to stream aubdump to another program

On 06/10/16 13:46, Ville Syrjälä wrote: On Thu, Oct 06, 2016 at 11:13:22AM +0100, Lionel Landwerlin wrote: This comes handy if you want to look at your application output without having to save it into a file. For example, use this with aubinator from Mesa : $ intel_aubdump -c

Re: [Intel-gfx] [PATCH v3 i-g-t] aubdump: add --command option to stream aubdump to another program

On Thu, Oct 06, 2016 at 11:13:22AM +0100, Lionel Landwerlin wrote: > This comes handy if you want to look at your application output without > having to save it into a file. For example, use this with aubinator from > Mesa : > > $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Why not

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Leave basic breadcrumbs in dmesg

On Thu, Oct 06, 2016 at 03:17:45PM +0300, Jani Nikula wrote: > On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when > > running the test. > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to handle GuC when GuC is not supported.

Em Qua, 2016-10-05 às 23:37 +, Vivi, Rodrigo escreveu: > Hi Daniel, > > So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573 > with > wontfix or notabug? > > I don't have a strong side on that actually, but Jani was against it > it > seems. Just my opinion: Considering that

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

On Thu, 06 Oct 2016, Jani Nikula wrote: > On Thu, 06 Oct 2016, Ville Syrjälä wrote: >> On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote: >>> == Series Details == >>> >>> Series: series starting with [1/3] Revert "Skip

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

On Thu, 06 Oct 2016, Ville Syrjälä wrote: > On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote: >> == Series Details == >> >> Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS >> 8700" >> URL :

Re: [Intel-gfx] [PATCH] drm/i915: Force relocations via cpu if we run out of idle aperture

On to, 2016-10-06 at 08:41 +0100, Chris Wilson wrote: > If we run out of enough aperture space to fit the entire object, we > fallback to trying to insert a single page. However, if that also fails, > we currently fail to userspace with an unexpected ENOSPC. (ENOSPC means > to userspace that their

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS > 8700" > URL : https://patchwork.freedesktop.org/series/12920/ > State : warning > > == Summary == > > Series 12920v1 Series

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Leave basic breadcrumbs in dmesg

On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when > running the test. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Add location of the Rcomp resistor to bxt_ddi_phy_info

On to, 2016-10-06 at 14:50 +0300, Ander Conselvan De Oliveira wrote: > On Wed, 2016-10-05 at 17:51 +0300, Imre Deak wrote: > > On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira > > wrote: > > > > > > Use struct bxt_ddi_phy_info to hold information of where the > > > Rcomp > > >

[Intel-gfx] [PATCH i-g-t] tests/drv_module_reload_basic: Leave basic breadcrumbs in dmesg

From: Ville Syrjälä Leave the normal "executing" and "exiting" breadcrumbs into dmesg when running the test. Signed-off-by: Ville Syrjälä --- tests/drv_module_reload_basic | 27 +++ 1 file changed, 27

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Add location of the Rcomp resistor to bxt_ddi_phy_info

On Wed, 2016-10-05 at 17:51 +0300, Imre Deak wrote: > On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > > > > Use struct bxt_ddi_phy_info to hold information of where the Rcomp > > resistor is located, instead of hard coding it in the init sequence. > > > > Note that this

Re: [Intel-gfx] [PATCH] drm/i915/gen9: fix DDB partitioning for multi-screen cases

Op 04-10-16 om 19:44 schreef Paulo Zanoni: > Em Ter, 2016-10-04 às 14:37 -0300, Paulo Zanoni escreveu: >> With the previous code we were only recomputing the DDB partitioning >> for the CRTCs included in the atomic commit, so any other active >> CRTCs >> would end up having their DDB registers

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

> > On 06/10/16 13:26, Conselvan De Oliveira, Ander wrote: > > On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote: > >> On Wed, 05 Oct 2016, "Argotti, Yann" wrote: > >>> > > > > > On Mon, 03 Oct 2016, Jairo Miramontes > >

Re: [Intel-gfx] [PATCH 0/6] Start of skl watermark cleanup

Op 05-10-16 om 17:33 schreef Lyude: > While it (mostly) works, the code for handling watermarks on Skylake has been > kind of ugly for a while. As well a lot of it isn't that friendly to atomic > transactions, Lots of copy paste, redundant wm values, etc. While this isn't a > full cleanup, it's a

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

On 06/10/16 13:26, Conselvan De Oliveira, Ander wrote: On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote: On Wed, 05 Oct 2016, "Argotti, Yann" wrote: On Mon, 03 Oct 2016, Jairo Miramontes wrote: This week

Re: [Intel-gfx] [PATCH 4/6] drm/i915/gen9: Make skl_wm_level per-plane

Op 05-10-16 om 22:33 schreef Paulo Zanoni: > Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu: >> Having skl_wm_level contain all of the watermarks for each plane is >> annoying since it prevents us from having any sort of object to >> represent a single watermark level, something we take

Re: [Intel-gfx] [PATCH v2 07/15] drm/omap: Use per-plane rotation property

On 06/10/16 13:30, Ville Syrjälä wrote: > On Thu, Oct 06, 2016 at 12:59:17PM +0300, Tomi Valkeinen wrote: >> >> On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote: >>> From: Ville Syrjälä >>> >>> The global mode_config.rotation_property is going away, switch

Re: [Intel-gfx] [PATCH v2 07/15] drm/omap: Use per-plane rotation property

On Thu, Oct 06, 2016 at 12:59:17PM +0300, Tomi Valkeinen wrote: > > On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The global mode_config.rotation_property is going away, switch over to > > per-plane rotation_property. > >

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote: > On Wed, 05 Oct 2016, "Argotti, Yann" wrote: > > > > > > > > > > > > > On Mon, 03 Oct 2016, Jairo Miramontes > > > > wrote: > > > > > > > > > > This week regressions

Re: [Intel-gfx] [PATCH v2 i-g-t 2/2] aubdump: add --command option to stream aubdump to another program

On Wed, Oct 05, 2016 at 11:48:27PM +0100, Lionel Landwerlin wrote: > This comes handy if you want to look at your application output without > having to save it into a file. For example, use this with aubinator from > Mesa : > > $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app > > v2:

[Intel-gfx] [PATCH v3 i-g-t] aubdump: add --command option to stream aubdump to another program

This comes handy if you want to look at your application output without having to save it into a file. For example, use this with aubinator from Mesa : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app v2: Fix handling empty command line option v3: Fix command line concatenation

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

On Wed, 05 Oct 2016, "Argotti, Yann" wrote: >> > On Mon, 03 Oct 2016, Jairo Miramontes >> > wrote: >> > > This week regressions >> > >> > In the past we used "regression", "bisect_pending", and "bisected" in >> > the bugzilla

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Sort DEV_INFO_FOR_EACH_FLAG

On 04/10/2016 14:32, Chris Wilson wrote: On Tue, Oct 04, 2016 at 03:42:58PM +0300, Joonas Lahtinen wrote: Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*). Signed-off-by: Joonas Lahtinen Ok. Looks like it should be easier to read. Reviewed-by:

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Create a struct to hold information about the broxton phys

On to, 2016-10-06 at 12:56 +0300, Imre Deak wrote: > On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > > Information about which phy is dual channel is hardcoded in the phy > > init > > sequence. Split that to a separate struct so the init sequence is > > more > > generic. > >

Re: [Intel-gfx] [PATCH v2 07/15] drm/omap: Use per-plane rotation property

On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The global mode_config.rotation_property is going away, switch over to > per-plane rotation_property. > > Not sure I got the annoying crtc rotation_property handling right. > Might

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Create a struct to hold information about the broxton phys

On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > Information about which phy is dual channel is hardcoded in the phy init > sequence. Split that to a separate struct so the init sequence is more > generic. > > Signed-off-by: Ander Conselvan de Oliveira > --- >  

Re: [Intel-gfx] [PATCH] tests/igt: dmesg noise is a kernel failure

On Thu, Oct 06, 2016 at 11:07:17AM +0200, Daniel Vetter wrote: > At least when testing the kernel. In normal programs pretty much all > the dmesg noise would simply be replaced by debug asserts, but in the > kernel we try rely hard to not fall over minor inconsistencies. > > Still for CI purposes

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Address broxton phy registers based on phy and channel number

On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > The port registers related to the phys in broxton map to different > channels and specific phys. Make that mapping explicit. > > Signed-off-by: Ander Conselvan de Oliveira > --- >  drivers/gpu/drm/i915/i915_drv.h   |   2

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Add explicit test lists for CI use.

Regardless of the list of tests we expect to pass, I think it's better to have an actual list rather than relying on the name of the tests (as we have been doing or are still doing, correct me if I'm wrong). Thanks for doing this! Acked-by: Lionel Landwerlin

Re: [Intel-gfx] [PATCH] tests/igt: dmesg noise is a kernel failure

On Thu, Oct 06, 2016 at 11:07:17AM +0200, Daniel Vetter wrote: > At least when testing the kernel. In normal programs pretty much all > the dmesg noise would simply be replaced by debug asserts, but in the > kernel we try rely hard to not fall over minor inconsistencies. > > Still for CI purposes

Re: [Intel-gfx] [PATCH i-g-t 1/2] aubdump: remove already handled -o

On 06/10/16 10:09, Petri Latvala wrote: On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote: - -o*) - file=${1##-o} - shift - ;; This breaks using -ofilename without spaces. Oh right, I didn't realize that was an acceptable input.

[Intel-gfx] [PATCH] drm/i915: Reset the breadcrumbs IRQ more carefully

Along with the interrupt, we want to restore the fake-irq and wait-timeout detection. If we use the breadcrumbs interface to setup the interrupt as it wants, the auxiliary timers will also be restored. Fixes: 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests") Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t 1/2] aubdump: remove already handled -o

On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote: > - -o*) > - file=${1##-o} > - shift > - ;; This breaks using -ofilename without spaces. -- Petri Latvala ___ Intel-gfx mailing list

[Intel-gfx] [PATCH] tests/igt: dmesg noise is a kernel failure

At least when testing the kernel. In normal programs pretty much all the dmesg noise would simply be replaced by debug asserts, but in the kernel we try rely hard to not fall over minor inconsistencies. Still for CI purposes there's not really a difference, hence don't treat it as such.

[Intel-gfx] [PATCH v9 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. v9: Have

[Intel-gfx] [PATCH v9 3/4] drm/i915: Use new CRC debugfs API

The core provides now an ABI to userspace for generation of frame CRCs, so implement the ->set_crc_source() callback and reuse as much code as possible with the previous ABI implementation. When handling the pageflip interrupt, we skip 1 or 2 frames depending on the HW because they contain wrong

[Intel-gfx] [PATCH v9 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov ---

[Intel-gfx] [PATCH v9 0/4] New debugfs API for capturing CRC of frames

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers

[Intel-gfx] [PATCH i-g-t v2] tests: Add explicit test lists for CI use.

See tests/intel-ci/README for rationale and explanation. v2: Use the current BAT set for fast-feedback.testlist first Signed-off-by: Petri Latvala --- Thanks for the feedback. This commit only contains the current test set, extended test suites are left for future

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Force relocations via cpu if we run out of idle aperture

== Series Details == Series: drm/i915: Force relocations via cpu if we run out of idle aperture URL : https://patchwork.freedesktop.org/series/13368/ State : warning == Summary == Series 13368v1 drm/i915: Force relocations via cpu if we run out of idle aperture

Re: [Intel-gfx] [PATCH] drm/i915: Distinguish last emitted request from last submitted request

Chris Wilson writes: > In order not to trigger hangcheck on a idle-but-waiting engine, we need > to distinguish between the pending request queue and the actual > execution queue. This is done later in "drm/i915: Enable multiple > timelines" but for now we need a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Save hangcheck score across resets

== Series Details == Series: drm/i915: Save hangcheck score across resets URL : https://patchwork.freedesktop.org/series/13367/ State : failure == Summary == Series 13367v1 drm/i915: Save hangcheck score across resets https://patchwork.freedesktop.org/api/1.0/series/13367/revisions/1/mbox/

[Intel-gfx] [PATCH] drm/i915: Force relocations via cpu if we run out of idle aperture

If we run out of enough aperture space to fit the entire object, we fallback to trying to insert a single page. However, if that also fails, we currently fail to userspace with an unexpected ENOSPC. (ENOSPC means to userspace that their batch could not be fitted within the GTT.) Prior to commit

Re: [Intel-gfx] [PATCH 04/22] drm/i915: Make HAS_DDI and HAS_PCH_LPT_LP only take dev_priv

On 05/10/2016 18:16, Ville Syrjälä wrote: On Wed, Oct 05, 2016 at 01:33:31PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This saves 3248 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On 06/10/2016 07:58, Joonas Lahtinen wrote: On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote: On 05/10/2016 17:50, Tvrtko Ursulin wrote: On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 01/22] drm/i915: Shrink cxsr_latency_table

On 05/10/2016 18:01, Ville Syrjälä wrote: On Wed, Oct 05, 2016 at 01:33:28PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin unsigned long is too wide - use smaller types in struct cxsr_latency to save 800-something bytes of .rodata. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH i-g-t RFC] tests: Add explicit test lists for CI use.

On Thu, Oct 06, 2016 at 09:31:32AM +0300, Petri Latvala wrote: > See tests/intel-ci/README for rationale and explanation. > > Signed-off-by: Petri Latvala > --- > > > The plans for CI are to use explicit test lists in the future, as laid > out in this commit. Comments,

  1   2   >